Apache
/
activemq-artemis
mirror of https://github.com/apache/activemq-artemis.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

NO-JIRA: fix RandomUtilDistributionTest assertion and improve failure message

This commit is contained in:
Robbie Gemmell 2020-08-05 17:37:22 +01:00 committed by Clebert Suconic
parent 8913df664e
commit 131b8b22ec
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/util/RandomUtilDistributionTest.java
View File

@ -69,9 +69,8 @@ public class RandomUtilDistributionTest {
// Be careful removing it (make sure you know what you're doing in case you do so) // Be careful removing it (make sure you know what you're doing in case you do so)
int minimumExpected = (int) ((iterations * numberOfStarts) * 0.80); int minimumExpected = (int) ((iterations * numberOfStarts) * 0.80);
log.debug("value=" + value + ", minimum expected = " + minimumExpected); log.debug("values = " + value + ", minimum expected = " + minimumExpected);
Assert.assertTrue("The Random distribution is pretty bad. All tries have returned duplicated randoms. value=" + value + ", minimum expected = " + minimumExpected, value > minimumExpected); Assert.assertTrue("The Random distribution is pretty bad. Many tries have returned duplicated randoms. Number of different values=" + value + ", minimum expected = " + minimumExpected, value >= minimumExpected);
} }
private int internalDistributionTest(int numberOfTries) throws Exception { private int internalDistributionTest(int numberOfTries) throws Exception {