Remove unnecessary null checks and assignments

artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ServerLocatorImpl.java

@@ -787,7 +787,6 @@ public final class ServerLocatorImpl implements ServerLocatorInternal, Discovery
             }
             catch (ActiveMQException e) {
                factory.close();
-               factory = null;
                if (e.getType() == ActiveMQExceptionType.NOT_CONNECTED) {
                   attempts++;
 
@@ -813,9 +812,7 @@ public final class ServerLocatorImpl implements ServerLocatorInternal, Discovery
       // how the sendSubscription happens.
       // in case this ever changes.
       if (topology != null && !factory.waitForTopology(callTimeout, TimeUnit.MILLISECONDS)) {
-         if (factory != null) {
          factory.cleanup();
-         }
          throw ActiveMQClientMessageBundle.BUNDLE.connectionTimedOutOnReceiveTopology(discoveryGroup);
       }
 
@@ -1647,21 +1644,19 @@ public final class ServerLocatorImpl implements ServerLocatorInternal, Discovery
 
          initialise();
 
-         ClientSessionFactory csf = null;
-
          createConnectors();
 
          try {
 
             int retryNumber = 0;
-            while (csf == null && !isClosed()) {
+            while (!isClosed()) {
                retryNumber++;
                for (Connector conn : connectors) {
                   if (logger.isDebugEnabled()) {
                      logger.debug(this + "::Submitting connect towards " + conn);
                   }
 
-                  csf = conn.tryConnect();
+                  ClientSessionFactory csf = conn.tryConnect();
 
                   if (csf != null) {
                      csf.getConnection().addFailureListener(new FailureListener() {

artemis-dto/src/main/java/org/apache/activemq/artemis/dto/XmlUtil.java

@@ -102,9 +102,7 @@ public class XmlUtil {
 
       XMLStreamReader reader = factory.createXMLStreamReader(new FileInputStream(configuration));
 
-      if (props != null) {
       reader = new PropertiesFilter(reader, props);
-      }
 
       return clazz.cast(unmarshaller.unmarshal(reader));
    }

artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/bridge/impl/JMSBridgeControlImpl.java

@@ -176,9 +176,6 @@ public class JMSBridgeControlImpl extends StandardMBean implements JMSBridgeCont
       if (mode != null) {
          bridge.setQualityOfServiceMode(QualityOfServiceMode.valueOf(mode));
       }
-      else {
-         mode = null;
-      }
    }
 
    @Override

artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/bridge/impl/JMSBridgeImpl.java

@@ -1523,7 +1523,6 @@ public final class JMSBridgeImpl implements JMSBridge {
 
          targetProducer.send(targetDestination, msg, msg.getJMSDeliveryMode(), msg.getJMSPriority(), timeToLive);
 
-         if (msg != null)
          messageCount++;
          if (JMSBridgeImpl.trace) {
             ActiveMQJMSBridgeLogger.LOGGER.trace("Sent message " + msg);

artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/proton/converter/message/JMSMappingOutboundTransformer.java

@@ -148,7 +148,6 @@ public class JMSMappingOutboundTransformer extends OutboundTransformer {
 
          String msgId = msg.getJMSMessageID();
 
-         if (msgId != null) {
          try {
             props.setMessageId(AMQPMessageIdHelper.INSTANCE.toIdObject(msgId));
          }
@@ -156,10 +155,6 @@ public class JMSMappingOutboundTransformer extends OutboundTransformer {
             props.setMessageId(msgId);
          }
       }
-         else {
-            props.setMessageId(msgId.toString());
-         }
-      }
       if (msg.getJMSDestination() != null) {
          props.setTo(vendor.toAddress(msg.getJMSDestination()));
          if (maMap == null) {

examples/features/standard/security-ldap/src/main/java/org/apache/activemq/artemis/jms/example/SecurityExample.java

@@ -64,7 +64,6 @@ public class SecurityExample {
          }
 
          // Step 5. bill tries to make a connection using wrong password
-         billConnection = null;
          try {
             billConnection = createConnection("bill", "activemq1", cf);
             result = false;