ARTEMIS-1697 give ActivateCallback default methods

artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/impl/JMSServerManagerImpl.java

@@ -168,11 +168,6 @@ public class JMSServerManagerImpl implements JMSServerManager, ActivateCallback
 
    // ActivateCallback implementation -------------------------------------
 
-   @Override
-   public void preActivate() {
-
-   }
-
    @Override
    public synchronized void activated() {
       if (!startCalled) {

artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActivateCallback.java

@@ -21,21 +21,25 @@ public interface ActivateCallback {
    /*
     * this is called before any services are started when the server first initialised
     */
-   void preActivate();
+   default void preActivate() {
+   }
 
    /*
     * this is called after most of the services have been started but before any cluster resources or JMS resources have been
     */
-   void activated();
+   default void activated() {
+   }
 
    /*
     * this is called when the server is stopping, after any network resources and clients are closed but before the rest
     * of the resources
     */
-   void deActivate();
+   default void deActivate() {
+   }
 
    /*
     * this is called when all resources have been started including any JMS resources
     */
-   void activationComplete();
+   default void activationComplete() {
+   }
 }

artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/FileLockNodeManager.java

@@ -170,18 +170,6 @@ public class FileLockNodeManager extends NodeManager {
       ActiveMQServerLogger.LOGGER.obtainedLiveLock();
 
       return new ActivateCallback() {
-         @Override
-         public void preActivate() {
-         }
-
-         @Override
-         public void activated() {
-         }
-
-         @Override
-         public void deActivate() {
-         }
-
          @Override
          public void activationComplete() {
             try {

artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/InVMNodeManager.java

@@ -108,18 +108,6 @@ public final class InVMNodeManager extends NodeManager {
       state = FAILING_BACK;
       liveLock.acquire();
       return new ActivateCallback() {
-         @Override
-         public void preActivate() {
-         }
-
-         @Override
-         public void activated() {
-         }
-
-         @Override
-         public void deActivate() {
-         }
-
          @Override
          public void activationComplete() {
             try {

artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/jdbc/JdbcNodeManager.java

@@ -350,18 +350,6 @@ public final class JdbcNodeManager extends NodeManager {
       ActiveMQServerLogger.LOGGER.obtainedLiveLock();
 
       return new ActivateCallback() {
-         @Override
-         public void preActivate() {
-         }
-
-         @Override
-         public void activated() {
-         }
-
-         @Override
-         public void deActivate() {
-         }
-
          @Override
          public void activationComplete() {
             try {

artemis-server/src/main/java/org/apache/activemq/artemis/core/server/management/impl/ManagementServiceImpl.java

@@ -547,10 +547,6 @@ public class ManagementServiceImpl implements ManagementService {
        * bridges won't be able to connect.
        */
       messagingServer.registerActivateCallback(new ActivateCallback() {
-         @Override
-         public void preActivate() {
-         }
-
          @Override
          public void activated() {
             try {
@@ -559,14 +555,6 @@ public class ManagementServiceImpl implements ManagementService {
                ActiveMQServerLogger.LOGGER.unableToCreateManagementNotificationAddress(managementNotificationAddress, e);
             }
          }
-
-         @Override
-         public void deActivate() {
-         }
-
-         @Override
-         public void activationComplete() {
-         }
       });
    }
 

tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/discovery/DiscoveryBaseTest.java

@@ -195,21 +195,6 @@ public class DiscoveryBaseTest extends ActiveMQTestBase {
       @Override
       public ActivateCallback startLiveNode() throws Exception {
          return new ActivateCallback() {
-            @Override
-            public void preActivate() {
-            }
-
-            @Override
-            public void activated() {
-            }
-
-            @Override
-            public void deActivate() {
-            }
-
-            @Override
-            public void activationComplete() {
-            }
          };
       }