Apache
/
activemq-artemis
mirror of https://github.com/apache/activemq-artemis.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

This closes #2441

This commit is contained in:
Justin Bertram 2018-12-13 10:53:34 -06:00
parent 4231d660c1 56c7fb1a95
commit 280ea56d8b
5 changed files with 15 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
artemis-protocols/artemis-amqp-protocol/src/test/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessageTest.java
View File

@ -17,6 +17,7 @@
package org.apache.activemq.artemis.protocol.amqp.broker;
import static org.junit.Assert.assertArrayEquals;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertNotEquals;
@ -1465,7 +1466,7 @@ public class AMQPMessageTest {
AMQPMessage readMessage = (AMQPMessage)decoded.getPersister().decode(buffer, null);
Assert.assertEquals(33, readMessage.getMessageID());
Assert.assertEquals("someAddress", readMessage.getAddress());
Assert.assertArrayEquals(original, readMessage.getExtraBytesProperty(name));
assertArrayEquals(original, readMessage.getExtraBytesProperty(name));
} finally {
buffer.release();
}
@ -1475,7 +1476,7 @@ public class AMQPMessageTest {
AMQPMessage readMessage = (AMQPMessage) EmbedMessageUtil.extractEmbedded(embeddedMessage);
Assert.assertEquals(33, readMessage.getMessageID());
Assert.assertEquals("someAddress", readMessage.getAddress());
Assert.assertArrayEquals(original, readMessage.getExtraBytesProperty(name));
assertArrayEquals(original, readMessage.getExtraBytesProperty(name));
}
}
@ -2231,14 +2232,14 @@ public class AMQPMessageTest {
byte[] leftArray = leftValue.getValue().getArray();
byte[] rightArray = rightValue.getValue().getArray();
if (leftArray == null && leftArray == null) {
if (leftArray == null && rightArray == null) {
return true;
}
if (!isNullnessEquals(leftArray, rightArray)) {
return false;
}
assertTrue(Arrays.equals(leftArray, rightArray));
assertArrayEquals(leftArray, rightArray);
} else {
return false;
}

1
artemis-protocols/artemis-amqp-protocol/src/test/java/org/apache/activemq/artemis/protocol/amqp/converter/message/JMSMappingInboundTransformerTest.java
View File

@ -150,6 +150,7 @@ public class JMSMappingInboundTransformerTest {
* @throws Exception
* if an error occurs during the test.
*/
@Test
public void testCreateBytesMessageFromDataWithUnknownContentType() throws Exception {
MessageImpl message = (MessageImpl) Message.Factory.create();
Binary binary = new Binary(new byte[0]);

8
artemis-rest/src/test/java/org/apache/activemq/artemis/rest/test/ClientAckQueueTest.java
View File

@ -52,7 +52,7 @@ public class ClientAckQueueTest extends MessageTestBase {
testAckTimeout();
}
public void testAckTimeout() throws Exception {
private void testAckTimeout() throws Exception {
ClientRequest request = new ClientRequest(generateURL("/queues/testAck"));
ClientResponse<?> response = Util.head(request);
@ -127,7 +127,7 @@ public class ClientAckQueueTest extends MessageTestBase {
testSuccessFirst(3, testName);
}
public void testSuccessFirst(int start, String queueName) throws Exception {
private void testSuccessFirst(int start, String queueName) throws Exception {
ClientRequest request = new ClientRequest(generateURL(Util.getUrlPath(queueName)));
ClientResponse<?> response = Util.head(request);
@ -205,7 +205,7 @@ public class ClientAckQueueTest extends MessageTestBase {
testPull(4, testName);
}
public void testPull(int start, String queueName) throws Exception {
private void testPull(int start, String queueName) throws Exception {
ClientRequest request = new ClientRequest(generateURL(Util.getUrlPath(queueName)));
ClientResponse<?> response = Util.head(request);
@ -287,7 +287,7 @@ public class ClientAckQueueTest extends MessageTestBase {
testReconnect(testName);
}
public void testReconnect(String queueName) throws Exception {
private void testReconnect(String queueName) throws Exception {
ClientRequest request = new ClientRequest(generateURL(Util.getUrlPath(queueName)));
ClientResponse<?> response = Util.head(request);

2
artemis-rest/src/test/java/org/apache/activemq/artemis/rest/test/ClientAckTopicTest.java
View File

@ -51,7 +51,7 @@ public class ClientAckTopicTest extends MessageTestBase {
testAckTimeout();
}
public void testAckTimeout() throws Exception {
private void testAckTimeout() throws Exception {
ClientRequest request = new ClientRequest(TestPortProvider.generateURL("/topics/testAck"));

5
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/distribution/SimpleSymmetricClusterTest.java
View File

@ -18,6 +18,7 @@ package org.apache.activemq.artemis.tests.integration.cluster.distribution;
import org.apache.activemq.artemis.core.server.cluster.impl.MessageLoadBalancingType;
import org.apache.activemq.artemis.tests.integration.IntegrationTestLogger;
import org.junit.Ignore;
import org.junit.Test;
public class SimpleSymmetricClusterTest extends ClusterTestBase {
@ -282,7 +283,9 @@ public class SimpleSymmetricClusterTest extends ClusterTestBase {
verifyReceiveRoundRobinInSomeOrder(33, 2, 0, 1);
}
public void _testSimpleRoundRobbinNoFailure() throws Exception {
@Test
@Ignore("Test not implemented yet")
public void testSimpleRoundRobbinNoFailure() throws Exception {
//TODO make this test to crash a node
setupServer(0, true, isNetty());
setupServer(1, true, isNetty());