Apache
/
activemq-artemis
mirror of https://github.com/apache/activemq-artemis.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

ARTEMIS-2291 ClassCastException on JMSBridgeImpl::stop leaks bridge resources

This commit is contained in:
Francesco Nigro 2019-03-29 17:14:26 +01:00 committed by Justin Bertram
parent 82fe0e5894
commit 34c8ed2adb
1 changed files with 27 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/bridge/impl/JMSBridgeImpl.java
View File

@ -533,12 +533,34 @@ public final class JMSBridgeImpl implements JMSBridge {
}
}
private void stopSessionFailover() {
XASession xaSource = (XASession) sourceSession;
XASession xaTarget = (XASession) targetSession;
private static void releaseCommunications(Session session, String sessionName) {
final XASession xaSession = (XASession) session;
((ClientSessionInternal) xaSource.getXAResource()).getSessionContext().releaseCommunications();
((ClientSessionInternal) xaTarget.getXAResource()).getSessionContext().releaseCommunications();
if (xaSession.getXAResource() instanceof ClientSessionInternal) {
try {
((ClientSessionInternal) xaSession.getXAResource()).getSessionContext().releaseCommunications();
} catch (Throwable t) {
ActiveMQJMSBridgeLogger.LOGGER.warnf(t, "Cannot release communications on %s", sessionName);
}
} else {
if (ActiveMQJMSBridgeLogger.LOGGER.isTraceEnabled()) {
ActiveMQJMSBridgeLogger.LOGGER.tracef("Cannot cast XAResource of %s to ClientSessionInternal and release communications: found class %s",
sessionName, xaSession.getClass().getCanonicalName());
}
}
}
private void stopSessionFailover() {
try {
releaseCommunications(sourceSession, "sourceSession");
} catch (Throwable t) {
ActiveMQJMSBridgeLogger.LOGGER.error("cannot release communications on sourceSession ", t);
}
try {
releaseCommunications(targetSession, "targetSession");
} catch (Throwable t) {
ActiveMQJMSBridgeLogger.LOGGER.error("cannot release communications on targetSession ", t);
}
}
@Override