diff --git a/.travis.yml b/.travis.yml index 773c75cf27..46b5e3d8ec 100644 --- a/.travis.yml +++ b/.travis.yml @@ -2,6 +2,8 @@ language: java install: true jdk: - openjdk8 + - openjdk11 + - openjdk14 # clean out Artemis artifacts from the cache before_install: @@ -19,5 +21,5 @@ script: cache: directories: - $HOME/.m2 - before_cache: +before_cache: - rm -rf $HOME/.m2/repository/org/apache/activemq/artemis-* diff --git a/artemis-boot/pom.xml b/artemis-boot/pom.xml index 1803632d1a..7b6655b873 100644 --- a/artemis-boot/pom.xml +++ b/artemis-boot/pom.xml @@ -35,6 +35,10 @@ + + com.google.errorprone + error_prone_core + junit junit diff --git a/artemis-cdi-client/pom.xml b/artemis-cdi-client/pom.xml index b79c6913e5..7720ba7f5c 100644 --- a/artemis-cdi-client/pom.xml +++ b/artemis-cdi-client/pom.xml @@ -48,6 +48,10 @@ provided true + + com.google.errorprone + error_prone_core + org.jboss.logging jboss-logging diff --git a/artemis-cli/pom.xml b/artemis-cli/pom.xml index c95ee0d46d..c0f6353253 100644 --- a/artemis-cli/pom.xml +++ b/artemis-cli/pom.xml @@ -108,6 +108,10 @@ provided true + + com.google.errorprone + error_prone_core + org.jboss.logging jboss-logging diff --git a/artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/check/QueueCheck.java b/artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/check/QueueCheck.java index 45ddc3e048..5bd4fd9d76 100644 --- a/artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/check/QueueCheck.java +++ b/artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/check/QueueCheck.java @@ -101,7 +101,7 @@ public class QueueCheck extends CheckAbstract { if (browse != null) { if (browse == -1) { - checkTasks.add(new CheckTask(String.format("a consumer can browse the queue", + checkTasks.add(new CheckTask(String.format("a consumer can browse the queue %s", getName()), this::checkQueueBrowse)); } else if (browse > 0) { checkTasks.add(new CheckTask(String.format("a consumer can browse %d messages from the queue %s", diff --git a/artemis-commons/pom.xml b/artemis-commons/pom.xml index 7f5408feed..cbf69524db 100644 --- a/artemis-commons/pom.xml +++ b/artemis-commons/pom.xml @@ -50,6 +50,10 @@ provided true + + com.google.errorprone + error_prone_core + org.wildfly.common wildfly-common diff --git a/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/Base64.java b/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/Base64.java index 75e9d98bfe..4d0685d4d7 100644 --- a/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/Base64.java +++ b/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/Base64.java @@ -19,7 +19,7 @@ import java.nio.charset.StandardCharsets; /** *

Encodes and decodes to and from Base64 notation.

*

Homepage: http://iharder.net/base64.

- *

The options parameter, which appears in a few places, is used to pass + *

The options parameter, which appears in a few places, is used to pass * several pieces of information to the encoder. In the "higher level" methods such as * encodeBytes( bytes, options ) the options parameter can be used to indicate such * things as first gzipping the bytes before encoding them, not inserting linefeeds @@ -66,9 +66,9 @@ import java.nio.charset.StandardCharsets; * when data that's being decoded is gzip-compressed and will decompress it * automatically. Generally things are cleaner. You'll probably have to * change some method calls that you were making to support the new - * options format (ints that you "OR" together). + * options format (ints that you "OR" together). *

  • v1.5.1 - Fixed bug when decompressing and decoding to a - * byte[] using decode( String s, boolean gzipCompressed ). + * byte[] using decode( String s, boolean gzipCompressed ). * Added the ability to "suspend" encoding in the Output Stream so * you can turn on and off the encoding if you need to embed base64 * data in an otherwise "normal" stream (like an XML file).
  • @@ -484,7 +484,7 @@ public class Base64 { * Serializes an object and returns the Base64-encoded * version of that serialized object. If the object * cannot be serialized or there is another error, - * the method will return null. + * the method will return null. * The object is not GZip-compressed before being encoded. * * @param serializableObject The object to encode @@ -499,7 +499,7 @@ public class Base64 { * Serializes an object and returns the Base64-encoded * version of that serialized object. If the object * cannot be serialized or there is another error, - * the method will return null. + * the method will return null. *

    * Valid options:

         *   GZIP: gzip-compresses object before encoding it.
    @@ -931,7 +931,7 @@ public class Base64 {
     
        /**
         * Attempts to decode Base64 data and deserialize a Java
    -    * Object within. Returns null if there was an error.
    +    * Object within. Returns null if there was an error.
         *
         * @param encodedObject The Base64 data to decode
         * @return The decoded and deserialized object
    @@ -972,7 +972,7 @@ public class Base64 {
         *
         * @param dataToEncode byte array of data to encode in base64 form
         * @param filename     Filename for saving encoded data
    -    * @return true if successful, false otherwise
    +    * @return true if successful, false otherwise
         * @since 2.1
         */
        public static boolean encodeToFile(final byte[] dataToEncode, final String filename) {
    @@ -1000,7 +1000,7 @@ public class Base64 {
         *
         * @param dataToDecode Base64-encoded data as a string
         * @param filename     Filename for saving decoded data
    -    * @return true if successful, false otherwise
    +    * @return true if successful, false otherwise
         * @since 2.1
         */
        public static boolean decodeToFile(final String dataToDecode, final String filename) {
    @@ -1116,7 +1116,7 @@ public class Base64 {
        } // end encodeFromFile
     
        /**
    -    * Reads infile and encodes it to outfile.
    +    * Reads infile and encodes it to outfile.
         *
         * @param infile  Input file
         * @param outfile Output file
    @@ -1153,7 +1153,7 @@ public class Base64 {
        } // end encodeFileToFile
     
        /**
    -    * Reads infile and decodes it to outfile.
    +    * Reads infile and decodes it to outfile.
         *
         * @param infile  Input file
         * @param outfile Output file
    @@ -1193,7 +1193,7 @@ public class Base64 {
     
        /**
         * A {@link Base64.InputStream} will read data from another
    -    * java.io.InputStream, given in the constructor,
    +    * java.io.InputStream, given in the constructor,
         * and encode/decode to/from Base64 notation on the fly.
         *
         * @see Base64
    @@ -1224,7 +1224,7 @@ public class Base64 {
           /**
            * Constructs a {@link Base64.InputStream} in DECODE mode.
            *
    -       * @param in the java.io.InputStream from which to read data.
    +       * @param in the java.io.InputStream from which to read data.
            * @since 1.3
            */
           public InputStream(final java.io.InputStream in) {
    @@ -1244,7 +1244,7 @@ public class Base64 {
            * 

    * Example: new Base64.InputStream( in, Base64.DECODE ) * - * @param in the java.io.InputStream from which to read data. + * @param in the java.io.InputStream from which to read data. * @param options Specified options * @see Base64#ENCODE * @see Base64#DECODE @@ -1404,7 +1404,7 @@ public class Base64 { /** * A {@link Base64.OutputStream} will write data to another - * java.io.OutputStream, given in the constructor, + * java.io.OutputStream, given in the constructor, * and encode/decode to/from Base64 notation on the fly. * * @see Base64 @@ -1437,7 +1437,7 @@ public class Base64 { /** * Constructs a {@link Base64.OutputStream} in ENCODE mode. * - * @param out the java.io.OutputStream to which data will be written. + * @param out the java.io.OutputStream to which data will be written. * @since 1.3 */ public OutputStream(final java.io.OutputStream out) { @@ -1457,7 +1457,7 @@ public class Base64 { *

    * Example: new Base64.OutputStream( out, Base64.ENCODE ) * - * @param out the java.io.OutputStream to which data will be written. + * @param out the java.io.OutputStream to which data will be written. * @param options Specified options. * @see Base64#ENCODE * @see Base64#DECODE diff --git a/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/InetAddresses.java b/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/InetAddresses.java index 3d4f089d2c..021d805b71 100644 --- a/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/InetAddresses.java +++ b/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/InetAddresses.java @@ -44,21 +44,21 @@ import static org.apache.activemq.artemis.utils.ByteUtil.intFromBytes; * *

    Examples of IP addresses and their byte representations: *

      - *
    • The IPv4 loopback address, {@code "127.0.0.1"}.
      + *
    • The IPv4 loopback address, {@code "127.0.0.1"}.
      * {@code 7f 00 00 01} * - *
    • The IPv6 loopback address, {@code "::1"}.
      + *
    • The IPv6 loopback address, {@code "::1"}.
      * {@code 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 01} * *
    • From the IPv6 reserved documentation prefix ({@code 2001:db8::/32}), - * {@code "2001:db8::1"}.
      + * {@code "2001:db8::1"}.
      * {@code 20 01 0d b8 00 00 00 00 00 00 00 00 00 00 00 01} * *
    • An IPv6 "IPv4 compatible" (or "compat") address, - * {@code "::192.168.0.1"}.
      + * {@code "::192.168.0.1"}.
      * {@code 00 00 00 00 00 00 00 00 00 00 00 00 c0 a8 00 01} * - *
    • An IPv6 "IPv4 mapped" address, {@code "::ffff:192.168.0.1"}.
      + *
    • An IPv6 "IPv4 mapped" address, {@code "::ffff:192.168.0.1"}.
      * {@code 00 00 00 00 00 00 00 00 00 00 ff ff c0 a8 00 01} *
    * diff --git a/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/SpawnedVMSupport.java b/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/SpawnedVMSupport.java index d99871567d..e71c57ffcb 100644 --- a/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/SpawnedVMSupport.java +++ b/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/SpawnedVMSupport.java @@ -171,7 +171,7 @@ public class SpawnedVMSupport { * @param logOutput * @param logErrorOutput * @param useLogging - * @param debugPort if <=0 it means no debug + * @param debugPort if <=0 it means no debug * @param args * @return * @throws IOException diff --git a/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/ConcurrentAppendOnlyChunkedList.java b/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/ConcurrentAppendOnlyChunkedList.java index f55d9e1a0c..49981fdb52 100644 --- a/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/ConcurrentAppendOnlyChunkedList.java +++ b/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/ConcurrentAppendOnlyChunkedList.java @@ -64,7 +64,7 @@ public final class ConcurrentAppendOnlyChunkedList { private volatile long cachedLastIndex = 0; /** - * @throws IllegalArgumentException if {@code chunkSize} is <0 or not a power of 2 + * @throws IllegalArgumentException if {@code chunkSize} is <0 or not a power of 2 */ public ConcurrentAppendOnlyChunkedList(final int chunkSize) { if (chunkSize <= 0) { diff --git a/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/ConcurrentLongHashMap.java b/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/ConcurrentLongHashMap.java index 32dd819abe..e632f0249a 100644 --- a/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/ConcurrentLongHashMap.java +++ b/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/ConcurrentLongHashMap.java @@ -33,9 +33,9 @@ import static org.apache.activemq.artemis.utils.Preconditions.checkNotNull; /** * Map from long to an Object. * - * Provides similar methods as a ConcurrentMap with 2 differences: + * Provides similar methods as a {@literal ConcurrentMap} with 2 differences: *
      - *
    1. No boxing/unboxing from long -> Long + *
    2. No boxing/unboxing from {@literal long -> Long} *
    3. Open hash map with linear probing, no node allocations to store the values *
    * diff --git a/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/ConcurrentLongHashSet.java b/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/ConcurrentLongHashSet.java index 90efca13f4..f46e602486 100644 --- a/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/ConcurrentLongHashSet.java +++ b/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/ConcurrentLongHashSet.java @@ -34,7 +34,7 @@ import static org.apache.activemq.artemis.utils.Preconditions.checkArgument; * Provides similar methods as a ConcurrentSet<Long> but since it's an open hash map with linear probing, no node * allocations are required to store the values. *

    - * Items MUST be >= 0. + * Items MUST be >= 0. */ public class ConcurrentLongHashSet { diff --git a/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/LongHashSet.java b/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/LongHashSet.java index a86a7f2b1f..201bb93ba9 100644 --- a/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/LongHashSet.java +++ b/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/LongHashSet.java @@ -28,7 +28,7 @@ import java.util.NoSuchElementException; import java.util.Set; /** - * A hash set implementation of {@link Set} that uses open addressing values. + * A hash set implementation of {@literal Set} that uses open addressing values. * To minimize the memory footprint, this class uses open addressing rather than chaining. * Collisions are resolved using linear probing. Deletions implement compaction, so cost of * remove can approach O(N) for full maps, which makes a small loadFactor recommended. diff --git a/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/SparseArrayLinkedList.java b/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/SparseArrayLinkedList.java index f6b2a518aa..e77fcbe3c8 100644 --- a/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/SparseArrayLinkedList.java +++ b/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/SparseArrayLinkedList.java @@ -28,7 +28,7 @@ import java.util.function.Predicate; * it's a linked list of arrays/chunks of {@code T}.
    * Differently from an {@code UnrolledLinkedList} this list doesn't optimize addition and removal to achieve a balanced * utilization among chunks ie a chunk is removed only if empty and chunks can't be merged. - * This list has been optimized for small-sized chunks (ideally <= 32 elements): this allow search/removal to + * This list has been optimized for small-sized chunks (ideally <= 32 elements): this allow search/removal to * be performed with a greedy approach despite a sparse chunk utilization (ie chunks contains few sparse elements).
    * * From the memory footprint's point of view, this list won't remove the last remaining array although empty to optimize diff --git a/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/UpdatableIterator.java b/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/UpdatableIterator.java index d4e15fa50c..204f672697 100644 --- a/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/UpdatableIterator.java +++ b/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/UpdatableIterator.java @@ -52,8 +52,6 @@ public class UpdatableIterator implements ResettableIterator, RepeatableIt * It is important that on nulling off the changedIterator, we atomically compare and set as the * changedIterator could be further updated by another thread whilst we are resetting, * the subsequent update simply would be picked up on the next reset. - * - * @return this (itself). */ @Override public void reset() { diff --git a/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/critical/CriticalComponent.java b/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/critical/CriticalComponent.java index 837b1ab346..39d46141b6 100644 --- a/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/critical/CriticalComponent.java +++ b/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/critical/CriticalComponent.java @@ -22,7 +22,7 @@ package org.apache.activemq.artemis.utils.critical; * You update a long every time you enter a critical path * you update a different long with a System.nanoTime every time you leave that path. * - * If the enterCritical > leaveCritical at any point, then you need to measure the timeout. + * If the enterCritical > leaveCritical at any point, then you need to measure the timeout. * if the system stops responding, then you have something irresponsive at the system. */ public interface CriticalComponent { diff --git a/artemis-commons/src/test/java/org/apache/activemq/artemis/utils/collections/LongHashSetTest.java b/artemis-commons/src/test/java/org/apache/activemq/artemis/utils/collections/LongHashSetTest.java index 09d18d05be..e322ffa810 100644 --- a/artemis-commons/src/test/java/org/apache/activemq/artemis/utils/collections/LongHashSetTest.java +++ b/artemis-commons/src/test/java/org/apache/activemq/artemis/utils/collections/LongHashSetTest.java @@ -247,6 +247,7 @@ public class LongHashSetTest { Assert.assertEquals(1, testSet.size()); } + @SuppressWarnings("CollectionToArraySafeParameter") @Test(expected = ArrayStoreException.class) public void toArrayThrowsArrayStoreExceptionForWrongType() { testSet.toArray(new String[1]); diff --git a/artemis-core-client-all/pom.xml b/artemis-core-client-all/pom.xml index 9ddde60cff..2428f8cec4 100644 --- a/artemis-core-client-all/pom.xml +++ b/artemis-core-client-all/pom.xml @@ -44,7 +44,7 @@ org.apache.maven.plugins maven-shade-plugin - 3.2.0 + 3.2.3 package @@ -97,8 +97,8 @@ - org.apache.activemq - org.apache.activemq + org.apache.activemq + org.apache.activemq org.apache.geronimo diff --git a/artemis-core-client/pom.xml b/artemis-core-client/pom.xml index 8af9d3d5f2..058a90a686 100644 --- a/artemis-core-client/pom.xml +++ b/artemis-core-client/pom.xml @@ -56,6 +56,10 @@ provided true + + com.google.errorprone + error_prone_core + org.wildfly.common wildfly-common @@ -142,7 +146,6 @@ org.apache.maven.plugins maven-javadoc-plugin - 2.9 true 128m diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/Message.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/Message.java index fdb5188cd4..4ade8bb268 100644 --- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/Message.java +++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/Message.java @@ -179,7 +179,7 @@ public interface Message { byte STREAM_TYPE = 6; - /** The message will contain another message persisted through {@link org.apache.activemq.artemis.spi.core.protocol.EmbedMessageUtil}*/ + /** The message will contain another message persisted through {@literal org.apache.activemq.artemis.spi.core.protocol.EmbedMessageUtil}*/ byte EMBEDDED_TYPE = 7; /** This is to embedd Large Messages from other protocol */ @@ -676,7 +676,6 @@ public interface Message { /** * @see #usageUp() * @return - * @throws Exception */ int usageDown(); diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/RefCountMessageListener.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/RefCountMessageListener.java index 91fa7f80a4..17168bbb77 100644 --- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/RefCountMessageListener.java +++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/RefCountMessageListener.java @@ -17,7 +17,7 @@ package org.apache.activemq.artemis.api.core; -/** If {@link Message#getContext()} != null and is implementing this interface. +/** * These methods will be called during refCount operations */ public interface RefCountMessageListener { diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/client/ClientSession.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/client/ClientSession.java index 965a4e7b52..5db79aa57e 100644 --- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/client/ClientSession.java +++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/client/ClientSession.java @@ -310,8 +310,7 @@ public interface ClientSession extends XAResource, AutoCloseable { *

    * * @param queueConfiguration the configuration to use when creating the queue - * @return the {@code Queue} instance that was created - * @throws Exception + * @throws ActiveMQException */ void createQueue(QueueConfiguration queueConfiguration) throws ActiveMQException; diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/ActiveMQServerControl.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/ActiveMQServerControl.java index b4e6c3aca6..643fb53fad 100644 --- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/ActiveMQServerControl.java +++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/ActiveMQServerControl.java @@ -1763,7 +1763,7 @@ public interface ActiveMQServerControl { * List the information about a user or all users if no username is supplied (only applicable when using the JAAS PropertiesLoginModule). * * @param username - * @return JSON array of user & role information + * @return JSON array of user and role information * @throws Exception */ @Operation(desc = "list info about a user or all users if no username is supplied (only applicable when using the JAAS PropertiesLoginModule)", impact = MBeanOperationInfo.ACTION) diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/AddressControl.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/AddressControl.java index 908fb20c9c..23817ed02e 100644 --- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/AddressControl.java +++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/AddressControl.java @@ -84,7 +84,7 @@ public interface AddressControl { String[] getQueueNames() throws Exception; /** - * Returns the names of both the local & remote queue(s) bound to this address. + * Returns the names of both the local and remote queue(s) bound to this address. */ @Attribute(desc = "names of both the local & remote queue(s) bound to this address") String[] getAllQueueNames() throws Exception; diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java index 7ad2c6becd..781e59e98d 100644 --- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java +++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java @@ -211,7 +211,6 @@ public class CoreMessage extends RefCountMessage implements ICoreMessage { * This will return the proper buffer to represent the data of the Message. If compressed it will decompress. * If large, it will read from the file or streaming. * @return - * @throws ActiveMQException */ @Override public ActiveMQBuffer getDataBuffer() { diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/server/ComponentConfigurationRoutingType.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/server/ComponentConfigurationRoutingType.java index 780572e574..d9ad4dd838 100644 --- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/server/ComponentConfigurationRoutingType.java +++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/server/ComponentConfigurationRoutingType.java @@ -18,7 +18,7 @@ package org.apache.activemq.artemis.core.server; /** * This class essentially mirrors {@code RoutingType} except it has some additional members to support special - * configuration semantics for diverts & bridges. These additional members weren't put in {@code RoutingType} + * configuration semantics for diverts and bridges. These additional members weren't put in {@code RoutingType} * so as to not confuse users. */ public enum ComponentConfigurationRoutingType { diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/spi/core/protocol/RemotingConnection.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/spi/core/protocol/RemotingConnection.java index 89452f64b8..f9f4fa508a 100644 --- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/spi/core/protocol/RemotingConnection.java +++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/spi/core/protocol/RemotingConnection.java @@ -240,7 +240,7 @@ public interface RemotingConnection extends BufferHandler { /** * Sets the client ID associated with this connection - * @return + * @param cID */ void setClientID(String cID); diff --git a/artemis-dto/pom.xml b/artemis-dto/pom.xml index e40bafb8f2..1f2bf55918 100644 --- a/artemis-dto/pom.xml +++ b/artemis-dto/pom.xml @@ -35,6 +35,10 @@ + + com.google.errorprone + error_prone_core + org.apache.activemq artemis-commons @@ -87,7 +91,7 @@ maven-antrun-plugin - 1.7 + 1.8 generate-resources @@ -104,6 +108,13 @@ + + + + @@ -130,6 +141,11 @@ jaxb-jxc ${version.jaxb} + + javax.activation + activation + ${version.activation} + diff --git a/artemis-features/pom.xml b/artemis-features/pom.xml index 6f4c3bfe9e..e38719e930 100644 --- a/artemis-features/pom.xml +++ b/artemis-features/pom.xml @@ -1,19 +1,19 @@ +~ Licensed to the Apache Software Foundation (ASF) under one or more +~ contributor license agreements. See the NOTICE file distributed with +~ this work for additional information regarding copyright ownership. +~ The ASF licenses this file to You under the Apache License, Version 2.0 +~ (the "License"); you may not use this file except in compliance with +~ the License. You may obtain a copy of the License at +~ +~ http://www.apache.org/licenses/LICENSE-2.0 +~ +~ Unless required by applicable law or agreed to in writing, software +~ distributed under the License is distributed on an "AS IS" BASIS, +~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +~ See the License for the specific language governing permissions and +~ limitations under the License. +--> 4.0.0 @@ -25,104 +25,104 @@ pom ActiveMQ Artemis Features - - 4.1.1 - + + 4.2.8 + - - - org.apache.karaf.features - framework - ${karaf.version} - kar - provided - - + + + org.apache.karaf.features + framework + ${karaf.version} + kar + provided + + - - - - src/main/resources - true - - - - - maven-checkstyle-plugin - - true - - - - org.apache.maven.plugins - maven-resources-plugin - - - filter - generate-resources - - resources - - - - - - org.apache.karaf.tooling - karaf-maven-plugin - ${karaf.version} - - - verify - install - - verify - - - - mvn:org.apache.karaf.features/framework/${karaf.version}/xml/features - mvn:org.apache.karaf.features/enterprise/${karaf.version}/xml/features - file:${project.build.directory}/classes/features.xml - - org.apache.karaf.features:framework - 1.8 - - framework - - - - - - - org.codehaus.mojo - build-helper-maven-plugin - - - attach-artifacts - package - - attach-artifact - - - - - target/classes/features.xml - xml - features - - - target/classes/artemis.xml - artemis - xml - - - target/classes/org.apache.activemq.artemis.cfg - cfg - - - - - - - - + + + + src/main/resources + true + + + + + maven-checkstyle-plugin + + true + + + + org.apache.maven.plugins + maven-resources-plugin + + + filter + generate-resources + + resources + + + + + + org.apache.karaf.tooling + karaf-maven-plugin + ${karaf.version} + + + verify + install + + verify + + + + mvn:org.apache.karaf.features/framework/${karaf.version}/xml/features + mvn:org.apache.karaf.features/enterprise/${karaf.version}/xml/features + file:${project.build.directory}/classes/features.xml + + org.apache.karaf.features:framework + 11 + + framework + + + + + + + org.codehaus.mojo + build-helper-maven-plugin + + + attach-artifacts + package + + attach-artifact + + + + + target/classes/features.xml + xml + features + + + target/classes/artemis.xml + artemis + xml + + + target/classes/org.apache.activemq.artemis.cfg + cfg + + + + + + + + diff --git a/artemis-hawtio/activemq-branding/pom.xml b/artemis-hawtio/activemq-branding/pom.xml index b20fa6305c..7c0e3044dc 100644 --- a/artemis-hawtio/activemq-branding/pom.xml +++ b/artemis-hawtio/activemq-branding/pom.xml @@ -92,6 +92,10 @@ slf4j-log4j12 provided + + com.google.errorprone + error_prone_core + diff --git a/artemis-hawtio/artemis-plugin/pom.xml b/artemis-hawtio/artemis-plugin/pom.xml index 5430b4a526..79a606c400 100644 --- a/artemis-hawtio/artemis-plugin/pom.xml +++ b/artemis-hawtio/artemis-plugin/pom.xml @@ -97,6 +97,10 @@ log4j provided + + com.google.errorprone + error_prone_core + diff --git a/artemis-hawtio/pom.xml b/artemis-hawtio/pom.xml index f386561c49..2b7838017f 100644 --- a/artemis-hawtio/pom.xml +++ b/artemis-hawtio/pom.xml @@ -35,9 +35,6 @@ ${project.basedir}/.. - 1.8 - 1.8 - 1.5.12 3.2.0 4.11 diff --git a/artemis-jdbc-store/pom.xml b/artemis-jdbc-store/pom.xml index edc70c0835..622a47760d 100644 --- a/artemis-jdbc-store/pom.xml +++ b/artemis-jdbc-store/pom.xml @@ -40,6 +40,10 @@ provided true + + com.google.errorprone + error_prone_core + org.jboss.logging jboss-logging diff --git a/artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/JDBCUtils.java b/artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/JDBCUtils.java index bf57e9ace5..ce6dc6f192 100644 --- a/artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/JDBCUtils.java +++ b/artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/JDBCUtils.java @@ -40,7 +40,7 @@ public class JDBCUtils { } /** - * Append to {@code errorMessage} a detailed description of the provided {@link SQLException}.
    + * Append to {@code errorMessage} a detailed description of the provided {@link SQLException}.
    * The information appended are: *

      *
    • SQL STATEMENTS
    • @@ -61,7 +61,7 @@ public class JDBCUtils { } /** - * Append to {@code errorMessage} a detailed description of the provided {@link SQLException}.
      + * Append to {@code errorMessage} a detailed description of the provided {@link SQLException}.
      * The information appended are: *
        *
      • SQL EXCEPTIONS details ({@link SQLException#getSQLState}, diff --git a/artemis-jms-client-all/pom.xml b/artemis-jms-client-all/pom.xml index 24e6c71d14..e55607d626 100644 --- a/artemis-jms-client-all/pom.xml +++ b/artemis-jms-client-all/pom.xml @@ -44,7 +44,7 @@ org.apache.maven.plugins maven-shade-plugin - 3.2.0 + 3.2.3 package diff --git a/artemis-jms-client/pom.xml b/artemis-jms-client/pom.xml index 378637b676..01fdb4615e 100644 --- a/artemis-jms-client/pom.xml +++ b/artemis-jms-client/pom.xml @@ -38,6 +38,10 @@ provided true + + com.google.errorprone + error_prone_core + org.apache.activemq artemis-core-client @@ -85,7 +89,6 @@ org.apache.maven.plugins maven-javadoc-plugin - 2.9 true 128m diff --git a/artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/DefaultConnectionProperties.java b/artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/DefaultConnectionProperties.java index aba1c8b682..6a6ac27f6a 100644 --- a/artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/DefaultConnectionProperties.java +++ b/artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/DefaultConnectionProperties.java @@ -23,7 +23,8 @@ import java.security.PrivilegedAction; /** *

        This class will provide default properties for constructors

        * - * + *
        + * * * * diff --git a/artemis-jms-server/pom.xml b/artemis-jms-server/pom.xml index b7785c5bc1..905d249436 100644 --- a/artemis-jms-server/pom.xml +++ b/artemis-jms-server/pom.xml @@ -44,6 +44,10 @@ providedtrue + + com.google.errorprone + error_prone_core + org.jboss.logging jboss-logging @@ -100,7 +104,6 @@ org.apache.maven.plugins maven-javadoc-plugin - 2.9 true 128m diff --git a/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/bridge/QualityOfServiceMode.java b/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/bridge/QualityOfServiceMode.java index fdf2aa3587..38ee3d7458 100644 --- a/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/bridge/QualityOfServiceMode.java +++ b/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/bridge/QualityOfServiceMode.java @@ -17,9 +17,9 @@ package org.apache.activemq.artemis.jms.bridge; /** - *

        Quality of server (QoS) levels

        + *

        Quality of server (QoS) levels

        * - *

        QOS_AT_MOST_ONCE

        + *

        QOS_AT_MOST_ONCE

        * * With this QoS mode messages will reach the destination from the source at * most once. The messages are consumed from the source and acknowledged before @@ -28,7 +28,7 @@ package org.apache.activemq.artemis.jms.bridge; * destination they could be lost. Hence delivery will occur at most once. This * mode is available for both persistent and non persistent messages. * - *

        QOS_DUPLICATES_OK

        + *

        QOS_DUPLICATES_OK

        * * With this QoS mode, the messages are consumed from the source and then * acknowledged after they have been successfully sent to the destination. @@ -38,7 +38,7 @@ package org.apache.activemq.artemis.jms.bridge; * failure. This mode is available for both persistent and non persistent * messages. * - *

        QOS_ONCE_AND_ONLY_ONCE

        + *

        QOS_ONCE_AND_ONLY_ONCE

        * * This QoS mode ensures messages will reach the destination from the source * once and only once. (Sometimes this mode is known as "exactly once"). If both diff --git a/artemis-journal/pom.xml b/artemis-journal/pom.xml index d799d90846..16ff7248ac 100644 --- a/artemis-journal/pom.xml +++ b/artemis-journal/pom.xml @@ -44,6 +44,12 @@ provided true
        + + com.google.errorprone + error_prone_core + provided + true + diff --git a/artemis-junit/src/main/java/org/apache/activemq/artemis/junit/ActiveMQConsumerResource.java b/artemis-junit/src/main/java/org/apache/activemq/artemis/junit/ActiveMQConsumerResource.java index 967d971d06..8e8428ada6 100644 --- a/artemis-junit/src/main/java/org/apache/activemq/artemis/junit/ActiveMQConsumerResource.java +++ b/artemis-junit/src/main/java/org/apache/activemq/artemis/junit/ActiveMQConsumerResource.java @@ -32,10 +32,10 @@ import org.apache.activemq.artemis.api.core.RoutingType; * *
        
          * public class SimpleTest {
        - *     @Rule
        + *     @Rule
          *     public ActiveMQConsumerResource client = new ActiveMQProducerResource( "vm://0", "test.queue" );
          *
        - *     @Test
        + *     @Test
          *     public void testSomething() throws Exception {
          *         // Use the embedded client here
          *         ClientMessage message = client.receiveMessage();
        diff --git a/artemis-junit/src/main/java/org/apache/activemq/artemis/junit/ActiveMQDynamicProducerResource.java b/artemis-junit/src/main/java/org/apache/activemq/artemis/junit/ActiveMQDynamicProducerResource.java
        index 612ab45018..027ada94d0 100644
        --- a/artemis-junit/src/main/java/org/apache/activemq/artemis/junit/ActiveMQDynamicProducerResource.java
        +++ b/artemis-junit/src/main/java/org/apache/activemq/artemis/junit/ActiveMQDynamicProducerResource.java
        @@ -32,10 +32,10 @@ import org.apache.activemq.artemis.api.core.client.ServerLocator;
          *
          * 
        
          * public class SimpleTest {
        - *     @Rule
        + *     @Rule
          *     public ActiveMQDynamicProducerResource producer = new ActiveMQDynamicProducerResource( "vm://0");
          *
        - *     @Test
        + *     @Test
          *     public void testSomething() throws Exception {
          *         // Use the embedded ClientProducer here
          *         producer.sendMessage( "test.address", "String Body" );
        diff --git a/artemis-junit/src/main/java/org/apache/activemq/artemis/junit/ActiveMQProducerResource.java b/artemis-junit/src/main/java/org/apache/activemq/artemis/junit/ActiveMQProducerResource.java
        index 33ae4d26d3..75d413e57f 100644
        --- a/artemis-junit/src/main/java/org/apache/activemq/artemis/junit/ActiveMQProducerResource.java
        +++ b/artemis-junit/src/main/java/org/apache/activemq/artemis/junit/ActiveMQProducerResource.java
        @@ -33,10 +33,10 @@ import org.apache.activemq.artemis.api.core.client.ServerLocator;
          *
          * 
        
          * public class SimpleTest {
        - *     @Rule
        + *     @Rule
          *     public ActiveMQProducerResource producer = new ActiveMQProducerResource( "vm://0", "test.queue");
          *
        - *     @Test
        + *     @Test
          *     public void testSomething() throws Exception {
          *         // Use the embedded ClientProducer here
          *         producer.sendMessage( "String Body" );
        diff --git a/artemis-junit/src/main/java/org/apache/activemq/artemis/junit/EmbeddedActiveMQResource.java b/artemis-junit/src/main/java/org/apache/activemq/artemis/junit/EmbeddedActiveMQResource.java
        index 6ae3c6ab9c..6c038f295c 100644
        --- a/artemis-junit/src/main/java/org/apache/activemq/artemis/junit/EmbeddedActiveMQResource.java
        +++ b/artemis-junit/src/main/java/org/apache/activemq/artemis/junit/EmbeddedActiveMQResource.java
        @@ -55,10 +55,10 @@ import org.slf4j.LoggerFactory;
          *
          * 
        
          * public class SimpleTest {
        - *     @Rule
        + *     @Rule
          *     public EmbeddedActiveMQResource server = new EmbeddedActiveMQResource();
          *
        - *     @Test
        + *     @Test
          *     public void testSomething() throws Exception {
          *         // Use the embedded server here
          *     }
        diff --git a/artemis-junit/src/main/java/org/apache/activemq/artemis/junit/EmbeddedJMSResource.java b/artemis-junit/src/main/java/org/apache/activemq/artemis/junit/EmbeddedJMSResource.java
        index be21a6f60d..acd98b87f4 100644
        --- a/artemis-junit/src/main/java/org/apache/activemq/artemis/junit/EmbeddedJMSResource.java
        +++ b/artemis-junit/src/main/java/org/apache/activemq/artemis/junit/EmbeddedJMSResource.java
        @@ -66,10 +66,10 @@ import org.slf4j.LoggerFactory;
          *
          * 
        
          * public class SimpleTest {
        - *     @Rule
        + *     @Rule
          *     public EmbeddedJMSResource server = new EmbeddedJMSResource();
          *
        - *     @Test
        + *     @Test
          *     public void testSomething() throws Exception {
          *         // Use the embedded server here
          *     }
        diff --git a/artemis-maven-plugin/pom.xml b/artemis-maven-plugin/pom.xml
        index 01b8da29ef..f99d166396 100644
        --- a/artemis-maven-plugin/pom.xml
        +++ b/artemis-maven-plugin/pom.xml
        @@ -82,6 +82,10 @@
                  3.4
                  provided
               
        +      
        +          com.google.errorprone
        +          error_prone_core
        +      
            
         
            
        @@ -90,7 +94,7 @@
                     
                        org.apache.maven.plugins
                        maven-plugin-plugin
        -               3.5.2
        +               3.6.0
                        
                           
                              default-descriptor
        diff --git a/artemis-protocols/artemis-amqp-protocol/pom.xml b/artemis-protocols/artemis-amqp-protocol/pom.xml
        index c321b3e052..1143fc92bf 100644
        --- a/artemis-protocols/artemis-amqp-protocol/pom.xml
        +++ b/artemis-protocols/artemis-amqp-protocol/pom.xml
        @@ -60,6 +60,10 @@
                  provided
                  true
               
        +      
        +          com.google.errorprone
        +          error_prone_core
        +      
         
               
        -                  3.1
                           
                        
                     
                  
               
        +
            
         
            
        @@ -99,20 +121,20 @@
                  
               
               
        -         
        +
        -                  -Xep:MissingOverride:WARN
        +                    -XDcompilePolicy=simple
        +                   TODO: do this only for generated-sources 
        +                  -Xplugin:ErrorProne -Xep:MissingOverride:WARN
                        
                     
        -         
        +         -->
                  
                     org.codehaus.mojo
                     javacc-maven-plugin
        -            2.6
                     
                        
                           generate-sources
        diff --git a/artemis-selector/src/main/java/org/apache/activemq/artemis/selector/impl/LRUCache.java b/artemis-selector/src/main/java/org/apache/activemq/artemis/selector/impl/LRUCache.java
        index efe3fcd9da..9e6a9d50e6 100644
        --- a/artemis-selector/src/main/java/org/apache/activemq/artemis/selector/impl/LRUCache.java
        +++ b/artemis-selector/src/main/java/org/apache/activemq/artemis/selector/impl/LRUCache.java
        @@ -48,14 +48,14 @@ public class LRUCache extends LinkedHashMap {
            }
         
            /**
        -    * Constructs an empty LRUCache instance with the specified
        +    * Constructs an empty LRUCache instance with the specified
             * initial capacity, maximumCacheSize,load factor and ordering mode.
             *
             * @param initialCapacity  the initial capacity.
             * @param maximumCacheSize
             * @param loadFactor       the load factor.
        -    * @param accessOrder      the ordering mode - true for access-order,
        -    *                         false for insertion-order.
        +    * @param accessOrder      the ordering mode - true for access-order,
        +    *                         false for insertion-order.
             * @throws IllegalArgumentException if the initial capacity is negative or
             *                                  the load factor is non-positive.
             */
        diff --git a/artemis-server-osgi/pom.xml b/artemis-server-osgi/pom.xml
        index 8d1519b7ce..d6df4f7ddf 100644
        --- a/artemis-server-osgi/pom.xml
        +++ b/artemis-server-osgi/pom.xml
        @@ -100,6 +100,10 @@
                  provided
                  true
               
        +      
        +          com.google.errorprone
        +          error_prone_core
        +      
               
                  org.jboss.logging
                  jboss-logging
        @@ -137,7 +141,6 @@
                  
                     org.apache.felix
                     maven-bundle-plugin
        -            3.3.0
                     true
                     
                        
        diff --git a/artemis-server/pom.xml b/artemis-server/pom.xml
        index 9cfbdd8eb8..d472cd0af8 100644
        --- a/artemis-server/pom.xml
        +++ b/artemis-server/pom.xml
        @@ -44,6 +44,10 @@
                  provided
                  true
               
        +      
        +          com.google.errorprone
        +          error_prone_core
        +      
               
                  org.jboss.logging
                  jboss-logging
        @@ -218,7 +222,6 @@
                        
                           org.apache.maven.plugins
                           maven-javadoc-plugin
        -                  2.9
                           
                              true
                              128m
        diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/config/impl/LegacyJMSConfiguration.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/config/impl/LegacyJMSConfiguration.java
        index 7b495dd355..884a5f9adf 100644
        --- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/config/impl/LegacyJMSConfiguration.java
        +++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/config/impl/LegacyJMSConfiguration.java
        @@ -139,7 +139,6 @@ public class LegacyJMSConfiguration implements Deployable {
             * Parse the topic node as a TopicConfiguration object
             *
             * @param node
        -    * @return topic configuration
             * @throws Exception
             */
            public void parseTopicConfiguration(final Node node) throws Exception {
        @@ -153,7 +152,6 @@ public class LegacyJMSConfiguration implements Deployable {
             * Parse the Queue Configuration node as a QueueConfiguration object
             *
             * @param node
        -    * @return jms queue configuration
             * @throws Exception
             */
            public void parseQueueConfiguration(final Node node) throws Exception {
        diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java
        index f42ae97c44..7fe293b476 100644
        --- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java
        +++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java
        @@ -2362,7 +2362,6 @@ public final class FileConfigurationParser extends XMLConfigurationUtil {
         
            /**
             * @param e
        -    * @return
             */
            protected void parseWildcardConfiguration(final Element e, final Configuration mainConfig) {
               WildcardConfiguration conf = mainConfig.getWildcardConfiguration();
        diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/SimpleAddressManager.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/SimpleAddressManager.java
        index 206891e536..2510a913d6 100644
        --- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/SimpleAddressManager.java
        +++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/SimpleAddressManager.java
        @@ -55,12 +55,12 @@ public class SimpleAddressManager implements AddressManager {
            private final StorageManager storageManager;
         
            /**
        -    * HashMap
        +    * {@code HashMap}
             */
            protected final ConcurrentMap mappings = new ConcurrentHashMap<>();
         
            /**
        -    * HashMap
        +    * {@code HashMap}
             */
            private final ConcurrentMap nameMap = new ConcurrentHashMap<>();
         
        diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ServerSession.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ServerSession.java
        index 514f458897..aff59ec440 100644
        --- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ServerSession.java
        +++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ServerSession.java
        @@ -278,7 +278,7 @@ public interface ServerSession extends SecurityAuth {
             * This method invokes {@link ActiveMQServer#createQueue(QueueConfiguration)} with a few client-specific additions:
             * 

          *
        • set the routing type based on the prefixes configured on the acceptor used by the client - *
        • strip any prefixes from the address & queue names (if applicable) + *
        • strip any prefixes from the address and queue names (if applicable) *
        • check authorization based on the client's credentials *
        • enforce queue creation resource limit *
        • set up callbacks to clean up temporary queues once the client disconnects diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/spi/core/protocol/AbstractProtocolManagerFactory.java b/artemis-server/src/main/java/org/apache/activemq/artemis/spi/core/protocol/AbstractProtocolManagerFactory.java index a8284c1a50..1fbeb23217 100644 --- a/artemis-server/src/main/java/org/apache/activemq/artemis/spi/core/protocol/AbstractProtocolManagerFactory.java +++ b/artemis-server/src/main/java/org/apache/activemq/artemis/spi/core/protocol/AbstractProtocolManagerFactory.java @@ -51,7 +51,7 @@ public abstract class AbstractProtocolManagerFactory

          /** * org.apache.commons.beanutils.BeanUtils will log all the parameters so we strip out any password parameters - * (e.g. passwords for SSL keystore & truststore) + * (e.g. passwords for SSL keystore and truststore) * * @param parameters */ diff --git a/artemis-service-extensions/pom.xml b/artemis-service-extensions/pom.xml index 77195800c4..cb2a86a255 100644 --- a/artemis-service-extensions/pom.xml +++ b/artemis-service-extensions/pom.xml @@ -63,6 +63,10 @@ provided true + + com.google.errorprone + error_prone_core + org.jboss.logmanager jboss-logmanager diff --git a/artemis-tools/pom.xml b/artemis-tools/pom.xml index 164e66534d..44694da869 100644 --- a/artemis-tools/pom.xml +++ b/artemis-tools/pom.xml @@ -32,6 +32,10 @@ + + com.google.errorprone + error_prone_core + junit junit diff --git a/artemis-web/pom.xml b/artemis-web/pom.xml index d51287446c..16c2fac963 100644 --- a/artemis-web/pom.xml +++ b/artemis-web/pom.xml @@ -44,6 +44,12 @@ provided true + + com.google.errorprone + error_prone_core + provided + true + org.jboss.logging jboss-logging diff --git a/artemis-website/pom.xml b/artemis-website/pom.xml index 4ff0c051f7..a66854ceb4 100644 --- a/artemis-website/pom.xml +++ b/artemis-website/pom.xml @@ -92,7 +92,6 @@ maven-javadoc-plugin - 2.10.1 javadoc-jar @@ -101,6 +100,7 @@ jar + 8 true 128m 512m diff --git a/etc/checkstyle-suppressions.xml b/etc/checkstyle-suppressions.xml index 9ff360adae..38d77dcca5 100644 --- a/etc/checkstyle-suppressions.xml +++ b/etc/checkstyle-suppressions.xml @@ -27,6 +27,7 @@ under the License. - + + diff --git a/examples/features/sub-modules/tomcat/pom.xml b/examples/features/sub-modules/tomcat/pom.xml index cc642cf757..4aaab0ffb8 100644 --- a/examples/features/sub-modules/tomcat/pom.xml +++ b/examples/features/sub-modules/tomcat/pom.xml @@ -35,7 +35,6 @@ under the License. ${project.basedir}/../../../.. UTF-8 ${project.baseUri} - 1.6 3.0-alpha-1 @@ -76,15 +75,6 @@ under the License. - - org.apache.maven.plugins - maven-compiler-plugin - - ${java.version} - ${java.version} - - - org.apache.tomcat.maven tomcat7-maven-plugin @@ -122,4 +112,4 @@ under the License. - \ No newline at end of file + diff --git a/examples/pom.xml b/examples/pom.xml index a597b043c5..9eefc92560 100644 --- a/examples/pom.xml +++ b/examples/pom.xml @@ -60,6 +60,19 @@ under the License. + + + + org.apache.maven.plugins + maven-compiler-plugin + + + + + + + + diff --git a/examples/protocols/stomp/stomp-dual-authentication/readme.md b/examples/protocols/stomp/stomp-dual-authentication/readme.md index 0da536a373..d8b95b8aa0 100644 --- a/examples/protocols/stomp/stomp-dual-authentication/readme.md +++ b/examples/protocols/stomp/stomp-dual-authentication/readme.md @@ -6,9 +6,9 @@ This example shows you how to configure 2-way SSL along with 2 different authent The various keystore files are generated using the following commands: -* `keytool -genkey -keystore server-side-keystore.jks -storepass secureexample -keypass secureexample -dname "CN=ActiveMQ Artemis Server, OU=Artemis, O=ActiveMQ, L=AMQ, S=AMQ, C=AMQ" -keyalg RSA` +* `keytool -genkey -keystore server-side-keystore.jks -storepass secureexample -keypass secureexample -dname "CN=localhost, OU=Artemis, O=ActiveMQ, L=AMQ, S=AMQ, C=AMQ" -keyalg RSA` * `keytool -export -keystore server-side-keystore.jks -file server-side-cert.cer -storepass secureexample` * `keytool -import -keystore client-side-truststore.jks -file server-side-cert.cer -storepass secureexample -keypass secureexample -noprompt` * `keytool -genkey -keystore client-side-keystore.jks -storepass secureexample -keypass secureexample -dname "CN=ActiveMQ Artemis Client, OU=Artemis, O=ActiveMQ, L=AMQ, S=AMQ, C=AMQ" -keyalg RSA` * `keytool -export -keystore client-side-keystore.jks -file client-side-cert.cer -storepass secureexample` -* `keytool -import -keystore server-side-truststore.jks -file client-side-cert.cer -storepass secureexample -keypass secureexample -noprompt` \ No newline at end of file +* `keytool -import -keystore server-side-truststore.jks -file client-side-cert.cer -storepass secureexample -keypass secureexample -noprompt` diff --git a/examples/protocols/stomp/stomp-dual-authentication/src/main/java/org/apache/activemq/artemis/jms/example/StompDualAuthenticationExample.java b/examples/protocols/stomp/stomp-dual-authentication/src/main/java/org/apache/activemq/artemis/jms/example/StompDualAuthenticationExample.java index dd5259d17b..688c03ab3f 100644 --- a/examples/protocols/stomp/stomp-dual-authentication/src/main/java/org/apache/activemq/artemis/jms/example/StompDualAuthenticationExample.java +++ b/examples/protocols/stomp/stomp-dual-authentication/src/main/java/org/apache/activemq/artemis/jms/example/StompDualAuthenticationExample.java @@ -29,9 +29,6 @@ import java.io.InputStream; import java.io.OutputStream; import java.net.Socket; import java.nio.charset.StandardCharsets; -import java.security.Security; - -import com.sun.net.ssl.internal.ssl.Provider; /** * An example where a client will send a Stomp message on a TCP socket @@ -45,7 +42,6 @@ public class StompDualAuthenticationExample { Connection connection = null; InitialContext initialContext = null; - Security.addProvider(new Provider()); try { // set up SSL keystores for Stomp connection diff --git a/examples/protocols/stomp/stomp-dual-authentication/src/main/resources/activemq/server0/client-side-keystore.jks b/examples/protocols/stomp/stomp-dual-authentication/src/main/resources/activemq/server0/client-side-keystore.jks index cb65a44ddc..88ed01f015 100644 Binary files a/examples/protocols/stomp/stomp-dual-authentication/src/main/resources/activemq/server0/client-side-keystore.jks and b/examples/protocols/stomp/stomp-dual-authentication/src/main/resources/activemq/server0/client-side-keystore.jks differ diff --git a/examples/protocols/stomp/stomp-dual-authentication/src/main/resources/activemq/server0/client-side-truststore.jks b/examples/protocols/stomp/stomp-dual-authentication/src/main/resources/activemq/server0/client-side-truststore.jks index 7eb1d5634d..902f8f4172 100644 Binary files a/examples/protocols/stomp/stomp-dual-authentication/src/main/resources/activemq/server0/client-side-truststore.jks and b/examples/protocols/stomp/stomp-dual-authentication/src/main/resources/activemq/server0/client-side-truststore.jks differ diff --git a/examples/protocols/stomp/stomp-dual-authentication/src/main/resources/activemq/server0/server-side-keystore.jks b/examples/protocols/stomp/stomp-dual-authentication/src/main/resources/activemq/server0/server-side-keystore.jks index 6089c6ee13..83f5e966b0 100644 Binary files a/examples/protocols/stomp/stomp-dual-authentication/src/main/resources/activemq/server0/server-side-keystore.jks and b/examples/protocols/stomp/stomp-dual-authentication/src/main/resources/activemq/server0/server-side-keystore.jks differ diff --git a/examples/protocols/stomp/stomp-dual-authentication/src/main/resources/activemq/server0/server-side-truststore.jks b/examples/protocols/stomp/stomp-dual-authentication/src/main/resources/activemq/server0/server-side-truststore.jks index 0b7e224163..edb5e59aee 100644 Binary files a/examples/protocols/stomp/stomp-dual-authentication/src/main/resources/activemq/server0/server-side-truststore.jks and b/examples/protocols/stomp/stomp-dual-authentication/src/main/resources/activemq/server0/server-side-truststore.jks differ diff --git a/integration/activemq-spring-integration/pom.xml b/integration/activemq-spring-integration/pom.xml index 56afdefcbd..714aae28ed 100644 --- a/integration/activemq-spring-integration/pom.xml +++ b/integration/activemq-spring-integration/pom.xml @@ -48,6 +48,10 @@ org.springframework spring-beans + + com.google.errorprone + error_prone_core + diff --git a/pom.xml b/pom.xml index 80fc80de0f..38af255341 100644 --- a/pom.xml +++ b/pom.xml @@ -71,6 +71,8 @@ + + 9+181-r4173-1 scp://people.apache.org/x1/www/activemq.apache.org @@ -93,7 +95,7 @@ 9.4.26.v20200117 3.6.13.Final 2.4 - 2.25.0 + 3.3.3 2.1.2 4.1.48.Final @@ -127,7 +129,7 @@ 2.1 - 2.4.3 + 2.5.10 1.4.3 5.1.7.RELEASE @@ -158,9 +160,6 @@ UTF-8 UTF-8 - 1.8 - 1.8 - + + com.google.errorprone + error_prone_core + 2.4.0 + provided + true + log4j @@ -878,19 +882,10 @@ - - org.apache.maven.plugins - maven-javadoc-plugin - - -Xdoclint:none - - org.apache.maven.plugins maven-compiler-plugin - - 3.1 + 3.8.1 @@ -910,17 +905,38 @@ 1.8 - - - - org.apache.maven.plugins - maven-javadoc-plugin - - -Xdoclint:none - - - - + + 8 + 8 + + + + java9on + + [9,) + + + 8 + 11 + --add-modules java.sql,jdk.unsupported + + + + + org.apache.maven.plugins + maven-compiler-plugin + + true + + -Xdiags:verbose + --add-exports=jdk.unsupported/sun.misc=ALL-UNNAMED + -XDcompilePolicy=simple + -Xplugin:ErrorProne -Xep:MissingOverride:ERROR -Xep:NonAtomicVolatileUpdate:ERROR -Xep:SynchronizeOnNonFinalField:ERROR -Xep:SynchronizeOnNonFinalField:ERROR -Xep:WaitNotInLoop:ERROR -XepExcludedPaths:.*/generated-sources/.* + + + + + owasp @@ -1396,34 +1412,15 @@ maven-compiler-plugin - 3.1 + 3.8.1 - true - true - ${javac-compiler-id} - - -Xep:MissingOverride:ERROR - -Xep:NonAtomicVolatileUpdate:ERROR - -Xep:SynchronizeOnNonFinalField:ERROR - -Xep:StaticAccessedFromInstance:ERROR - -Xep:SynchronizeOnNonFinalField:ERROR - -Xep:WaitNotInLoop:ERROR - -Xdiags:verbose - + true + + -J-Xbootclasspath/p:${settings.localRepository}/com/google/errorprone/javac/${javac.version}/javac-${javac.version}.jar -Xep:MissingOverride:ERROR -Xep:NonAtomicVolatileUpdate:ERROR -Xep:SynchronizeOnNonFinalField:ERROR -Xep:StaticAccessedFromInstance:ERROR -Xep:SynchronizeOnNonFinalField:ERROR -Xep:WaitNotInLoop:ERROR + -Xdiags:verbose + - - - org.codehaus.plexus - plexus-compiler-javac-errorprone - 2.8 - - - com.google.errorprone - error_prone_core - 2.0.9 - - org.apache.maven.plugins @@ -1433,8 +1430,7 @@ org.apache.maven.plugins maven-javadoc-plugin - - 2.9 + 3.0.1 org.apache.maven.plugins @@ -1605,7 +1601,7 @@ org.apache.maven.plugins maven-checkstyle-plugin - 3.0.0 + 3.1.1 com.github.sevntu-checkstyle @@ -1729,7 +1725,7 @@ org.apache.felix maven-bundle-plugin - 3.0.0 + 4.2.1 true @@ -1822,7 +1818,6 @@ org.apache.maven.plugins maven-javadoc-plugin - 2.9 128m 1024m diff --git a/tests/artemis-test-support/pom.xml b/tests/artemis-test-support/pom.xml index 666ea8393b..2565ce6cb3 100644 --- a/tests/artemis-test-support/pom.xml +++ b/tests/artemis-test-support/pom.xml @@ -81,6 +81,10 @@ org.apache.geronimo.specs geronimo-jms_2.0_spec + + com.google.errorprone + error_prone_core + diff --git a/tests/artemis-test-support/src/main/java/org/apache/activemq/transport/amqp/client/AmqpSession.java b/tests/artemis-test-support/src/main/java/org/apache/activemq/transport/amqp/client/AmqpSession.java index ff23e67560..86309eb1cb 100644 --- a/tests/artemis-test-support/src/main/java/org/apache/activemq/transport/amqp/client/AmqpSession.java +++ b/tests/artemis-test-support/src/main/java/org/apache/activemq/transport/amqp/client/AmqpSession.java @@ -180,9 +180,9 @@ public class AmqpSession extends AmqpAbstractResource { * * @param address * the address to which the sender will produce its messages. - * @param senderSettlementMode + * @param senderMode * controls the settlement mode used by the created Sender - * @param receiverSettlementMode + * @param receiverMode * controls the desired settlement mode used by the remote Receiver * * @return a newly created sender that is ready for use. @@ -200,9 +200,9 @@ public class AmqpSession extends AmqpAbstractResource { * * @param address * the address to which the sender will produce its messages. - * @param senderSettlementMode + * @param senderMode * controls the settlement mode used by the created Sender - * @param receiverSettlementMode + * @param receiverMode * controls the desired settlement mode used by the remote Receiver * @param outcomes * specifies the outcomes supported by the sender @@ -387,9 +387,9 @@ public class AmqpSession extends AmqpAbstractResource { * * @param address * the address to which the receiver will subscribe for its messages. - * @param senderSettlementMode + * @param senderMode * controls the desired settlement mode used by the remote Sender - * @param receiverSettlementMode + * @param receiverMode * controls the settlement mode used by the created Receiver * * @return a newly created receiver that is ready for use. @@ -491,9 +491,8 @@ public class AmqpSession extends AmqpAbstractResource { } /** - * Create a receiver instance using the given Source + * Create a receiver instance using the given receiverId * - * @param source the caller created and configured Source used to create the receiver link. * @return a newly created receiver that is ready for use. * @throws Exception if an error occurs while creating the receiver. */ diff --git a/tests/artemis-test-support/src/main/java/org/apache/activemq/transport/amqp/client/util/IdGenerator.java b/tests/artemis-test-support/src/main/java/org/apache/activemq/transport/amqp/client/util/IdGenerator.java index f93ca6ea8c..7a2017f475 100644 --- a/tests/artemis-test-support/src/main/java/org/apache/activemq/transport/amqp/client/util/IdGenerator.java +++ b/tests/artemis-test-support/src/main/java/org/apache/activemq/transport/amqp/client/util/IdGenerator.java @@ -231,7 +231,7 @@ public class IdGenerator { /** * When using the {@link java.net.InetAddress#getHostName()} method in an - * environment where neither a proper DNS lookup nor an /etc/hosts + * environment where neither a proper DNS lookup nor an /etc/hosts * entry exists for a given host, the following exception will be thrown: * * java.net.UnknownHostException: <hostname>: <hostname> @@ -241,7 +241,7 @@ public class IdGenerator { * Instead of just throwing an UnknownHostException and giving up, this * method grabs a suitable hostname from the exception and prevents the * exception from being thrown. If a suitable hostname cannot be acquired - * from the exception, only then is the UnknownHostException thrown. + * from the exception, only then is the UnknownHostException thrown. * * @return The hostname * @throws UnknownHostException if the given host cannot be looked up. diff --git a/tests/compatibility-tests/pom.xml b/tests/compatibility-tests/pom.xml index 80e38f5773..9ebab02231 100644 --- a/tests/compatibility-tests/pom.xml +++ b/tests/compatibility-tests/pom.xml @@ -32,6 +32,10 @@ + + com.google.errorprone + error_prone_core + org.apache.activemq artemis-server @@ -166,6 +170,7 @@ org.codehaus.groovy groovy-all ${groovy.version} + pom org.apache.activemq @@ -267,7 +272,6 @@ org.apache.qpid qpid-jms-client - ${qpid.jms.version} org.apache.qpid @@ -276,12 +280,11 @@ org.slf4j slf4j-api - 1.7.5 org.jboss.marshalling jboss-marshalling-river - 2.0.2.Final + 2.0.9.Final @@ -324,7 +327,7 @@ org.apache.activemq:artemis-hornetq-protocol:${project.version} org.apache.activemq:artemis-amqp-protocol:${project.version} org.apache.activemq:artemis-hornetq-protocol:${project.version} - org.codehaus.groovy:groovy-all:${groovy.version} + org.codehaus.groovy:groovy-all:pom:${groovy.version} org.apache.activemq.tests:compatibility-tests:${project.version} @@ -346,7 +349,7 @@ org.apache.activemq:artemis-hornetq-protocol:2.6.3 org.apache.activemq:artemis-amqp-protocol:2.6.3 org.apache.activemq:artemis-hornetq-protocol:2.6.3 - org.codehaus.groovy:groovy-all:${groovy.version} + org.codehaus.groovy:groovy-all:pom:${groovy.version} org.apache.activemq.tests:compatibility-tests:${project.version} @@ -370,7 +373,7 @@ org.apache.activemq:artemis-hornetq-protocol:2.7.0 org.apache.activemq:artemis-amqp-protocol:2.7.0 org.apache.activemq:artemis-hornetq-protocol:2.7.0 - org.codehaus.groovy:groovy-all:${groovy.version} + org.codehaus.groovy:groovy-all:pom:${groovy.version} org.apache.activemq.tests:compatibility-tests:${project.version} @@ -395,8 +398,8 @@ org.apache.activemq:artemis-hornetq-protocol:2.10.0 org.apache.activemq:artemis-amqp-protocol:2.10.0 org.apache.activemq:artemis-hornetq-protocol:2.10.0 - org.codehaus.groovy:groovy-all:${groovy.version} - org.jboss.marshalling:jboss-marshalling-river:2.0.2.Final + org.codehaus.groovy:groovy-all:pom:${groovy.version} + org.jboss.marshalling:jboss-marshalling-river:2.0.9.Final org.apache.activemq.tests:compatibility-tests:${project.version} @@ -420,7 +423,7 @@ org.apache.activemq:artemis-hornetq-protocol:2.4.0 org.apache.activemq:artemis-amqp-protocol:2.4.0 org.apache.activemq:artemis-hornetq-protocol:2.4.0 - org.codehaus.groovy:groovy-all:${groovy.version} + org.codehaus.groovy:groovy-all:pom:${groovy.version} org.apache.activemq.tests:compatibility-tests:${project.version} @@ -444,7 +447,7 @@ org.apache.activemq:artemis-hornetq-protocol:2.1.0 org.apache.activemq:artemis-amqp-protocol:2.1.0 org.apache.activemq:artemis-hornetq-protocol:2.1.0 - org.codehaus.groovy:groovy-all:${groovy.version} + org.codehaus.groovy:groovy-all:pom:${groovy.version} org.apache.activemq.tests:compatibility-tests:${project.version} @@ -468,7 +471,7 @@ org.apache.activemq:artemis-hornetq-protocol:2.0.0 org.apache.activemq:artemis-amqp-protocol:2.0.0 org.apache.activemq:artemis-hornetq-protocol:2.0.0 - org.codehaus.groovy:groovy-all:${groovy.version} + org.codehaus.groovy:groovy-all:pom:${groovy.version} org.apache.activemq.tests:compatibility-tests:${project.version} @@ -492,7 +495,7 @@ org.apache.activemq:artemis-hornetq-protocol:1.4.0 org.apache.activemq:artemis-amqp-protocol:1.4.0 org.apache.activemq:artemis-hornetq-protocol:1.4.0 - org.codehaus.groovy:groovy-all:${groovy.version} + org.codehaus.groovy:groovy-all:pom:${groovy.version} org.apache.activemq.tests:compatibility-tests:${project.version} @@ -516,8 +519,8 @@ org.apache.activemq:artemis-hornetq-protocol:1.5.5 org.apache.activemq:artemis-amqp-protocol:1.5.5 org.apache.activemq:artemis-hornetq-protocol:1.5.5 - org.codehaus.groovy:groovy-all:${groovy.version} - org.jboss.marshalling:jboss-marshalling-river:2.0.2.Final + org.codehaus.groovy:groovy-all:pom:${groovy.version} + org.jboss.marshalling:jboss-marshalling-river:2.0.9.Final org.apache.activemq.tests:compatibility-tests:${project.version} @@ -542,7 +545,7 @@ org.hornetq:hornetq-jms-server:2.3.5.Final - org.codehaus.groovy:groovy-all:${groovy.version} + org.codehaus.groovy:groovy-all:pom:${groovy.version} org.apache.activemq.tests:compatibility-tests:${project.version} @@ -567,7 +570,7 @@ org.hornetq:hornetq-jms-server:2.4.7.Final - org.codehaus.groovy:groovy-all:${groovy.version} + org.codehaus.groovy:groovy-all:pom:${groovy.version} org.apache.activemq.tests:compatibility-tests:${project.version} @@ -635,7 +638,7 @@ ${skipCompatibilityTests} - -Djgroups.bind_addr=::1 ${activemq-surefire-argline} + ${modular.jdk.surefire.arg} -Djgroups.bind_addr=::1 ${activemq-surefire-argline}

        Default properties
        Name Default Value
        AMQ_HOST or org.apache.activemq.AMQ_HOST localhost
        AMQ_PORT or org.apache.activemq.AMQ_PORT 61616