diff --git a/artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/PrintData.java b/artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/PrintData.java index 9256acc4a1..7c5fddf130 100644 --- a/artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/PrintData.java +++ b/artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/PrintData.java @@ -289,7 +289,7 @@ public class PrintData extends LockAbstract { private final Map> completePages = new HashMap<>(); - public PageCursorsInfo() { + private PageCursorsInfo() { } /** diff --git a/artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/XmlDataExporter.java b/artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/XmlDataExporter.java index c3deae4940..3aec34f546 100644 --- a/artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/XmlDataExporter.java +++ b/artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/XmlDataExporter.java @@ -935,7 +935,7 @@ public final class XmlDataExporter extends LockAbstract { boolean wrap = true; - public PrettyPrintHandler(XMLStreamWriter target) { + PrettyPrintHandler(XMLStreamWriter target) { this.target = target; } diff --git a/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/ReusableLatch.java b/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/ReusableLatch.java index 4f04f22930..19023edcb6 100644 --- a/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/ReusableLatch.java +++ b/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/ReusableLatch.java @@ -43,7 +43,7 @@ public class ReusableLatch { @SuppressWarnings("serial") private static class CountSync extends AbstractQueuedSynchronizer { - public CountSync(int count) { + private CountSync(int count) { setState(count); } diff --git a/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/TypedProperties.java b/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/TypedProperties.java index 166f39e550..eeb5783c7d 100644 --- a/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/TypedProperties.java +++ b/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/TypedProperties.java @@ -598,7 +598,7 @@ public final class TypedProperties { private static final class NullValue extends PropertyValue { - public NullValue() { + private NullValue() { } @Override @@ -622,11 +622,11 @@ public final class TypedProperties { final boolean val; - public BooleanValue(final boolean val) { + private BooleanValue(final boolean val) { this.val = val; } - public BooleanValue(final ActiveMQBuffer buffer) { + private BooleanValue(final ActiveMQBuffer buffer) { val = buffer.readBoolean(); } @@ -652,11 +652,11 @@ public final class TypedProperties { final byte val; - public ByteValue(final byte val) { + private ByteValue(final byte val) { this.val = val; } - public ByteValue(final ActiveMQBuffer buffer) { + private ByteValue(final ActiveMQBuffer buffer) { val = buffer.readByte(); } @@ -681,11 +681,11 @@ public final class TypedProperties { final byte[] val; - public BytesValue(final byte[] val) { + private BytesValue(final byte[] val) { this.val = val; } - public BytesValue(final ActiveMQBuffer buffer) { + private BytesValue(final ActiveMQBuffer buffer) { int len = buffer.readInt(); val = new byte[len]; buffer.readBytes(val); @@ -714,11 +714,11 @@ public final class TypedProperties { final short val; - public ShortValue(final short val) { + private ShortValue(final short val) { this.val = val; } - public ShortValue(final ActiveMQBuffer buffer) { + private ShortValue(final ActiveMQBuffer buffer) { val = buffer.readShort(); } @@ -743,11 +743,11 @@ public final class TypedProperties { final int val; - public IntValue(final int val) { + private IntValue(final int val) { this.val = val; } - public IntValue(final ActiveMQBuffer buffer) { + private IntValue(final ActiveMQBuffer buffer) { val = buffer.readInt(); } @@ -772,11 +772,11 @@ public final class TypedProperties { final long val; - public LongValue(final long val) { + private LongValue(final long val) { this.val = val; } - public LongValue(final ActiveMQBuffer buffer) { + private LongValue(final ActiveMQBuffer buffer) { val = buffer.readLong(); } @@ -801,11 +801,11 @@ public final class TypedProperties { final float val; - public FloatValue(final float val) { + private FloatValue(final float val) { this.val = val; } - public FloatValue(final ActiveMQBuffer buffer) { + private FloatValue(final ActiveMQBuffer buffer) { val = Float.intBitsToFloat(buffer.readInt()); } @@ -831,11 +831,11 @@ public final class TypedProperties { final double val; - public DoubleValue(final double val) { + private DoubleValue(final double val) { this.val = val; } - public DoubleValue(final ActiveMQBuffer buffer) { + private DoubleValue(final ActiveMQBuffer buffer) { val = Double.longBitsToDouble(buffer.readLong()); } @@ -860,11 +860,11 @@ public final class TypedProperties { final char val; - public CharValue(final char val) { + private CharValue(final char val) { this.val = val; } - public CharValue(final ActiveMQBuffer buffer) { + private CharValue(final ActiveMQBuffer buffer) { val = (char) buffer.readShort(); } @@ -889,11 +889,11 @@ public final class TypedProperties { final SimpleString val; - public StringValue(final SimpleString val) { + private StringValue(final SimpleString val) { this.val = val; } - public StringValue(final ActiveMQBuffer buffer) { + private StringValue(final ActiveMQBuffer buffer) { val = buffer.readSimpleString(); } diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/UDPBroadcastEndpointFactory.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/UDPBroadcastEndpointFactory.java index dff18a5ff7..e5cc1ffc39 100644 --- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/UDPBroadcastEndpointFactory.java +++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/UDPBroadcastEndpointFactory.java @@ -113,7 +113,7 @@ public final class UDPBroadcastEndpointFactory implements BroadcastEndpointFacto private volatile boolean open; - public UDPBroadcastEndpoint() { + private UDPBroadcastEndpoint() { } public UDPBroadcastEndpoint setGroupAddress(InetAddress groupAddress) { diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/CoreNotificationType.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/CoreNotificationType.java index 1821962e8f..ff514ad8d4 100644 --- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/CoreNotificationType.java +++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/CoreNotificationType.java @@ -43,7 +43,7 @@ public enum CoreNotificationType implements NotificationType { private final int value; - private CoreNotificationType(final int value) { + CoreNotificationType(final int value) { this.value = value; } diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientMessageImpl.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientMessageImpl.java index 926ac1bd3b..a6a2231a8d 100644 --- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientMessageImpl.java +++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientMessageImpl.java @@ -318,7 +318,7 @@ public class ClientMessageImpl extends MessageImpl implements ClientMessageInter private final class DecodingContext implements BodyEncoder { - public DecodingContext() { + private DecodingContext() { } @Override diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/CompressedLargeMessageControllerImpl.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/CompressedLargeMessageControllerImpl.java index e7cc17364e..0e826b5c36 100644 --- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/CompressedLargeMessageControllerImpl.java +++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/CompressedLargeMessageControllerImpl.java @@ -40,7 +40,7 @@ final class CompressedLargeMessageControllerImpl implements LargeMessageControll private final LargeMessageController bufferDelegate; - public CompressedLargeMessageControllerImpl(final LargeMessageController bufferDelegate) { + CompressedLargeMessageControllerImpl(final LargeMessageController bufferDelegate) { this.bufferDelegate = bufferDelegate; } diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/LargeMessageControllerImpl.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/LargeMessageControllerImpl.java index c3b18a37b5..da4d6bd1ce 100644 --- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/LargeMessageControllerImpl.java +++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/LargeMessageControllerImpl.java @@ -1141,7 +1141,7 @@ public class LargeMessageControllerImpl implements LargeMessageController { private final class FileCache { - public FileCache(final File cachedFile) { + private FileCache(final File cachedFile) { this.cachedFile = cachedFile; } @@ -1323,13 +1323,13 @@ public class LargeMessageControllerImpl implements LargeMessageController { final int flowControlSize; final boolean continues; - public LargeData() { + private LargeData() { continues = false; flowControlSize = 0; chunk = null; } - public LargeData(byte[] chunk, int flowControlSize, boolean continues) { + private LargeData(byte[] chunk, int flowControlSize, boolean continues) { this.chunk = chunk; this.flowControlSize = flowControlSize; this.continues = continues; diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ServerLocatorImpl.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ServerLocatorImpl.java index 8c71002699..e7c67cf812 100644 --- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ServerLocatorImpl.java +++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ServerLocatorImpl.java @@ -1784,7 +1784,7 @@ public final class ServerLocatorImpl implements ServerLocatorInternal, Discovery private volatile ClientSessionFactoryInternal factory; - public Connector(TransportConfiguration initialConnector, ClientSessionFactoryInternal factory) { + private Connector(TransportConfiguration initialConnector, ClientSessionFactoryInternal factory) { this.initialConnector = initialConnector; this.factory = factory; } diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/MessageImpl.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/MessageImpl.java index df771321fb..10818fa266 100644 --- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/MessageImpl.java +++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/MessageImpl.java @@ -1013,7 +1013,7 @@ public abstract class MessageImpl implements MessageInternal { private int lastPos = 0; - public DecodingContext() { + private DecodingContext() { } @Override diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnector.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnector.java index b209f89f40..62c405b48b 100644 --- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnector.java +++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnector.java @@ -725,7 +725,7 @@ public class NettyConnector extends AbstractConnector { private final CountDownLatch latch = new CountDownLatch(1); private boolean handshakeComplete = false; - public HttpUpgradeHandler(ChannelPipeline pipeline, HttpClientCodec httpClientCodec) { + private HttpUpgradeHandler(ChannelPipeline pipeline, HttpClientCodec httpClientCodec) { this.pipeline = pipeline; this.httpClientCodec = httpClientCodec; } @@ -798,7 +798,7 @@ public class NettyConnector extends AbstractConnector { private String cookie; - public HttpHandler() throws Exception { + HttpHandler() throws Exception { url = new URI("http", null, host, port, servletPath, null, null).toString(); } diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/OrderedExecutorFactory.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/OrderedExecutorFactory.java index b0b13ae9c0..d80d7bd06d 100644 --- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/OrderedExecutorFactory.java +++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/OrderedExecutorFactory.java @@ -74,7 +74,7 @@ public final class OrderedExecutorFactory implements ExecutorFactory { private static final int STATE_NOT_RUNNING = 0; private static final int STATE_RUNNING = 1; - public OrderedExecutor(Executor delegate) { + private OrderedExecutor(Executor delegate) { this.delegate = delegate; } diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/SoftValueHashMap.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/SoftValueHashMap.java index b499910fda..17228c276a 100644 --- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/SoftValueHashMap.java +++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/SoftValueHashMap.java @@ -342,7 +342,7 @@ public class SoftValueHashMap implemen used = usedCounter.incrementAndGet(); } - public AggregatedSoftReference(final K key, final V referent) { + AggregatedSoftReference(final K key, final V referent) { super(referent, refQueue); this.key = key; } diff --git a/artemis-dto/src/main/java/org/apache/activemq/artemis/dto/XmlUtil.java b/artemis-dto/src/main/java/org/apache/activemq/artemis/dto/XmlUtil.java index c49dbe5336..5fa86678ed 100644 --- a/artemis-dto/src/main/java/org/apache/activemq/artemis/dto/XmlUtil.java +++ b/artemis-dto/src/main/java/org/apache/activemq/artemis/dto/XmlUtil.java @@ -42,7 +42,7 @@ public class XmlUtil { static final Pattern pattern = Pattern.compile("\\$\\{([^\\}]+)\\}"); private final Properties props; - public PropertiesFilter(XMLStreamReader parent, Properties props) { + PropertiesFilter(XMLStreamReader parent, Properties props) { super(parent); this.props = props; } diff --git a/artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/journal/TransactionHolder.java b/artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/journal/TransactionHolder.java index c03e7479d4..348c823d51 100644 --- a/artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/journal/TransactionHolder.java +++ b/artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/journal/TransactionHolder.java @@ -24,7 +24,7 @@ import org.apache.activemq.artemis.core.journal.RecordInfo; final class TransactionHolder { - public TransactionHolder(final long id) { + TransactionHolder(final long id) { transactionID = id; } diff --git a/artemis-jdbc-store/src/test/java/org/apache/activemq/artemis/jdbc/file/JDBCSequentialFileFactoryTest.java b/artemis-jdbc-store/src/test/java/org/apache/activemq/artemis/jdbc/file/JDBCSequentialFileFactoryTest.java index 1a8fba4c9f..5f7d7e6443 100644 --- a/artemis-jdbc-store/src/test/java/org/apache/activemq/artemis/jdbc/file/JDBCSequentialFileFactoryTest.java +++ b/artemis-jdbc-store/src/test/java/org/apache/activemq/artemis/jdbc/file/JDBCSequentialFileFactoryTest.java @@ -169,7 +169,7 @@ public class JDBCSequentialFileFactoryTest { private final CountDownLatch countDownLatch; - public IOCallbackCountdown(int size) { + private IOCallbackCountdown(int size) { this.countDownLatch = new CountDownLatch(size); } diff --git a/artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQJMSConsumer.java b/artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQJMSConsumer.java index f3ba6e246b..c59812ba88 100644 --- a/artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQJMSConsumer.java +++ b/artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQJMSConsumer.java @@ -143,7 +143,7 @@ public class ActiveMQJMSConsumer implements JMSConsumer { private final MessageListener wrapped; - public MessageListenerWrapper(MessageListener wrapped) { + MessageListenerWrapper(MessageListener wrapped) { this.wrapped = wrapped; } diff --git a/artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQJMSProducer.java b/artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQJMSProducer.java index 6e37a86214..17d6c3c126 100644 --- a/artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQJMSProducer.java +++ b/artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQJMSProducer.java @@ -628,7 +628,7 @@ public final class ActiveMQJMSProducer implements JMSProducer { private final CompletionListener wrapped; - public CompletionListenerWrapper(CompletionListener wrapped) { + CompletionListenerWrapper(CompletionListener wrapped) { this.wrapped = wrapped; } diff --git a/artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQMessageProducer.java b/artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQMessageProducer.java index 112b535c3f..5a0d5c3573 100644 --- a/artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQMessageProducer.java +++ b/artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQMessageProducer.java @@ -533,9 +533,9 @@ public class ActiveMQMessageProducer implements MessageProducer, QueueSender, To * @param jmsMessage * @param producer */ - public CompletionListenerWrapper(CompletionListener listener, - Message jmsMessage, - ActiveMQMessageProducer producer) { + private CompletionListenerWrapper(CompletionListener listener, + Message jmsMessage, + ActiveMQMessageProducer producer) { this.completionListener = listener; this.jmsMessage = jmsMessage; this.producer = producer; diff --git a/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/bridge/impl/JMSBridgeImpl.java b/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/bridge/impl/JMSBridgeImpl.java index 46cc0d492d..79873200c2 100644 --- a/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/bridge/impl/JMSBridgeImpl.java +++ b/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/bridge/impl/JMSBridgeImpl.java @@ -1900,7 +1900,7 @@ public final class JMSBridgeImpl implements JMSBridge { BridgeFailoverListener failoverListener; private final boolean isSource; - public BridgeExceptionListener(boolean ha, BridgeFailoverListener failoverListener, boolean isSource) { + private BridgeExceptionListener(boolean ha, BridgeFailoverListener failoverListener, boolean isSource) { this.ha = ha; this.failoverListener = failoverListener; this.isSource = isSource; @@ -1992,7 +1992,7 @@ public final class JMSBridgeImpl implements JMSBridge { private final boolean isSource; volatile FailoverEventType lastEvent; - public BridgeFailoverListener(boolean isSource) { + private BridgeFailoverListener(boolean isSource) { this.isSource = isSource; } diff --git a/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/management/JMSNotificationType.java b/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/management/JMSNotificationType.java index 68ec9edfcc..5f71effbd9 100644 --- a/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/management/JMSNotificationType.java +++ b/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/management/JMSNotificationType.java @@ -31,7 +31,7 @@ public enum JMSNotificationType implements NotificationType { private int type; - private JMSNotificationType(int type) { + JMSNotificationType(int type) { this.type = type; } diff --git a/artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/aio/AIOSequentialFileFactory.java b/artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/aio/AIOSequentialFileFactory.java index 2a79e6e3da..f3f12a5804 100644 --- a/artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/aio/AIOSequentialFileFactory.java +++ b/artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/aio/AIOSequentialFileFactory.java @@ -359,7 +359,7 @@ public final class AIOSequentialFileFactory extends AbstractSequentialFileFactor private class PollerThread extends Thread { - public PollerThread() { + private PollerThread() { super("Apache ActiveMQ Artemis libaio poller"); } diff --git a/artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalBase.java b/artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalBase.java index 50632fa7e6..e2ca84d12d 100644 --- a/artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalBase.java +++ b/artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalBase.java @@ -28,7 +28,7 @@ abstract class JournalBase implements Journal { protected final int fileSize; private final boolean supportsCallback; - public JournalBase(boolean supportsCallback, int fileSize) { + JournalBase(boolean supportsCallback, int fileSize) { if (fileSize < JournalImpl.MIN_FILE_SIZE) { throw new IllegalArgumentException("File size cannot be less than " + JournalImpl.MIN_FILE_SIZE + " bytes"); } diff --git a/artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalCompactor.java b/artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalCompactor.java index 1acbcaaf3e..40926e00dc 100644 --- a/artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalCompactor.java +++ b/artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalCompactor.java @@ -444,7 +444,7 @@ public class JournalCompactor extends AbstractJournalUpdateTask implements Journ JournalFile usedFile; - public DeleteCompactCommand(final long id, final JournalFile usedFile) { + private DeleteCompactCommand(final long id, final JournalFile usedFile) { this.id = id; this.usedFile = usedFile; } @@ -479,7 +479,7 @@ public class JournalCompactor extends AbstractJournalUpdateTask implements Journ private final int size; - public UpdateCompactCommand(final long id, final JournalFile usedFile, final int size) { + private UpdateCompactCommand(final long id, final JournalFile usedFile, final int size) { this.id = id; this.usedFile = usedFile; this.size = size; @@ -501,7 +501,7 @@ public class JournalCompactor extends AbstractJournalUpdateTask implements Journ */ private final JournalFile commitFile; - public CommitCompactCommand(final JournalTransaction liveTransaction, final JournalFile commitFile) { + private CommitCompactCommand(final JournalTransaction liveTransaction, final JournalFile commitFile) { this.liveTransaction = liveTransaction; this.commitFile = commitFile; } @@ -526,7 +526,7 @@ public class JournalCompactor extends AbstractJournalUpdateTask implements Journ */ private final JournalFile rollbackFile; - public RollbackCompactCommand(final JournalTransaction liveTransaction, final JournalFile rollbackFile) { + private RollbackCompactCommand(final JournalTransaction liveTransaction, final JournalFile rollbackFile) { this.liveTransaction = liveTransaction; this.rollbackFile = rollbackFile; } diff --git a/artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalImpl.java b/artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalImpl.java index e19e72889e..61d6800ee4 100644 --- a/artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalImpl.java +++ b/artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalImpl.java @@ -2578,7 +2578,7 @@ public class JournalImpl extends JournalBase implements TestableJournal, Journal // Used on Load private static final class TransactionHolder { - public TransactionHolder(final long id) { + private TransactionHolder(final long id) { transactionID = id; } diff --git a/artemis-native/src/test/java/org/apache/activemq/artemis/jlibaio/test/LibaioTest.java b/artemis-native/src/test/java/org/apache/activemq/artemis/jlibaio/test/LibaioTest.java index 617553c69c..71f7516fba 100644 --- a/artemis-native/src/test/java/org/apache/activemq/artemis/jlibaio/test/LibaioTest.java +++ b/artemis-native/src/test/java/org/apache/activemq/artemis/jlibaio/test/LibaioTest.java @@ -721,7 +721,7 @@ public class LibaioTest { String errorMessage; int errno; - public TestInfo() { + TestInfo() { count.incrementAndGet(); } diff --git a/artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTProtocolManager.java b/artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTProtocolManager.java index e99272f767..d2c0793177 100644 --- a/artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTProtocolManager.java +++ b/artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTProtocolManager.java @@ -43,7 +43,7 @@ class MQTTProtocolManager implements ProtocolManager, NotificationListener { private MQTTLogger log = MQTTLogger.LOGGER; - public MQTTProtocolManager(ActiveMQServer server) { + MQTTProtocolManager(ActiveMQServer server) { this.server = server; } diff --git a/artemis-protocols/artemis-proton-plug/src/main/java/org/proton/plug/util/CreditsSemaphore.java b/artemis-protocols/artemis-proton-plug/src/main/java/org/proton/plug/util/CreditsSemaphore.java index 170e8755d8..a175805de9 100644 --- a/artemis-protocols/artemis-proton-plug/src/main/java/org/proton/plug/util/CreditsSemaphore.java +++ b/artemis-protocols/artemis-proton-plug/src/main/java/org/proton/plug/util/CreditsSemaphore.java @@ -23,7 +23,7 @@ public class CreditsSemaphore { @SuppressWarnings("serial") private static class Sync extends AbstractQueuedSynchronizer { - public Sync(int initial) { + private Sync(int initial) { setState(initial); } diff --git a/artemis-protocols/artemis-proton-plug/src/main/java/org/proton/plug/util/ReusableLatch.java b/artemis-protocols/artemis-proton-plug/src/main/java/org/proton/plug/util/ReusableLatch.java index 87e00e00fb..beccc03987 100644 --- a/artemis-protocols/artemis-proton-plug/src/main/java/org/proton/plug/util/ReusableLatch.java +++ b/artemis-protocols/artemis-proton-plug/src/main/java/org/proton/plug/util/ReusableLatch.java @@ -38,7 +38,7 @@ public class ReusableLatch { @SuppressWarnings("serial") private static class CountSync extends AbstractQueuedSynchronizer { - public CountSync(int count) { + private CountSync(int count) { setState(count); } diff --git a/artemis-protocols/artemis-proton-plug/src/test/java/org/proton/plug/context/AbstractConnectionContextTest.java b/artemis-protocols/artemis-proton-plug/src/test/java/org/proton/plug/context/AbstractConnectionContextTest.java index 1cf7bb2538..bfa0bad038 100644 --- a/artemis-protocols/artemis-proton-plug/src/test/java/org/proton/plug/context/AbstractConnectionContextTest.java +++ b/artemis-protocols/artemis-proton-plug/src/test/java/org/proton/plug/context/AbstractConnectionContextTest.java @@ -50,7 +50,7 @@ public class AbstractConnectionContextTest { private class TestConnectionContext extends AbstractConnectionContext { - public TestConnectionContext(AMQPConnectionCallback connectionCallback) { + private TestConnectionContext(AMQPConnectionCallback connectionCallback) { super(connectionCallback, Executors.newSingleThreadExecutor(ActiveMQThreadFactory.defaultThreadFactory()), null); } diff --git a/artemis-protocols/artemis-proton-plug/src/test/java/org/proton/plug/test/minimalserver/MinimalServer.java b/artemis-protocols/artemis-proton-plug/src/test/java/org/proton/plug/test/minimalserver/MinimalServer.java index 7cb7861272..8729cb40be 100644 --- a/artemis-protocols/artemis-proton-plug/src/test/java/org/proton/plug/test/minimalserver/MinimalServer.java +++ b/artemis-protocols/artemis-proton-plug/src/test/java/org/proton/plug/test/minimalserver/MinimalServer.java @@ -120,7 +120,7 @@ public class MinimalServer { AMQPServerConnectionContext connection; - public ProtocolDecoder() { + ProtocolDecoder() { } @Override diff --git a/artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/ActiveMQStompException.java b/artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/ActiveMQStompException.java index 9fb0786af3..7966037ed6 100644 --- a/artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/ActiveMQStompException.java +++ b/artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/ActiveMQStompException.java @@ -97,7 +97,7 @@ public class ActiveMQStompException extends Exception { public final String key; public final String val; - public Header(String key, String val) { + private Header(String key, String val) { this.key = key; this.val = val; } diff --git a/artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/StompProtocolManager.java b/artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/StompProtocolManager.java index b3e52afb0f..4b6f5ba1b2 100644 --- a/artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/StompProtocolManager.java +++ b/artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/StompProtocolManager.java @@ -75,10 +75,10 @@ class StompProtocolManager implements ProtocolManager { // Constructors -------------------------------------------------- - public StompProtocolManager(final StompProtocolManagerFactory factory, - final ActiveMQServer server, - final List incomingInterceptors, - final List outgoingInterceptors) { + StompProtocolManager(final StompProtocolManagerFactory factory, + final ActiveMQServer server, + final List incomingInterceptors, + final List outgoingInterceptors) { this.factory = factory; this.server = server; this.executor = server.getExecutorFactory().getExecutor(); diff --git a/artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/StompVersions.java b/artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/StompVersions.java index adf360c6e8..a41726f2aa 100644 --- a/artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/StompVersions.java +++ b/artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/StompVersions.java @@ -26,7 +26,7 @@ public enum StompVersions { private String version; - private StompVersions(String ver) { + StompVersions(String ver) { this.version = ver; } diff --git a/artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/v11/StompFrameHandlerV11.java b/artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/v11/StompFrameHandlerV11.java index 6874173672..91d011914e 100644 --- a/artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/v11/StompFrameHandlerV11.java +++ b/artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/v11/StompFrameHandlerV11.java @@ -251,7 +251,7 @@ public class StompFrameHandlerV11 extends VersionedStompFrameHandler implements AtomicLong lastAccepted = new AtomicLong(0); StompFrame pingFrame; - public HeartBeater(long clientPing, long clientAcceptPing) { + private HeartBeater(long clientPing, long clientAcceptPing) { if (clientPing != 0) { serverAcceptPing = clientPing > MIN_CLIENT_PING ? clientPing : MIN_CLIENT_PING; } diff --git a/artemis-rest/src/test/java/org/apache/activemq/artemis/rest/test/AutoAckTopicTest.java b/artemis-rest/src/test/java/org/apache/activemq/artemis/rest/test/AutoAckTopicTest.java index d8fe822c13..baf464f5db 100644 --- a/artemis-rest/src/test/java/org/apache/activemq/artemis/rest/test/AutoAckTopicTest.java +++ b/artemis-rest/src/test/java/org/apache/activemq/artemis/rest/test/AutoAckTopicTest.java @@ -150,7 +150,7 @@ public class AutoAckTopicTest extends MessageTestBase { private boolean isFinished = false; private boolean failed = false; - public NewPullSubscriber(String url) { + private NewPullSubscriber(String url) { this.url = url; } @@ -187,7 +187,7 @@ public class AutoAckTopicTest extends MessageTestBase { private boolean isFinished = false; private boolean failed = false; - public AcceptWaitListener(String url) { + private AcceptWaitListener(String url) { this.url = url; } diff --git a/artemis-selector/src/main/java/org/apache/activemq/artemis/selector/filter/ComparisonExpression.java b/artemis-selector/src/main/java/org/apache/activemq/artemis/selector/filter/ComparisonExpression.java index 05cbbe5fe4..bc3b3333df 100755 --- a/artemis-selector/src/main/java/org/apache/activemq/artemis/selector/filter/ComparisonExpression.java +++ b/artemis-selector/src/main/java/org/apache/activemq/artemis/selector/filter/ComparisonExpression.java @@ -79,7 +79,7 @@ public abstract class ComparisonExpression extends BinaryExpression implements B /** */ - public LikeExpression(Expression right, String like, int escape) { + LikeExpression(Expression right, String like, int escape) { super(right); StringBuffer regexp = new StringBuffer(like.length() * 2); diff --git a/artemis-selector/src/main/java/org/apache/activemq/artemis/selector/filter/ConstantExpression.java b/artemis-selector/src/main/java/org/apache/activemq/artemis/selector/filter/ConstantExpression.java index 010b736868..8d88bbd695 100755 --- a/artemis-selector/src/main/java/org/apache/activemq/artemis/selector/filter/ConstantExpression.java +++ b/artemis-selector/src/main/java/org/apache/activemq/artemis/selector/filter/ConstantExpression.java @@ -27,7 +27,7 @@ public class ConstantExpression implements Expression { static class BooleanConstantExpression extends ConstantExpression implements BooleanExpression { - public BooleanConstantExpression(Object value) { + BooleanConstantExpression(Object value) { super(value); } diff --git a/artemis-selector/src/main/java/org/apache/activemq/artemis/selector/filter/UnaryExpression.java b/artemis-selector/src/main/java/org/apache/activemq/artemis/selector/filter/UnaryExpression.java index fb9832a69e..3121ac297d 100755 --- a/artemis-selector/src/main/java/org/apache/activemq/artemis/selector/filter/UnaryExpression.java +++ b/artemis-selector/src/main/java/org/apache/activemq/artemis/selector/filter/UnaryExpression.java @@ -125,7 +125,7 @@ public abstract class UnaryExpression implements Expression { abstract static class BooleanUnaryExpression extends UnaryExpression implements BooleanExpression { - public BooleanUnaryExpression(Expression left) { + BooleanUnaryExpression(Expression left) { super(left); } diff --git a/artemis-server-osgi/src/test/java/org/apache/activemq/artemis/osgi/ProtocolTrackerTest.java b/artemis-server-osgi/src/test/java/org/apache/activemq/artemis/osgi/ProtocolTrackerTest.java index 46435cdd1d..18e1f766d4 100644 --- a/artemis-server-osgi/src/test/java/org/apache/activemq/artemis/osgi/ProtocolTrackerTest.java +++ b/artemis-server-osgi/src/test/java/org/apache/activemq/artemis/osgi/ProtocolTrackerTest.java @@ -64,7 +64,7 @@ public class ProtocolTrackerTest { ServiceReference> ref; ProtocolManagerFactory factory; - public RefFact(IMocksControl c, BundleContext context, String[] protocols) { + RefFact(IMocksControl c, BundleContext context, String[] protocols) { ref = c.createMock(ServiceReference.class); factory = c.createMock(ProtocolManagerFactory.class); expect(factory.getProtocols()).andReturn(protocols).atLeastOnce(); diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/config/HAPolicyConfiguration.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/config/HAPolicyConfiguration.java index c1510d1b54..3ffd56a37b 100644 --- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/config/HAPolicyConfiguration.java +++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/config/HAPolicyConfiguration.java @@ -20,7 +20,7 @@ import java.io.Serializable; public interface HAPolicyConfiguration extends Serializable { - public enum TYPE { + enum TYPE { LIVE_ONLY, REPLICATED, REPLICA, diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/config/StoreConfiguration.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/config/StoreConfiguration.java index d25cdd9be2..553ece58b1 100644 --- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/config/StoreConfiguration.java +++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/config/StoreConfiguration.java @@ -20,7 +20,7 @@ import java.io.Serializable; public interface StoreConfiguration extends Serializable { - public enum StoreType { + enum StoreType { FILE, DATABASE } diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/filter/impl/FilterImpl.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/filter/impl/FilterImpl.java index dd9f7dd10c..9cacff0f12 100644 --- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/filter/impl/FilterImpl.java +++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/filter/impl/FilterImpl.java @@ -172,7 +172,7 @@ public class FilterImpl implements Filter { private final ServerMessage message; - public FilterableServerMessage(ServerMessage message) { + private FilterableServerMessage(ServerMessage message) { this.message = message; } diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageCacheImpl.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageCacheImpl.java index 8d9b872a5b..8fd59d7c80 100644 --- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageCacheImpl.java +++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageCacheImpl.java @@ -37,7 +37,7 @@ class PageCacheImpl implements PageCache { // Constructors -------------------------------------------------- - public PageCacheImpl(final Page page) { + PageCacheImpl(final Page page) { this.page = page; } diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionCounterImpl.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionCounterImpl.java index a28288a5f4..54dc7e99a8 100644 --- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionCounterImpl.java +++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionCounterImpl.java @@ -351,7 +351,7 @@ public class PageSubscriptionCounterImpl implements PageSubscriptionCounter { private static class ItemOper { - public ItemOper(PageSubscriptionCounterImpl counter, long id, int add) { + private ItemOper(PageSubscriptionCounterImpl counter, long id, int add) { this.counter = counter; this.id = id; this.amount = add; diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionImpl.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionImpl.java index 9eac4ce5f4..c89161a36a 100644 --- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionImpl.java +++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionImpl.java @@ -942,7 +942,7 @@ final class PageSubscriptionImpl implements PageSubscription { } } - public PageCursorInfo(final long pageId, final int numberOfMessages, final PageCache cache) { + private PageCursorInfo(final long pageId, final int numberOfMessages, final PageCache cache) { logger.tracef("Created PageCursorInfo for pageNr=%d, numberOfMessages=%d, cache=%s", pageId, numberOfMessages, cache); this.pageId = pageId; this.numberOfMessages = numberOfMessages; @@ -1130,7 +1130,7 @@ final class PageSubscriptionImpl implements PageSubscription { */ private volatile PagedReference cachedNext; - public CursorIterator() { + private CursorIterator() { } @Override diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PageTransactionInfoImpl.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PageTransactionInfoImpl.java index 150285597c..1dde3092ca 100644 --- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PageTransactionInfoImpl.java +++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PageTransactionInfoImpl.java @@ -303,7 +303,7 @@ public final class PageTransactionInfoImpl implements PageTransactionInfo { final PagePosition pagePosition; final PageIterator iterator; - public LateDelivery(PageSubscription subscription, PagePosition pagePosition, PageIterator iterator) { + private LateDelivery(PageSubscription subscription, PagePosition pagePosition, PageIterator iterator) { this.subscription = subscription; this.pagePosition = pagePosition; this.iterator = iterator; @@ -332,7 +332,7 @@ public final class PageTransactionInfoImpl implements PageTransactionInfo { private final PagingManager pagingManager; - public UpdatePageTXOperation(final StorageManager storageManager, final PagingManager pagingManager) { + private UpdatePageTXOperation(final StorageManager storageManager, final PagingManager pagingManager) { this.storageManager = storageManager; this.pagingManager = pagingManager; } diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PagingStoreImpl.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PagingStoreImpl.java index 8fec06ce77..f57f1b84bb 100644 --- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PagingStoreImpl.java +++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PagingStoreImpl.java @@ -937,9 +937,9 @@ public class PagingStoreImpl implements PagingStore { this.usedStores.add(store); } - public FinishPageMessageOperation(final PageTransactionInfo pageTransaction, - final StorageManager storageManager, - final PagingManager pagingManager) { + private FinishPageMessageOperation(final PageTransactionInfo pageTransaction, + final StorageManager storageManager, + final PagingManager pagingManager) { this.pageTransaction = pageTransaction; this.storageManager = storageManager; this.pagingManager = pagingManager; diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/StorageManager.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/StorageManager.java index f92d0d85c7..d08b84d59e 100644 --- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/StorageManager.java +++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/StorageManager.java @@ -223,7 +223,7 @@ public interface StorageManager extends IDGenerator, ActiveMQComponent { DURABLE(".msg"), TEMPORARY(".tmp"), SYNC(".sync"); final String extension; - private LargeMessageExtension(String extension) { + LargeMessageExtension(String extension) { this.extension = extension; } diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/nullpm/NullStorageLargeServerMessage.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/nullpm/NullStorageLargeServerMessage.java index 365954ca44..5b325b6000 100644 --- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/nullpm/NullStorageLargeServerMessage.java +++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/nullpm/NullStorageLargeServerMessage.java @@ -24,11 +24,11 @@ import org.apache.activemq.artemis.core.server.impl.ServerMessageImpl; class NullStorageLargeServerMessage extends ServerMessageImpl implements LargeServerMessage { - public NullStorageLargeServerMessage() { + NullStorageLargeServerMessage() { super(); } - public NullStorageLargeServerMessage(NullStorageLargeServerMessage other) { + NullStorageLargeServerMessage(NullStorageLargeServerMessage other) { super(other); } diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/ProtocolHandler.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/ProtocolHandler.java index fed7a7542c..f4fef21376 100644 --- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/ProtocolHandler.java +++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/ProtocolHandler.java @@ -94,7 +94,7 @@ public class ProtocolHandler { private final boolean httpEnabled; - public ProtocolDecoder(boolean http, boolean httpEnabled) { + ProtocolDecoder(boolean http, boolean httpEnabled) { this.http = http; this.httpEnabled = httpEnabled; } diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/CoreProtocolManager.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/CoreProtocolManager.java index 32edb93860..410b0c09e3 100644 --- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/CoreProtocolManager.java +++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/CoreProtocolManager.java @@ -204,11 +204,11 @@ public class CoreProtocolManager implements ProtocolManager { private final Acceptor acceptorUsed; private final CoreRemotingConnection rc; - public LocalChannelHandler(final Configuration config, - final ConnectionEntry entry, - final Channel channel0, - final Acceptor acceptorUsed, - final CoreRemotingConnection rc) { + private LocalChannelHandler(final Configuration config, + final ConnectionEntry entry, + final Channel channel0, + final Acceptor acceptorUsed, + final CoreRemotingConnection rc) { this.config = config; this.entry = entry; this.channel0 = channel0; diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/BackupReplicationStartFailedMessage.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/BackupReplicationStartFailedMessage.java index 91830f8197..0564220d51 100644 --- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/BackupReplicationStartFailedMessage.java +++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/BackupReplicationStartFailedMessage.java @@ -36,7 +36,7 @@ public final class BackupReplicationStartFailedMessage extends PacketImpl { final int code; - private BackupRegistrationProblem(int code) { + BackupRegistrationProblem(int code) { this.code = code; } diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/ReplicationLiveIsStoppingMessage.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/ReplicationLiveIsStoppingMessage.java index 28e03cf663..339cfa82da 100644 --- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/ReplicationLiveIsStoppingMessage.java +++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/ReplicationLiveIsStoppingMessage.java @@ -39,7 +39,7 @@ public final class ReplicationLiveIsStoppingMessage extends PacketImpl { FAIL_OVER(1); private final int code; - private LiveStopping(int code) { + LiveStopping(int code) { this.code = code; } } diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/ReplicationStartSyncMessage.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/ReplicationStartSyncMessage.java index d31db8b1c2..157e02ba1b 100644 --- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/ReplicationStartSyncMessage.java +++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/ReplicationStartSyncMessage.java @@ -46,7 +46,7 @@ public class ReplicationStartSyncMessage extends PacketImpl { private byte code; - private SyncDataType(byte code) { + SyncDataType(byte code) { this.code = code; } diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/ReplicationSyncFileMessage.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/ReplicationSyncFileMessage.java index ed5901f964..69997418fc 100644 --- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/ReplicationSyncFileMessage.java +++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/ReplicationSyncFileMessage.java @@ -53,7 +53,7 @@ public final class ReplicationSyncFileMessage extends PacketImpl { private byte code; private static final Set ALL_OF = EnumSet.allOf(FileType.class); - private FileType(int code) { + FileType(int code) { this.code = (byte) code; } diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/HttpAcceptorHandler.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/HttpAcceptorHandler.java index 7be3bacbcc..f92a303064 100644 --- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/HttpAcceptorHandler.java +++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/HttpAcceptorHandler.java @@ -123,13 +123,13 @@ public class HttpAcceptorHandler extends ChannelDuplexHandler { private final ChannelPromise promise; - public ResponseRunner(final ByteBuf buffer, ChannelPromise promise) { + ResponseRunner(final ByteBuf buffer, ChannelPromise promise) { this.buffer = buffer; bogusResponse = false; this.promise = promise; } - public ResponseRunner() { + ResponseRunner() { bogusResponse = true; buffer = Unpooled.buffer(0); promise = channel.newPromise(); @@ -211,7 +211,7 @@ public class HttpAcceptorHandler extends ChannelDuplexHandler { final long timeReceived; - public ResponseHolder(final long timeReceived, final FullHttpResponse response) { + private ResponseHolder(final long timeReceived, final FullHttpResponse response) { this.timeReceived = timeReceived; this.response = response; } diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/BackupManager.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/BackupManager.java index d8e077c8d0..105bea365a 100644 --- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/BackupManager.java +++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/BackupManager.java @@ -186,10 +186,10 @@ public class BackupManager implements ActiveMQComponent { private boolean announcingBackup; private boolean backupAnnounced = false; - public BackupConnector(String name, - TransportConfiguration connector, - long retryInterval, - ClusterManager clusterManager) { + private BackupConnector(String name, + TransportConfiguration connector, + long retryInterval, + ClusterManager clusterManager) { this.name = name; this.connector = connector; this.retryInterval = retryInterval; @@ -328,11 +328,11 @@ public class BackupManager implements ActiveMQComponent { private final TransportConfiguration[] tcConfigs; - public StaticBackupConnector(TransportConfiguration[] tcConfigs, - String name, - TransportConfiguration connector, - long retryInterval, - ClusterManager clusterManager) { + private StaticBackupConnector(TransportConfiguration[] tcConfigs, + String name, + TransportConfiguration connector, + long retryInterval, + ClusterManager clusterManager) { super(name, connector, retryInterval, clusterManager); this.tcConfigs = tcConfigs; } @@ -365,11 +365,11 @@ public class BackupManager implements ActiveMQComponent { private final DiscoveryGroupConfiguration discoveryGroupConfiguration; - public DiscoveryBackupConnector(DiscoveryGroupConfiguration discoveryGroupConfiguration, - String name, - TransportConfiguration connector, - long retryInterval, - ClusterManager clusterManager) { + private DiscoveryBackupConnector(DiscoveryGroupConfiguration discoveryGroupConfiguration, + String name, + TransportConfiguration connector, + long retryInterval, + ClusterManager clusterManager) { super(name, connector, retryInterval, clusterManager); this.discoveryGroupConfiguration = discoveryGroupConfiguration; } diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/ClusterController.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/ClusterController.java index f8579be1cb..bdb17d64a2 100644 --- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/ClusterController.java +++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/ClusterController.java @@ -306,10 +306,10 @@ public class ClusterController implements ActiveMQComponent { private final ChannelHandler channelHandler; boolean authorized = false; - public ClusterControllerChannelHandler(Channel clusterChannel, - Acceptor acceptorUsed, - CoreRemotingConnection remotingConnection, - ChannelHandler channelHandler) { + private ClusterControllerChannelHandler(Channel clusterChannel, + Acceptor acceptorUsed, + CoreRemotingConnection remotingConnection, + ChannelHandler channelHandler) { this.clusterChannel = clusterChannel; this.acceptorUsed = acceptorUsed; this.remotingConnection = remotingConnection; @@ -396,7 +396,7 @@ public class ClusterController implements ActiveMQComponent { private ServerLocatorInternal serverLocator; - public ConnectRunnable(ServerLocatorInternal serverLocator) { + private ConnectRunnable(ServerLocatorInternal serverLocator) { this.serverLocator = serverLocator; } diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/BridgeImpl.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/BridgeImpl.java index 44e608c39b..a978be88f2 100644 --- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/BridgeImpl.java +++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/BridgeImpl.java @@ -1055,7 +1055,7 @@ public class BridgeImpl implements Bridge, SessionFailureListener, SendAcknowled private final Executor executor; - public FutureConnectRunnable(Executor exe, BridgeImpl bridge) { + private FutureConnectRunnable(Executor exe, BridgeImpl bridge) { executor = exe; this.bridge = bridge; } @@ -1071,7 +1071,7 @@ public class BridgeImpl implements Bridge, SessionFailureListener, SendAcknowled private final BridgeImpl bridge; - public ConnectRunnable(BridgeImpl bridge2) { + private ConnectRunnable(BridgeImpl bridge2) { bridge = bridge2; } diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/ClusterConnectionImpl.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/ClusterConnectionImpl.java index 2b09c4c1bf..82b1e4fe79 100644 --- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/ClusterConnectionImpl.java +++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/ClusterConnectionImpl.java @@ -835,12 +835,12 @@ public final class ClusterConnectionImpl implements ClusterConnection, AfterConn private volatile boolean reset = false; - public MessageFlowRecordImpl(final ServerLocatorInternal targetLocator, - final long eventUID, - final String targetNodeID, - final TransportConfiguration connector, - final SimpleString queueName, - final Queue queue) { + private MessageFlowRecordImpl(final ServerLocatorInternal targetLocator, + final long eventUID, + final String targetNodeID, + final TransportConfiguration connector, + final SimpleString queueName, + final Queue queue) { this.targetLocator = targetLocator; this.queue = queue; this.targetNodeID = targetNodeID; @@ -1418,7 +1418,7 @@ public final class ClusterConnectionImpl implements ClusterConnection, AfterConn private final TransportConfiguration[] tcConfigs; - public StaticClusterConnector(TransportConfiguration[] tcConfigs) { + private StaticClusterConnector(TransportConfiguration[] tcConfigs) { this.tcConfigs = tcConfigs; } @@ -1446,7 +1446,7 @@ public final class ClusterConnectionImpl implements ClusterConnection, AfterConn private final DiscoveryGroupConfiguration dg; - public DiscoveryClusterConnector(DiscoveryGroupConfiguration dg) { + private DiscoveryClusterConnector(DiscoveryGroupConfiguration dg) { this.dg = dg; } diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/qourum/QuorumManager.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/qourum/QuorumManager.java index d510b41e0a..76a5d5e605 100644 --- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/qourum/QuorumManager.java +++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/qourum/QuorumManager.java @@ -257,7 +257,7 @@ public final class QuorumManager implements ClusterTopologyListener, ActiveMQCom private final List runnables; private int size; - public VoteRunnableHolder(QuorumVote quorumVote, List runnables, int size) { + private VoteRunnableHolder(QuorumVote quorumVote, List runnables, int size) { this.quorumVote = quorumVote; this.runnables = runnables; @@ -282,7 +282,7 @@ public final class QuorumManager implements ClusterTopologyListener, ActiveMQCom private final QuorumVote quorumVote; private ClusterControl clusterControl; - public VoteRunnable(TransportConfiguration serverTC, QuorumVote quorumVote) { + private VoteRunnable(TransportConfiguration serverTC, QuorumVote quorumVote) { this.serverTC = serverTC; this.quorumVote = quorumVote; } diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/BackupTopologyListener.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/BackupTopologyListener.java index f00bf4b602..9b70f27e7e 100644 --- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/BackupTopologyListener.java +++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/BackupTopologyListener.java @@ -32,7 +32,7 @@ final class BackupTopologyListener implements ClusterTopologyListener { // Transport configuration of this node private final TransportConfiguration myTc; - public BackupTopologyListener(String ownId, TransportConfiguration nodeTransportConfig) { + BackupTopologyListener(String ownId, TransportConfiguration nodeTransportConfig) { this.ownId = ownId; this.myTc = nodeTransportConfig; } diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ColocatedActivation.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ColocatedActivation.java index 4428136d6d..b81abb7272 100644 --- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ColocatedActivation.java +++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ColocatedActivation.java @@ -169,7 +169,7 @@ public class ColocatedActivation extends LiveActivation { //the available nodes that we can request private final List> nodes = new ArrayList<>(); - public RequestBackupQuorumVote() { + private RequestBackupQuorumVote() { super(REQUEST_BACKUP_QUORUM_VOTE); } @@ -249,11 +249,11 @@ public class ColocatedActivation extends LiveActivation { private String nodeID; private boolean backupAvailable; - public RequestBackupVote() { + RequestBackupVote() { backupsSize = -1; } - public RequestBackupVote(int backupsSize, String nodeID, boolean backupAvailable) { + RequestBackupVote(int backupsSize, String nodeID, boolean backupAvailable) { this.backupsSize = backupsSize; this.nodeID = nodeID; this.backupAvailable = backupAvailable; diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java index 00b7a3c1e4..eaf7656f9f 100644 --- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java +++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java @@ -2708,7 +2708,7 @@ public class QueueImpl implements Queue { final boolean scheduleExpiry; - public DepageRunner(boolean scheduleExpiry) { + private DepageRunner(boolean scheduleExpiry) { this.scheduleExpiry = scheduleExpiry; } @@ -2785,7 +2785,7 @@ public class QueueImpl implements Queue { Iterator lastIterator = null; - public TotalQueueIterator() { + private TotalQueueIterator() { if (pageSubscription != null) { pageIter = pageSubscription.iterator(); } @@ -2911,7 +2911,7 @@ public class QueueImpl implements Queue { private float threshold; private long checkPeriod; - public SlowConsumerReaperRunnable(long checkPeriod, float threshold, SlowConsumerPolicy policy) { + private SlowConsumerReaperRunnable(long checkPeriod, float threshold, SlowConsumerPolicy policy) { this.checkPeriod = checkPeriod; this.policy = policy; this.threshold = threshold; diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ReplicationError.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ReplicationError.java index 63af112bbf..55c5adadaa 100644 --- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ReplicationError.java +++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ReplicationError.java @@ -39,7 +39,7 @@ final class ReplicationError implements Interceptor { private final ActiveMQServer server; private LiveNodeLocator nodeLocator; - public ReplicationError(ActiveMQServer server, LiveNodeLocator nodeLocator) { + ReplicationError(ActiveMQServer server, LiveNodeLocator nodeLocator) { this.server = server; this.nodeLocator = nodeLocator; } diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ScheduledDeliveryHandlerImpl.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ScheduledDeliveryHandlerImpl.java index 25f4aa0ac0..b70c1b13ec 100644 --- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ScheduledDeliveryHandlerImpl.java +++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ScheduledDeliveryHandlerImpl.java @@ -165,7 +165,7 @@ public class ScheduledDeliveryHandlerImpl implements ScheduledDeliveryHandler { long deliveryTime; - public ScheduledDeliveryRunnable(final long deliveryTime) { + private ScheduledDeliveryRunnable(final long deliveryTime) { this.deliveryTime = deliveryTime; } diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerConsumerImpl.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerConsumerImpl.java index ae1f5b109e..7de9fc5021 100644 --- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerConsumerImpl.java +++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerConsumerImpl.java @@ -1094,7 +1094,7 @@ public class ServerConsumerImpl implements ServerConsumer, ReadyListener { private BodyEncoder context; - public LargeMessageDeliverer(final LargeServerMessage message, final MessageReference ref) throws Exception { + private LargeMessageDeliverer(final LargeServerMessage message, final MessageReference ref) throws Exception { largeMessage = message; largeMessage.incrementDelayDeletionCount(); diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/SharedNothingLiveActivation.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/SharedNothingLiveActivation.java index fcc67926cf..3e0d81208e 100644 --- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/SharedNothingLiveActivation.java +++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/SharedNothingLiveActivation.java @@ -363,7 +363,7 @@ public class SharedNothingLiveActivation extends LiveActivation { private final SimpleString nodeId; private final CountDownLatch latch = new CountDownLatch(1); - public NodeIdListener(SimpleString nodeId) { + NodeIdListener(SimpleString nodeId) { this.nodeId = nodeId; } diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/transaction/Transaction.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/transaction/Transaction.java index 33c1eea443..65b7339540 100644 --- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/transaction/Transaction.java +++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/transaction/Transaction.java @@ -29,7 +29,7 @@ import org.apache.activemq.artemis.core.server.impl.RefsOperation; */ public interface Transaction { - static enum State { + enum State { ACTIVE, PREPARED, COMMITTED, ROLLEDBACK, SUSPENDED, ROLLBACK_ONLY } diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/transaction/impl/ResourceManagerImpl.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/transaction/impl/ResourceManagerImpl.java index 51f8c492cc..ff415159d5 100644 --- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/transaction/impl/ResourceManagerImpl.java +++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/transaction/impl/ResourceManagerImpl.java @@ -242,7 +242,7 @@ public class ResourceManagerImpl implements ResourceManager { public final long recordID; - public HeuristicCompletionHolder(final long recordID, final Xid xid, final boolean isCommit) { + private HeuristicCompletionHolder(final long recordID, final Xid xid, final boolean isCommit) { this.recordID = recordID; this.xid = xid; this.isCommit = isCommit; diff --git a/artemis-server/src/test/java/org/apache/activemq/artemis/core/security/jaas/PropertiesLoginModuleTest.java b/artemis-server/src/test/java/org/apache/activemq/artemis/core/security/jaas/PropertiesLoginModuleTest.java index 8d5347258e..777ba504ff 100644 --- a/artemis-server/src/test/java/org/apache/activemq/artemis/core/security/jaas/PropertiesLoginModuleTest.java +++ b/artemis-server/src/test/java/org/apache/activemq/artemis/core/security/jaas/PropertiesLoginModuleTest.java @@ -141,7 +141,7 @@ public class PropertiesLoginModuleTest extends Assert { private final String user; private final String pass; - public UserPassHandler(final String user, final String pass) { + private UserPassHandler(final String user, final String pass) { this.user = user; this.pass = pass; } diff --git a/artemis-server/src/test/java/org/apache/activemq/artemis/core/server/cluster/impl/BroadcastGroupImplTest.java b/artemis-server/src/test/java/org/apache/activemq/artemis/core/server/cluster/impl/BroadcastGroupImplTest.java index b7ed6434bd..222a11b9c6 100644 --- a/artemis-server/src/test/java/org/apache/activemq/artemis/core/server/cluster/impl/BroadcastGroupImplTest.java +++ b/artemis-server/src/test/java/org/apache/activemq/artemis/core/server/cluster/impl/BroadcastGroupImplTest.java @@ -42,7 +42,7 @@ public class BroadcastGroupImplTest extends ActiveMQTestBase { static class BroadcastEndpointImpl implements BroadcastEndpoint { private BroadcastEndpointFactoryImpl factory; - public BroadcastEndpointImpl(BroadcastEndpointFactoryImpl factory) { + BroadcastEndpointImpl(BroadcastEndpointFactoryImpl factory) { this.factory = factory; } diff --git a/artemis-server/src/test/java/org/apache/activemq/artemis/core/server/impl/ScheduledDeliveryHandlerTest.java b/artemis-server/src/test/java/org/apache/activemq/artemis/core/server/impl/ScheduledDeliveryHandlerTest.java index 71e04f9333..c489e12592 100644 --- a/artemis-server/src/test/java/org/apache/activemq/artemis/core/server/impl/ScheduledDeliveryHandlerTest.java +++ b/artemis-server/src/test/java/org/apache/activemq/artemis/core/server/impl/ScheduledDeliveryHandlerTest.java @@ -288,7 +288,7 @@ public class ScheduledDeliveryHandlerTest extends Assert { final long id; - public FakeMessage(final long id) { + FakeMessage(final long id) { this.id = id; } diff --git a/artemis-server/src/test/java/org/apache/activemq/artemis/core/settings/RepositoryTest.java b/artemis-server/src/test/java/org/apache/activemq/artemis/core/settings/RepositoryTest.java index 06acedec5a..b7563e1738 100644 --- a/artemis-server/src/test/java/org/apache/activemq/artemis/core/settings/RepositoryTest.java +++ b/artemis-server/src/test/java/org/apache/activemq/artemis/core/settings/RepositoryTest.java @@ -247,7 +247,7 @@ public class RepositoryTest extends ActiveMQTestBase { return DummyMergeable.merged.contains(i); } - public DummyMergeable(final Integer id) { + DummyMergeable(final Integer id) { this.id = id; } diff --git a/artemis-server/src/test/java/org/apache/activemq/artemis/tests/util/ActiveMQTestBase.java b/artemis-server/src/test/java/org/apache/activemq/artemis/tests/util/ActiveMQTestBase.java index 3e4d4c0a2d..eee17194f9 100644 --- a/artemis-server/src/test/java/org/apache/activemq/artemis/tests/util/ActiveMQTestBase.java +++ b/artemis-server/src/test/java/org/apache/activemq/artemis/tests/util/ActiveMQTestBase.java @@ -1803,7 +1803,7 @@ public abstract class ActiveMQTestBase extends Assert { /** * @param recordsType */ - public RecordTypeCounter(HashMap recordsType) { + private RecordTypeCounter(HashMap recordsType) { this.recordsType = recordsType; } diff --git a/artemis-web/src/test/java/org/apache/activemq/cli/test/WebServerComponentTest.java b/artemis-web/src/test/java/org/apache/activemq/cli/test/WebServerComponentTest.java index f1d2abdfca..723e4fff78 100644 --- a/artemis-web/src/test/java/org/apache/activemq/cli/test/WebServerComponentTest.java +++ b/artemis-web/src/test/java/org/apache/activemq/cli/test/WebServerComponentTest.java @@ -99,7 +99,7 @@ public class WebServerComponentTest extends Assert { private CountDownLatch latch; private String body; - public ClientHandler(CountDownLatch latch) { + ClientHandler(CountDownLatch latch) { this.latch = latch; } diff --git a/examples/features/perf/perf/src/main/java/org/apache/activemq/artemis/jms/example/PerfBase.java b/examples/features/perf/perf/src/main/java/org/apache/activemq/artemis/jms/example/PerfBase.java index 2ef0282db6..0b3e741dcf 100644 --- a/examples/features/perf/perf/src/main/java/org/apache/activemq/artemis/jms/example/PerfBase.java +++ b/examples/features/perf/perf/src/main/java/org/apache/activemq/artemis/jms/example/PerfBase.java @@ -361,7 +361,7 @@ public abstract class PerfBase { private final AtomicLong count = new AtomicLong(0); - public PerfListener(final CountDownLatch countDownLatch, final PerfParams perfParams) { + private PerfListener(final CountDownLatch countDownLatch, final PerfParams perfParams) { this.countDownLatch = countDownLatch; this.perfParams = perfParams; warmingUp = perfParams.getNoOfWarmupMessages() > 0; diff --git a/examples/features/standard/message-group/src/main/java/org/apache/activemq/artemis/jms/example/MessageGroupExample.java b/examples/features/standard/message-group/src/main/java/org/apache/activemq/artemis/jms/example/MessageGroupExample.java index 4db76180d9..f8ee48ab42 100644 --- a/examples/features/standard/message-group/src/main/java/org/apache/activemq/artemis/jms/example/MessageGroupExample.java +++ b/examples/features/standard/message-group/src/main/java/org/apache/activemq/artemis/jms/example/MessageGroupExample.java @@ -104,7 +104,7 @@ class SimpleMessageListener implements MessageListener { private final String name; private final Map messageReceiverMap; - public SimpleMessageListener(final String listenerName, Map messageReceiverMap) { + SimpleMessageListener(final String listenerName, Map messageReceiverMap) { name = listenerName; this.messageReceiverMap = messageReceiverMap; } diff --git a/examples/features/standard/message-group2/src/main/java/org/apache/activemq/artemis/jms/example/MessageGroup2Example.java b/examples/features/standard/message-group2/src/main/java/org/apache/activemq/artemis/jms/example/MessageGroup2Example.java index 717c4541f6..4b24928578 100644 --- a/examples/features/standard/message-group2/src/main/java/org/apache/activemq/artemis/jms/example/MessageGroup2Example.java +++ b/examples/features/standard/message-group2/src/main/java/org/apache/activemq/artemis/jms/example/MessageGroup2Example.java @@ -111,7 +111,7 @@ class SimpleMessageListener implements MessageListener { private final String name; final Map messageReceiverMap; - public SimpleMessageListener(String listenerName, Map messageReceiverMap) { + SimpleMessageListener(String listenerName, Map messageReceiverMap) { name = listenerName; this.messageReceiverMap = messageReceiverMap; } diff --git a/examples/features/standard/message-priority/src/main/java/org/apache/activemq/artemis/jms/example/MessagePriorityExample.java b/examples/features/standard/message-priority/src/main/java/org/apache/activemq/artemis/jms/example/MessagePriorityExample.java index b8796156ca..1ef0f713e0 100644 --- a/examples/features/standard/message-priority/src/main/java/org/apache/activemq/artemis/jms/example/MessagePriorityExample.java +++ b/examples/features/standard/message-priority/src/main/java/org/apache/activemq/artemis/jms/example/MessagePriorityExample.java @@ -115,7 +115,7 @@ class SimpleMessageListener implements MessageListener { ArrayList msgReceived; AtomicBoolean result; - public SimpleMessageListener(ArrayList msgReceived, AtomicBoolean result) { + SimpleMessageListener(ArrayList msgReceived, AtomicBoolean result) { this.msgReceived = msgReceived; this.result = result; } diff --git a/examples/features/standard/queue-selector/src/main/java/org/apache/activemq/artemis/jms/example/QueueSelectorExample.java b/examples/features/standard/queue-selector/src/main/java/org/apache/activemq/artemis/jms/example/QueueSelectorExample.java index 3f8f9fde5e..b915dd0248 100644 --- a/examples/features/standard/queue-selector/src/main/java/org/apache/activemq/artemis/jms/example/QueueSelectorExample.java +++ b/examples/features/standard/queue-selector/src/main/java/org/apache/activemq/artemis/jms/example/QueueSelectorExample.java @@ -117,7 +117,7 @@ class SimpleMessageListener implements MessageListener { private final String name; private AtomicBoolean result; - public SimpleMessageListener(final String listener, AtomicBoolean result) { + SimpleMessageListener(final String listener, AtomicBoolean result) { name = listener; this.result = result; } diff --git a/examples/features/standard/static-selector/src/main/java/org/apache/activemq/artemis/jms/example/StaticSelectorExample.java b/examples/features/standard/static-selector/src/main/java/org/apache/activemq/artemis/jms/example/StaticSelectorExample.java index f3d82f55a3..627ef7da7e 100644 --- a/examples/features/standard/static-selector/src/main/java/org/apache/activemq/artemis/jms/example/StaticSelectorExample.java +++ b/examples/features/standard/static-selector/src/main/java/org/apache/activemq/artemis/jms/example/StaticSelectorExample.java @@ -111,7 +111,7 @@ class SimpleMessageListener implements MessageListener { private final String name; private AtomicBoolean result; - public SimpleMessageListener(final String listener, AtomicBoolean result) { + SimpleMessageListener(final String listener, AtomicBoolean result) { name = listener; this.result = result; } diff --git a/examples/features/standard/topic-selector-example2/src/main/java/org/apache/activemq/artemis/jms/example/TopicSelectorExample2.java b/examples/features/standard/topic-selector-example2/src/main/java/org/apache/activemq/artemis/jms/example/TopicSelectorExample2.java index 97ece3f5b1..037e5fb087 100644 --- a/examples/features/standard/topic-selector-example2/src/main/java/org/apache/activemq/artemis/jms/example/TopicSelectorExample2.java +++ b/examples/features/standard/topic-selector-example2/src/main/java/org/apache/activemq/artemis/jms/example/TopicSelectorExample2.java @@ -119,7 +119,7 @@ class SimpleMessageListener implements MessageListener { private final String name; AtomicBoolean result; - public SimpleMessageListener(final String listener, AtomicBoolean result) { + SimpleMessageListener(final String listener, AtomicBoolean result) { name = listener; this.result = result; } diff --git a/examples/features/standard/xa-send/src/main/java/org/apache/activemq/artemis/jms/example/XASendExample.java b/examples/features/standard/xa-send/src/main/java/org/apache/activemq/artemis/jms/example/XASendExample.java index 53fed86243..769727b490 100644 --- a/examples/features/standard/xa-send/src/main/java/org/apache/activemq/artemis/jms/example/XASendExample.java +++ b/examples/features/standard/xa-send/src/main/java/org/apache/activemq/artemis/jms/example/XASendExample.java @@ -173,7 +173,7 @@ class SimpleMessageListener implements MessageListener { ArrayList receiveHolder; AtomicBoolean result; - public SimpleMessageListener(ArrayList receiveHolder, AtomicBoolean result) { + SimpleMessageListener(ArrayList receiveHolder, AtomicBoolean result) { this.receiveHolder = receiveHolder; this.result = result; } diff --git a/integration/activemq-aerogear-integration/src/main/java/org/apache/activemq/artemis/integration/aerogear/AeroGearConnectorService.java b/integration/activemq-aerogear-integration/src/main/java/org/apache/activemq/artemis/integration/aerogear/AeroGearConnectorService.java index 0be4cd0f06..1fb3ca1c69 100644 --- a/integration/activemq-aerogear-integration/src/main/java/org/apache/activemq/artemis/integration/aerogear/AeroGearConnectorService.java +++ b/integration/activemq-aerogear-integration/src/main/java/org/apache/activemq/artemis/integration/aerogear/AeroGearConnectorService.java @@ -315,7 +315,7 @@ public class AeroGearConnectorService implements ConnectorService, Consumer, Mes private int retryAttempt; - public ReconnectRunnable(int retryAttempt) { + private ReconnectRunnable(int retryAttempt) { this.retryAttempt = retryAttempt; } diff --git a/tests/extra-tests/src/test/java/org/apache/activemq/artemis/tests/extras/byteman/HierarchicalObjectRepositoryTest.java b/tests/extra-tests/src/test/java/org/apache/activemq/artemis/tests/extras/byteman/HierarchicalObjectRepositoryTest.java index 50a626834d..d981aa9ba8 100644 --- a/tests/extra-tests/src/test/java/org/apache/activemq/artemis/tests/extras/byteman/HierarchicalObjectRepositoryTest.java +++ b/tests/extra-tests/src/test/java/org/apache/activemq/artemis/tests/extras/byteman/HierarchicalObjectRepositoryTest.java @@ -73,7 +73,7 @@ public class HierarchicalObjectRepositoryTest { private final int code; - public Clearer(int code) { + private Clearer(int code) { this.code = code; } diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/aerogear/AeroGearBasicServerTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/aerogear/AeroGearBasicServerTest.java index 6882ca0a0d..ded85ec52c 100644 --- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/aerogear/AeroGearBasicServerTest.java +++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/aerogear/AeroGearBasicServerTest.java @@ -203,7 +203,7 @@ public class AeroGearBasicServerTest extends ActiveMQTestBase { JSONObject jsonObject; private CountDownLatch latch; - public AeroGearHandler(CountDownLatch latch) { + AeroGearHandler(CountDownLatch latch) { this.latch = latch; } diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/AutogroupIdTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/AutogroupIdTest.java index 97e0a8739a..487edfb18c 100644 --- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/AutogroupIdTest.java +++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/AutogroupIdTest.java @@ -203,7 +203,7 @@ public class AutogroupIdTest extends ActiveMQTestBase { private final CountDownLatch latch; - public MyMessageHandler(final CountDownLatch latch) { + private MyMessageHandler(final CountDownLatch latch) { this.latch = latch; } diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/CommitRollbackTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/CommitRollbackTest.java index def7fec7a0..ec9c041c24 100644 --- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/CommitRollbackTest.java +++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/CommitRollbackTest.java @@ -242,7 +242,7 @@ public class CommitRollbackTest extends ActiveMQTestBase { private final CountDownLatch latch; - public ackHandler(final ClientSession session, final CountDownLatch latch) { + private ackHandler(final ClientSession session, final CountDownLatch latch) { this.session = session; this.latch = latch; } diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/DeadLetterAddressTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/DeadLetterAddressTest.java index 95289ec3e4..8ce7a3ea9e 100644 --- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/DeadLetterAddressTest.java +++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/DeadLetterAddressTest.java @@ -175,7 +175,7 @@ public class DeadLetterAddressTest extends ActiveMQTestBase { private final ClientSession clientSession; - public TestHandler(CountDownLatch latch, ClientSession clientSession) { + TestHandler(CountDownLatch latch, ClientSession clientSession) { this.latch = latch; this.clientSession = clientSession; } diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/DeliveryOrderTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/DeliveryOrderTest.java index 9fb960b9b2..8b04ba418f 100644 --- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/DeliveryOrderTest.java +++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/DeliveryOrderTest.java @@ -154,7 +154,7 @@ public class DeliveryOrderTest extends ActiveMQTestBase { boolean failed = false; - public Receiver(final CountDownLatch latch) { + Receiver(final CountDownLatch latch) { this.latch = latch; } diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/HangConsumerTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/HangConsumerTest.java index 2c888964b7..2be294744a 100644 --- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/HangConsumerTest.java +++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/HangConsumerTest.java @@ -215,20 +215,20 @@ public class HangConsumerTest extends ActiveMQTestBase { * @param addressSettingsRepository * @param executor */ - public MyQueueWithBlocking(final long id, - final SimpleString address, - final SimpleString name, - final Filter filter, - final SimpleString user, - final PageSubscription pageSubscription, - final boolean durable, - final boolean temporary, - final boolean autoCreated, - final ScheduledExecutorService scheduledExecutor, - final PostOffice postOffice, - final StorageManager storageManager, - final HierarchicalRepository addressSettingsRepository, - final Executor executor) { + MyQueueWithBlocking(final long id, + final SimpleString address, + final SimpleString name, + final Filter filter, + final SimpleString user, + final PageSubscription pageSubscription, + final boolean durable, + final boolean temporary, + final boolean autoCreated, + final ScheduledExecutorService scheduledExecutor, + final PostOffice postOffice, + final StorageManager storageManager, + final HierarchicalRepository addressSettingsRepository, + final Executor executor) { super(id, address, name, filter, pageSubscription, user, durable, temporary, autoCreated, scheduledExecutor, postOffice, storageManager, addressSettingsRepository, executor); } @@ -247,10 +247,10 @@ public class HangConsumerTest extends ActiveMQTestBase { class LocalFactory extends QueueFactoryImpl { - public LocalFactory(final ExecutorFactory executorFactory, - final ScheduledExecutorService scheduledExecutor, - final HierarchicalRepository addressSettingsRepository, - final StorageManager storageManager) { + LocalFactory(final ExecutorFactory executorFactory, + final ScheduledExecutorService scheduledExecutor, + final HierarchicalRepository addressSettingsRepository, + final StorageManager storageManager) { super(executorFactory, scheduledExecutor, addressSettingsRepository, storageManager); } @@ -567,9 +567,9 @@ public class HangConsumerTest extends ActiveMQTestBase { class MyActiveMQServer extends ActiveMQServerImpl { - public MyActiveMQServer(Configuration configuration, - MBeanServer mbeanServer, - ActiveMQSecurityManager securityManager) { + MyActiveMQServer(Configuration configuration, + MBeanServer mbeanServer, + ActiveMQSecurityManager securityManager) { super(configuration, mbeanServer, securityManager); } diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/InterruptedLargeMessageTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/InterruptedLargeMessageTest.java index 62e24fafd9..a4be3ad871 100644 --- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/InterruptedLargeMessageTest.java +++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/InterruptedLargeMessageTest.java @@ -513,20 +513,20 @@ public class InterruptedLargeMessageTest extends LargeMessageTestBase { class NoPostACKQueue extends QueueImpl { - public NoPostACKQueue(long id, - SimpleString address, - SimpleString name, - Filter filter, - SimpleString user, - PageSubscription pageSubscription, - boolean durable, - boolean temporary, - boolean autoCreated, - ScheduledExecutorService scheduledExecutor, - PostOffice postOffice, - StorageManager storageManager, - HierarchicalRepository addressSettingsRepository, - Executor executor) { + NoPostACKQueue(long id, + SimpleString address, + SimpleString name, + Filter filter, + SimpleString user, + PageSubscription pageSubscription, + boolean durable, + boolean temporary, + boolean autoCreated, + ScheduledExecutorService scheduledExecutor, + PostOffice postOffice, + StorageManager storageManager, + HierarchicalRepository addressSettingsRepository, + Executor executor) { super(id, address, name, filter, pageSubscription, user, durable, temporary, autoCreated, scheduledExecutor, postOffice, storageManager, addressSettingsRepository, executor); } @@ -552,11 +552,11 @@ public class InterruptedLargeMessageTest extends LargeMessageTestBase { final ExecutorFactory execFactory; - public NoPostACKQueueFactory(StorageManager storageManager, - PostOffice postOffice, - ScheduledExecutorService scheduledExecutor, - HierarchicalRepository addressSettingsRepository, - final ExecutorFactory execFactory) { + NoPostACKQueueFactory(StorageManager storageManager, + PostOffice postOffice, + ScheduledExecutorService scheduledExecutor, + HierarchicalRepository addressSettingsRepository, + final ExecutorFactory execFactory) { this.storageManager = storageManager; this.postOffice = postOffice; this.scheduledExecutor = scheduledExecutor; diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/MessageConsumerRollbackTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/MessageConsumerRollbackTest.java index de9a4ccbb8..b4a3843b89 100644 --- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/MessageConsumerRollbackTest.java +++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/MessageConsumerRollbackTest.java @@ -173,7 +173,7 @@ public class MessageConsumerRollbackTest extends ActiveMQTestBase { CountDownLatch commitLatch; - public LocalConsumer(AtomicInteger counter, CountDownLatch commitLatch) { + private LocalConsumer(AtomicInteger counter, CountDownLatch commitLatch) { this.counter = counter; this.commitLatch = commitLatch; } diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/MessageGroupingConnectionFactoryTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/MessageGroupingConnectionFactoryTest.java index f38ea3189d..282014f2f0 100644 --- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/MessageGroupingConnectionFactoryTest.java +++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/MessageGroupingConnectionFactoryTest.java @@ -124,7 +124,7 @@ public class MessageGroupingConnectionFactoryTest extends ActiveMQTestBase { private final boolean acknowledge; - public DummyMessageHandler(final CountDownLatch latch, final boolean acknowledge) { + private DummyMessageHandler(final CountDownLatch latch, final boolean acknowledge) { this.latch = latch; this.acknowledge = acknowledge; } diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/MessageGroupingTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/MessageGroupingTest.java index 3da716df81..03fcd03daf 100644 --- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/MessageGroupingTest.java +++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/MessageGroupingTest.java @@ -555,7 +555,7 @@ public class MessageGroupingTest extends ActiveMQTestBase { private final boolean acknowledge; - public DummyMessageHandler(final CountDownLatch latch, final boolean acknowledge) { + private DummyMessageHandler(final CountDownLatch latch, final boolean acknowledge) { this.latch = latch; this.acknowledge = acknowledge; } diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/MessageHandlerTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/MessageHandlerTest.java index f73403a4db..cdc0c44397 100644 --- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/MessageHandlerTest.java +++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/MessageHandlerTest.java @@ -153,7 +153,7 @@ public class MessageHandlerTest extends ActiveMQTestBase { private final CountDownLatch latch; - public MyHandler(final CountDownLatch latch) { + MyHandler(final CountDownLatch latch) { this.latch = latch; } @@ -246,7 +246,7 @@ public class MessageHandlerTest extends ActiveMQTestBase { private final CountDownLatch latch; - public MyHandler(final CountDownLatch latch) { + MyHandler(final CountDownLatch latch) { this.latch = latch; } @@ -326,7 +326,7 @@ public class MessageHandlerTest extends ActiveMQTestBase { private final CountDownLatch latch; - public MyHandler(final CountDownLatch latch) { + MyHandler(final CountDownLatch latch) { this.latch = latch; } diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/MultipleThreadFilterOneTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/MultipleThreadFilterOneTest.java index e8015be34a..b342dea76b 100644 --- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/MultipleThreadFilterOneTest.java +++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/MultipleThreadFilterOneTest.java @@ -72,7 +72,7 @@ public class MultipleThreadFilterOneTest extends ActiveMQTestBase { public final AtomicInteger errors = new AtomicInteger(0); - public SomeProducer() throws Exception { + SomeProducer() throws Exception { locator = createNonHALocator(isNetty); factory = locator.createSessionFactory(); prodSession = factory.createSession(false, false); @@ -135,7 +135,7 @@ public class MultipleThreadFilterOneTest extends ActiveMQTestBase { final AtomicInteger errors = new AtomicInteger(0); - public SomeConsumer(int nr) throws Exception { + SomeConsumer(int nr) throws Exception { locator = createNonHALocator(isNetty); factory = locator.createSessionFactory(); consumerSession = factory.createSession(false, false); diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/PagingTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/PagingTest.java index 41467b5352..91f5b2fb1d 100644 --- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/PagingTest.java +++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/PagingTest.java @@ -3022,10 +3022,10 @@ public class PagingTest extends ActiveMQTestBase { class InterruptedCursorProvider extends PageCursorProviderImpl { - public InterruptedCursorProvider(PagingStore pagingStore, - StorageManager storageManager, - Executor executor, - int maxCacheSize) { + InterruptedCursorProvider(PagingStore pagingStore, + StorageManager storageManager, + Executor executor, + int maxCacheSize) { super(pagingStore, storageManager, executor, maxCacheSize); } @@ -5681,7 +5681,7 @@ public class PagingTest extends ActiveMQTestBase { private final CountDownLatch pageUp; private final CountDownLatch pageDone; - public DummyOperationContext(CountDownLatch pageUp, CountDownLatch pageDone) { + private DummyOperationContext(CountDownLatch pageUp, CountDownLatch pageDone) { this.pageDone = pageDone; this.pageUp = pageUp; } diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/ServerLocatorConnectTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/ServerLocatorConnectTest.java index ea91ccd00d..257592e6cd 100644 --- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/ServerLocatorConnectTest.java +++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/ServerLocatorConnectTest.java @@ -156,7 +156,7 @@ public class ServerLocatorConnectTest extends ActiveMQTestBase { CountDownLatch latch; Exception e; - public Connector(ServerLocatorInternal locator, CountDownLatch latch) { + Connector(ServerLocatorInternal locator, CountDownLatch latch) { this.locator = locator; this.latch = latch; } diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/SessionStopStartTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/SessionStopStartTest.java index 3d8eff66e6..5b1de42ab2 100644 --- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/SessionStopStartTest.java +++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/SessionStopStartTest.java @@ -352,11 +352,11 @@ public class SessionStopStartTest extends ActiveMQTestBase { private boolean stop = true; - public MyHandler(final CountDownLatch latch) { + MyHandler(final CountDownLatch latch) { this.latch = latch; } - public MyHandler(final CountDownLatch latch, final boolean stop) { + MyHandler(final CountDownLatch latch, final boolean stop) { this(latch); this.stop = stop; } @@ -447,11 +447,11 @@ public class SessionStopStartTest extends ActiveMQTestBase { private boolean stop = true; - public MyHandler(final CountDownLatch latch) { + MyHandler(final CountDownLatch latch) { this.latch = latch; } - public MyHandler(final CountDownLatch latch, final boolean stop) { + MyHandler(final CountDownLatch latch, final boolean stop) { this(latch); this.stop = stop; } diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/TemporaryQueueTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/TemporaryQueueTest.java index 26a50d679e..9503ddb724 100644 --- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/TemporaryQueueTest.java +++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/TemporaryQueueTest.java @@ -358,7 +358,7 @@ public class TemporaryQueueTest extends SingleServerTestBase { final ClientSession sess; - public MyHandler(ClientSession sess, String color, int expectedMessages) { + MyHandler(ClientSession sess, String color, int expectedMessages) { this.sess = sess; latch = new CountDownLatch(expectedMessages); this.color = color; diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/NodeManagerTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/NodeManagerTest.java index 901bfa30fd..4cba6bc6e4 100644 --- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/NodeManagerTest.java +++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/NodeManagerTest.java @@ -162,7 +162,7 @@ public class NodeManagerTest extends ActiveMQTestBase { private NodeManager manager; Throwable e; - public NodeRunner(NodeManager nodeManager, NodeManagerAction action) { + NodeRunner(NodeManager nodeManager, NodeManagerAction action) { this.manager = nodeManager; this.action = action; } diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/distribution/ClusteredGroupingTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/distribution/ClusteredGroupingTest.java index 6cacd3c39a..c15ded0b0d 100644 --- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/distribution/ClusteredGroupingTest.java +++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/distribution/ClusteredGroupingTest.java @@ -1650,12 +1650,12 @@ public class ClusteredGroupingTest extends ClusterTestBase { private final int node; - public ThreadSender(final int msgStart, - final int msgEnd, - final int node, - final SimpleString id, - final CountDownLatch latch, - final boolean wait) { + ThreadSender(final int msgStart, + final int msgEnd, + final int node, + final SimpleString id, + final CountDownLatch latch, + final boolean wait) { this.msgStart = msgStart; this.msgEnd = msgEnd; this.node = node; diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/failover/FailBackManualTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/failover/FailBackManualTest.java index 0a53f61033..1dc00e37af 100644 --- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/failover/FailBackManualTest.java +++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/failover/FailBackManualTest.java @@ -177,7 +177,7 @@ public class FailBackManualTest extends FailoverTestBase { private final TestableServer server; - public ServerStarter(TestableServer server) { + ServerStarter(TestableServer server) { this.server = server; } diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/failover/QuorumFailOverTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/failover/QuorumFailOverTest.java index 955e34c960..6043f888ca 100644 --- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/failover/QuorumFailOverTest.java +++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/failover/QuorumFailOverTest.java @@ -104,7 +104,7 @@ public class QuorumFailOverTest extends StaticClusterWithBackupFailoverTest { final String prefix; final Map> nodes = new ConcurrentHashMap<>(); - public TopologyListener(String string) { + private TopologyListener(String string) { prefix = string; } diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/reattach/MultiThreadReattachSupportTestBase.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/reattach/MultiThreadReattachSupportTestBase.java index e36475acff..1037e048ed 100644 --- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/reattach/MultiThreadReattachSupportTestBase.java +++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/reattach/MultiThreadReattachSupportTestBase.java @@ -201,7 +201,7 @@ public abstract class MultiThreadReattachSupportTestBase extends ActiveMQTestBas private final boolean failOnCreateConnection; - public Failer(final ClientSession session, final boolean failOnCreateConnection) { + private Failer(final ClientSession session, final boolean failOnCreateConnection) { this.session = session; this.failOnCreateConnection = failOnCreateConnection; diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/reattach/RandomReattachTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/reattach/RandomReattachTest.java index 8d1fe3248d..4c4873880c 100644 --- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/reattach/RandomReattachTest.java +++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/reattach/RandomReattachTest.java @@ -1268,7 +1268,7 @@ public class RandomReattachTest extends ActiveMQTestBase { private boolean executed; - public Failer(final ClientSessionInternal session) { + Failer(final ClientSessionInternal session) { this.session = session; } diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/client/NewQueueRequestorTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/client/NewQueueRequestorTest.java index 1fec02b06a..84a7940474 100644 --- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/client/NewQueueRequestorTest.java +++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/client/NewQueueRequestorTest.java @@ -85,7 +85,7 @@ public class NewQueueRequestorTest extends JMSTestBase { private final QueueSender sender; - public TestMessageListener(final QueueSession sess) throws JMSException { + TestMessageListener(final QueueSession sess) throws JMSException { this.sess = sess; sender = sess.createSender(null); } diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/connection/ExceptionListenerTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/connection/ExceptionListenerTest.java index 6e62231e1d..4d9b79f3b3 100644 --- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/connection/ExceptionListenerTest.java +++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/connection/ExceptionListenerTest.java @@ -75,7 +75,7 @@ public class ExceptionListenerTest extends ActiveMQTestBase { private final CountDownLatch latch; - public MyExceptionListener(final CountDownLatch latch) { + private MyExceptionListener(final CountDownLatch latch) { this.latch = latch; } diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/jms2client/JmsContextTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/jms2client/JmsContextTest.java index 58b284b8ee..e3d7b6d04e 100644 --- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/jms2client/JmsContextTest.java +++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/jms2client/JmsContextTest.java @@ -559,7 +559,7 @@ public class JmsContextTest extends JMSTestBase { private CountDownLatch latch; private BytesMessage message; - public SimpleCompletionListener(CountDownLatch latch) { + private SimpleCompletionListener(CountDownLatch latch) { this.latch = latch; } @@ -582,7 +582,7 @@ public class JmsContextTest extends JMSTestBase { private JMSContext context; private volatile Throwable error; - public InvalidMessageListener(JMSContext context, CountDownLatch latch, int id) { + private InvalidMessageListener(JMSContext context, CountDownLatch latch, int id) { this.id = id; this.latch = latch; this.context = context; @@ -633,7 +633,7 @@ public class JmsContextTest extends JMSTestBase { private CountDownLatch latch; private Exception ex; - public JMSCOntextStopCompletionListener(JMSContext context, CountDownLatch latch) { + private JMSCOntextStopCompletionListener(JMSContext context, CountDownLatch latch) { this.context = context; this.latch = latch; } diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/server/management/JMSServerControlTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/server/management/JMSServerControlTest.java index 1dd3c0a281..b42bba9c50 100644 --- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/server/management/JMSServerControlTest.java +++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/server/management/JMSServerControlTest.java @@ -1031,7 +1031,7 @@ public class JMSServerControlTest extends ManagementTestBase { JMSStorageManager delegate; - public FakeJMSStorageManager(JMSStorageManager delegate) { + FakeJMSStorageManager(JMSStorageManager delegate) { this.delegate = delegate; } diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/journal/ValidateTransactionHealthTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/journal/ValidateTransactionHealthTest.java index a88199a9b4..895a8f3d56 100644 --- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/journal/ValidateTransactionHealthTest.java +++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/journal/ValidateTransactionHealthTest.java @@ -178,7 +178,7 @@ public class ValidateTransactionHealthTest extends ActiveMQTestBase { long lastID = 0; - public Loader(final long expectedRecords) { + Loader(final long expectedRecords) { this.expectedRecords = expectedRecords; } @@ -346,10 +346,10 @@ public class ValidateTransactionHealthTest extends ActiveMQTestBase { Exception e; - public LocalThread(final JournalImpl journal, - final long numberOfElements, - final int transactionSize, - final AtomicLong nextID) { + LocalThread(final JournalImpl journal, + final long numberOfElements, + final int transactionSize, + final AtomicLong nextID) { super(); this.journal = journal; this.numberOfElements = numberOfElements; diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/ManagementWithPagingServerTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/ManagementWithPagingServerTest.java index 6bd8a53680..236403ba45 100644 --- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/ManagementWithPagingServerTest.java +++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/ManagementWithPagingServerTest.java @@ -214,7 +214,7 @@ public class ManagementWithPagingServerTest extends ManagementTestBase { private long delay; private volatile Exception error = null; - public SenderThread(SimpleString address, int num, long delay) { + private SenderThread(SimpleString address, int num, long delay) { this.address = address; this.num = num; this.delay = delay; @@ -263,7 +263,7 @@ public class ManagementWithPagingServerTest extends ManagementTestBase { private long delay; private volatile Exception error = null; - public ReceiverThread(SimpleString queue, int num, long delay) { + private ReceiverThread(SimpleString queue, int num, long delay) { this.queue = queue; this.num = num; this.delay = delay; @@ -303,7 +303,7 @@ public class ManagementWithPagingServerTest extends ManagementTestBase { private volatile boolean stop = false; private Exception error = null; - public ManagementThread(QueueControl queueControl) { + private ManagementThread(QueueControl queueControl) { this.queueControl = queueControl; } diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/amq/JMSConsumer2Test.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/amq/JMSConsumer2Test.java index 3f28aa74d1..5b0c038575 100644 --- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/amq/JMSConsumer2Test.java +++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/amq/JMSConsumer2Test.java @@ -69,7 +69,7 @@ public class JMSConsumer2Test extends BasicOpenWireTest { private final Message message; - public AckAndClose(Message m) { + AckAndClose(Message m) { this.message = m; } diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/amq/MessageListenerRedeliveryTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/amq/MessageListenerRedeliveryTest.java index 5606a6a36e..e5ada0229c 100644 --- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/amq/MessageListenerRedeliveryTest.java +++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/amq/MessageListenerRedeliveryTest.java @@ -92,7 +92,7 @@ public class MessageListenerRedeliveryTest extends BasicOpenWireTest { public int counter; private final Session session; - public TestMessageListener(Session session) { + private TestMessageListener(Session session) { this.session = session; } diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/paging/PagingWithFailoverAndCountersTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/paging/PagingWithFailoverAndCountersTest.java index de8dced37d..0f9f3d372b 100644 --- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/paging/PagingWithFailoverAndCountersTest.java +++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/paging/PagingWithFailoverAndCountersTest.java @@ -97,10 +97,10 @@ public class PagingWithFailoverAndCountersTest extends ActiveMQTestBase { class TestThread extends Thread { - public TestThread() { + TestThread() { } - public TestThread(String name) { + TestThread(String name) { super(name); } @@ -232,7 +232,7 @@ public class PagingWithFailoverAndCountersTest extends ActiveMQTestBase { class MonitorThread extends TestThread { - public MonitorThread() { + MonitorThread() { super("Monitor-thread"); } diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/ra/ActiveMQMessageHandlerTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/ra/ActiveMQMessageHandlerTest.java index d2d67e2309..0aab4c5968 100644 --- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/ra/ActiveMQMessageHandlerTest.java +++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/ra/ActiveMQMessageHandlerTest.java @@ -798,7 +798,7 @@ public class ActiveMQMessageHandlerTest extends ActiveMQRATestBase { boolean throwException = true; - public ExceptionDummyMessageEndpoint(CountDownLatch latch) { + ExceptionDummyMessageEndpoint(CountDownLatch latch) { super(latch); } @@ -820,7 +820,7 @@ public class ActiveMQMessageHandlerTest extends ActiveMQRATestBase { AtomicInteger messages = new AtomicInteger(0); AtomicInteger interrupted = new AtomicInteger(0); - public MultipleEndpoints(CountDownLatch latch, CountDownLatch latchDone, boolean pause) { + MultipleEndpoints(CountDownLatch latch, CountDownLatch latchDone, boolean pause) { super(latch); this.latch = latch; this.latchDone = latchDone; diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/ra/ActiveMQMessageHandlerXATest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/ra/ActiveMQMessageHandlerXATest.java index 11af3cd84f..4278ef8a75 100644 --- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/ra/ActiveMQMessageHandlerXATest.java +++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/ra/ActiveMQMessageHandlerXATest.java @@ -195,7 +195,7 @@ public class ActiveMQMessageHandlerXATest extends ActiveMQRATestBase { private Xid xid; - public XADummyEndpoint(CountDownLatch latch) { + XADummyEndpoint(CountDownLatch latch) { super(latch); xid = new XidImpl("xa1".getBytes(), 1, UUIDGenerator.getInstance().generateStringUUID().getBytes()); } @@ -242,7 +242,7 @@ public class ActiveMQMessageHandlerXATest extends ActiveMQRATestBase { boolean interrupted = false; - public PausingXADummyEndpoint(CountDownLatch latch, CountDownLatch beforeDeliveryLatch) { + PausingXADummyEndpoint(CountDownLatch latch, CountDownLatch beforeDeliveryLatch) { super(latch); this.beforeDeliveryLatch = beforeDeliveryLatch; } diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/server/ExpiryRunnerTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/server/ExpiryRunnerTest.java index 57773ed706..ccc0175054 100644 --- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/server/ExpiryRunnerTest.java +++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/server/ExpiryRunnerTest.java @@ -258,7 +258,7 @@ public class ExpiryRunnerTest extends ActiveMQTestBase { private final CountDownLatch latch; - public DummyMessageHandler(final ClientConsumer consumer, final CountDownLatch latch) { + private DummyMessageHandler(final ClientConsumer consumer, final CountDownLatch latch) { this.consumer = consumer; this.latch = latch; } diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/stomp/StompOverWebsocketTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/stomp/StompOverWebsocketTest.java index d665cc2539..39cd4f737b 100644 --- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/stomp/StompOverWebsocketTest.java +++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/stomp/StompOverWebsocketTest.java @@ -80,7 +80,7 @@ public class StompOverWebsocketTest extends StompTest { private WebSocketClientHandshaker handshaker; - public WebsocketHandler(WebSocketClientHandshaker webSocketClientHandshaker) { + WebsocketHandler(WebSocketClientHandshaker webSocketClientHandshaker) { this.handshaker = webSocketClientHandshaker; } diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/stomp/util/AbstractClientStompFrame.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/stomp/util/AbstractClientStompFrame.java index dc2e1ed69a..06771bb6eb 100644 --- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/stomp/util/AbstractClientStompFrame.java +++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/stomp/util/AbstractClientStompFrame.java @@ -169,7 +169,7 @@ public abstract class AbstractClientStompFrame implements ClientStompFrame { public String key; public String val; - public Header(String key, String val) { + private Header(String key, String val) { this.key = key; this.val = val; } diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/stomp/util/AbstractStompClientConnection.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/stomp/util/AbstractStompClientConnection.java index 5c6cc6bba7..a4244c10cc 100644 --- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/stomp/util/AbstractStompClientConnection.java +++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/stomp/util/AbstractStompClientConnection.java @@ -303,7 +303,7 @@ public abstract class AbstractStompClientConnection implements StompClientConnec ClientStompFrame pingFrame; volatile boolean stop = false; - public Pinger(long interval) { + private Pinger(long interval) { this.pingInterval = interval; pingFrame = createFrame("STOMP"); pingFrame.setBody("\n"); diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/xa/BasicXaTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/xa/BasicXaTest.java index 9eef719910..5bd2463044 100644 --- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/xa/BasicXaTest.java +++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/xa/BasicXaTest.java @@ -871,7 +871,7 @@ public class BasicXaTest extends ActiveMQTestBase { private final CountDownLatch latch; - public TxMessageHandler(final ClientSession session, final CountDownLatch latch) { + TxMessageHandler(final ClientSession session, final CountDownLatch latch) { this.latch = latch; this.session = session; } diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/xa/XaTimeoutTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/xa/XaTimeoutTest.java index 6d02cc9845..c19a200b89 100644 --- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/xa/XaTimeoutTest.java +++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/xa/XaTimeoutTest.java @@ -693,7 +693,7 @@ public class XaTimeoutTest extends ActiveMQTestBase { final CountDownLatch latch; - public RollbackCompleteOperation(final CountDownLatch latch) { + RollbackCompleteOperation(final CountDownLatch latch) { this.latch = latch; } diff --git a/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/AutoAckMesageListenerTest.java b/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/AutoAckMesageListenerTest.java index 858b5290a1..13a4699912 100644 --- a/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/AutoAckMesageListenerTest.java +++ b/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/AutoAckMesageListenerTest.java @@ -99,7 +99,7 @@ public class AutoAckMesageListenerTest extends JMSTestCase { private final CountDownLatch monitor; - public AutoAckMsgListener(CountDownLatch latch, Session session) { + private AutoAckMsgListener(CountDownLatch latch, Session session) { this.monitor = latch; this.session = session; } diff --git a/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/MessageConsumerTest.java b/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/MessageConsumerTest.java index 45e0f3c8c7..abd8b1ea5a 100644 --- a/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/MessageConsumerTest.java +++ b/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/MessageConsumerTest.java @@ -1976,10 +1976,10 @@ public class MessageConsumerTest extends JMSTestCase { final AtomicBoolean running; - public ThreadCloser(final AtomicBoolean running, - final Object waitMonitor, - final long timeToSleep, - final MessageConsumer topicConsumer) { + private ThreadCloser(final AtomicBoolean running, + final Object waitMonitor, + final long timeToSleep, + final MessageConsumer topicConsumer) { this.running = running; this.waitMonitor = waitMonitor; this.timeToSleep = timeToSleep; @@ -2024,10 +2024,10 @@ public class MessageConsumerTest extends JMSTestCase { final AtomicBoolean running; - public ThreadReceiver(final AtomicBoolean running, - final Object waitMonitor, - final long timeToWait, - final MessageConsumer topicConsumer) { + private ThreadReceiver(final AtomicBoolean running, + final Object waitMonitor, + final long timeToWait, + final MessageConsumer topicConsumer) { this.running = running; this.waitMonitor = waitMonitor; this.timeToWait = timeToWait; @@ -3819,7 +3819,7 @@ public class MessageConsumerTest extends JMSTestCase { private CountDownLatch latch; private JMSException exception; - public ConnectionCloseMessageListener(Connection conn, CountDownLatch latch) { + private ConnectionCloseMessageListener(Connection conn, CountDownLatch latch) { this.conn = conn; this.latch = latch; } @@ -3842,7 +3842,7 @@ public class MessageConsumerTest extends JMSTestCase { private CountDownLatch latch; private JMSException exception; - public ConnectionStopMessageListener(Connection conn, CountDownLatch latch) { + private ConnectionStopMessageListener(Connection conn, CountDownLatch latch) { this.conn = conn; this.latch = latch; } @@ -3865,7 +3865,7 @@ public class MessageConsumerTest extends JMSTestCase { private CountDownLatch latch; private JMSException exception; - public SessionCloseMessageListener(Session session, CountDownLatch latch) { + private SessionCloseMessageListener(Session session, CountDownLatch latch) { this.session = session; this.latch = latch; } @@ -3904,7 +3904,7 @@ public class MessageConsumerTest extends JMSTestCase { ActiveMQTestBase.waitForLatch(latch); } - public ExceptionRedelMessageListenerImpl(final Session sess) { + private ExceptionRedelMessageListenerImpl(final Session sess) { this.sess = sess; } @@ -3994,7 +3994,7 @@ public class MessageConsumerTest extends JMSTestCase { private final boolean transacted; - public RedelMessageListenerImpl(final boolean transacted) { + private RedelMessageListenerImpl(final boolean transacted) { this.transacted = transacted; } @@ -4070,11 +4070,11 @@ public class MessageConsumerTest extends JMSTestCase { private CountDownLatch latch = new CountDownLatch(1); - public MessageListenerImpl(final int count) { + private MessageListenerImpl(final int count) { latch = new CountDownLatch(count); } - public MessageListenerImpl() { + private MessageListenerImpl() { this(1); } diff --git a/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/MessageProducerTest.java b/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/MessageProducerTest.java index 19bb908999..a9ec1c4eae 100644 --- a/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/MessageProducerTest.java +++ b/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/MessageProducerTest.java @@ -735,7 +735,7 @@ public class MessageProducerTest extends JMSTestCase { private CountDownLatch latch; private JMSException exception; - public CloseCompletionListener(MessageProducer p, CountDownLatch latch) { + private CloseCompletionListener(MessageProducer p, CountDownLatch latch) { this.p = p; this.latch = latch; } @@ -762,7 +762,7 @@ public class MessageProducerTest extends JMSTestCase { private JMSException exception; private Connection conn; - public ConnectionCloseCompletionListener(Connection conn, CountDownLatch latch) { + private ConnectionCloseCompletionListener(Connection conn, CountDownLatch latch) { this.conn = conn; this.latch = latch; } @@ -789,7 +789,7 @@ public class MessageProducerTest extends JMSTestCase { private JMSException exception; private Session session; - public SessionCloseCompletionListener(Session session, CountDownLatch latch) { + private SessionCloseCompletionListener(Session session, CountDownLatch latch) { this.session = session; this.latch = latch; } diff --git a/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/MiscellaneousTest.java b/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/MiscellaneousTest.java index 4febb3dc90..d2eb533ca1 100644 --- a/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/MiscellaneousTest.java +++ b/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/MiscellaneousTest.java @@ -242,7 +242,7 @@ public class MiscellaneousTest extends JMSTestCase { private boolean resultSet; - public Result() { + private Result() { success = false; e = null; } diff --git a/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/TransactedSessionTest.java b/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/TransactedSessionTest.java index b814d6e665..6f31649a58 100644 --- a/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/TransactedSessionTest.java +++ b/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/TransactedSessionTest.java @@ -697,7 +697,7 @@ public class TransactedSessionTest extends JMSTestCase { private final Connection conn; - public myReceiver(CountDownLatch startLatch, Connection conn) { + myReceiver(CountDownLatch startLatch, Connection conn) { this.startLatch = startLatch; this.conn = conn; } diff --git a/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/message/MessageHeaderTest.java b/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/message/MessageHeaderTest.java index cbb7a9d43d..ad2e8d20d1 100644 --- a/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/message/MessageHeaderTest.java +++ b/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/message/MessageHeaderTest.java @@ -836,7 +836,7 @@ public class MessageHeaderTest extends MessageHeaderTestBase { private final ClientMessage message; - public FakeSession(final ClientMessage message) { + FakeSession(final ClientMessage message) { this.message = message; } diff --git a/tests/performance-tests/src/test/java/org/apache/activemq/artemis/tests/performance/paging/MeasurePagingMultiThreadTest.java b/tests/performance-tests/src/test/java/org/apache/activemq/artemis/tests/performance/paging/MeasurePagingMultiThreadTest.java index 87645b81cd..e19b190137 100644 --- a/tests/performance-tests/src/test/java/org/apache/activemq/artemis/tests/performance/paging/MeasurePagingMultiThreadTest.java +++ b/tests/performance-tests/src/test/java/org/apache/activemq/artemis/tests/performance/paging/MeasurePagingMultiThreadTest.java @@ -69,7 +69,7 @@ public class MeasurePagingMultiThreadTest extends ActiveMQTestBase { Throwable e; - public Sender() throws Exception { + Sender() throws Exception { session = factory.createSession(false, true, true); producer = session.createProducer(adr); msg = session.createMessage(true); diff --git a/tests/performance-tests/src/test/java/org/apache/activemq/artemis/tests/performance/sends/AbstractSendReceivePerfTest.java b/tests/performance-tests/src/test/java/org/apache/activemq/artemis/tests/performance/sends/AbstractSendReceivePerfTest.java index 12d622941e..be8093c917 100644 --- a/tests/performance-tests/src/test/java/org/apache/activemq/artemis/tests/performance/sends/AbstractSendReceivePerfTest.java +++ b/tests/performance-tests/src/test/java/org/apache/activemq/artemis/tests/performance/sends/AbstractSendReceivePerfTest.java @@ -126,7 +126,7 @@ public abstract class AbstractSendReceivePerfTest extends JMSTestBase { public boolean failed = false; - public MessageReceiver(String qname, long numberOfSamples) throws Exception { + private MessageReceiver(String qname, long numberOfSamples) throws Exception { super("Receiver " + qname); this.qName = qname; this.numberOfSamples = numberOfSamples; @@ -160,7 +160,7 @@ public abstract class AbstractSendReceivePerfTest extends JMSTestBase { public boolean failed = false; - public MessageSender(String qname) throws Exception { + private MessageSender(String qname) throws Exception { super("Sender " + qname); this.qName = qname; diff --git a/tests/stress-tests/src/test/java/org/apache/activemq/artemis/tests/stress/journal/JournalCleanupCompactStressTest.java b/tests/stress-tests/src/test/java/org/apache/activemq/artemis/tests/stress/journal/JournalCleanupCompactStressTest.java index 6bd2fcf425..ae2b2f1611 100644 --- a/tests/stress-tests/src/test/java/org/apache/activemq/artemis/tests/stress/journal/JournalCleanupCompactStressTest.java +++ b/tests/stress-tests/src/test/java/org/apache/activemq/artemis/tests/stress/journal/JournalCleanupCompactStressTest.java @@ -301,7 +301,7 @@ public class JournalCleanupCompactStressTest extends ActiveMQTestBase { OperationContextImpl ctx = new OperationContextImpl(executorFactory.getExecutor()); - public FastAppenderTx() { + FastAppenderTx() { super("FastAppenderTX"); } @@ -373,7 +373,7 @@ public class JournalCleanupCompactStressTest extends ActiveMQTestBase { OperationContextImpl ctx = new OperationContextImpl(executorFactory.getExecutor()); - public FastUpdateTx(final LinkedBlockingDeque queue) { + FastUpdateTx(final LinkedBlockingDeque queue) { super("FastUpdateTX"); this.queue = queue; } @@ -475,7 +475,7 @@ public class JournalCleanupCompactStressTest extends ActiveMQTestBase { */ class SlowAppenderNoTX extends Thread { - public SlowAppenderNoTX() { + SlowAppenderNoTX() { super("SlowAppender"); } diff --git a/tests/stress-tests/src/test/java/org/apache/activemq/artemis/tests/stress/remote/PingStressTest.java b/tests/stress-tests/src/test/java/org/apache/activemq/artemis/tests/stress/remote/PingStressTest.java index 9f717bd8b7..9af6b90445 100644 --- a/tests/stress-tests/src/test/java/org/apache/activemq/artemis/tests/stress/remote/PingStressTest.java +++ b/tests/stress-tests/src/test/java/org/apache/activemq/artemis/tests/stress/remote/PingStressTest.java @@ -100,7 +100,7 @@ public class PingStressTest extends ActiveMQTestBase { int threadNumber; - public LocalThread(final int i) { + LocalThread(final int i) { super("LocalThread i = " + i); threadNumber = i; } diff --git a/tests/timing-tests/src/test/java/org/apache/activemq/artemis/tests/timing/jms/bridge/impl/JMSBridgeImplTest.java b/tests/timing-tests/src/test/java/org/apache/activemq/artemis/tests/timing/jms/bridge/impl/JMSBridgeImplTest.java index 9b5116e0d5..d322a1add7 100644 --- a/tests/timing-tests/src/test/java/org/apache/activemq/artemis/tests/timing/jms/bridge/impl/JMSBridgeImplTest.java +++ b/tests/timing-tests/src/test/java/org/apache/activemq/artemis/tests/timing/jms/bridge/impl/JMSBridgeImplTest.java @@ -745,7 +745,7 @@ public class JMSBridgeImplTest extends ActiveMQTestBase { private final ClassLoader original; private final String knownClass = "com.class.only.visible.to.tccl.SomeClass"; - public MockContextClassLoader(ClassLoader parent) { + private MockContextClassLoader(ClassLoader parent) { super(parent); original = Thread.currentThread().getContextClassLoader(); } diff --git a/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/asyncio/MultiThreadAsynchronousFileTest.java b/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/asyncio/MultiThreadAsynchronousFileTest.java index 6c638aef36..fb0f96613e 100644 --- a/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/asyncio/MultiThreadAsynchronousFileTest.java +++ b/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/asyncio/MultiThreadAsynchronousFileTest.java @@ -159,10 +159,10 @@ public class MultiThreadAsynchronousFileTest extends AIOTestBase { AIOSequentialFile libaio; - public ThreadProducer(final String name, - final CountDownLatch latchStart, - final AIOSequentialFile libaio, - final boolean sync) { + ThreadProducer(final String name, + final CountDownLatch latchStart, + final AIOSequentialFile libaio, + final boolean sync) { super(name); this.latchStart = latchStart; this.libaio = libaio; diff --git a/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/paging/impl/PagingStoreImplTest.java b/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/paging/impl/PagingStoreImplTest.java index 498beb4fd5..97520f322f 100644 --- a/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/paging/impl/PagingStoreImplTest.java +++ b/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/paging/impl/PagingStoreImplTest.java @@ -634,7 +634,7 @@ public class PagingStoreImplTest extends ActiveMQTestBase { class WriterThread extends Thread { - public WriterThread() { + WriterThread() { super("PageWriter"); } @@ -668,7 +668,7 @@ public class PagingStoreImplTest extends ActiveMQTestBase { class ReaderThread extends Thread { - public ReaderThread() { + ReaderThread() { super("PageReader"); } @@ -787,11 +787,11 @@ public class PagingStoreImplTest extends ActiveMQTestBase { final SequentialFileFactory factory; - public FakeStoreFactory() { + FakeStoreFactory() { factory = new FakeSequentialFileFactory(); } - public FakeStoreFactory(final SequentialFileFactory factory) { + FakeStoreFactory(final SequentialFileFactory factory) { this.factory = factory; } diff --git a/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/postoffice/impl/WildcardAddressManagerUnitTest.java b/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/postoffice/impl/WildcardAddressManagerUnitTest.java index 23b1c652db..61783ac386 100644 --- a/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/postoffice/impl/WildcardAddressManagerUnitTest.java +++ b/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/postoffice/impl/WildcardAddressManagerUnitTest.java @@ -84,11 +84,11 @@ public class WildcardAddressManagerUnitTest extends ActiveMQTestBase { final SimpleString address; final SimpleString id; - public BindingFake(String addressParameter, String id) { + BindingFake(String addressParameter, String id) { this(SimpleString.toSimpleString(addressParameter), SimpleString.toSimpleString(id)); } - public BindingFake(SimpleString addressParameter, SimpleString id) { + BindingFake(SimpleString addressParameter, SimpleString id) { this.address = addressParameter; this.id = id; } diff --git a/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/server/impl/QueueImplTest.java b/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/server/impl/QueueImplTest.java index e21d6d9e38..b98c419e47 100644 --- a/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/server/impl/QueueImplTest.java +++ b/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/server/impl/QueueImplTest.java @@ -1219,10 +1219,10 @@ public class QueueImplTest extends ActiveMQTestBase { boolean first; - public AddtoQueueRunner(final boolean first, - final QueueImpl queue, - final MessageReference messageReference, - final CountDownLatch countDownLatch) { + AddtoQueueRunner(final boolean first, + final QueueImpl queue, + final MessageReference messageReference, + final CountDownLatch countDownLatch) { this.queue = queue; this.messageReference = messageReference; this.countDownLatch = countDownLatch;