Apache
/
activemq-artemis
mirror of https://github.com/apache/activemq-artemis.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

ARTEMIS-3770 mitigate potential NPE 

This was being triggered by
org.apache.activemq.artemis.tests.integration.routing.MQTTRedirectTest.
This commit is contained in:
Justin Bertram 2022-05-10 12:12:35 -05:00 committed by clebertsuconic
parent bed9af2e51
commit 3a0658c202
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTProtocolHandler.java
View File

@ -448,10 +448,14 @@ public class MQTTProtocolHandler extends ChannelInboundHandlerAdapter {
private void disconnectExistingSession(MQTTConnection existingConnection) { private void disconnectExistingSession(MQTTConnection existingConnection) {
if (existingConnection != null) { if (existingConnection != null) {
MQTTSession existingSession = session.getProtocolManager().getSessionState(session.getConnection().getClientID()).getSession(); MQTTSession existingSession = session.getProtocolManager().getSessionState(session.getConnection().getClientID()).getSession();
if (existingSession != null) {
if (session.getVersion() == MQTTVersion.MQTT_5) { if (session.getVersion() == MQTTVersion.MQTT_5) {
existingSession.getProtocolHandler().sendDisconnect(MQTTReasonCodes.SESSION_TAKEN_OVER); existingSession.getProtocolHandler().sendDisconnect(MQTTReasonCodes.SESSION_TAKEN_OVER);
} }
existingSession.getConnectionManager().disconnect(false); existingSession.getConnectionManager().disconnect(false);
} else {
existingConnection.disconnect(false);
}
} }
} }