Apache
/
activemq-artemis
mirror of https://github.com/apache/activemq-artemis.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

ARTEMIS-2570 Improve performance of ConnectionsView

This commit is contained in:
Sebastian Thomschke 2019-12-06 11:55:48 +01:00 committed by GitHub
parent 5d76bcbcb8
commit 3ad8391e9b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/view/ConnectionView.java
View File

@ -70,13 +70,11 @@ public class ConnectionView extends ActiveMQAbstractView<RemotingConnection> {
.add("protocol", toString(connection.getProtocolName())) .add("protocol", toString(connection.getProtocolName()))
.add("clientID", toString(connection.getClientID() != null ? connection.getClientID() : jmsSessionClientID)) .add("clientID", toString(connection.getClientID() != null ? connection.getClientID() : jmsSessionClientID))
.add("localAddress", toString(connection.getTransportLocalAddress())) .add("localAddress", toString(connection.getTransportLocalAddress()))
.add("sessionCount", server.getSessions(connection.getID().toString()).size()); .add("sessionCount", sessions.size());
} }
@Override @Override
public Object getField(RemotingConnection connection, String fieldName) { public Object getField(RemotingConnection connection, String fieldName) {
List<ServerSession> sessions = server.getSessions(connection.getID().toString());
switch (fieldName) { switch (fieldName) {
case "connectionID": case "connectionID":
return connection.getID(); return connection.getID();
@ -84,6 +82,7 @@ public class ConnectionView extends ActiveMQAbstractView<RemotingConnection> {
return connection.getRemoteAddress(); return connection.getRemoteAddress();
case "users": case "users":
Set<String> users = new TreeSet<>(); Set<String> users = new TreeSet<>();
List<ServerSession> sessions = server.getSessions(connection.getID().toString());
for (ServerSession session : sessions) { for (ServerSession session : sessions) {
String username = session.getUsername() == null ? "" : session.getUsername(); String username = session.getUsername() == null ? "" : session.getUsername();
users.add(username); users.add(username);
@ -100,7 +99,7 @@ public class ConnectionView extends ActiveMQAbstractView<RemotingConnection> {
case "localAddress": case "localAddress":
return connection.getTransportLocalAddress(); return connection.getTransportLocalAddress();
case "sessionCount": case "sessionCount":
return sessions.size(); return server.getSessions(connection.getID().toString()).size();
default: default:
throw new IllegalArgumentException("Unsupported field, " + fieldName); throw new IllegalArgumentException("Unsupported field, " + fieldName);
} }