This closes #785

This commit is contained in:
Clebert Suconic 2016-09-21 16:31:14 -04:00
commit 3d8fbc1395
7 changed files with 22 additions and 1 deletions

View File

@ -56,6 +56,7 @@ public class ActiveMQScheduledComponentTest {
final ActiveMQScheduledComponent local = new ActiveMQScheduledComponent(scheduledExecutorService, executorService, 100, TimeUnit.MILLISECONDS, false) {
@Override
public void run() {
if (count.get() == 0) {
try {

View File

@ -201,6 +201,7 @@ public class GenericSQLProvider implements SQLProvider {
public static class Factory implements SQLProvider.Factory {
@Override
public SQLProvider create(String tableName) {
return new GenericSQLProvider(tableName);
}

View File

@ -2400,6 +2400,7 @@ public class ActiveMQServerImpl implements ActiveMQServer {
return new Date().getTime() - startDate.getTime();
}
@Override
public boolean addClientConnection(String clientId, boolean unique) {
final AtomicInteger i = connectedClientIds.putIfAbsent(clientId, new AtomicInteger(1));
if (i != null) {
@ -2413,6 +2414,7 @@ public class ActiveMQServerImpl implements ActiveMQServer {
return true;
}
@Override
public void removeClientConnection(String clientId) {
AtomicInteger i = connectedClientIds.get(clientId);
if (i != null && i.decrementAndGet() == 0) {

View File

@ -1100,6 +1100,7 @@ public class QueueImpl implements Queue {
}
}
@Override
public void expire(final MessageReference ref) throws Exception {
SimpleString messageExpiryAddress = expiryAddressFromMessageAddress(ref);
if (messageExpiryAddress == null) {

View File

@ -36,7 +36,7 @@ After you add the JDK to the IDE, add also the vm.jar specific to your platform
There's a [SOF Question](http://stackoverflow.com/questions/27906481/can-intellij-14-be-used-to-work-with-ibm-jdk-1-7/32852361#32852361) about this that could be useful in case you are running into this issue.
### Style Templates for Idea
### Style Templates and Inspection Settings for Idea
We have shared the style templates that are good for this project. If you want to apply them use these steps:
@ -45,6 +45,12 @@ We have shared the style templates that are good for this project. If you want t
* Select both Code Style Templates and File templates (it's the default option)
* Select OK and restart Idea
Similarly, to import inspection settings:
* File->Settings->Editor->Inspections->Manage->Import
* Select the file ./artemis-cloned-folder/etc/ide-settings/IDEA-artemis-inspections.xml
* Select OK
### Issue: My JUnit tests are not runnable with in the IDE.
If the "Run <classname>" or "Run all tests" option is not present. It is likely that the default profile has not been

View File

@ -0,0 +1,8 @@
<?xml version="1.0" encoding="UTF-8"?>
<inspections version="1.0">
<option name="myName" value="Artemis" />
<inspection_tool class="MissingOverrideAnnotation" enabled="true" level="ERROR" enabled_by_default="true">
<option name="ignoreObjectMethods" value="false" />
<option name="ignoreAnonymousClassMethods" value="false" />
</inspection_tool>
</inspections>

View File

@ -19,6 +19,8 @@ org.eclipse.jdt.core.compiler.debug.sourceFile=generate
org.eclipse.jdt.core.compiler.problem.assertIdentifier=error
org.eclipse.jdt.core.compiler.problem.enumIdentifier=error
org.eclipse.jdt.core.compiler.problem.forbiddenReference=warning
org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotation=error
org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotationForInterfaceMethodImplementation=enabled
org.eclipse.jdt.core.compiler.processAnnotations=enabled
org.eclipse.jdt.core.compiler.source=1.7
org.eclipse.jdt.core.formatter.align_type_members_on_columns=false