Apache
/
activemq-artemis
mirror of https://github.com/apache/activemq-artemis.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

ARTEMIS-4986: fixups for prior PR feedback

This commit is contained in:
Robbie Gemmell 2024-08-15 13:53:04 +01:00 committed by clebertsuconic
parent 32e456c88a
commit 3f5184a933
3 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/Channel.java
View File

@ -58,8 +58,8 @@ public interface Channel {
boolean supports(byte packetID, int version);
/*
* Due to ARTEMIS-4986, older versions (2.30.0 in particular) will require a special voting handling,
* where we would perform specific retries at older values.
* Due to ARTEMIS-4986, older versions (<= 2.31.2 in particular) before 2.37.0 will require
* special voting handling, where we would perform specific retries with older values.
*/
default boolean requireSpecialVotingHandling() {
return false;

2
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ChannelImpl.java
View File

@ -202,7 +202,7 @@ public final class ChannelImpl implements Channel {
@Override
public boolean requireSpecialVotingHandling() {
return connection.getChannelVersion() < PacketImpl.ARTEMIS_2_36_0_VERSION;
return connection.getChannelVersion() < PacketImpl.ARTEMIS_2_37_0_VERSION;
}
@Override

3
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/PacketImpl.java
View File

@ -53,7 +53,8 @@ public class PacketImpl implements Packet {
// 2.29.0
public static final int ARTEMIS_2_29_0_VERSION = 135;
public static final int ARTEMIS_2_36_0_VERSION = 136;
// 2.37.0
public static final int ARTEMIS_2_37_0_VERSION = 136;
public static final SimpleString OLD_QUEUE_PREFIX = SimpleString.of("jms.queue.");
public static final SimpleString OLD_TEMP_QUEUE_PREFIX = SimpleString.of("jms.tempqueue.");