Apache
/
activemq-artemis
mirror of https://github.com/apache/activemq-artemis.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

ARTEMIS-1407 Remove unused method that performs invalid operation 

Remove the unused transaction remove method as the getTransaction method
provides the remove operation and the remove method was doing an invalud
remove of wrong type from the transactions collection.
This commit is contained in:
Timothy Bish 2017-09-11 15:01:18 -04:00 committed by Justin Bertram
parent 07a218572c
commit 412b63a6b5
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPConnectionCallback.java
View File

@ -24,7 +24,6 @@ import java.util.concurrent.ConcurrentMap;
import java.util.concurrent.Executor; import java.util.concurrent.Executor;
import java.util.concurrent.atomic.AtomicBoolean; import java.util.concurrent.atomic.AtomicBoolean;
import io.netty.buffer.ByteBuf;
import org.apache.activemq.artemis.api.core.ActiveMQBuffers; import org.apache.activemq.artemis.api.core.ActiveMQBuffers;
import org.apache.activemq.artemis.api.core.ActiveMQException; import org.apache.activemq.artemis.api.core.ActiveMQException;
import org.apache.activemq.artemis.core.buffers.impl.ChannelBufferWrapper; import org.apache.activemq.artemis.core.buffers.impl.ChannelBufferWrapper;
@ -55,6 +54,8 @@ import org.apache.qpid.proton.amqp.Symbol;
import org.apache.qpid.proton.amqp.transport.AmqpError; import org.apache.qpid.proton.amqp.transport.AmqpError;
import org.jboss.logging.Logger; import org.jboss.logging.Logger;
import io.netty.buffer.ByteBuf;
public class AMQPConnectionCallback implements FailureListener, CloseListener { public class AMQPConnectionCallback implements FailureListener, CloseListener {
private static final Logger logger = Logger.getLogger(AMQPConnectionCallback.class); private static final Logger logger = Logger.getLogger(AMQPConnectionCallback.class);
@ -261,11 +262,6 @@ public class AMQPConnectionCallback implements FailureListener, CloseListener {
return tx; return tx;
} }
public Transaction removeTransaction(Binary txid) {
XidImpl xid = newXID(txid.getArray());
return transactions.remove(xid);
}
protected XidImpl newXID() { protected XidImpl newXID() {
return newXID(UUIDGenerator.getInstance().generateStringUUID().getBytes()); return newXID(UUIDGenerator.getInstance().generateStringUUID().getBytes());
} }