mirror of
https://github.com/apache/activemq-artemis.git
synced 2025-02-28 14:29:31 +00:00
This closes #1209
This commit is contained in:
commit
4edc3297f0
@ -177,13 +177,24 @@ public class ActiveMQJAASSecurityManager implements ActiveMQSecurityManager3 {
|
|||||||
final String password,
|
final String password,
|
||||||
final X509Certificate[] certificates) throws LoginException {
|
final X509Certificate[] certificates) throws LoginException {
|
||||||
LoginContext lc;
|
LoginContext lc;
|
||||||
if (certificateConfigurationName != null && certificateConfigurationName.length() > 0 && certificates != null) {
|
ClassLoader currentLoader = Thread.currentThread().getContextClassLoader();
|
||||||
lc = new LoginContext(certificateConfigurationName, null, new JaasCallbackHandler(user, password, certificates), certificateConfiguration);
|
ClassLoader thisLoader = this.getClass().getClassLoader();
|
||||||
} else {
|
try {
|
||||||
lc = new LoginContext(configurationName, null, new JaasCallbackHandler(user, password, certificates), configuration);
|
if (thisLoader != currentLoader) {
|
||||||
|
Thread.currentThread().setContextClassLoader(thisLoader);
|
||||||
|
}
|
||||||
|
if (certificateConfigurationName != null && certificateConfigurationName.length() > 0 && certificates != null) {
|
||||||
|
lc = new LoginContext(certificateConfigurationName, null, new JaasCallbackHandler(user, password, certificates), certificateConfiguration);
|
||||||
|
} else {
|
||||||
|
lc = new LoginContext(configurationName, null, new JaasCallbackHandler(user, password, certificates), configuration);
|
||||||
|
}
|
||||||
|
lc.login();
|
||||||
|
return lc.getSubject();
|
||||||
|
} finally {
|
||||||
|
if (thisLoader != currentLoader) {
|
||||||
|
Thread.currentThread().setContextClassLoader(currentLoader);
|
||||||
|
}
|
||||||
}
|
}
|
||||||
lc.login();
|
|
||||||
return lc.getSubject();
|
|
||||||
}
|
}
|
||||||
|
|
||||||
private Set<RolePrincipal> getPrincipalsInRole(final CheckType checkType, final Set<Role> roles) {
|
private Set<RolePrincipal> getPrincipalsInRole(final CheckType checkType, final Set<Role> roles) {
|
||||||
|
@ -0,0 +1,99 @@
|
|||||||
|
/*
|
||||||
|
* Licensed to the Apache Software Foundation (ASF) under one or more
|
||||||
|
* contributor license agreements. See the NOTICE file distributed with
|
||||||
|
* this work for additional information regarding copyright ownership.
|
||||||
|
* The ASF licenses this file to You under the Apache License, Version 2.0
|
||||||
|
* (the "License"); you may not use this file except in compliance with
|
||||||
|
* the License. You may obtain a copy of the License at
|
||||||
|
*
|
||||||
|
* http://www.apache.org/licenses/LICENSE-2.0
|
||||||
|
*
|
||||||
|
* Unless required by applicable law or agreed to in writing, software
|
||||||
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
||||||
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||||
|
* See the License for the specific language governing permissions and
|
||||||
|
* limitations under the License.
|
||||||
|
*/
|
||||||
|
package org.apache.activemq.artemis.core.security.jaas;
|
||||||
|
|
||||||
|
import org.apache.activemq.artemis.core.security.CheckType;
|
||||||
|
import org.apache.activemq.artemis.core.security.Role;
|
||||||
|
import org.apache.activemq.artemis.spi.core.security.ActiveMQJAASSecurityManager;
|
||||||
|
import org.junit.Rule;
|
||||||
|
import org.junit.Test;
|
||||||
|
import org.junit.rules.TemporaryFolder;
|
||||||
|
import org.junit.runner.RunWith;
|
||||||
|
import org.junit.runners.Parameterized;
|
||||||
|
|
||||||
|
import java.io.UnsupportedEncodingException;
|
||||||
|
import java.net.URL;
|
||||||
|
import java.net.URLClassLoader;
|
||||||
|
import java.net.URLDecoder;
|
||||||
|
import java.nio.charset.StandardCharsets;
|
||||||
|
import java.util.Arrays;
|
||||||
|
import java.util.Collection;
|
||||||
|
import java.util.HashSet;
|
||||||
|
import java.util.Set;
|
||||||
|
|
||||||
|
import static org.junit.Assert.assertEquals;
|
||||||
|
import static org.junit.Assert.assertNotNull;
|
||||||
|
|
||||||
|
@RunWith(Parameterized.class)
|
||||||
|
public class JAASSecurityManagerTest {
|
||||||
|
|
||||||
|
@Parameterized.Parameters(name = "newLoader=({0})")
|
||||||
|
public static Collection<Object[]> data() {
|
||||||
|
return Arrays.asList(new Object[][] {{true}, {false}});
|
||||||
|
}
|
||||||
|
|
||||||
|
static {
|
||||||
|
String path = System.getProperty("java.security.auth.login.config");
|
||||||
|
if (path == null) {
|
||||||
|
URL resource = PropertiesLoginModuleTest.class.getClassLoader().getResource("login.config");
|
||||||
|
if (resource != null) {
|
||||||
|
try {
|
||||||
|
path = URLDecoder.decode(resource.getFile(), StandardCharsets.UTF_8.name());
|
||||||
|
System.setProperty("java.security.auth.login.config", path);
|
||||||
|
} catch (UnsupportedEncodingException e) {
|
||||||
|
throw new RuntimeException(e);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
@Parameterized.Parameter
|
||||||
|
public boolean usingNewLoader;
|
||||||
|
|
||||||
|
@Rule
|
||||||
|
public TemporaryFolder tmpDir = new TemporaryFolder();
|
||||||
|
|
||||||
|
@Test
|
||||||
|
public void testLoginClassloading() throws Exception {
|
||||||
|
ClassLoader existingLoader = Thread.currentThread().getContextClassLoader();
|
||||||
|
System.out.println("loader: " + existingLoader);
|
||||||
|
try {
|
||||||
|
if (usingNewLoader) {
|
||||||
|
URLClassLoader simulatedLoader = new URLClassLoader(new URL[]{tmpDir.getRoot().toURI().toURL()}, null);
|
||||||
|
Thread.currentThread().setContextClassLoader(simulatedLoader);
|
||||||
|
}
|
||||||
|
ActiveMQJAASSecurityManager securityManager = new ActiveMQJAASSecurityManager("PropertiesLogin");
|
||||||
|
|
||||||
|
String result = securityManager.validateUser("first", "secret", null);
|
||||||
|
|
||||||
|
assertNotNull(result);
|
||||||
|
assertEquals("first", result);
|
||||||
|
|
||||||
|
Role role = new Role("programmers", true, true, true, true, true, true, true, true, true, true);
|
||||||
|
Set<Role> roles = new HashSet<>();
|
||||||
|
roles.add(role);
|
||||||
|
result = securityManager.validateUserAndRole("first", "secret", roles, CheckType.SEND, "someaddress", null);
|
||||||
|
|
||||||
|
assertNotNull(result);
|
||||||
|
assertEquals("first", result);
|
||||||
|
|
||||||
|
} finally {
|
||||||
|
Thread.currentThread().setContextClassLoader(existingLoader);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
}
|
Loading…
x
Reference in New Issue
Block a user