ARTEMIS-4346: move stomp test client to artemis-test-support systest helper module

tests/artemis-test-support/pom.xml

@@ -103,6 +103,13 @@
          <scope>provided</scope>
       </dependency>
 
+      <dependency>
+         <groupId>org.apache.activemq</groupId>
+         <artifactId>artemis-stomp-protocol</artifactId>
+         <version>${project.version}</version>
+         <scope>provided</scope>
+      </dependency>
+
       <!-- This should be the only dependency not at 'provided' scope, for now -->
       <dependency>
          <groupId>org.apache.activemq</groupId>

tests/artemis-test-support/src/main/java/org/apache/activemq/artemis/tests/integration/stomp/util/AbstractStompClientConnection.java

@@ -30,7 +30,6 @@ import io.netty.buffer.ByteBuf;
 import io.netty.buffer.Unpooled;
 import io.netty.channel.ChannelFuture;
 import org.apache.activemq.artemis.core.protocol.stomp.Stomp;
-import org.apache.activemq.artemis.tests.util.Wait;
 import org.apache.activemq.artemis.utils.collections.ConcurrentHashSet;
 import org.apache.activemq.transport.netty.NettyTransport;
 import org.apache.activemq.transport.netty.NettyTransportFactory;
@@ -91,8 +90,6 @@ public abstract class AbstractStompClientConnection implements StompClientConnec
       transport.setTransportListener(new StompTransportListener());
       transport.connect();
 
-      Wait.waitFor(() -> transport.isConnected(), 1000);
-
       if (!transport.isConnected()) {
          throw new RuntimeException("Could not connect transport");
       }
@@ -112,8 +109,6 @@ public abstract class AbstractStompClientConnection implements StompClientConnec
       if (autoConnect) {
          transport.connect();
 
-         Wait.waitFor(() -> transport.isConnected(), 1000);
-
          if (!transport.isConnected()) {
             throw new RuntimeException("Could not connect transport");
          }