From 67ee34d4d94efd9e139ed99376faccb2529e007d Mon Sep 17 00:00:00 2001 From: Jiri Danek Date: Tue, 1 May 2018 08:27:20 +0200 Subject: [PATCH] ARTEMIS-1449 Remove deprecated -XX:+UseFastAccessorMethods JVM option This option was removed in JRE 10 and its presence causes error on startup. Artemis still does not compile on JDK 9 and up, so what I tried was to compile on JDK 1.8 and then start Artemis on 1.8 and 10. That now works for me. --- .../activemq/artemis/cli/commands/bin/artemis-service.xml | 1 - .../apache/activemq/artemis/cli/commands/etc/artemis.profile | 2 +- .../activemq/artemis/cli/commands/etc/artemis.profile.cmd | 2 +- artemis-distribution/src/main/resources/bin/artemis | 2 +- artemis-distribution/src/main/resources/bin/artemis.cmd | 2 +- docs/user-manual/en/perf-tuning.md | 2 +- examples/common/config/server.properties | 2 +- 7 files changed, 6 insertions(+), 7 deletions(-) diff --git a/artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/bin/artemis-service.xml b/artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/bin/artemis-service.xml index 395e041e5b..9bb77e8268 100644 --- a/artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/bin/artemis-service.xml +++ b/artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/bin/artemis-service.xml @@ -36,7 +36,6 @@ -Xbootclasspath/a:%ARTEMIS_HOME%\lib\${logmanager} -XX:+UseParallelGC -XX:+AggressiveOpts - -XX:+UseFastAccessorMethods -Xms512M -Xmx1024M diff --git a/artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/artemis.profile b/artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/artemis.profile index 7f53c9959e..5f83be8940 100644 --- a/artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/artemis.profile +++ b/artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/artemis.profile @@ -30,7 +30,7 @@ ARTEMIS_INSTANCE_ETC_URI='${artemis.instance.etc.uri}' # Java Opts -JAVA_ARGS="${java-opts} -XX:+PrintClassHistogram -XX:+UseG1GC -XX:+AggressiveOpts -XX:+UseFastAccessorMethods -Xms512M -Xmx2G -Dhawtio.realm=activemq -Dhawtio.offline="true" -Dhawtio.role=${role} -Dhawtio.rolePrincipalClasses=org.apache.activemq.artemis.spi.core.security.jaas.RolePrincipal -Djolokia.policyLocation=${ARTEMIS_INSTANCE_ETC_URI}jolokia-access.xml" +JAVA_ARGS="${java-opts} -XX:+PrintClassHistogram -XX:+UseG1GC -XX:+AggressiveOpts -Xms512M -Xmx2G -Dhawtio.realm=activemq -Dhawtio.offline="true" -Dhawtio.role=${role} -Dhawtio.rolePrincipalClasses=org.apache.activemq.artemis.spi.core.security.jaas.RolePrincipal -Djolokia.policyLocation=${ARTEMIS_INSTANCE_ETC_URI}jolokia-access.xml" # # There might be options that you only want to enable on specifc commands, like setting a JMX port diff --git a/artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/artemis.profile.cmd b/artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/artemis.profile.cmd index 6b95afc9e9..5d579c3bb2 100644 --- a/artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/artemis.profile.cmd +++ b/artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/artemis.profile.cmd @@ -32,7 +32,7 @@ rem Cluster Properties: Used to pass arguments to ActiveMQ Artemis which can be rem set ARTEMIS_CLUSTER_PROPS=-Dactivemq.remoting.default.port=61617 -Dactivemq.remoting.amqp.port=5673 -Dactivemq.remoting.stomp.port=61614 -Dactivemq.remoting.hornetq.port=5446 rem Java Opts -set JAVA_ARGS=${java-opts} -XX:+PrintClassHistogram -XX:+UseG1GC -XX:+AggressiveOpts -XX:+UseFastAccessorMethods -Xms512M -Xmx1024M -Xbootclasspath/a:%ARTEMIS_HOME%\lib\${logmanager} -Djava.security.auth.login.config=%ARTEMIS_INSTANCE_ETC%\login.config -Dhawtio.offline="true" -Dhawtio.realm=activemq -Dhawtio.role=${role} -Dhawtio.rolePrincipalClasses=org.apache.activemq.artemis.spi.core.security.jaas.RolePrincipal -Djolokia.policyLocation=%ARTEMIS_INSTANCE_ETC_URI%\jolokia-access.xml -Dartemis.instance=%ARTEMIS_INSTANCE% +set JAVA_ARGS=${java-opts} -XX:+PrintClassHistogram -XX:+UseG1GC -XX:+AggressiveOpts -Xms512M -Xmx1024M -Xbootclasspath/a:%ARTEMIS_HOME%\lib\${logmanager} -Djava.security.auth.login.config=%ARTEMIS_INSTANCE_ETC%\login.config -Dhawtio.offline="true" -Dhawtio.realm=activemq -Dhawtio.role=${role} -Dhawtio.rolePrincipalClasses=org.apache.activemq.artemis.spi.core.security.jaas.RolePrincipal -Djolokia.policyLocation=%ARTEMIS_INSTANCE_ETC_URI%\jolokia-access.xml -Dartemis.instance=%ARTEMIS_INSTANCE% rem There might be options that you only want to enable on specifc commands, like setting a JMX port rem See https://issues.apache.org/jira/browse/ARTEMIS-318 diff --git a/artemis-distribution/src/main/resources/bin/artemis b/artemis-distribution/src/main/resources/bin/artemis index c53c6f9dff..a7eeade333 100755 --- a/artemis-distribution/src/main/resources/bin/artemis +++ b/artemis-distribution/src/main/resources/bin/artemis @@ -45,7 +45,7 @@ if [ -z "$ARTEMIS_HOME" ] ; then fi # Set Defaults Properties -JAVA_ARGS="-XX:+UseParallelGC -XX:+AggressiveOpts -XX:+UseFastAccessorMethods -Xms512M -Xmx1024M" +JAVA_ARGS="-XX:+UseParallelGC -XX:+AggressiveOpts -Xms512M -Xmx1024M" CLASSPATH="$ARTEMIS_HOME/lib/artemis-boot.jar" # OS specific support. diff --git a/artemis-distribution/src/main/resources/bin/artemis.cmd b/artemis-distribution/src/main/resources/bin/artemis.cmd index 9c820850d0..24b8c9ea64 100755 --- a/artemis-distribution/src/main/resources/bin/artemis.cmd +++ b/artemis-distribution/src/main/resources/bin/artemis.cmd @@ -45,7 +45,7 @@ echo. :RUN_JAVA rem "Set Defaults." -set JAVA_ARGS=-XX:+UseParallelGC -XX:+AggressiveOpts -XX:+UseFastAccessorMethods -Xms512M -Xmx1024M +set JAVA_ARGS=-XX:+UseParallelGC -XX:+AggressiveOpts -Xms512M -Xmx1024M rem "Create full JVM Args" set JVM_ARGS=%JAVA_ARGS% diff --git a/docs/user-manual/en/perf-tuning.md b/docs/user-manual/en/perf-tuning.md index 61773849b8..81f1f44516 100644 --- a/docs/user-manual/en/perf-tuning.md +++ b/docs/user-manual/en/perf-tuning.md @@ -224,7 +224,7 @@ tunings won't apply to JDKs from other providers (e.g. IBM or JRockit) tuning parameters, for the Sun Hotspot JVM the full list of options is available [here](http://www.oracle.com/technetwork/java/javase/tech/vmoptions-jsp-140102.html). - We recommend at least using `-XX:+AggressiveOpts` and `-XX:+UseFastAccessorMethods`. + We recommend at least using `-XX:+AggressiveOpts`. You may get some mileage with the other tuning parameters depending on your OS platform and application usage patterns. diff --git a/examples/common/config/server.properties b/examples/common/config/server.properties index cff66e28f5..345f3895ab 100644 --- a/examples/common/config/server.properties +++ b/examples/common/config/server.properties @@ -15,4 +15,4 @@ # specific language governing permissions and limitations # under the License. -server.args=-XX:+UseParallelGC -Xms256M -Xmx256M -XX:+AggressiveOpts -XX:+UseFastAccessorMethods -Dcom.sun.management.jmxremote -Djava.util.logging.config.file=${imported.basedir}/config/logging.properties -Djava.naming.factory.initial=org.apache.activemq.artemis.jndi.ActiveMQInitialContextFactory +server.args=-XX:+UseParallelGC -Xms256M -Xmx256M -XX:+AggressiveOpts -Dcom.sun.management.jmxremote -Djava.util.logging.config.file=${imported.basedir}/config/logging.properties -Djava.naming.factory.initial=org.apache.activemq.artemis.jndi.ActiveMQInitialContextFactory