Apache
/
activemq-artemis
mirror of https://github.com/apache/activemq-artemis.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

ARTEMIS-1728 Reclaim memory when page cursor complete 

Free hash set used to hold page position for acks and removed refs.
The two set is cleared, but they still hold a big array.

It is safe to replace the old one with empty set.
This commit is contained in:
huaishk 2018-03-05 17:32:29 +08:00 committed by Clebert Suconic
parent 79ad9cb254
commit 7f606a4690
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionImpl.java
View File

@ -334,7 +334,9 @@ final class PageSubscriptionImpl implements PageSubscription {
} }
infoPG.acks.clear(); infoPG.acks.clear();
infoPG.acks = Collections.synchronizedSet(new LinkedHashSet<PagePosition>());
infoPG.removedReferences.clear(); infoPG.removedReferences.clear();
infoPG.removedReferences = new ConcurrentHashSet<>();
} }
tx.addOperation(new TransactionOperationAbstract() { tx.addOperation(new TransactionOperationAbstract() {
@ -901,11 +903,11 @@ final class PageSubscriptionImpl implements PageSubscription {
private final long pageId; private final long pageId;
// Confirmed ACKs on this page // Confirmed ACKs on this page
private final Set<PagePosition> acks = Collections.synchronizedSet(new LinkedHashSet<PagePosition>()); private Set<PagePosition> acks = Collections.synchronizedSet(new LinkedHashSet<PagePosition>());
private WeakReference<PageCache> cache; private WeakReference<PageCache> cache;
private final Set<PagePosition> removedReferences = new ConcurrentHashSet<>(); private Set<PagePosition> removedReferences = new ConcurrentHashSet<>();
// The page was live at the time of the creation // The page was live at the time of the creation
private final boolean wasLive; private final boolean wasLive;