ARTEMIS-3538 Removing a few extra // ----- structural comments

This commit is contained in:
Clebert Suconic 2021-11-02 21:45:09 -04:00
parent 923e4cc892
commit 8b3663e827
403 changed files with 8 additions and 1998 deletions

View File

@ -456,8 +456,6 @@ public final class XmlDataExporter extends DBOption {
return queues;
}
// Inner classes -------------------------------------------------
/**
* Proxy to handle indenting the XML since <code>javax.xml.stream.XMLStreamWriter</code> doesn't support that.
*/

View File

@ -220,9 +220,6 @@ public final class SimpleString implements CharSequence, Serializable, Comparabl
return toString().compareTo(o.toString());
}
// Public
// ---------------------------------------------------------------------------
/**
* returns the underlying byte array of this SimpleString
*

View File

@ -128,15 +128,4 @@ public class RandomUtil {
return RandomUtil.random.nextFloat();
}
// Public --------------------------------------------------------
// Package protected ---------------------------------------------
// Protected -----------------------------------------------------
// Private -------------------------------------------------------
// Inner classes -------------------------------------------------
}

View File

@ -206,7 +206,6 @@ public final class UUIDGenerator {
return null;
}
// Private -------------------------------------------------------
private static boolean isBlackList(final byte[] address) {
for (byte[] blackList : UUIDGenerator.BLACK_LIST) {

View File

@ -66,8 +66,6 @@ import java.util.Random;
* lock), and so has no method synchronization.
*/
public class UUIDTimer {
// // // Constants
/**
* Since System.longTimeMillis() returns time from january 1st 1970, and
* UUIDs need time from the beginning of gregorian calendar (15-oct-1582),
@ -245,11 +243,6 @@ public class UUIDTimer {
uuidData[UUID.INDEX_CLOCK_LO + 3] = (byte) clockLo;
}
/*
* /////////////////////////////////////////////////////////// // Private
* methods ///////////////////////////////////////////////////////////
*/
private static final int MAX_WAIT_COUNT = 50;
/**

View File

@ -630,8 +630,6 @@ public class TypedProperties {
return sb.append("]").toString();
}
// Private ------------------------------------------------------------------------------------
private synchronized void doPutValue(final SimpleString key, final PropertyValue value) {
if (!internalProperties && internalPropertyPredicate != null && internalPropertyPredicate.test(key)) {
internalProperties = true;
@ -676,8 +674,6 @@ public class TypedProperties {
}
}
// Inner classes ------------------------------------------------------------------------------
private abstract static class PropertyValue {
abstract Object getValue();

View File

@ -32,8 +32,6 @@ public class ConcurrentHashSetTest extends Assert {
private String element;
// Public --------------------------------------------------------
@Test
public void testAdd() throws Exception {
Assert.assertTrue(set.add(element));
@ -114,12 +112,4 @@ public class ConcurrentHashSetTest extends Assert {
set = new ConcurrentHashSet<>();
element = RandomUtil.randomString();
}
// Package protected ---------------------------------------------
// Protected -----------------------------------------------------
// Private -------------------------------------------------------
// Inner classes -------------------------------------------------
}

View File

@ -32,8 +32,6 @@ public class TypedPropertiesConversionTest {
private final SimpleString unknownKey = new SimpleString("this.key.is.never.used");
// Public --------------------------------------------------------
@Before
public void setUp() throws Exception {
key = RandomUtil.randomSimpleString();
@ -291,12 +289,4 @@ public class TypedPropertiesConversionTest {
Assert.assertNull(props.getBytesProperty(unknownKey));
}
// Package protected ---------------------------------------------
// Protected -----------------------------------------------------
// Private -------------------------------------------------------
// Inner classes -------------------------------------------------
}

View File

@ -58,8 +58,6 @@ public class TypedPropertiesTest {
// Public --------------------------------------------------------
private TypedProperties props;
private SimpleString key;

View File

@ -316,8 +316,6 @@ public final class AddressSettingsInfo {
this.enableMetrics = enableMetrics;
}
// Public --------------------------------------------------------
public int getPageCacheMaxSize() {
return pageCacheMaxSize;
}

View File

@ -78,8 +78,6 @@ public final class DayCounterInfo {
this.counters = counters;
}
// Public --------------------------------------------------------
/**
* Returns the date of the counter.
*/

View File

@ -89,8 +89,6 @@ public final class MessageCounterInfo {
this.updateTimestamp = updateTimestamp;
}
// Public --------------------------------------------------------
/**
* Returns the name of the queue.
*/

View File

@ -73,8 +73,6 @@ public final class ObjectNameBuilder {
this.jmxUseBrokerName = jmxUseBrokerName;
}
// Public --------------------------------------------------------
/**
* Returns the ObjectName used by the single {@link ActiveMQServerControl}.
*/

View File

@ -857,18 +857,6 @@ public final class ClientConsumerImpl implements ClientConsumerInternal {
}
}
// Public
// ---------------------------------------------------------------------------------------
// Package protected
// ---------------------------------------------------------------------------------------
// Protected
// ---------------------------------------------------------------------------------------
// Private
// ---------------------------------------------------------------------------------------
/**
* Sending an initial credit for slow consumers
*/
@ -1137,9 +1125,6 @@ public final class ClientConsumerImpl implements ClientConsumerInternal {
'}';
}
// Inner classes
// --------------------------------------------------------------------------------
private class Runner implements Runnable {
@Override

View File

@ -55,8 +55,6 @@ public final class ClientLargeMessageImpl extends ClientMessageImpl implements C
super();
}
// Public --------------------------------------------------------
@Override
public int getEncodeSize() {
if (writableBuffer != null) {
@ -160,8 +158,6 @@ public final class ClientLargeMessageImpl extends ClientMessageImpl implements C
}
}
// Inner classes -------------------------------------------------
private static class ActiveMQOutputStream extends OutputStream {
private final ActiveMQBuffer bufferOut;

View File

@ -192,8 +192,6 @@ public class ClientProducerImpl implements ClientProducerInternal {
return rateLimiter == null ? -1 : rateLimiter.getRate();
}
// Public ---------------------------------------------------------------------------------------
@Override
public ClientProducerCredits getProducerCredits() {
return producerCredits;

View File

@ -1959,9 +1959,6 @@ public final class ClientSessionImpl implements ClientSessionInternal, FailureLi
connectionFailed(me, failedOver);
}
// Public
// ----------------------------------------------------------------------------
@Override
public void setForceNotSameRM(final boolean force) {
forceNotSameRM = force;

View File

@ -718,8 +718,6 @@ final class CompressedLargeMessageControllerImpl implements LargeMessageControll
throw new UnsupportedOperationException();
}
// Inner classes -------------------------------------------------
@Override
public ByteBuf byteBuf() {
return null;

View File

@ -122,8 +122,6 @@ public class LargeMessageControllerImpl implements LargeMessageController {
this.bufferSize = bufferSize;
}
// Public --------------------------------------------------------
public void setLocal(boolean local) {
this.local = local;
}

View File

@ -293,8 +293,6 @@ public class PacketImpl implements Packet {
this.type = type;
}
// Public --------------------------------------------------------
public SimpleString convertName(SimpleString name) {
if (name == null) {
return null;

View File

@ -36,8 +36,6 @@ public class ActiveMQExceptionMessage extends PacketImpl {
super(EXCEPTION);
}
// Public --------------------------------------------------------
@Override
public boolean isResponse() {
return true;

View File

@ -35,8 +35,6 @@ public class ActiveMQExceptionMessage_V2 extends ActiveMQExceptionMessage {
super();
}
// Public --------------------------------------------------------
@Override
public boolean isResponse() {
return true;

View File

@ -58,8 +58,6 @@ public class ClusterTopologyChangeMessage extends PacketImpl {
super(CLUSTER_TOPOLOGY);
}
// Public --------------------------------------------------------
/**
* @param clusterTopologyV2
*/

View File

@ -49,8 +49,6 @@ public class CreateAddressMessage extends PacketImpl {
super(CREATE_ADDRESS);
}
// Public --------------------------------------------------------
@Override
protected String getPacketString() {
StringBuffer buff = new StringBuffer(super.getPacketString());

View File

@ -59,7 +59,6 @@ public class CreateQueueMessage extends PacketImpl {
super(CREATE_QUEUE);
}
// Public --------------------------------------------------------
/**
* @param createQueueMessageV2
*/

View File

@ -188,8 +188,6 @@ public class CreateQueueMessage_V2 extends CreateQueueMessage {
super(CREATE_QUEUE_V2);
}
// Public --------------------------------------------------------
public QueueConfiguration toQueueConfiguration() {
return new QueueConfiguration(queueName)
.setAddress(address)

View File

@ -108,8 +108,6 @@ public class CreateSessionMessage extends PacketImpl {
super(type);
}
// Public --------------------------------------------------------
public String getName() {
return name;
}

View File

@ -44,8 +44,6 @@ public class CreateSessionMessage_V2 extends CreateSessionMessage {
super(CREATESESSION_V2);
}
// Public --------------------------------------------------------
public String getClientID() {
return clientID;

View File

@ -54,8 +54,6 @@ public class CreateSharedQueueMessage extends PacketImpl {
super(packetType);
}
// Public --------------------------------------------------------
@Override
protected String getPacketString() {
StringBuffer buff = new StringBuffer(super.getPacketString());

View File

@ -40,8 +40,6 @@ public class DisconnectMessage extends PacketImpl {
super(disconnectV2);
}
// Public --------------------------------------------------------
public SimpleString getNodeID() {
return nodeID;
}

View File

@ -35,8 +35,6 @@ public class DisconnectMessage_V2 extends DisconnectMessage {
super(DISCONNECT_V2);
}
// Public --------------------------------------------------------
public SimpleString getScaleDownNodeID() {
return scaleDownNodeID;
}

View File

@ -46,8 +46,6 @@ public class DisconnectMessage_V3 extends DisconnectMessage {
super(DISCONNECT_V3);
}
// Public --------------------------------------------------------
public DisconnectReason getReason() {
return reason;
}

View File

@ -32,8 +32,6 @@ public class NullResponseMessage_V2 extends NullResponseMessage {
super();
}
// Public --------------------------------------------------------
@Override
public long getCorrelationID() {
return correlationID;

View File

@ -33,8 +33,6 @@ public class PacketsConfirmedMessage extends PacketImpl {
super(PACKETS_CONFIRMED);
}
// Public --------------------------------------------------------
public int getCommandID() {
return commandID;
}

View File

@ -37,8 +37,6 @@ public class ReattachSessionResponseMessage extends PacketImpl {
super(REATTACH_SESSION_RESP);
}
// Public --------------------------------------------------------
public int getLastConfirmedCommandID() {
return lastConfirmedCommandID;
}

View File

@ -41,8 +41,6 @@ public class SessionAcknowledgeMessage extends PacketImpl {
super(SESS_ACKNOWLEDGE);
}
// Public --------------------------------------------------------
public long getConsumerID() {
return consumerID;
}

View File

@ -24,8 +24,6 @@ public class SessionCloseMessage extends PacketImpl {
super(SESS_CLOSE);
}
// Public --------------------------------------------------------
@Override
public boolean equals(final Object other) {
if (other instanceof SessionCloseMessage == false) {

View File

@ -33,8 +33,6 @@ public class SessionConsumerCloseMessage extends PacketImpl {
super(SESS_CONSUMER_CLOSE);
}
// Public --------------------------------------------------------
public long getConsumerID() {
return consumerID;
}

View File

@ -34,8 +34,6 @@ public class SessionConsumerFlowCreditMessage extends PacketImpl {
super(SESS_FLOWTOKEN);
}
// Public --------------------------------------------------------
public long getConsumerID() {
return consumerID;
}

View File

@ -41,8 +41,6 @@ public abstract class SessionContinuationMessage extends PacketImpl {
super(type);
}
// Public --------------------------------------------------------
/**
* @return the body
*/

View File

@ -39,8 +39,6 @@ public class SessionExpireMessage extends PacketImpl {
super(SESS_EXPIRED);
}
// Public --------------------------------------------------------
public long getConsumerID() {
return consumerID;
}

View File

@ -45,8 +45,6 @@ public class SessionIndividualAcknowledgeMessage extends PacketImpl {
super(SESS_INDIVIDUAL_ACKNOWLEDGE);
}
// Public --------------------------------------------------------
public long getConsumerID() {
return consumerID;
}

View File

@ -62,15 +62,11 @@ public class SessionReceiveContinuationMessage extends SessionContinuationMessag
return consumerID;
}
// Protected -----------------------------------------------------
@Override
public int expectedEncodeSize() {
return super.expectedEncodeSize() + DataConstants.SIZE_LONG;
}
// Public --------------------------------------------------------
@Override
public void encodeRest(final ActiveMQBuffer buffer) {
super.encodeRest(buffer);

View File

@ -40,8 +40,6 @@ public class SessionReceiveMessage extends MessagePacket {
super(SESS_RECEIVE_MSG, message);
}
// Public --------------------------------------------------------
public long getConsumerID() {
return consumerID;
}

View File

@ -38,8 +38,6 @@ public class SessionRequestProducerCreditsMessage extends PacketImpl {
super(SESS_PRODUCER_REQUEST_CREDITS);
}
// Public --------------------------------------------------------
public int getCredits() {
return credits;
}

View File

@ -94,8 +94,6 @@ public class SessionSendContinuationMessage extends SessionContinuationMessage {
this.messageBodySize = messageBodySize;
}
// Public --------------------------------------------------------
/**
* @return the requiresResponse
*/

View File

@ -48,8 +48,6 @@ public class SessionSendContinuationMessage_V2 extends SessionSendContinuationMe
super(message, body, continues, requiresResponse, messageBodySize, handler);
}
// Public --------------------------------------------------------
@Override
public int expectedEncodeSize() {
return super.expectedEncodeSize() + DataConstants.SIZE_LONG;

View File

@ -35,8 +35,6 @@ public class SessionSendLargeMessage extends PacketImpl implements MessagePacket
this.largeMessage = largeMessage;
}
// Public --------------------------------------------------------
public Message getLargeMessage() {
return largeMessage;
}

View File

@ -67,8 +67,6 @@ public class SessionSendMessage extends MessagePacket {
this.handler = null;
}
// Public --------------------------------------------------------
@Override
public boolean isRequiresResponse() {
return requiresResponse;

View File

@ -27,14 +27,4 @@ public class SessionUniqueAddMetaDataMessage extends SessionAddMetaDataMessageV2
super(SESS_UNIQUE_ADD_METADATA, key, data);
}
// Public --------------------------------------------------------
// Package protected ---------------------------------------------
// Protected -----------------------------------------------------
// Private -------------------------------------------------------
// Inner classes -------------------------------------------------
}

View File

@ -41,8 +41,6 @@ public class SessionXAAfterFailedMessage extends PacketImpl {
super(SESS_XA_FAILED);
}
// Public --------------------------------------------------------
public Xid getXid() {
return xid;
}

View File

@ -41,8 +41,6 @@ public class SessionXAResponseMessage extends PacketImpl {
super(SESS_XA_RESP);
}
// Public --------------------------------------------------------
@Override
public boolean isResponse() {
return true;

View File

@ -32,8 +32,6 @@ public class SessionXAResponseMessage_V2 extends SessionXAResponseMessage {
super();
}
// Public --------------------------------------------------------
@Override
public long getCorrelationID() {
return correlationID;

View File

@ -36,8 +36,6 @@ public class SessionXAResumeMessage extends PacketImpl {
super(SESS_XA_RESUME);
}
// Public --------------------------------------------------------
public Xid getXid() {
return xid;
}

View File

@ -36,8 +36,6 @@ public class SessionXARollbackMessage extends PacketImpl {
super(SESS_XA_ROLLBACK);
}
// Public --------------------------------------------------------
public Xid getXid() {
return xid;
}

View File

@ -33,8 +33,6 @@ public class SessionXASetTimeoutMessage extends PacketImpl {
super(SESS_XA_SET_TIMEOUT);
}
// Public --------------------------------------------------------
public int getTimeoutSeconds() {
return timeoutSeconds;
}

View File

@ -33,8 +33,6 @@ public class SessionXASetTimeoutResponseMessage extends PacketImpl {
super(SESS_XA_SET_TIMEOUT_RESP);
}
// Public --------------------------------------------------------
@Override
public boolean isResponse() {
return true;

View File

@ -38,8 +38,6 @@ public class SessionXAStartMessage extends PacketImpl {
super(SESS_XA_START);
}
// Public --------------------------------------------------------
public Xid getXid() {
return xid;
}

View File

@ -43,8 +43,6 @@ public class SubscribeClusterTopologyUpdatesMessage extends PacketImpl {
super(packetType);
}
// Public --------------------------------------------------------
public boolean isClusterConnection() {
return clusterConnection;
}

View File

@ -32,8 +32,6 @@ public class SubscribeClusterTopologyUpdatesMessageV2 extends SubscribeClusterTo
super(SUBSCRIBE_TOPOLOGY_V2);
}
// Public --------------------------------------------------------
@Override
public void encodeRest(final ActiveMQBuffer buffer) {
super.encodeRest(buffer);

View File

@ -301,7 +301,6 @@ public class NettyConnector extends AbstractConnector {
private final ClientProtocolManager protocolManager;
// Public --------------------------------------------------------
public NettyConnector(final Map<String, Object> configuration,
final BufferHandler handler,
final BaseConnectionLifeCycleListener<?> listener,
@ -960,8 +959,6 @@ public class NettyConnector extends AbstractConnector {
}
}
// Public --------------------------------------------------------
public int getConnectTimeoutMillis() {
return connectTimeoutMillis;
}
@ -970,14 +967,6 @@ public class NettyConnector extends AbstractConnector {
this.connectTimeoutMillis = connectTimeoutMillis;
}
// Package protected ---------------------------------------------
// Protected -----------------------------------------------------
// Private -------------------------------------------------------
// Inner classes -------------------------------------------------
private static final class ActiveMQClientChannelHandler extends ActiveMQChannelHandler {
ActiveMQClientChannelHandler(final ChannelGroup group,

View File

@ -241,7 +241,6 @@ public class SSLSupport {
return supportedSuites.delete(supportedSuites.length() - 2, supportedSuites.length()).toString();
}
// Private -------------------------------------------------------
private TrustManagerFactory loadTrustManagerFactory() throws Exception {
if (trustManagerFactoryPlugin != null) {
return AccessController.doPrivileged((PrivilegedAction<TrustManagerFactory>) () -> ((TrustManagerFactoryPlugin) ClassloadingUtil.newInstanceFromClassLoader(SSLSupport.class, trustManagerFactoryPlugin)).getTrustManagerFactory());

View File

@ -87,8 +87,6 @@ public class XidImpl implements Xid, Serializable {
globalTransactionId = copyBytes(other.getGlobalTransactionId());
}
// Xid implementation ------------------------------------------------------------------
@Override
public byte[] getBranchQualifier() {
return branchQualifier;
@ -104,8 +102,6 @@ public class XidImpl implements Xid, Serializable {
return globalTransactionId;
}
// Public -------------------------------------------------------------------------------
@Override
public int hashCode() {
if (!hashCalculated) {
@ -159,7 +155,6 @@ public class XidImpl implements Xid, Serializable {
" base64:" + toBase64String(this);
}
// Private -------------------------------------------------------------------------------
private String stringRep(final byte[] bytes) {
StringBuffer buff = new StringBuffer();

View File

@ -33,8 +33,6 @@ public class ActiveMQBufferInputStream extends InputStream {
private ActiveMQBuffer bb;
// Public --------------------------------------------------------
public ActiveMQBufferInputStream(final ActiveMQBuffer paramByteBuffer) {
bb = paramByteBuffer;
}
@ -132,12 +130,6 @@ public class ActiveMQBufferInputStream extends InputStream {
return false;
}
// Package protected ---------------------------------------------
// Protected -----------------------------------------------------
// Private -------------------------------------------------------
/**
* @return
*/
@ -145,6 +137,4 @@ public class ActiveMQBufferInputStream extends InputStream {
return bb.writerIndex() - bb.readerIndex();
}
// Inner classes -------------------------------------------------
}

View File

@ -86,14 +86,4 @@ public class JNDIUtil {
}
}
// Public --------------------------------------------------------
// Package protected ---------------------------------------------
// Protected -----------------------------------------------------
// Private -------------------------------------------------------
// Inner classes -------------------------------------------------
}

View File

@ -53,8 +53,6 @@ public class ObjectInputStreamWithClassLoader extends ObjectInputStream {
setBlackList(blackList);
}
// Public ---------------------------------------------------------------------------------------
/**
* @return the whiteList configured on this policy instance.
*/
@ -93,10 +91,6 @@ public class ObjectInputStreamWithClassLoader extends ObjectInputStream {
this.blackList = StringUtil.splitStringList(blackList, ",");
}
// Package protected ----------------------------------------------------------------------------
// Protected ------------------------------------------------------------------------------------
@Override
protected Class resolveClass(final ObjectStreamClass desc) throws IOException, ClassNotFoundException {
if (System.getSecurityManager() == null) {
@ -133,7 +127,6 @@ public class ObjectInputStreamWithClassLoader extends ObjectInputStream {
}
}
// Private --------------------------------------------------------------------------------------
private Class resolveClass0(final ObjectStreamClass desc) throws IOException, ClassNotFoundException {
String name = desc.getName();
@ -268,6 +261,4 @@ public class ObjectInputStreamWithClassLoader extends ObjectInputStream {
return false;
}
// Inner classes --------------------------------------------------------------------------------
}

View File

@ -40,15 +40,4 @@ public class SizeFormatterUtil {
}
return String.format("%.2f %s", s, suffix);
}
// Public --------------------------------------------------------
// Package protected ---------------------------------------------
// Protected -----------------------------------------------------
// Private -------------------------------------------------------
// Inner classes -------------------------------------------------
}

View File

@ -57,8 +57,6 @@ public class SoftValueLongObjectHashMap<V extends SoftValueLongObjectHashMap.Val
this.maxElements = maxElements;
}
// Public --------------------------------------------------------
public void setMaxElements(final int maxElements) {
this.maxElements = maxElements;
checkCacheSize();
@ -332,12 +330,6 @@ public class SoftValueLongObjectHashMap<V extends SoftValueLongObjectHashMap.Val
return mapDelegate.hashCode();
}
// Package protected ---------------------------------------------
// Protected -----------------------------------------------------
// Private -------------------------------------------------------
@SuppressWarnings("unchecked")
private void processQueue() {
AggregatedSoftReference ref;
@ -351,8 +343,6 @@ public class SoftValueLongObjectHashMap<V extends SoftValueLongObjectHashMap.Val
return new AggregatedSoftReference(key, value, refQueue);
}
// Inner classes -------------------------------------------------
static final class AggregatedSoftReference<V> extends SoftReference<V> {
final long key;

View File

@ -52,9 +52,7 @@ public class TimeAndCounterIDGenerator implements IDGenerator {
refresh();
}
// Public --------------------------------------------------------
// Public --------------------------------------------------------
@Override
public long generateID() {
@ -132,12 +130,6 @@ public class TimeAndCounterIDGenerator implements IDGenerator {
")";
}
// Package protected ---------------------------------------------
// Protected -----------------------------------------------------
// Private -------------------------------------------------------
private long newTM() {
return (System.currentTimeMillis() & TimeAndCounterIDGenerator.MASK_TIME) << TimeAndCounterIDGenerator.BITS_TO_MOVE;
}

View File

@ -392,6 +392,4 @@ public final class XMLUtil {
});
}
// Inner classes --------------------------------------------------------------------------------
}

View File

@ -45,14 +45,4 @@ public class XidCodecSupport {
return DataConstants.SIZE_INT * 3 + xid.getBranchQualifier().length + xid.getGlobalTransactionId().length;
}
// Public --------------------------------------------------------
// Package protected ---------------------------------------------
// Protected -----------------------------------------------------
// Private -------------------------------------------------------
// Inner classes -------------------------------------------------
}

View File

@ -26,8 +26,6 @@ import org.junit.Test;
public class TimeAndCounterIDGeneratorTest extends Assert {
// Public --------------------------------------------------------
@Test
public void testCalculation() {
TimeAndCounterIDGenerator seq = new TimeAndCounterIDGenerator();

View File

@ -27,8 +27,6 @@ import org.w3c.dom.NodeList;
public class XMLUtilTest extends SilentTestCase {
// Public --------------------------------------------------------
@Test
public void testGetTextContext_1() throws Exception {
String document = "<blah>foo</blah>";

View File

@ -349,7 +349,6 @@ public class ActiveMQBytesMessage extends ActiveMQMessage implements BytesMessag
reset();
}
// Public --------------------------------------------------------
@Override
public byte getType() {

View File

@ -498,8 +498,6 @@ public class ActiveMQConnection extends ActiveMQConnectionForContextImpl impleme
return null; // we offer RA
}
// Public ---------------------------------------------------------------------------------------
/**
* Sets a FailureListener for the session which is notified if a failure occurs on the session.
*
@ -559,12 +557,6 @@ public class ActiveMQConnection extends ActiveMQConnectionForContextImpl impleme
return initialSession;
}
// Package protected ----------------------------------------------------------------------------
// Protected ------------------------------------------------------------------------------------
// In case the user forgets to close the connection manually
@Override
protected final void finalize() throws Throwable {
if (!closed) {
@ -634,7 +626,6 @@ public class ActiveMQConnection extends ActiveMQConnectionForContextImpl impleme
return sessionFactory;
}
// Private --------------------------------------------------------------------------------------
/**
* @param transacted
@ -710,8 +701,6 @@ public class ActiveMQConnection extends ActiveMQConnectionForContextImpl impleme
}
// Inner classes --------------------------------------------------------------------------------
private static class JMSFailureListener implements SessionFailureListener {
private final WeakReference<ActiveMQConnection> connectionRef;

View File

@ -868,10 +868,6 @@ public class ActiveMQConnectionFactory extends JNDIStorable implements Connectio
return JMSFactoryType.CF.intValue();
}
// Package protected ----------------------------------------------------------------------------
// Protected ------------------------------------------------------------------------------------
protected synchronized ActiveMQConnection createConnectionInternal(final String username,
final String password,
final boolean isXA,
@ -947,7 +943,6 @@ public class ActiveMQConnectionFactory extends JNDIStorable implements Connectio
"]";
}
// Private --------------------------------------------------------------------------------------
private void checkWrite() {
if (readOnly) {

View File

@ -425,7 +425,6 @@ public class ActiveMQDestination extends JNDIStorable implements Destination, Se
return queue;
}
// Public --------------------------------------------------------
public String getAddress() {
return simpleAddress != null ? simpleAddress.toString() : null;
@ -509,14 +508,6 @@ public class ActiveMQDestination extends JNDIStorable implements Destination, Se
props.put("address", getAddress());
}
// Package protected ---------------------------------------------
// Protected -----------------------------------------------------
// Private -------------------------------------------------------
// Inner classes -------------------------------------------------
public enum TYPE {
QUEUE,
TOPIC,

View File

@ -84,7 +84,6 @@ public class ActiveMQMapMessage extends ActiveMQMessage implements MapMessage {
}
}
// Public --------------------------------------------------------
@Override
public byte getType() {
@ -330,11 +329,8 @@ public class ActiveMQMapMessage extends ActiveMQMessage implements MapMessage {
readBodyMap(message.getBodyBuffer(), map);
}
// Package protected ---------------------------------------------
// Protected -----------------------------------------------------
// Private -------------------------------------------------------
/**
* Check the name

View File

@ -767,7 +767,6 @@ public class ActiveMQMessage implements javax.jms.Message {
return message.getBodySize() == 0;
}
// Public --------------------------------------------------------
public void setIndividualAcknowledge() {
this.individualAck = true;
@ -861,9 +860,7 @@ public class ActiveMQMessage implements javax.jms.Message {
return sb.toString();
}
// Package protected ---------------------------------------------
// Protected -----------------------------------------------------
protected void checkWrite() throws JMSException {
if (readOnly) {
@ -877,8 +874,6 @@ public class ActiveMQMessage implements javax.jms.Message {
}
}
// Private ------------------------------------------------------------
private void checkStream() throws JMSException {
if (!(message.getType() == ActiveMQBytesMessage.TYPE || message.getType() == ActiveMQStreamMessage.TYPE)) {
throw ActiveMQJMSClientBundle.BUNDLE.onlyValidForByteOrStreamMessages();
@ -944,5 +939,4 @@ public class ActiveMQMessage implements javax.jms.Message {
}
}
// Inner classes -------------------------------------------------
}

View File

@ -180,7 +180,6 @@ public final class ActiveMQMessageConsumer implements QueueReceiver, TopicSubscr
return noLocal;
}
// Public --------------------------------------------------------
@Override
public String toString() {
@ -191,11 +190,8 @@ public final class ActiveMQMessageConsumer implements QueueReceiver, TopicSubscr
return consumer.isClosed();
}
// Package protected ---------------------------------------------
// Protected -----------------------------------------------------
// Private -------------------------------------------------------
private void checkClosed() throws JMSException {
if (consumer.isClosed() || session.getCoreSession().isClosed()) {
@ -265,6 +261,4 @@ public final class ActiveMQMessageConsumer implements QueueReceiver, TopicSubscr
}
}
// Inner classes -------------------------------------------------
}

View File

@ -325,7 +325,6 @@ public class ActiveMQMessageProducer implements MessageProducer, QueueSender, To
return (Queue) getDestination();
}
// Public --------------------------------------------------------
@Override
public String toString() {

View File

@ -73,7 +73,6 @@ public class ActiveMQObjectMessage extends ActiveMQMessage implements ObjectMess
this.options = options;
}
// Public --------------------------------------------------------
@Override
public byte getType() {

View File

@ -63,7 +63,6 @@ public class ActiveMQQueue extends ActiveMQDestination implements Queue {
// Queue implementation ------------------------------------------
// Public --------------------------------------------------------
@Override
public String getQueueName() {
@ -95,11 +94,5 @@ public class ActiveMQQueue extends ActiveMQDestination implements Queue {
return super.getAddress().hashCode();
}
// Package protected ---------------------------------------------
// Protected -----------------------------------------------------
// Private -------------------------------------------------------
// Inner classes -------------------------------------------------
}

View File

@ -101,21 +101,12 @@ public final class ActiveMQQueueBrowser implements QueueBrowser {
return queue;
}
// Public ---------------------------------------------------------------------------------------
@Override
public String toString() {
return "ActiveMQQueueBrowser->" + consumer;
}
// Package protected ----------------------------------------------------------------------------
// Protected ------------------------------------------------------------------------------------
// Private --------------------------------------------------------------------------------------
// Inner classes --------------------------------------------------------------------------------
private final class BrowserEnumeration implements Enumeration<ActiveMQMessage> {
ClientMessage current = null;

View File

@ -1138,7 +1138,6 @@ public class ActiveMQSession implements QueueSession, TopicSession {
return (TopicSession) getSession();
}
// Public --------------------------------------------------------
@Override
public String toString() {
@ -1236,8 +1235,6 @@ public class ActiveMQSession implements QueueSession, TopicSession {
return enable1xPrefixes;
}
// Package protected ---------------------------------------------
void deleteQueue(final SimpleString queueName) throws JMSException {
if (!session.isClosed()) {
try {
@ -1252,8 +1249,6 @@ public class ActiveMQSession implements QueueSession, TopicSession {
return connection;
}
// Protected -----------------------------------------------------
void checkClosed() throws JMSException {
if (session.isClosed()) {
@ -1279,7 +1274,6 @@ public class ActiveMQSession implements QueueSession, TopicSession {
session.createQueue(queueConfiguration.setName(queueName).setAddress(destination.getAddress()).setAutoCreated(autoCreated).setDurable(durable));
}
// Private -------------------------------------------------------
private ActiveMQQueue lookupQueue(final String queueName, boolean isTemporary) throws ActiveMQException {
@ -1336,6 +1330,5 @@ public class ActiveMQSession implements QueueSession, TopicSession {
return topic;
}
}
// Inner classes -------------------------------------------------
}

View File

@ -76,7 +76,6 @@ public class ActiveMQStreamMessage extends ActiveMQMessage implements StreamMess
message = new ClientMessageImpl((byte) 0, false, 0, 0, (byte) 4, 1500, null);
}
// Public --------------------------------------------------------
@Override
public byte getType() {

View File

@ -31,7 +31,6 @@ public class ActiveMQTemporaryQueue extends ActiveMQQueue implements TemporaryQu
// TemporaryQueue implementation ------------------------------------------
// Public --------------------------------------------------------
public ActiveMQTemporaryQueue() {
this(null, null);
}
@ -69,11 +68,5 @@ public class ActiveMQTemporaryQueue extends ActiveMQQueue implements TemporaryQu
return super.getAddress().hashCode();
}
// Package protected ---------------------------------------------
// Protected -----------------------------------------------------
// Private -------------------------------------------------------
// Inner classes -------------------------------------------------
}

View File

@ -32,7 +32,6 @@ public class ActiveMQTemporaryTopic extends ActiveMQTopic implements TemporaryTo
super(address, true, session);
}
// Public --------------------------------------------------------
@Override
public boolean equals(final Object o) {
@ -54,12 +53,4 @@ public class ActiveMQTemporaryTopic extends ActiveMQTopic implements TemporaryTo
return super.getAddress().hashCode();
}
// Package protected ---------------------------------------------
// Protected -----------------------------------------------------
// Private -------------------------------------------------------
// Inner classes -------------------------------------------------
}

View File

@ -60,7 +60,6 @@ public class ActiveMQTextMessage extends ActiveMQMessage implements TextMessage
setText(foreign.getText());
}
// Public --------------------------------------------------------
@Override
public byte getType() {

View File

@ -67,7 +67,6 @@ public class ActiveMQTopic extends ActiveMQDestination implements Topic {
return getName();
}
// Public --------------------------------------------------------
@Override
public String toString() {
@ -94,11 +93,5 @@ public class ActiveMQTopic extends ActiveMQDestination implements Topic {
return super.getAddress().hashCode();
}
// Package protected ---------------------------------------------
// Protected -----------------------------------------------------
// Private -------------------------------------------------------
// Inner classes -------------------------------------------------
}

View File

@ -32,7 +32,6 @@ public class JMSBridgeControlImpl extends StandardMBean implements JMSBridgeCont
this.bridge = bridge;
}
// Public --------------------------------------------------------
@Override
public void pause() throws Exception {
@ -207,12 +206,4 @@ public class JMSBridgeControlImpl extends StandardMBean implements JMSBridgeCont
}
// Package protected ---------------------------------------------
// Protected -----------------------------------------------------
// Private -------------------------------------------------------
// Inner classes -------------------------------------------------
}

View File

@ -940,10 +940,6 @@ public final class JMSBridgeImpl implements JMSBridge {
this.tm = tm;
}
// Public ---------------------------------------------------------------------------
// Private -------------------------------------------------------------------
private synchronized void checkParams() {
checkNotNull(sourceCff, "sourceCff");
checkNotNull(targetCff, "targetCff");
@ -1747,8 +1743,6 @@ public final class JMSBridgeImpl implements JMSBridge {
return service;
}
// Inner classes ---------------------------------------------------------------
/**
* We use a Thread which polls the sourceDestination instead of a MessageListener
* to ensure that message delivery does not happen concurrently with

View File

@ -49,7 +49,6 @@ public class PersistedBindings implements EncodingSupport {
this.name = name;
}
// Public --------------------------------------------------------
@Override
public void decode(ActiveMQBuffer buffer) {
type = PersistedType.getType(buffer.readByte());
@ -132,12 +131,4 @@ public class PersistedBindings implements EncodingSupport {
bindings.remove(address);
}
// Package protected ---------------------------------------------
// Protected -----------------------------------------------------
// Private -------------------------------------------------------
// Inner classes -------------------------------------------------
}

View File

@ -41,7 +41,6 @@ public class PersistedConnectionFactory implements EncodingSupport {
}
// Public --------------------------------------------------------
/**
* @return the id
@ -81,12 +80,4 @@ public class PersistedConnectionFactory implements EncodingSupport {
return config.getEncodeSize();
}
// Package protected ---------------------------------------------
// Protected -----------------------------------------------------
// Private -------------------------------------------------------
// Inner classes -------------------------------------------------
}

View File

@ -51,15 +51,6 @@ public class PersistedDestination implements EncodingSupport {
this.selector = selector;
this.durable = durable;
}
// Public --------------------------------------------------------
// Package protected ---------------------------------------------
// Protected -----------------------------------------------------
// Private -------------------------------------------------------
// Inner classes -------------------------------------------------
public long getId() {
return id;

View File

@ -98,7 +98,6 @@ public final class JMSJournalStorageManagerImpl implements JMSStorageManager {
this.idGenerator = idGenerator;
}
// Public --------------------------------------------------------
@Override
public List<PersistedConnectionFactory> recoverConnectionFactories() {
List<PersistedConnectionFactory> cfs = new ArrayList<>(mapFactories.values());
@ -277,11 +276,8 @@ public final class JMSJournalStorageManagerImpl implements JMSStorageManager {
}
// Package protected ---------------------------------------------
// Protected -----------------------------------------------------
// Private -------------------------------------------------------
private void checkAndCreateDir(final File dir, final boolean create) {
@ -296,6 +292,5 @@ public final class JMSJournalStorageManagerImpl implements JMSStorageManager {
}
}
// Inner classes -------------------------------------------------
}

View File

@ -949,14 +949,5 @@ public class ConnectionFactoryConfigurationImpl implements ConnectionFactoryConf
return useTopologyForLoadBalancing;
}
// Public --------------------------------------------------------
// Package protected ---------------------------------------------
// Protected -----------------------------------------------------
// Private -------------------------------------------------------
// Inner classes -------------------------------------------------
}

View File

@ -79,14 +79,5 @@ public class JMSQueueConfigurationImpl implements JMSQueueConfiguration {
return this;
}
// Public --------------------------------------------------------
// Package protected ---------------------------------------------
// Protected -----------------------------------------------------
// Private -------------------------------------------------------
// Inner classes -------------------------------------------------
}

View File

@ -52,14 +52,5 @@ public class TopicConfigurationImpl implements TopicConfiguration {
return this;
}
// Public --------------------------------------------------------
// Package protected ---------------------------------------------
// Protected -----------------------------------------------------
// Private -------------------------------------------------------
// Inner classes -------------------------------------------------
}

View File

@ -112,14 +112,5 @@ public class TransportConfigurationEncodingSupport {
}
// Public --------------------------------------------------------
// Package protected ---------------------------------------------
// Protected -----------------------------------------------------
// Private -------------------------------------------------------
// Inner classes -------------------------------------------------
}

Some files were not shown because too many files have changed in this diff Show More