Apache
/
activemq-artemis
mirror of https://github.com/apache/activemq-artemis.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

ARTEMIS-4752 upgrade ErrorProne to 2.27.0 

The upgraded ErrorProne found some new issues so this commit fixes those
as well.
This commit is contained in:
Justin Bertram 2024-05-01 14:40:57 -05:00 committed by Robbie Gemmell
parent 14e83faa1b
commit 8b73335b46
4 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pom.xml
View File

@ -105,7 +105,7 @@
<jetty.version>10.0.20</jetty.version>
<jetty-servlet-api.version>4.0.6</jetty-servlet-api.version>
<jgroups.version>5.3.4.Final</jgroups.version>
<errorprone.version>2.24.1</errorprone.version>
<errorprone.version>2.27.0</errorprone.version>
<maven.bundle.plugin.version>5.1.9</maven.bundle.plugin.version>
<jib.maven.plugin.version>3.3.2</jib.maven.plugin.version>
<versions.maven.plugin.version>2.16.1</versions.maven.plugin.version>

8
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/ActiveMQServerControlTest.java
View File

@ -2620,7 +2620,7 @@ public class ActiveMQServerControlTest extends ManagementTestBase {
second = array.getJsonObject(0);
}
Assert.assertNotNull(first.getJsonNumber(ConsumerField.ID.getAlternativeName()).longValue());
Assert.assertNotNull(first.getJsonNumber(ConsumerField.ID.getAlternativeName()));
Assert.assertTrue(first.getString(ConsumerField.CONNECTION.getAlternativeName()).length() > 0);
Assert.assertEquals(factory.getConnection().getID().toString(), first.getString(ConsumerField.CONNECTION.getAlternativeName()));
Assert.assertTrue(first.getString(ConsumerField.SESSION.getAlternativeName()).length() > 0);
@ -2633,7 +2633,7 @@ public class ActiveMQServerControlTest extends ManagementTestBase {
// test the old version that has been replaced for backward compatibility
Assert.assertEquals(0, first.getJsonNumber(ConsumerField.MESSAGES_IN_TRANSIT.getAlternativeName()).longValue());
Assert.assertNotNull(second.getJsonNumber(ConsumerField.ID.getAlternativeName()).longValue());
Assert.assertNotNull(second.getJsonNumber(ConsumerField.ID.getAlternativeName()));
Assert.assertTrue(second.getString(ConsumerField.CONNECTION.getAlternativeName()).length() > 0);
Assert.assertEquals(factory.getConnection().getID().toString(), second.getString(ConsumerField.CONNECTION.getAlternativeName()));
Assert.assertTrue(second.getString(ConsumerField.SESSION.getAlternativeName()).length() > 0);
@ -2704,7 +2704,7 @@ public class ActiveMQServerControlTest extends ManagementTestBase {
JsonObject second = sorted[1];
Assert.assertTrue(first.getJsonNumber(ConsumerField.CREATION_TIME.getName()).longValue() > 0);
Assert.assertNotNull(first.getJsonNumber(ConsumerField.ID.getAlternativeName()).longValue());
Assert.assertNotNull(first.getJsonNumber(ConsumerField.ID.getAlternativeName()));
Assert.assertTrue(first.getString(ConsumerField.CONNECTION.getAlternativeName()).length() > 0);
Assert.assertEquals(factory.getConnection().getID().toString(), first.getString(ConsumerField.CONNECTION.getAlternativeName()));
Assert.assertTrue(first.getString(ConsumerField.SESSION.getAlternativeName()).length() > 0);
@ -2719,7 +2719,7 @@ public class ActiveMQServerControlTest extends ManagementTestBase {
Assert.assertEquals(0, first.getJsonNumber(ConsumerField.LAST_ACKNOWLEDGED_TIME.getName()).longValue());
Assert.assertTrue(second.getJsonNumber(ConsumerField.CREATION_TIME.getName()).longValue() > 0);
Assert.assertNotNull(second.getJsonNumber(ConsumerField.ID.getAlternativeName()).longValue());
Assert.assertNotNull(second.getJsonNumber(ConsumerField.ID.getAlternativeName()));
Assert.assertTrue(second.getString(ConsumerField.CONNECTION.getAlternativeName()).length() > 0);
Assert.assertEquals(factory2.getConnection().getID().toString(), second.getString(ConsumerField.CONNECTION.getAlternativeName()));
Assert.assertTrue(second.getString(ConsumerField.SESSION.getAlternativeName()).length() > 0);

4
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/server/ConfigurationTest.java
View File

@ -127,8 +127,8 @@ public class ConfigurationTest extends ActiveMQTestBase {
Assert.assertTrue(server.getActiveMQServerControl().getStatus().contains("2"));
// verify some server attributes
Assert.assertNotNull(server.getActiveMQServerControl().getStatus().contains("version"));
Assert.assertNotNull(server.getActiveMQServerControl().getStatus().contains("uptime"));
Assert.assertTrue(server.getActiveMQServerControl().getStatus().contains("version"));
Assert.assertTrue(server.getActiveMQServerControl().getStatus().contains("uptime"));
} finally {
try {

6
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/stomp/StompWithLargeMessagesTest.java
View File

@ -143,7 +143,7 @@ public class StompWithLargeMessagesTest extends StompTestBase {
unsubFrame.addHeader("receipt", "567");
ClientStompFrame response = conn.sendFrame(unsubFrame);
assertNotNull(response);
assertNotNull(response.getCommand().equals("RECEIPT"));
assertTrue(response.getCommand().equals("RECEIPT"));
conn.disconnect();
}
@ -186,7 +186,7 @@ public class StompWithLargeMessagesTest extends StompTestBase {
unsubFrame.addHeader("receipt", "567");
ClientStompFrame response = conn.sendFrame(unsubFrame);
assertNotNull(response);
assertNotNull(response.getCommand().equals("RECEIPT"));
assertTrue(response.getCommand().equals("RECEIPT"));
conn.disconnect();
}
@ -324,7 +324,7 @@ public class StompWithLargeMessagesTest extends StompTestBase {
unsubFrame.addHeader("receipt", "567");
ClientStompFrame response = conn.sendFrame(unsubFrame);
assertNotNull(response);
assertNotNull(response.getCommand().equals("RECEIPT"));
assertTrue(response.getCommand().equals("RECEIPT"));
conn.disconnect();
}