ARTEMIS-209 fix keepAlive

artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConnection.java

@@ -201,11 +201,12 @@ public class OpenWireConnection implements RemotingConnection, CommandVisitor {
          // the connection handles pings, negotiations directly.
          // and delegate all other commands to manager.
          if (command.getClass() == KeepAliveInfo.class) {
+            dataReceived = true;
             KeepAliveInfo info = (KeepAliveInfo) command;
-            if (info.isResponseRequired()) {
-               info.setResponseRequired(false);
-               protocolManager.sendReply(this, info);
-            }
+            info.setResponseRequired(false);
+            // if we don't respond to KeepAlive commands then the client will think the server is dead and timeout
+            // for some reason KeepAliveInfo.isResponseRequired() is always false
+            protocolManager.sendReply(this, info);
          }
          else if (command.getClass() == WireFormatInfo.class) {
             // amq here starts a read/write monitor thread (detect ttl?)

tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/SimpleOpenWireTest.java

@@ -87,6 +87,16 @@ public class SimpleOpenWireTest extends BasicOpenWireTest {
       session.close();
    }
 
+
+   @Test
+   public void testKeepAlive() throws Exception {
+      connection.start();
+
+      Thread.sleep(125000);
+
+      connection.createSession(false, 1);
+   }
+
    @Test
    public void testSimpleTopic() throws Exception {
       connection.start();