ARTEMIS-493 - NullPointerException when trying a null connection remote properties are passed by client

adde a check and fixed a couple of other potential NPE's

https://issues.apache.org/jira/browse/ARTEMIS-493

artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/proton/plug/ProtonSessionIntegrationCallback.java

@@ -242,23 +242,29 @@ public class ProtonSessionIntegrationCallback implements AMQPSessionCallback, Se
 
    @Override
    public void rollbackCurrentTX() throws Exception {
-      recoverContext();
+      //need to check here as this can be called if init fails
-      try {
+      if (serverSession != null) {
-         serverSession.rollback(false);
+         recoverContext();
-      }
+         try {
-      finally {
+            serverSession.rollback(false);
-         resetContext();
+         }
+         finally {
+            resetContext();
+         }
       }
    }
 
    @Override
    public void close() throws Exception {
-      recoverContext();
+      //need to check here as this can be called if init fails
-      try {
+      if (serverSession != null) {
-         serverSession.close(false);
+         recoverContext();
-      }
+         try {
-      finally {
+            serverSession.close(false);
-         resetContext();
+         }
+         finally {
+            resetContext();
+         }
       }
    }
 

artemis-protocols/artemis-proton-plug/src/main/java/org/proton/plug/context/AbstractConnectionContext.java

@@ -182,7 +182,11 @@ public abstract class AbstractConnectionContext extends ProtonInitializable impl
             connection.open();
          }
          initialise();
-         if (!connection.getRemoteProperties().containsKey(CONNECTION_OPEN_FAILED)) {
+         /*
+         * This can be null which is in effect an empty map, also we really dont need to check this for in bound connections
+         * but its here in case we add support for outbound connections.
+         * */
+         if (connection.getRemoteProperties() == null || !connection.getRemoteProperties().containsKey(CONNECTION_OPEN_FAILED)) {
             long nextKeepAliveTime = handler.tick(true);
             flushBytes();
             if (nextKeepAliveTime > 0 && scheduledPool != null) {