ARTEMIS-1532 Use @Ignore annotation to disable tests

This commit is contained in:
Jiri Danek 2017-12-03 23:51:01 +01:00 committed by Clebert Suconic
parent 62280c88dc
commit b17cec0a5e
6 changed files with 27 additions and 12 deletions

View File

@ -44,6 +44,7 @@ import org.apache.activemq.artemis.tests.integration.IntegrationTestLogger;
import org.apache.activemq.artemis.tests.util.ActiveMQTestBase; import org.apache.activemq.artemis.tests.util.ActiveMQTestBase;
import org.junit.Assert; import org.junit.Assert;
import org.junit.Before; import org.junit.Before;
import org.junit.Ignore;
import org.junit.Test; import org.junit.Test;
public class ConsumerWindowSizeTest extends ActiveMQTestBase { public class ConsumerWindowSizeTest extends ActiveMQTestBase {
@ -542,8 +543,9 @@ public class ConsumerWindowSizeTest extends ActiveMQTestBase {
internalTestSlowConsumerNoBuffer(false); internalTestSlowConsumerNoBuffer(false);
} }
// I believe this test became invalid after we started using another thread to deliver the large message @Test
public void disabled_testSlowConsumerNoBufferLargeMessages() throws Exception { @Ignore("I believe this test became invalid after we started using another thread to deliver the large message")
public void testSlowConsumerNoBufferLargeMessages() throws Exception {
internalTestSlowConsumerNoBuffer(true); internalTestSlowConsumerNoBuffer(true);
} }
@ -559,13 +561,12 @@ public class ConsumerWindowSizeTest extends ActiveMQTestBase {
server.start(); server.start();
locator.setConsumerWindowSize(0); locator.setConsumerWindowSize(0);
if (largeMessages) {
locator.setMinLargeMessageSize(100);
}
ClientSessionFactory sf = createSessionFactory(locator); ClientSessionFactory sf = createSessionFactory(locator);
if (largeMessages) {
sf.getServerLocator().setMinLargeMessageSize(100);
}
session = sf.createSession(false, true, true); session = sf.createSession(false, true, true);
SimpleString ADDRESS = addressA; SimpleString ADDRESS = addressA;

View File

@ -18,6 +18,7 @@ package org.apache.activemq.artemis.tests.integration.cluster.distribution;
import org.apache.activemq.artemis.core.server.cluster.impl.MessageLoadBalancingType; import org.apache.activemq.artemis.core.server.cluster.impl.MessageLoadBalancingType;
import org.junit.Before; import org.junit.Before;
import org.junit.Ignore;
import org.junit.Test; import org.junit.Test;
public class ClusteredRequestResponseTest extends ClusterTestBase { public class ClusteredRequestResponseTest extends ClusterTestBase {
@ -83,7 +84,9 @@ public class ClusteredRequestResponseTest extends ClusterTestBase {
* *
* TODO: I believe this test is invalid. I'm just ignoring it for now. It will probably go away * TODO: I believe this test is invalid. I'm just ignoring it for now. It will probably go away
*/ */
public void invalidTest_testRequestResponseNoWaitForBindings() throws Exception { @Test
@Ignore
public void testRequestResponseNoWaitForBindings() throws Exception {
setupCluster(); setupCluster();
startServers(0, 1, 2, 3, 4); startServers(0, 1, 2, 3, 4);

View File

@ -29,6 +29,7 @@ import org.apache.activemq.artemis.api.core.client.ActiveMQClient;
import org.apache.activemq.artemis.api.jms.JMSFactoryType; import org.apache.activemq.artemis.api.jms.JMSFactoryType;
import org.apache.activemq.artemis.tests.util.JMSTestBase; import org.apache.activemq.artemis.tests.util.JMSTestBase;
import org.junit.Before; import org.junit.Before;
import org.junit.Ignore;
import org.junit.Test; import org.junit.Test;
public class PreACKJMSTest extends JMSTestBase { public class PreACKJMSTest extends JMSTestBase {
@ -95,7 +96,9 @@ public class PreACKJMSTest extends JMSTestBase {
assertNull("ConnectionFactory is on PreACK mode, the message shouldn't be received", msg2); assertNull("ConnectionFactory is on PreACK mode, the message shouldn't be received", msg2);
} }
public void disabled_testPreACKTransactional() throws Exception { @Test
@Ignore
public void testPreACKTransactional() throws Exception {
conn = cf.createConnection(); conn = cf.createConnection();
Session sess = conn.createSession(true, Session.SESSION_TRANSACTED); Session sess = conn.createSession(true, Session.SESSION_TRANSACTED);

View File

@ -72,6 +72,7 @@ import org.apache.activemq.command.ActiveMQQueue;
import org.apache.activemq.command.ActiveMQTopic; import org.apache.activemq.command.ActiveMQTopic;
import org.junit.Assert; import org.junit.Assert;
import org.junit.Before; import org.junit.Before;
import org.junit.Ignore;
import org.junit.Test; import org.junit.Test;
public class SimpleOpenWireTest extends BasicOpenWireTest { public class SimpleOpenWireTest extends BasicOpenWireTest {
@ -526,7 +527,8 @@ public class SimpleOpenWireTest extends BasicOpenWireTest {
} }
} }
// @Test -- ignored for now @Test
@Ignore("ignored for now")
public void testKeepAlive() throws Exception { public void testKeepAlive() throws Exception {
connection.start(); connection.start();

View File

@ -62,6 +62,7 @@ import org.apache.activemq.artemis.tests.util.ActiveMQTestBase;
import org.apache.activemq.artemis.tests.util.CreateMessage; import org.apache.activemq.artemis.tests.util.CreateMessage;
import org.junit.Assert; import org.junit.Assert;
import org.junit.Before; import org.junit.Before;
import org.junit.Ignore;
import org.junit.Test; import org.junit.Test;
public class SecurityTest extends ActiveMQTestBase { public class SecurityTest extends ActiveMQTestBase {
@ -1605,7 +1606,9 @@ public class SecurityTest extends ActiveMQTestBase {
} }
public void _testComplexRoles2() throws Exception { @Test
@Ignore
public void testComplexRoles2() throws Exception {
ActiveMQServer server = createServer(); ActiveMQServer server = createServer();
server.start(); server.start();
ActiveMQJAASSecurityManager securityManager = (ActiveMQJAASSecurityManager) server.getSecurityManager(); ActiveMQJAASSecurityManager securityManager = (ActiveMQJAASSecurityManager) server.getSecurityManager();
@ -1645,8 +1648,8 @@ public class SecurityTest extends ActiveMQTestBase {
ClientSession andrewConnection = null; ClientSession andrewConnection = null;
ClientSession frankConnection = null; ClientSession frankConnection = null;
ClientSession samConnection = null; ClientSession samConnection = null;
locator.setBlockOnNonDurableSend(true).setBlockOnDurableSend(true);
ClientSessionFactory factory = createSessionFactory(locator); ClientSessionFactory factory = createSessionFactory(locator);
factory.getServerLocator().setBlockOnNonDurableSend(true).setBlockOnDurableSend(true);
ClientSession adminSession = factory.createSession("all", "all", false, true, true, false, -1); ClientSession adminSession = factory.createSession("all", "all", false, true, true, false, -1);
String genericQueueName = "genericQueue"; String genericQueueName = "genericQueue";

View File

@ -33,6 +33,7 @@ import org.apache.activemq.artemis.jms.tests.ActiveMQServerTestCase;
import org.apache.activemq.artemis.jms.tests.util.ProxyAssertSupport; import org.apache.activemq.artemis.jms.tests.util.ProxyAssertSupport;
import org.apache.activemq.artemis.tests.util.ActiveMQTestBase; import org.apache.activemq.artemis.tests.util.ActiveMQTestBase;
import org.junit.Assert; import org.junit.Assert;
import org.junit.Ignore;
import org.junit.Test; import org.junit.Test;
import static org.junit.Assert.assertNotNull; import static org.junit.Assert.assertNotNull;
@ -883,7 +884,9 @@ public class SelectorTest extends ActiveMQServerTestCase {
// Test case proposed by a customer on this user forum: // Test case proposed by a customer on this user forum:
// http://community.jboss.org/thread/153426?tstart=0 // http://community.jboss.org/thread/153426?tstart=0
// This test needs to be moved away // This test needs to be moved away
public void disabled_testMultipleConsumers() throws Exception { @Test
@Ignore
public void testMultipleConsumers() throws Exception {
Connection conn = null; Connection conn = null;
try { try {