ARTEMIS-4980: move sources jar creation to typical package phase, isolate to release profiles

This commit is contained in:
Robbie Gemmell 2024-08-08 15:30:11 +01:00
parent 3f32e53dc6
commit b59dc42410
4 changed files with 74 additions and 112 deletions

View File

@ -38,44 +38,30 @@
<build>
<pluginManagement>
<plugins>
<!-- Override root pom definition, so as to ensure the shading has a fresh base sources jar
for the module before shading, with nothing much in it, and doesnt instead grab a large
already-shaded remote snapshot, possibly each day (local) or on every build (CI) -->
<!-- Ensure the shading has a fresh base sources jar for the module before shading,
with nothing much in it, and doesnt instead grab a large already-shaded remote
snapshot, possibly each day (local) or on every build (CI) -->
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-source-plugin</artifactId>
<executions>
<execution>
<id>attach-sources</id>
<phase>package</phase>
<goals>
<goal>jar-no-fork</goal>
</goals>
<configuration>
<forceCreation>true</forceCreation>
</configuration>
</execution>
</executions>
<configuration>
<forceCreation>true</forceCreation>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
<configuration>
<!-- Ensures the shading is always working upon a fresh base jar, which has
nothing much in it, rather than potentially working on already-shaded
output still present from prior runs and renamed to have the base name -->
<forceCreation>true</forceCreation>
</configuration>
</plugin>
</plugins>
</pluginManagement>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
<executions>
<execution>
<id>default-jar</id>
<configuration>
<!-- Ensures the shading is always working upon a fresh base jar, which has
nothing much in it, rather than potentially working on already-shaded
output still present from prior runs and renamed to have the base name -->
<forceCreation>true</forceCreation>
</configuration>
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-shade-plugin</artifactId>
@ -86,7 +72,7 @@
<goal>shade</goal>
</goals>
<configuration>
<createSourcesJar>true</createSourcesJar>
<createSourcesJar>${shade-plugin-create-sources}</createSourcesJar>
<shadeSourcesContent>true</shadeSourcesContent>
<filters>
<filter>

View File

@ -42,44 +42,30 @@
<build>
<pluginManagement>
<plugins>
<!-- Override root pom definition, so as to ensure the shading has a fresh base sources jar
for the module before shading, with nothing much in it, and doesnt instead grab a large
already-shaded remote snapshot, possibly each day (local) or on every build (CI) -->
<!-- Ensure the shading has a fresh base sources jar for the module before shading,
with nothing much in it, and doesnt instead grab a large already-shaded remote
snapshot, possibly each day (local) or on every build (CI) -->
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-source-plugin</artifactId>
<executions>
<execution>
<id>attach-sources</id>
<phase>package</phase>
<goals>
<goal>jar-no-fork</goal>
</goals>
<configuration>
<forceCreation>true</forceCreation>
</configuration>
</execution>
</executions>
<configuration>
<forceCreation>true</forceCreation>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
<configuration>
<!-- Ensures the shading is always working upon a fresh base jar, which has
nothing much in it, rather than potentially working on already-shaded
output still present from prior runs and renamed to have the base name -->
<forceCreation>true</forceCreation>
</configuration>
</plugin>
</plugins>
</pluginManagement>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
<executions>
<execution>
<id>default-jar</id>
<configuration>
<!-- Ensures the shading is always working upon a fresh base jar, which has
nothing much in it, rather than potentially working on already-shaded
output still present from prior runs and renamed to have the base name -->
<forceCreation>true</forceCreation>
</configuration>
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-shade-plugin</artifactId>
@ -90,7 +76,7 @@
<goal>shade</goal>
</goals>
<configuration>
<createSourcesJar>true</createSourcesJar>
<createSourcesJar>${shade-plugin-create-sources}</createSourcesJar>
<shadeSourcesContent>true</shadeSourcesContent>
<filters>
<filter>

View File

@ -38,44 +38,30 @@
<build>
<pluginManagement>
<plugins>
<!-- Override root pom definition, so as to ensure the shading has a fresh base sources jar
for the module before shading, with nothing much in it, and doesnt instead grab a large
already-shaded remote snapshot, possibly each day (local) or on every build (CI) -->
<!-- Ensure the shading has a fresh base sources jar for the module before shading,
with nothing much in it, and doesnt instead grab a large already-shaded remote
snapshot, possibly each day (local) or on every build (CI) -->
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-source-plugin</artifactId>
<executions>
<execution>
<id>attach-sources</id>
<phase>package</phase>
<goals>
<goal>jar-no-fork</goal>
</goals>
<configuration>
<forceCreation>true</forceCreation>
</configuration>
</execution>
</executions>
<configuration>
<forceCreation>true</forceCreation>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
<configuration>
<!-- Ensures the shading is always working upon a fresh base jar, which has
nothing much in it, rather than potentially working on already-shaded
output still present from prior runs and renamed to have the base name -->
<forceCreation>true</forceCreation>
</configuration>
</plugin>
</plugins>
</pluginManagement>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
<executions>
<execution>
<id>default-jar</id>
<configuration>
<!-- Ensures the shading is always working upon a fresh base jar, which has
nothing much in it, rather than potentially working on already-shaded
output still present from prior runs and renamed to have the base name -->
<forceCreation>true</forceCreation>
</configuration>
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-shade-plugin</artifactId>
@ -86,7 +72,7 @@
<goal>shade</goal>
</goals>
<configuration>
<createSourcesJar>true</createSourcesJar>
<createSourcesJar>${shade-plugin-create-sources}</createSourcesJar>
<shadeSourcesContent>true</shadeSourcesContent>
<filters>
<filter>

42
pom.xml
View File

@ -220,6 +220,8 @@
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
<shade-plugin-create-sources>false</shade-plugin-create-sources>
<maven.test.failure.ignore>false</maven.test.failure.ignore>
<maven.test.redirectTestOutputToFile>true</maven.test.redirectTestOutputToFile>
@ -432,6 +434,9 @@
<modules>
<module>artemis-website</module>
</modules>
<properties>
<shade-plugin-create-sources>true</shade-plugin-create-sources>
</properties>
<build>
<plugins>
<plugin>
@ -478,16 +483,32 @@
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-source-plugin</artifactId>
<executions>
<execution>
<id>attach-sources</id>
<goals>
<goal>jar-no-fork</goal>
</goals>
</execution>
</executions>
</plugin>
</plugins>
</build>
</profile>
<!-- Override the apache-release profile from the parent to skip creating
a source-release archive here, it is done in artemis-distribution. -->
<profile>
<id>apache-release</id>
<properties>
<shade-plugin-create-sources>true</shade-plugin-create-sources>
</properties>
<build>
<plugins>
<plugin>
<!-- Override the apache-release profile from the parent to skip creating
a source-release archive here, it is done in artemis-distribution. -->
<inherited>false</inherited>
<artifactId>maven-assembly-plugin</artifactId>
<executions>
<execution>
@ -824,20 +845,6 @@
<artifactId>transformer-tools-mvn</artifactId>
<version>${version.batavia}</version>
</plugin>
<plugin>
<inherited>true</inherited>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-source-plugin</artifactId>
<executions>
<execution>
<id>attach-sources</id>
<phase>verify</phase>
<goals>
<goal>jar-no-fork</goal>
</goals>
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
@ -1065,9 +1072,6 @@
<noindex>true</noindex>
</configuration>
</plugin>
<plugin>
<artifactId>maven-source-plugin</artifactId>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-help-plugin</artifactId>