Apache
/
activemq-artemis
mirror of https://github.com/apache/activemq-artemis.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

ARTEMIS-3354 journal-max-io cannot be set to 1 with ASYNCIO journal

This commit is contained in:
franz1981 2021-06-17 09:49:50 +02:00 committed by clebertsuconic
parent 7fc312ab5d
commit bb3f31340d
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/aio/AIOSequentialFileFactory.java
View File

@ -112,7 +112,8 @@ public final class AIOSequentialFileFactory extends AbstractSequentialFileFactor
final IOCriticalErrorListener listener, final IOCriticalErrorListener listener,
final CriticalAnalyzer analyzer) { final CriticalAnalyzer analyzer) {
super(journalDir, true, bufferSize, bufferTimeout, maxIO, logRates, listener, analyzer); super(journalDir, true, bufferSize, bufferTimeout, maxIO, logRates, listener, analyzer);
callbackPool = PlatformDependent.hasUnsafe() ? new MpmcArrayQueue<>(maxIO) : new MpmcAtomicArrayQueue<>(maxIO); final int adjustedMaxIO = Math.max(2, maxIO);
callbackPool = PlatformDependent.hasUnsafe() ? new MpmcArrayQueue<>(adjustedMaxIO) : new MpmcAtomicArrayQueue<>(adjustedMaxIO);
if (logger.isTraceEnabled()) { if (logger.isTraceEnabled()) {
logger.trace("New AIO File Created"); logger.trace("New AIO File Created");
} }

5
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/journal/AIOSequentialFileFactoryTest.java
View File

@ -39,6 +39,11 @@ public class AIOSequentialFileFactoryTest extends SequentialFileFactoryTestBase
return new AIOSequentialFileFactory(new File(folder), 10); return new AIOSequentialFileFactory(new File(folder), 10);
} }
@Test
public void canCreateFactoryWithMaxIOLessThenTwo() {
AIOSequentialFileFactory factory = new AIOSequentialFileFactory(new File("ignore"), 1);
}
@Test @Test
public void testBuffer() throws Exception { public void testBuffer() throws Exception {
SequentialFile file = factory.createSequentialFile("filtetmp.log"); SequentialFile file = factory.createSequentialFile("filtetmp.log");