Apache
/
activemq-artemis
mirror of https://github.com/apache/activemq-artemis.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

ARTEMIS-4456 Register metrics plugin

This commit is contained in:
Domenico Francesco Bruscino 2023-10-03 07:00:54 +02:00 committed by Justin Bertram
parent b8bb560ff0
commit c27b7b65c7
4 changed files with 31 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java
View File

@ -3367,6 +3367,10 @@ public class ActiveMQServerImpl implements ActiveMQServer {
registerBrokerPlugins(getBrokerPlugins()); registerBrokerPlugins(getBrokerPlugins());
} }
if (configuration.getMetricsConfiguration() != null && configuration.getMetricsConfiguration().getPlugin() != null) {
configuration.getMetricsConfiguration().getPlugin().registered(this);
}
return true; return true;
} }

9
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/metrics/ActiveMQMetricsPlugin.java
View File

@ -20,10 +20,19 @@ import java.io.Serializable;
import java.util.Map; import java.util.Map;
import io.micrometer.core.instrument.MeterRegistry; import io.micrometer.core.instrument.MeterRegistry;
import org.apache.activemq.artemis.core.server.ActiveMQServer;
public interface ActiveMQMetricsPlugin extends Serializable { public interface ActiveMQMetricsPlugin extends Serializable {
ActiveMQMetricsPlugin init(Map<String, String> options); ActiveMQMetricsPlugin init(Map<String, String> options);
MeterRegistry getRegistry(); MeterRegistry getRegistry();
/**
* The plugin has been registered with the server
*
* @param server The ActiveMQServer the plugin has been registered to
*/
default void registered(ActiveMQServer server) {
}
} }

12
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/metrics/plugins/SimpleMetricsPlugin.java
View File

@ -20,6 +20,7 @@ import java.util.Map;
import io.micrometer.core.instrument.MeterRegistry; import io.micrometer.core.instrument.MeterRegistry;
import io.micrometer.core.instrument.simple.SimpleMeterRegistry; import io.micrometer.core.instrument.simple.SimpleMeterRegistry;
import org.apache.activemq.artemis.core.server.ActiveMQServer;
import org.apache.activemq.artemis.core.server.metrics.ActiveMQMetricsPlugin; import org.apache.activemq.artemis.core.server.metrics.ActiveMQMetricsPlugin;
/** /**
@ -31,6 +32,8 @@ public class SimpleMetricsPlugin implements ActiveMQMetricsPlugin {
private Map<String, String> options; private Map<String, String> options;
private ActiveMQServer server;
@Override @Override
public ActiveMQMetricsPlugin init(Map<String, String> options) { public ActiveMQMetricsPlugin init(Map<String, String> options) {
this.meterRegistry = new SimpleMeterRegistry(); this.meterRegistry = new SimpleMeterRegistry();
@ -43,7 +46,16 @@ public class SimpleMetricsPlugin implements ActiveMQMetricsPlugin {
return meterRegistry; return meterRegistry;
} }
@Override
public void registered(ActiveMQServer server) {
this.server = server;
}
public Map<String, String> getOptions() { public Map<String, String> getOptions() {
return options; return options;
} }
public ActiveMQServer getServer() {
return server;
}
} }

6
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/plugin/MetricsPluginTest.java
View File

@ -270,6 +270,12 @@ public class MetricsPluginTest extends ActiveMQTestBase {
checkMetric(getMetrics(), "artemis.message.count", "queue", queueName, Double.valueOf(messageCount * 2)); checkMetric(getMetrics(), "artemis.message.count", "queue", queueName, Double.valueOf(messageCount * 2));
} }
@Test
public void testMetricsPluginRegistration() {
assertEquals(SimpleMetricsPlugin.class, server.getConfiguration().getMetricsConfiguration().getPlugin().getClass());
assertEquals(server, ((SimpleMetricsPlugin)server.getConfiguration().getMetricsConfiguration().getPlugin()).getServer());
}
public Map<Meter.Id, Double> getMetrics() { public Map<Meter.Id, Double> getMetrics() {
return getMetrics(server); return getMetrics(server);
} }