diff --git a/artemis-server/src/main/resources/schema/artemis-configuration.xsd b/artemis-server/src/main/resources/schema/artemis-configuration.xsd index f4d9d1d493..7355fdbeed 100644 --- a/artemis-server/src/main/resources/schema/artemis-configuration.xsd +++ b/artemis-server/src/main/resources/schema/artemis-configuration.xsd @@ -1054,6 +1054,37 @@ + + + + + + + + + + + restricts a clusters connections to the listed connector-ref's + + + + + + + + + + + + + name of the discovery group to use for this connection + + + + + + + @@ -1222,13 +1253,6 @@ - - - - - - - @@ -1281,7 +1305,7 @@ - + @@ -1469,29 +1493,9 @@ - - - - - - - - - - - - - - - name of discovery group used by this bridge - - - - - - - - + + + @@ -2334,7 +2338,7 @@ - + @@ -2517,36 +2521,10 @@ - - - - - - - - - - restricts cluster connections to the listed connector-ref's - - - - - - - - - - - - name of discovery group used by this cluster-connection - - - - - - - - + + + + diff --git a/artemis-server/src/test/java/org/apache/activemq/artemis/core/config/impl/FileConfigurationParserTest.java b/artemis-server/src/test/java/org/apache/activemq/artemis/core/config/impl/FileConfigurationParserTest.java index 56cb63700f..a1d9a7ee53 100644 --- a/artemis-server/src/test/java/org/apache/activemq/artemis/core/config/impl/FileConfigurationParserTest.java +++ b/artemis-server/src/test/java/org/apache/activemq/artemis/core/config/impl/FileConfigurationParserTest.java @@ -311,6 +311,13 @@ public class FileConfigurationParserTest extends ServerTestBase { " remote-connector\n" + " \n" + " \n" + + " \n" + + " \n" + + " remote-connector\n" + + " \n" + + " mincing-machine\n" + + " sausage-factory\n" + + " \n" + "\n" + lastPart; ByteArrayInputStream input = new ByteArrayInputStream(configStr.getBytes(StandardCharsets.UTF_8)); @@ -318,7 +325,7 @@ public class FileConfigurationParserTest extends ServerTestBase { Configuration config = parser.parseMainConfig(input); List bridgeConfigs = config.getBridgeConfigurations(); - assertEquals(1, bridgeConfigs.size()); + assertEquals(2, bridgeConfigs.size()); BridgeConfiguration bconfig = bridgeConfigs.get(0); diff --git a/artemis-server/src/test/java/org/apache/activemq/artemis/core/config/impl/FileConfigurationTest.java b/artemis-server/src/test/java/org/apache/activemq/artemis/core/config/impl/FileConfigurationTest.java index 5216ba7a47..48516272d5 100644 --- a/artemis-server/src/test/java/org/apache/activemq/artemis/core/config/impl/FileConfigurationTest.java +++ b/artemis-server/src/test/java/org/apache/activemq/artemis/core/config/impl/FileConfigurationTest.java @@ -406,6 +406,7 @@ public class FileConfigurationTest extends ConfigurationImplTest { Assert.assertEquals("connector2", ccc.getStaticConnectors().get(1)); Assert.assertEquals(null, ccc.getDiscoveryGroupName()); Assert.assertEquals(222, ccc.getProducerWindowSize()); + Assert.assertEquals(true, ccc.isAllowDirectConnectionsOnly()); } else { Assert.assertEquals("cluster-connection2", ccc.getName()); Assert.assertEquals("queues2", ccc.getAddress()); @@ -418,6 +419,7 @@ public class FileConfigurationTest extends ConfigurationImplTest { Assert.assertEquals(Collections.emptyList(), ccc.getStaticConnectors()); Assert.assertEquals("dg1", ccc.getDiscoveryGroupName()); Assert.assertEquals(333, ccc.getProducerWindowSize()); + Assert.assertEquals(false, ccc.isAllowDirectConnectionsOnly()); } } diff --git a/artemis-server/src/test/resources/ConfigurationTest-full-config.xml b/artemis-server/src/test/resources/ConfigurationTest-full-config.xml index 03e3e96cf8..704cb58e0b 100644 --- a/artemis-server/src/test/resources/ConfigurationTest-full-config.xml +++ b/artemis-server/src/test/resources/ConfigurationTest-full-config.xml @@ -233,13 +233,13 @@ 10002 2 false - true 1G 444 STRIP connector1 + true queue2 @@ -249,7 +249,6 @@ queue3 - bridge-forwarding-address2 org.foo.BridgeTransformer3 @@ -257,6 +256,7 @@ 555k + bridge-forwarding-address2 queue3 @@ -421,22 +421,22 @@ 1 222 123 - + connector1 connector2 +
queues2
connector2 456 + 456 4 false STRICT 2 333 - 456 -
connector2 diff --git a/artemis-server/src/test/resources/ConfigurationTest-xinclude-config.xml b/artemis-server/src/test/resources/ConfigurationTest-xinclude-config.xml index 84bb539057..44961398de 100644 --- a/artemis-server/src/test/resources/ConfigurationTest-xinclude-config.xml +++ b/artemis-server/src/test/resources/ConfigurationTest-xinclude-config.xml @@ -302,7 +302,7 @@ 1 222 123 - + connector1 connector2 diff --git a/artemis-server/src/test/resources/ConfigurationTest-xinclude-schema-config-cluster-connections.xml b/artemis-server/src/test/resources/ConfigurationTest-xinclude-schema-config-cluster-connections.xml index ed29c619a9..aee09856e0 100644 --- a/artemis-server/src/test/resources/ConfigurationTest-xinclude-schema-config-cluster-connections.xml +++ b/artemis-server/src/test/resources/ConfigurationTest-xinclude-schema-config-cluster-connections.xml @@ -31,7 +31,7 @@ 1 222 123 - + connector1 connector2 diff --git a/tests/integration-tests/src/test/resources/reload-bridge-updated.xml b/tests/integration-tests/src/test/resources/reload-bridge-updated.xml index ffa263878d..f268f85916 100644 --- a/tests/integration-tests/src/test/resources/reload-bridge-updated.xml +++ b/tests/integration-tests/src/test/resources/reload-bridge-updated.xml @@ -37,9 +37,9 @@ under the License. + 2 a-from a-new - 2 connector