From 5c051e98329eb69a1d923ce20c689d2aee065348 Mon Sep 17 00:00:00 2001 From: Clebert Suconic Date: Tue, 6 Jul 2021 14:19:11 -0400 Subject: [PATCH] ARTEMIS-3327 Removing unecessary block operation on journal append record --- .../activemq/artemis/core/journal/impl/JournalImpl.java | 6 ------ 1 file changed, 6 deletions(-) diff --git a/artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalImpl.java b/artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalImpl.java index ed6f38a2a4..8509db64ec 100644 --- a/artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalImpl.java +++ b/artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalImpl.java @@ -935,7 +935,6 @@ public class JournalImpl extends JournalBase implements TestableJournal, Journal throw ActiveMQJournalBundle.BUNDLE.recordLargerThanStoreMax(addRecordEncodeSize, maxRecordSize); } - final SimpleFuture result = newSyncAndCallbackResult(sync, callback); appendExecutor.execute(new Runnable() { @Override public void run() { @@ -952,12 +951,9 @@ public class JournalImpl extends JournalBase implements TestableJournal, Journal ", usedFile = " + usedFile); } - result.set(true); } catch (ActiveMQShutdownException e) { - result.fail(e); logger.error("appendAddRecord:" + e, e); } catch (Throwable e) { - result.fail(e); setErrorCondition(callback, null, e); logger.error("appendAddRecord::" + e, e); } finally { @@ -965,8 +961,6 @@ public class JournalImpl extends JournalBase implements TestableJournal, Journal } } }); - - result.get(); }