ARTEMIS-405 correct some missing docs

This commit is contained in:
jbertram 2016-05-23 15:39:43 -05:00 committed by Clebert Suconic
parent d6bbc9ce35
commit d9b721b35b
3 changed files with 9 additions and 6 deletions

View File

@ -16,6 +16,7 @@
*/ */
package org.apache.activemq.artemis.api.core.management; package org.apache.activemq.artemis.api.core.management;
import javax.management.MBeanOperationInfo;
import java.util.Map; import java.util.Map;
/** /**
@ -46,5 +47,6 @@ public interface AcceptorControl extends ActiveMQComponentControl {
* Re-create the acceptor with the existing configuration values. Useful, for example, for reloading key/trust * Re-create the acceptor with the existing configuration values. Useful, for example, for reloading key/trust
* stores on acceptors which support SSL. * stores on acceptors which support SSL.
*/ */
@Operation(desc = "Re-create the acceptor with the existing configuration values. Useful, for example, for reloading key/trust stores on acceptors which support SSL.", impact = MBeanOperationInfo.ACTION)
void reload(); void reload();
} }

View File

@ -30,10 +30,12 @@ public interface ActiveMQComponentControl {
/** /**
* Starts this component. * Starts this component.
*/ */
@Operation(desc = "starts this component")
void start() throws Exception; void start() throws Exception;
/** /**
* Stops this component. * Stops this component.
*/ */
@Operation(desc = "stops this component")
void stop() throws Exception; void stop() throws Exception;
} }

View File

@ -21,7 +21,6 @@ import javax.management.MBeanRegistrationException;
import javax.management.MBeanServer; import javax.management.MBeanServer;
import javax.management.NotificationBroadcasterSupport; import javax.management.NotificationBroadcasterSupport;
import javax.management.ObjectName; import javax.management.ObjectName;
import javax.management.StandardMBean;
import java.lang.reflect.InvocationTargetException; import java.lang.reflect.InvocationTargetException;
import java.lang.reflect.Method; import java.lang.reflect.Method;
import java.util.ArrayList; import java.util.ArrayList;
@ -262,7 +261,7 @@ public class ManagementServiceImpl implements ManagementService {
public synchronized void registerDivert(final Divert divert, final DivertConfiguration config) throws Exception { public synchronized void registerDivert(final Divert divert, final DivertConfiguration config) throws Exception {
ObjectName objectName = objectNameBuilder.getDivertObjectName(divert.getUniqueName().toString()); ObjectName objectName = objectNameBuilder.getDivertObjectName(divert.getUniqueName().toString());
DivertControl divertControl = new DivertControlImpl(divert, storageManager, config); DivertControl divertControl = new DivertControlImpl(divert, storageManager, config);
registerInJMX(objectName, new StandardMBean(divertControl, DivertControl.class)); registerInJMX(objectName, divertControl);
registerInRegistry(ResourceNames.CORE_DIVERT + config.getName(), divertControl); registerInRegistry(ResourceNames.CORE_DIVERT + config.getName(), divertControl);
if (logger.isDebugEnabled()) { if (logger.isDebugEnabled()) {
@ -282,7 +281,7 @@ public class ManagementServiceImpl implements ManagementService {
final TransportConfiguration configuration) throws Exception { final TransportConfiguration configuration) throws Exception {
ObjectName objectName = objectNameBuilder.getAcceptorObjectName(configuration.getName()); ObjectName objectName = objectNameBuilder.getAcceptorObjectName(configuration.getName());
AcceptorControl control = new AcceptorControlImpl(acceptor, storageManager, configuration); AcceptorControl control = new AcceptorControlImpl(acceptor, storageManager, configuration);
registerInJMX(objectName, new StandardMBean(control, AcceptorControl.class)); registerInJMX(objectName, control);
registerInRegistry(ResourceNames.CORE_ACCEPTOR + configuration.getName(), control); registerInRegistry(ResourceNames.CORE_ACCEPTOR + configuration.getName(), control);
} }
@ -320,7 +319,7 @@ public class ManagementServiceImpl implements ManagementService {
broadcastGroup.setNotificationService(this); broadcastGroup.setNotificationService(this);
ObjectName objectName = objectNameBuilder.getBroadcastGroupObjectName(configuration.getName()); ObjectName objectName = objectNameBuilder.getBroadcastGroupObjectName(configuration.getName());
BroadcastGroupControl control = new BroadcastGroupControlImpl(broadcastGroup, storageManager, configuration); BroadcastGroupControl control = new BroadcastGroupControlImpl(broadcastGroup, storageManager, configuration);
registerInJMX(objectName, new StandardMBean(control, BroadcastGroupControl.class)); registerInJMX(objectName, control);
registerInRegistry(ResourceNames.CORE_BROADCAST_GROUP + configuration.getName(), control); registerInRegistry(ResourceNames.CORE_BROADCAST_GROUP + configuration.getName(), control);
} }
@ -337,7 +336,7 @@ public class ManagementServiceImpl implements ManagementService {
bridge.setNotificationService(this); bridge.setNotificationService(this);
ObjectName objectName = objectNameBuilder.getBridgeObjectName(configuration.getName()); ObjectName objectName = objectNameBuilder.getBridgeObjectName(configuration.getName());
BridgeControl control = new BridgeControlImpl(bridge, storageManager, configuration); BridgeControl control = new BridgeControlImpl(bridge, storageManager, configuration);
registerInJMX(objectName, new StandardMBean(control, BridgeControl.class)); registerInJMX(objectName, control);
registerInRegistry(ResourceNames.CORE_BRIDGE + configuration.getName(), control); registerInRegistry(ResourceNames.CORE_BRIDGE + configuration.getName(), control);
} }
@ -353,7 +352,7 @@ public class ManagementServiceImpl implements ManagementService {
final ClusterConnectionConfiguration configuration) throws Exception { final ClusterConnectionConfiguration configuration) throws Exception {
ObjectName objectName = objectNameBuilder.getClusterConnectionObjectName(configuration.getName()); ObjectName objectName = objectNameBuilder.getClusterConnectionObjectName(configuration.getName());
ClusterConnectionControl control = new ClusterConnectionControlImpl(cluster, storageManager, configuration); ClusterConnectionControl control = new ClusterConnectionControlImpl(cluster, storageManager, configuration);
registerInJMX(objectName, new StandardMBean(control, ClusterConnectionControl.class)); registerInJMX(objectName, control);
registerInRegistry(ResourceNames.CORE_CLUSTER_CONNECTION + configuration.getName(), control); registerInRegistry(ResourceNames.CORE_CLUSTER_CONNECTION + configuration.getName(), control);
} }