From 89253b8513d597af04c631ce0b32882113e5d84b Mon Sep 17 00:00:00 2001 From: domson-tech <85628785+domson-tech@users.noreply.github.com> Date: Mon, 1 Nov 2021 20:53:15 +0800 Subject: [PATCH] ARTEMIS-3547 remove first field to improve code first field is not necessary here, only pos field can work. So remove first here. --- .../RoundRobinConnectionLoadBalancingPolicy.java | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/client/loadbalance/RoundRobinConnectionLoadBalancingPolicy.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/client/loadbalance/RoundRobinConnectionLoadBalancingPolicy.java index 388cf347a4..60ad022cd8 100644 --- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/client/loadbalance/RoundRobinConnectionLoadBalancingPolicy.java +++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/client/loadbalance/RoundRobinConnectionLoadBalancingPolicy.java @@ -31,17 +31,14 @@ public final class RoundRobinConnectionLoadBalancingPolicy implements Connection private static final long serialVersionUID = 7511196010141439559L; - private boolean first = true; - - private int pos; + private int pos = -1; @Override public int select(final int max) { - if (first) { + if (pos == -1) { // We start on a random one pos = RandomUtil.randomInterval(0, max); - first = false; } else { pos++;