From 27ef1b2bf092e953ee49eac7e99e3cfb7b72d898 Mon Sep 17 00:00:00 2001 From: jbertram Date: Wed, 20 Jul 2016 16:44:00 -0500 Subject: [PATCH] ARTEMIS-405 more docs for JMS destinations --- .../artemis/api/jms/management/DestinationControl.java | 9 ++++++++- .../artemis/jms/management/impl/JMSTopicControlImpl.java | 2 +- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/artemis-jms-client/src/main/java/org/apache/activemq/artemis/api/jms/management/DestinationControl.java b/artemis-jms-client/src/main/java/org/apache/activemq/artemis/api/jms/management/DestinationControl.java index 678fb21cf3..afd07ca155 100644 --- a/artemis-jms-client/src/main/java/org/apache/activemq/artemis/api/jms/management/DestinationControl.java +++ b/artemis-jms-client/src/main/java/org/apache/activemq/artemis/api/jms/management/DestinationControl.java @@ -18,6 +18,7 @@ package org.apache.activemq.artemis.api.jms.management; import javax.management.MBeanOperationInfo; +import org.apache.activemq.artemis.api.core.management.Attribute; import org.apache.activemq.artemis.api.core.management.Operation; import org.apache.activemq.artemis.api.core.management.Parameter; @@ -30,31 +31,37 @@ public interface DestinationControl { /** * Returns the name of this destination. */ + @Attribute(desc = "the name of this destination") String getName(); /** - * Returns the ActiveMQ Artemis address corresponding to this destination. + * Returns the address corresponding to this destination. */ + @Attribute(desc = "the address corresponding to this destination") String getAddress(); /** * Returns whether this destination is temporary. */ + @Attribute(desc = "whether this destination is temporary") boolean isTemporary(); /** * Returns the number of messages currently in this destination. */ + @Attribute(desc = "the number of messages currently in this destination") long getMessageCount() throws Exception; /** * Returns the number of messages that this queue is currently delivering to its consumers. */ + @Attribute(desc = "the number of messages that this queue is currently delivering to its consumers") int getDeliveringCount(); /** * Returns the number of messages added to this queue since it was created. */ + @Attribute(desc = "the number of messages added to this queue since it was created") long getMessagesAdded(); // Operations ---------------------------------------------------- diff --git a/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/management/impl/JMSTopicControlImpl.java b/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/management/impl/JMSTopicControlImpl.java index 63d3d45b1a..5a0842d9df 100644 --- a/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/management/impl/JMSTopicControlImpl.java +++ b/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/management/impl/JMSTopicControlImpl.java @@ -365,7 +365,7 @@ public class JMSTopicControlImpl extends StandardMBean implements TopicControl { @Override public MBeanInfo getMBeanInfo() { MBeanInfo info = super.getMBeanInfo(); - return new MBeanInfo(info.getClassName(), info.getDescription(), info.getAttributes(), info.getConstructors(), MBeanInfoHelper.getMBeanOperationsInfo(TopicControl.class), info.getNotifications()); + return new MBeanInfo(info.getClassName(), info.getDescription(), MBeanInfoHelper.getMBeanAttributesInfo(TopicControl.class), info.getConstructors(), MBeanInfoHelper.getMBeanOperationsInfo(TopicControl.class), info.getNotifications()); } // Inner classes -------------------------------------------------