ARTEMIS-1207: Align when setClientId can be called

Update ActiveMQConnection to change/alighn behaviour for addtional methods:
- getMetaData
- stop

Adding test to avoid regression.

This is aligning with qpid-jms and openwire clients

artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQConnection.java

@@ -267,8 +267,6 @@ public class ActiveMQConnection extends ActiveMQConnectionForContextImpl impleme
    public ConnectionMetaData getMetaData() throws JMSException {
       checkClosed();
 
-      justCreated = false;
-
       if (metaData == null) {
          metaData = new ActiveMQConnectionMetaData(thisVersion);
       }
@@ -323,7 +321,6 @@ public class ActiveMQConnection extends ActiveMQConnectionForContextImpl impleme
          session.stop();
       }
 
-      justCreated = false;
       started = false;
    }
 

tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/ConnectionTest.java

@@ -97,6 +97,15 @@ public class ConnectionTest extends JMSTestCase {
       connection2.setClientID(clientID);
    }
 
+   @Test
+   public void testSetClientIdAfterStop() throws Exception {
+      try (Connection connection = createConnection()) {
+         connection.stop();
+         connection.setClientID("clientId");
+      }
+   }
+
+
    @Test
    public void testSetClientAfterStart() throws Exception {
       Connection connection = null;
@@ -174,6 +183,14 @@ public class ConnectionTest extends JMSTestCase {
       connection.close();
    }
 
+   @Test
+   public void testSetClientIdAfterGetMetadata() throws Exception {
+      try (Connection connection = createConnection()) {
+         connection.getMetaData();
+         connection.setClientID("clientId");
+      }
+   }
+
    /**
     * Test creation of QueueSession
     */