Apache/activemq-artemis
1
0
Fork 0
mirror of https://github.com/apache/activemq-artemis.git synced 2025-02-08 02:59:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

ARTEMIS-3109 unsetting expiry-address results in excessive logging

Browse Source
This commit is contained in:
Justin Bertram 2021-02-08 14:38:42 -06:00 committed by Clebert Suconic
parent 1647f5e1f1
commit ea6b133ac8
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQServerLogger.java
View File

@ -1048,8 +1048,8 @@ public interface ActiveMQServerLogger extends BasicLogger {
void errorExpiringReferencesNoBindings(SimpleString expiryAddress); void errorExpiringReferencesNoBindings(SimpleString expiryAddress);
@LogMessage(level = Logger.Level.WARN) @LogMessage(level = Logger.Level.WARN)
@Message(id = 222147, value = "Messages are being expired on queue {0}. However there is no expiry queue configured, hence messages will be dropped.", format = Message.Format.MESSAGE_FORMAT) @Message(id = 222147, value = "Messages are being expired on queue {0}, but there is no Expiry Address configured so messages will be dropped.", format = Message.Format.MESSAGE_FORMAT)
void errorExpiringReferencesNoQueue(SimpleString name); void errorExpiringReferencesNoAddress(SimpleString name);
@LogMessage(level = Logger.Level.WARN) @LogMessage(level = Logger.Level.WARN)
@Message(id = 222148, value = "Message {0} has exceeded max delivery attempts. No bindings for Dead Letter Address {1} so dropping it", @Message(id = 222148, value = "Message {0} has exceeded max delivery attempts. No bindings for Dead Letter Address {1} so dropping it",

4
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
View File

@ -3491,7 +3491,7 @@ public class QueueImpl extends CriticalComponentImpl implements Queue {
private void expire(final Transaction tx, final MessageReference ref) throws Exception { private void expire(final Transaction tx, final MessageReference ref) throws Exception {
SimpleString expiryAddress = addressSettingsRepository.getMatch(address.toString()).getExpiryAddress(); SimpleString expiryAddress = addressSettingsRepository.getMatch(address.toString()).getExpiryAddress();
if (expiryAddress != null) { if (expiryAddress != null && expiryAddress.length() != 0) {
createExpiryResources(); createExpiryResources();
@ -3507,7 +3507,7 @@ public class QueueImpl extends CriticalComponentImpl implements Queue {
if (!printErrorExpiring) { if (!printErrorExpiring) {
printErrorExpiring = true; printErrorExpiring = true;
// print this only once // print this only once
ActiveMQServerLogger.LOGGER.errorExpiringReferencesNoQueue(name); ActiveMQServerLogger.LOGGER.errorExpiringReferencesNoAddress(name);
} }
acknowledge(tx, ref, AckReason.EXPIRED, null); acknowledge(tx, ref, AckReason.EXPIRED, null);