From ee261e736c04572efa464a19a6cb045a455c5710 Mon Sep 17 00:00:00 2001 From: Clebert Suconic Date: Fri, 14 Apr 2017 18:07:09 -0400 Subject: [PATCH] ARTEMIS-1114 Improving some comment --- .../artemis/core/journal/impl/JournalTransaction.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalTransaction.java b/artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalTransaction.java index 36d585a803..78887db15b 100644 --- a/artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalTransaction.java +++ b/artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalTransaction.java @@ -232,7 +232,10 @@ public class JournalTransaction { public void commit(final JournalFile file) { JournalCompactor compactor = journal.getCompactor(); - // The race lies here.... + // https://issues.apache.org/jira/browse/ARTEMIS-1114 + // There was a race once where compacting was not set + // because the Journal was missing a readLock and compacting was starting + // without setting this properly... if (compacting && compactor != null) { if (logger.isTraceEnabled()) { logger.trace("adding tx " + this.id + " into compacting");