ARTEMIS-3318/ARTEMIS-2931 Fixing potential issue
The issue here is not supposed to happen, however I'm changing the return here to true and logging the warn properly
This commit is contained in:
parent
cfee2035c8
commit
f0476d6a12
|
@ -573,8 +573,10 @@ public class PagingStoreImpl implements PagingStore {
|
||||||
SequentialFile file = factory.createSequentialFile(fileName);
|
SequentialFile file = factory.createSequentialFile(fileName);
|
||||||
return file.exists() && file.size() > 0;
|
return file.exists() && file.size() > 0;
|
||||||
} catch (Exception ignored) {
|
} catch (Exception ignored) {
|
||||||
logger.debug("PagingStoreFactory::checkPageFileExists never-throws assumption failed.", ignored);
|
// never supposed to happen, but just in case
|
||||||
return false;
|
logger.warn("PagingStoreFactory::checkPageFileExists never-throws assumption failed.", ignored);
|
||||||
|
return true; // returning false would make the acks to the page to go missing.
|
||||||
|
// since we are not sure on the result for this case, we just return true
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue