Apache
/
activemq-artemis
mirror of https://github.com/apache/activemq-artemis.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

ARTEMIS-3318/ARTEMIS-2931 Fixing potential issue 

The issue here is not supposed to happen,
however I'm changing the return here to true and logging the warn properly
This commit is contained in:
Clebert Suconic 2021-05-27 08:50:53 -04:00
parent cfee2035c8
commit f0476d6a12
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PagingStoreImpl.java
View File

@ -573,8 +573,10 @@ public class PagingStoreImpl implements PagingStore {
SequentialFile file = factory.createSequentialFile(fileName);
return file.exists() && file.size() > 0;
} catch (Exception ignored) {
logger.debug("PagingStoreFactory::checkPageFileExists never-throws assumption failed.", ignored);
return false;
// never supposed to happen, but just in case
logger.warn("PagingStoreFactory::checkPageFileExists never-throws assumption failed.", ignored);
return true; // returning false would make the acks to the page to go missing.
// since we are not sure on the result for this case, we just return true
}
}