Apache
/
activemq-artemis
mirror of https://github.com/apache/activemq-artemis.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

NO-JIRA removing useless assertionRemainingMessages 

JMSTestCase is deprecated anyway.
in its older form many many years ago a server would be reused over
between tests.

what forced us to make such verification to avoid messages from one test
leaking into the next.

This was because a server startup was expensive many years ago (less
efficient code and the hardware available 10 years ago)

with the current state of things this is not needed as the server will
be started from scratch on every test
This commit is contained in:
clebert 2022-05-25 11:32:14 -04:00 committed by clebertsuconic
parent 3ea18a8ea7
commit f14ba5f742
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/JMSTestCase.java
View File

@ -69,8 +69,6 @@ public class JMSTestCase extends ActiveMQServerTestCase {
cf = new ActiveMQJMSConnectionFactory("tcp://127.0.0.1:61616?blockOnAcknowledge=true&blockOnDurableSend=true&blockOnNonDurableSend=true");
queueCf = new ActiveMQQueueConnectionFactory("tcp://127.0.0.1:61616?blockOnAcknowledge=true&blockOnDurableSend=true&blockOnNonDurableSend=true");
topicCf = new ActiveMQTopicConnectionFactory("tcp://127.0.0.1:61616?blockOnAcknowledge=true&blockOnDurableSend=true&blockOnNonDurableSend=true");
assertRemainingMessages(0);
}
protected final JMSContext createContext() {
@ -115,8 +113,6 @@ public class JMSTestCase extends ActiveMQServerTestCase {
}
cf = null;
assertRemainingMessages(0);
}
protected Connection createConnection(ConnectionFactory cf1) throws JMSException {