Apache
/
activemq-artemis
mirror of https://github.com/apache/activemq-artemis.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

ARTEMIS-3529 Tweaks on test - Removing AssertionLogger and reformat

This commit is contained in:
Clebert Suconic 2021-10-13 19:14:42 -04:00
parent 1d84800d5a
commit fd12209488
1 changed files with 46 additions and 61 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/client/MoveMessageDuplicateIDTest.java
View File

@ -23,7 +23,6 @@ import javax.jms.MessageProducer;
import javax.jms.Session; import javax.jms.Session;
import javax.jms.TextMessage; import javax.jms.TextMessage;
import javax.jms.Topic; import javax.jms.Topic;
import java.util.Arrays; import java.util.Arrays;
import java.util.Collection; import java.util.Collection;
@ -32,7 +31,6 @@ import org.apache.activemq.artemis.api.core.management.AddressControl;
import org.apache.activemq.artemis.core.config.Configuration; import org.apache.activemq.artemis.core.config.Configuration;
import org.apache.activemq.artemis.core.server.Queue; import org.apache.activemq.artemis.core.server.Queue;
import org.apache.activemq.artemis.core.settings.impl.AddressSettings; import org.apache.activemq.artemis.core.settings.impl.AddressSettings;
import org.apache.activemq.artemis.logs.AssertionLoggerHandler;
import org.apache.activemq.artemis.tests.integration.management.ManagementControlHelper; import org.apache.activemq.artemis.tests.integration.management.ManagementControlHelper;
import org.apache.activemq.artemis.tests.util.CFUtil; import org.apache.activemq.artemis.tests.util.CFUtil;
import org.apache.activemq.artemis.tests.util.JMSTestBase; import org.apache.activemq.artemis.tests.util.JMSTestBase;
@ -44,17 +42,15 @@ import org.junit.runners.Parameterized;
@RunWith(Parameterized.class) @RunWith(Parameterized.class)
public class MoveMessageDuplicateIDTest extends JMSTestBase { public class MoveMessageDuplicateIDTest extends JMSTestBase {
@Parameterized.Parameter(0) @Parameterized.Parameter(0)
public String protocol = "AMQP"; public String protocol = "AMQP";
@Parameterized.Parameters(name = "protocol={0}") @Parameterized.Parameters(name = "protocol={0}")
public static Collection<Object[]> parameters() { public static Collection<Object[]> parameters() {
return Arrays.asList(new Object[][] { return Arrays.asList(new Object[][]{{"AMQP"}, {"CORE"}, {"OPENWIRE"}});
{"AMQP"},
{"CORE"},
{"OPENWIRE"}
});
} }
@Override @Override
protected Configuration createDefaultConfig(boolean netty) throws Exception { protected Configuration createDefaultConfig(boolean netty) throws Exception {
return super.createDefaultConfig(netty).setMessageExpiryScanPeriod(50); return super.createDefaultConfig(netty).setMessageExpiryScanPeriod(50);
@ -63,8 +59,6 @@ public class MoveMessageDuplicateIDTest extends JMSTestBase {
@Test @Test
public void testTwoQueuesSingleDLQ() throws Exception { public void testTwoQueuesSingleDLQ() throws Exception {
AssertionLoggerHandler.startCapture();
try {
server.getAddressSettingsRepository().clear(); server.getAddressSettingsRepository().clear();
server.getAddressSettingsRepository().addMatch("#", new AddressSettings().setDeadLetterAddress(SimpleString.toSimpleString("JUNKYARD")).setExpiryAddress(SimpleString.toSimpleString("JUNKYARD")).setMaxDeliveryAttempts(1)); server.getAddressSettingsRepository().addMatch("#", new AddressSettings().setDeadLetterAddress(SimpleString.toSimpleString("JUNKYARD")).setExpiryAddress(SimpleString.toSimpleString("JUNKYARD")).setMaxDeliveryAttempts(1));
@ -115,14 +109,8 @@ public class MoveMessageDuplicateIDTest extends JMSTestBase {
conn.close(); conn.close();
Wait.assertEquals(200L, junkQueue::getMessageCount, 2000, 10); Wait.assertEquals(200L, junkQueue::getMessageCount, 2000, 10);
} finally {
AssertionLoggerHandler.stopCapture();
} }
}
@Test @Test
public void testMultiplSubscriptionSingleExpire() throws Exception { public void testMultiplSubscriptionSingleExpire() throws Exception {
server.getAddressSettingsRepository().clear(); server.getAddressSettingsRepository().clear();
@ -205,9 +193,6 @@ public class MoveMessageDuplicateIDTest extends JMSTestBase {
conn.close(); conn.close();
Wait.assertEquals(200L, junkQueue::getMessageCount, 2000, 10); Wait.assertEquals(200L, junkQueue::getMessageCount, 2000, 10);
} }
} }