The provider of an SSL key/trust store is different from that store's
type. However, the broker currently doesn't differentiate these and uses
the provider for both. Changing this *may* potentially break existing
users who are setting the provider, but I don't see any way to avoid
that. This is a bug that needs to be fixed in order to support use-cases
like PKCS#11.
Change summary:
- Added documentation.
- Consolidated several 2-way SSL tests classes into a single
parameterized test class. All these classes were essentially the same
except for a few key test parameters. Consolidating them avoided
having to update the same code in multiple places.
- Expanded tests to include different providers & types.
- Regenerated all SSL artifacts to allow tests to pass with new
constraints.
- Improved logging for when SSL handler initialization fails.
Previously, when a session was reattached, all the close/failure listeners
were removed from the old connection and set onto the new connection.
This only worked when at most 1 session of the old connection was
transferred: When the second session was transferred, the old
connection already didn't contain any close/failure listeners anymore,
and therefore the list of close/failure listeners was overwritten by
an empty list for the new connection.
Now, when a session is being transferred, it only transfers the
close/failure listeners that belong to it, which are the session itself
+ the TempQueueCleanerUppers.
Modified a test to check whether the sessions are failure listeners of
the new connection after reattachment.
During session reattachment, also set the new connection on the
"session" member of the ServerSessionPacketHandler. Until now,
the connected ServerSessionImpl instance still referenced the old
connection although it had already been transferred on the new connection.
The "filter" toolbar above many pages has all controls without spacing.
This PR inserts a little bit of spacing to make the groups of controls
more obvious.
Spacing is applied 3 times:
- at the start of the row to separate it from the left margin
- at "sort order" to separate the "filter" group from the "ordering"
group
- at "columns" to separate it from "reset"
Since the "looking glass" being an icon, no extra spacing was needed
there.
Note: I tried to use "1em" as spacing, but that did not work, so this PR
uses "10px".
Justin Bertram
AntonRoskvist
gtully
Andy Taylor
Domenico Francesco Bruscino
dhawkins
franz1981
Clebert Suconic
Sebastian Thomschke
Markus Meierhofer
Erwin Dondorp