Commit Graph

1551 Commits

Author SHA1 Message Date
Christopher L. Shannon (cshannon) 80ce96768e ARTEMIS-2752: Properly cleanup Federated Address Divert consumers
DivertBindings are now properly cleaned up when a queue binding is
removed that matches the divert. The correct key is now used to remove
the queue address from the set and the correct address is now used to
remove the remote consumer.
2020-05-11 14:56:24 -04:00
Andy Taylor 5737f965d2 ARTEMIS-2749 - Broadcast Group Control Improvements
added some default behaviour for when overridden

https://issues.apache.org/jira/browse/ARTEMIS-2749
2020-05-11 10:28:19 -05:00
Clebert Suconic 7438d7ff07 ARTEMIS-2750 Fixing out of order cancellations in AMQP 2020-05-04 13:15:56 -04:00
Andy Taylor 2ab381565c ARTEMIS-2749 - Broadcast Group Control Improvements
https://issues.apache.org/jira/browse/ARTEMIS-2749
2020-05-04 16:20:08 +01:00
Andy Taylor 8a04ee07de ARTEMIS-2648 - audit logging improvements
https://issues.apache.org/jira/browse/ARTEMIS-2648
2020-05-04 15:19:08 +01:00
Justin Bertram 0b155cf5ea ARTEMIS-2666 mngmnt for duplicate ID cache 2020-05-01 13:13:45 -05:00
Justin Bertram ea09a0fd39 ARTEMIS-2638 retro resources created recursively w/# match 2020-05-01 11:56:02 -05:00
Justin Bertram d53b2bcef6 ARTEMIS-2745 queue registering wrong metrics 2020-04-30 14:53:36 -05:00
Clebert Suconic 4c28297685 ARTEMIS-2741 Passing call timeout to cluster connection bridge
This one should improve eventual failures on ClusterConnectionControlTest
to validate this, run ClusterConnectionControlTest::testNotifications in a loop

you will see eventually the test taking longer to shutdown the executor as the call could be blocked.
2020-04-28 22:56:21 -04:00
Clebert Suconic 54c4611229 NO-JIRA test output cleanup 2020-04-28 21:48:21 -04:00
Justin Bertram 6709883d0e ARTEMIS-2738 implement per-acceptor security domains 2020-04-28 21:45:38 -04:00
Clebert Suconic 2ebf3c8e1b ARTEMIS-2372 Filtering on Message Annotations 2020-04-28 11:18:30 -04:00
Francesco Nigro 0abb06322c ARTEMIS-2717 Isolate the current Quorum Vote implementation 2020-04-23 18:24:11 -04:00
Justin Bertram 4b97e06890 ARTEMIS-2726 implement min/max expiry-delay 2020-04-23 17:56:51 -04:00
Clebert Suconic 3541ebf218 ARTEMIS-2732 Cleanup on testsuite logging 2020-04-22 23:08:46 -04:00
Clebert Suconic 11a3e810bb [maven-release-plugin] prepare for next development iteration 2020-04-21 17:06:21 -04:00
Clebert Suconic 30272e0c2f [maven-release-plugin] prepare release 2.12.0 2020-04-21 17:06:08 -04:00
Clebert Suconic 974609d206 ARTEMIS-2728 Fixing Deadlock with LargeServerMessage
verified by LargeMessageTest::testTwoBindingsAndRestart
2020-04-20 14:40:46 -04:00
brusdev 1d8e9f7fff ARTEMIS-2724 The setting auto-delete-created-queues doesn't work
Set the default auto-delete for created queues.
2020-04-20 14:16:37 -04:00
Clebert Suconic d81c0f44eb NO-JIRA Fixing intermittent failures 2020-04-20 11:38:03 -04:00
Clebert Suconic a000164169 ARTEMIS-2721 Activation keeps retrying even after server.stop()
This won't be an issue on a real server (Production system)

however, on the testsuite or while embedded this could cause issues,
if a same instance is stopped then started.

This is the reason why BackupAuthenticationTest was intermittently failing.

I also adapted the test since I would need to stop the server and reactivate it in order to change the configuration.
The previous test wasn't acting like a real server.
2020-04-17 18:26:22 -04:00
Clebert Suconic 45a4f6fc39 ARTEMIS-2720 Additional test
I wrote a small / quick test while I was testing the PR #3089
and I decided to keep it with the PR
2020-04-17 16:33:04 -04:00
Justin Bertram 6441068b95 ARTEMIS-2720 optimize match searching 2020-04-17 16:31:52 -04:00
Justin Bertram c841b84b3e ARTEMIS-2720 optimize cache clearing 2020-04-17 16:31:52 -04:00
Clebert Suconic d231e2ac63 [maven-release-plugin] prepare for next development iteration 2020-04-16 16:16:41 -04:00
Clebert Suconic 9636f4a3b0 [maven-release-plugin] prepare release 2.12.0 2020-04-16 16:16:28 -04:00
Clebert Suconic d9aacec8bb ARTEMIS-1975 Fixing Typo on QueueImpl::errorProcessing 2020-04-16 10:52:45 -04:00
Justin Bertram 410a552894 ARTEMIS-2711 use peer host:port for acceptor SSL engine 2020-04-16 10:32:54 -04:00
Clebert Suconic ad60a0b02b ARTEMIS-1975 Dealing with connection drops on AMQP Large Message 2020-04-15 22:26:58 -04:00
Francesco Nigro 46060b89ff ARTEMIS-2676 PageCursorProviderImpl::cleanup can save decoding pages without large messages 2020-04-15 22:20:50 -04:00
Francesco Nigro 5a829ff1f4 ARTEMIS-2713 Master failback can trigger a useless quorum vote on slave failover 2020-04-15 21:56:34 -04:00
Francesco Nigro e4c5ea719f ARTEMIS-2713 Added ReplicatedMultipleFailbackTest 2020-04-15 21:56:34 -04:00
Justin Bertram f0b4afa672 ARTEMIS-2714 log details for 'Address already in use'
Currently when the broker hits the common 'Address already in use' issue
when starting the process terminates with a vague exception. The user is
left to guess which acceptor actually failed. If the broker has lots of
acceptors it is a tedious process to identify the problematic
configuration. This commit adds details to the exception message about
which acceptor failed and which host:port it was attempting to bind to.
2020-04-15 15:48:59 -04:00
Justin Bertram 40a6bab898 ARTEMIS-2708 JDK bug causes missed props reload 2020-04-13 16:02:35 -04:00
Justin Bertram 701b4e4794 ARTEMIS-2692 refactor queue creation
This commit changes all tests to use the new methods.
2020-04-13 14:25:30 -05:00
Justin Bertram 2efa44daf5 ARTEMIS-2692 refactor queue creation
This commit does the following:
- Deprecates existing overloaded createQueue, createSharedQueue,
  createTemporaryQueue, & updateQueue methods for ClientSession,
  ServerSession, ActiveMQServer, & ActiveMQServerControl where
  applicable.
- Deprecates QueueAttributes, QueueConfig, & CoreQueueConfiguration.
- Deprecates existing overloaded constructors for QueueImpl.
- Implements QueueConfiguration with JavaDoc to be the single,
  centralized configuration object for both client-side and broker-side
  queue creation including methods to convert to & from JSON for use in
  the management API.
- Implements new createQueue, createSharedQueue & updateQueue methods
  with JavaDoc for ClientSession, ServerSession, ActiveMQServer, &
  ActiveMQServerControl as well as a new constructor for QueueImpl all
  using the new QueueConfiguration object.
- Changes all internal broker code to use the new methods.
2020-04-13 14:25:30 -05:00
Clebert Suconic 679bc1a3a0 ARTEMIS-2698 Fixing Typos on exposed group properties 2020-04-08 16:00:26 -04:00
brusdev 5f5c47e8a5 ARTEMIS-2693 Improve log of starting acceptor errors
Add the log of starting acceptor errors to simplify the detection of the
failing acceptor in case of multiple acceptors.
2020-04-08 15:44:26 -04:00
brusdev 24c0601519 ARTEMIS-2684 NullPointer exception when slave tries to scale down
Check the parentServer before to access to its configuration and storageManager.
2020-04-08 15:42:26 -04:00
brusdev 0f200a4798 ARTEMIS-2698 Expose queue group attributes 2020-04-08 12:53:56 -04:00
Francesco Nigro 124ed872a6 ARTEMIS-2702 QuorumVoteServerConnect with requestToStayLive is voting order sensitive 2020-04-08 12:53:03 -04:00
Clebert Suconic af796d5ce4 ARTEMIS-2701 Improving DLQ/check over previously removed records 2020-04-06 12:25:35 -04:00
brusdev 38a79be314 ARTEMIS-2691 Improve critical analyzer LOG policy
Reset the critical component timer after the expiration to allow further LOG
actions after the first expiration.
2020-04-04 18:19:46 -04:00
Clebert Suconic 4e1840dce2 NO-JIRA Fixing PagingStore not initialized exception during shutdown 2020-04-03 10:41:27 -04:00
Atri Sharma 505b3b0fdc ARTEMIS-2636: Add Disk Store Usage Metrics
ARTEMIS-2688: Check Arguments In FileStoreMonitor.calculateUsage
2020-04-02 11:04:42 -04:00
Francesco Nigro 493ce497c7 ARTEMIS-1975 Fix AMQP paged large message usage counter 2020-04-01 17:46:26 -04:00
Atri Sharma 405eb969c1 ARTEMIS-2636: Introduce Disk Usage Metrics
ARTEMIS-2636: This commit introduces metrics to publish the amount of disk used currently
2020-03-30 22:27:58 -04:00
Justin Bertram 59e07c9780 ARTEMIS-2681 timestamp not set on notif msgs 2020-03-27 15:42:26 -04:00
Clebert Suconic ddb67ccdb1 ARTEMIS-1975 Fixing deadlock after error processing 2020-03-26 16:07:18 -04:00
Clebert Suconic ca50b3449e ARTEMIS-1975 Removing ThreadLocal for StorageManager 2020-03-25 21:54:46 -04:00
Justin Bertram fdfe3ba3fa ARTEMIS-2679 deprecate message-expiry-thread-priority
Due to the changes in 6b5fff40cb the
config parameter message-expiry-thread-priority is no longer needed. The
code now uses a ScheduledExecutorService and a thread pool rather than
dedicating a thread 100% to the expiry scanner. The pool's size can be
controlled via scheduled-thread-pool-max-size.
2020-03-25 16:43:38 -04:00
Justin Bertram d0afa6a7e6 NO-JIRA remove stale notification property
This appears to have been added to the code-base by mistake over 10
years ago. It seems related to debugging and I can't see anywhere where
it is actually used so I'm removing it.
2020-03-25 16:40:53 -04:00
Clebert Suconic a4489a322e ARTEMIS-1975 Moving encode cache towards AMQPLargeMessage
Using a property on AMQPLargeMessage instead of a ThreadLocal
This was causing issues on the journal as the message may transverse different threads on the journal.
2020-03-24 18:22:59 -04:00
Clebert Suconic f874a02d17 ARTEMIS-2673 PageStore should only be removed when Address is removed
& ARTEMIS-2674 AMQP should use a separate executor for IO
2020-03-23 20:02:17 -04:00
Justin Bertram 3107535a32 ARTEMIS-2671 NPE in LDAP security plugin listener
To get the name of the destination use the relative Rdn position rather than a
strict match of "uid". Also, improve logging.
2020-03-23 17:02:38 -04:00
Justin Bertram 402dda2161 ARTEMIS-2667 NPE w/clearing non-durable dupl ID cache 2020-03-23 16:55:42 -04:00
Benjamin Graf 2645f3df46 NO-JIRA: Fix small typo in variable name and toString representation 2020-03-23 15:06:30 -05:00
Clebert Suconic 7bf8bcc7fe ARTEMIS-2662 Make Page to be resilient to invalid position
in case of an invalid position on getMessage, it should instead of runtimeException
be more resilient and fix itself.
2020-03-18 12:04:50 -04:00
Justin Bertram 2eae280a9f ARTEMIS-2576 fix possible NPE for auth failure 2020-03-17 14:26:34 -05:00
Clebert Suconic c801c00e33 ARTEMIS-2662 Using previously stored encodeSize on page record offset
There is no guarantee that the encodeSize size is the same in AMQP right after read.
As the protocol may add additional bytes right after decoded such as header, extra properties.. etc.
2020-03-17 05:55:25 -04:00
Francesco Nigro 2105479304 ARTEMIS-2658 AMQP message read from page has wrong encode size 2020-03-16 18:20:39 +01:00
Francesco Nigro 2025cbbfd0 ARTEMIS-2656 NPE with read-whole-page == true 2020-03-13 13:51:37 +01:00
brusdev 951b5d5ded ARTEMIS-2652 Fix PageCursorProviderImplTest on IBM JVM
Replace the page mock to fix an incompatibility between IBM JDK and Mockito.
2020-03-11 11:32:47 -04:00
Justin Bertram ed7fee6d9c ARTEMIS-2643 allow masked password when resetting via mgmnt 2020-03-05 21:38:09 -05:00
Justin Bertram b2417d33b1 ARTEMIS-2640 mgmnt ops reporting wrong audit details 2020-03-05 21:37:37 -05:00
Justin Bertram 339ccccbd7 ARTEMIS-2631 address orphaned from JMS temp queue 2020-03-05 21:36:35 -05:00
Justin Bertram 766f88c22a ARTEMIS-2629 ensure queue auto-delete after expiration 2020-03-05 21:35:35 -05:00
Justin Bertram 8c259116a8 NO-JIRA clarify & verify web socket support for MQTT 2020-03-05 21:34:53 -05:00
Clebert Suconic ddd8ed4402 ARTEMIS-1975 Real Large Message support into AMQP
This is a Large commit where I am refactoring largeMessage Body out of CoreMessage
which is now reused with AMQP.

I had also to fix Reference Counting to fix how Large Messages are Acked

And I also had to make sure Large Messages are transversing correctly when in cluster.
2020-02-25 15:25:01 +01:00
Justin Bertram d0758f34f6 ARTEMIS-2624 auto-create expiry resources 2020-02-20 17:44:56 -05:00
Justin Bertram b76f3b3a0d ARTEMIS-2587 auto-create dead-letter resources
This is a reimplementation of the IndividualDeadLetterQueueStrategy
from 5.x in a way that makes sense with the Artemis addressing model.
2020-02-20 17:44:56 -05:00
Christopher L. Shannon (cshannon) 3966e47338 ARTEMIS-2613: Add support for DivertBindings for federated addresses
This will allow federated addresses to create remote consumers based on
the existing of divert bindings and matching queue bindings
2020-02-17 12:15:18 -05:00
Clebert Suconic 990890d228 ARTEMIS-2622 Making replica resilient to closed pages 2020-02-14 14:01:52 -05:00
Justin Bertram a8cf6b04b4 ARTEMIS-2607 interceptor returns false but processing continues 2020-02-14 13:23:05 -05:00
Francesco Nigro 5897909dc9 ARTEMIS-2617 use core pools to reduce GC on journal loading 2020-02-12 13:29:51 -05:00
Francesco Nigro 3282f105bb ARTEMIS-2604 Optimize journal loading
- Avoid some Properties Decoding, checking if we need certain properties like scheduled delivery
- Avoid creating some unnecessary SimpleString instances
- Removed some intermediate ActiveMQBuffer allocation
- Removed some intermediate UnreleasableByteBuf allocation
2020-02-05 11:13:53 -05:00
sebthom 4bc5c6f2a8 NO-JIRA Add serialVersionUID and remove redundant casts
Adding serialVersionUID to WildcardConfiguration since it is
serializable. Without serialVersionUID  being specified a new one is
generated on each compilation which prevents object deserialization
between releases.
2020-02-03 09:54:43 -06:00
Sebastian Thomschke 85a1c753d7 NO-JIRA Wrong autoDeleteDelay value passed to createSharedQueue 2020-02-03 09:53:13 -06:00
Sebastian Thomschke 3797b62420 NO-JIRA Remove unnecessary null-check in ExpiryScanner 2020-02-03 09:51:49 -06:00
sebthom cfa11bbadc ARTEMIS-2610 Improve ActiveMQServer.getConnectionCount() 2020-02-03 09:44:17 -06:00
Christopher L. Shannon d1558f172b
This closes #2958 2020-01-30 15:54:13 -05:00
Christopher L. Shannon 7ad2d0f71a
This closes #2959 2020-01-30 15:53:12 -05:00
Sebastian Thomschke 0250f84921
NO-JIRA Fix Javadoc warning in ActiveMQTestBase
Fixes Javadoc warnings "Javadoc: Exception Exception is not declared" and "Javadoc: Exception InterruptedException is not declared"
2020-01-29 17:34:08 +01:00
Sebastian Thomschke c117976e3a
NO-JIRA Fix Javadoc @link syntax in ActiveMQServerConsumerPlugin
Fixes Javadoc warning "Javadoc: Missing closing brace for inline tag"
2020-01-29 17:21:53 +01:00
Sebastian Thomschke a3aa669827
NO-JIRA Fix compiler warning in FileConfigurationParserTest
Fixes compiler warning "Unnecessary cast from String to String".
2020-01-29 17:15:53 +01:00
Wei Yang 1d1f0625db ARTEMIS-2544 Remove rolledback PageTransactionInfo to free up memory 2020-01-23 11:23:14 +08:00
Sebastian Thomschke cf26103bb2 ARTEMIS-2571 Remove synchronization of ActiveMQServerImpl#getSessions() 2020-01-22 15:32:55 -06:00
Francesco Nigro c3e74e055c ARTEMIS-2599 DescribeJournal isn't correctly counting surviving msg 2020-01-21 12:14:02 -05:00
Francesco Nigro fa0c187ae6 ARTEMIS-2602 Reduce number of copies for non JDBC Journal 2020-01-18 18:45:12 +01:00
Francesco Nigro b10d765139 ARTEMIS-2602 load surviving records into SparseArrayLinkedList 2020-01-17 14:31:52 -05:00
Clebert Suconic 1a6c4e5c62 ARTEMIS-2603 Deadlock between pageStore.getCurrentID and page.cleanup
This happened when JournalStorageManager.startReplication and PageStore.cleanup were called between multiple threads.
2020-01-17 11:39:30 -05:00
Clebert Suconic bbe9f9adce NO-JIRA Adding test name into temporary folder name directory
This is to make it possible to identify what test is leaking files whenever that is happening.
That is because future tests will report the leaks, and it's difficult to identify where it happened.

Also i'm changing NoProcessFilesBehind to show the getOpenFD propertly
2020-01-13 09:39:51 -05:00
Justin Bertram 97735ca72c [maven-release-plugin] prepare for next development iteration 2020-01-10 09:00:58 -06:00
Justin Bertram 25a947f6cb [maven-release-plugin] prepare release 2.11.0 2020-01-10 08:57:46 -06:00
Clebert Suconic e397a17796 ARTEMIS-2592 Fixing DeadLock between deleteMessages and depage
This was happening through purge
2020-01-09 19:41:14 -06:00
yang wei 3e20906a49 NO-JIRA typo on logger 2020-01-09 15:21:29 -06:00
Justin Bertram 9e9c0778b1 ARTEMIS-2516 support sys props in xinclude href 2020-01-09 14:04:09 -05:00
Clebert Suconic 534d8b4719 NO-JIRA Happy new year! 2020-01-08 20:44:05 -05:00
Justin Bertram 0293d80574 NO-JIRA support 0 in human readable byte calculation 2020-01-08 12:37:30 -06:00
Wei Yang 0e6a1dee47 ARTEMIS-2584 Optimize PageTransactionInfoImpl in-memory size 2020-01-08 12:39:14 -05:00