Commit Graph

11036 Commits

Author SHA1 Message Date
Clebert Suconic cbbaa7a8e0 NO-JIRA Mirror and Divert Smoke Test
I was doing some verification with Diverts and Mirror in the form of a smoke test.

no issue found but I'm keeping the test.
2024-07-30 20:41:53 -04:00
Howard Gao 4ce0dfca2d ARTEMIS-4959 moveMessages operation can move more messages than max messageCount 2024-07-30 11:55:53 -04:00
Justin Bertram 86f36e95b0 ARTEMIS-4960 Ubuntu package name change preventing Docker image build 2024-07-29 16:28:45 -05:00
Howard Gao 096a869c1e ARTEMIS-4954 AddressControl.pause() can pause the snf queue 2024-07-25 19:51:30 -04:00
Timothy Bish 284ce80618 ARTEMIS-4952 Use getObjectPropertyForFilter when applying filters
When counting messages with provided filters and grouping use the API
getObjectPropertyForFilter which translates values from AMQP message
annotations that are otherwise missed by the filters.
2024-07-25 19:51:19 -04:00
Clebert Suconic fa917ae3fd [maven-release-plugin] prepare for next development iteration 2024-07-25 13:47:10 -04:00
Clebert Suconic 75f17ba64d [maven-release-plugin] prepare release 2.36.0 2024-07-25 13:47:09 -04:00
Clebert Suconic db0ba73aa4 ARTEMIS-4941 Remove lazy update after application properties only when it's paging
for regular messages it's quite obvious when the message is leaving the queue but for paged messages it becomes a challenge. We should just ignore the update for paged messages.
2024-07-25 13:01:57 -04:00
Clebert Suconic 1a5c2ec51c Revert "ARTEMIS-4941 Remove lazy update after application properties as it's no longer needed"
This reverts commit fb2a57f3ed.
2024-07-25 13:01:57 -04:00
Robbie Gemmell 90797e1c42 ARTEMIS-4953: update to activemq 5.18.5 2024-07-25 13:06:52 +01:00
Domenico Francesco Bruscino c50f0e7001 ARTEMIS-4951 Support multiple connection router occurrences with same policy 2024-07-25 11:04:09 +01:00
Justin Bertram 8841c50591
NO-JIRA flesh out 2.36.0 highlights 2024-07-24 12:46:23 -05:00
Clebert Suconic 00e400c96c Edit on versions.adoc 2024-07-24 13:23:03 -04:00
Clebert Suconic e05549603a Update versions.adoc 2024-07-24 13:16:51 -04:00
Clebert Suconic ca44ad2a33 ARTEMIS-3509 Improving assertions in StompTest 2024-07-24 12:13:07 -04:00
Clebert Suconic e50c73eac9 Revert "ARTEMIS-3509 Improving assertions on StompTest"
Sorry for the spam, I pushed this commit by mistake / accident

This reverts commit db0a0975bb.
2024-07-24 10:42:19 -04:00
Clebert Suconic db0a0975bb ARTEMIS-3509 Improving assertions on StompTest 2024-07-24 09:59:43 -04:00
Justin Bertram 8d1a66fbbd ARTEMIS-4931 fix bridge config encoding
This commit fixes 3 distinct issues with bridge configuration encoding:

 - The encoding size was calculated incorrectly in three ways:
   - Using 0 instead of `DataConstants.SIZE_NULL` when no transformer is
     defined resulting in a calculated size discrepancy of -1.
   - Using `DataConstants.INT` instead of `DataConstants.SIZE_INT` for
     the number of transformer properties resulting in a calculated size
     discrepancy of +2 when using a configuration with a transformer.
   - Using 0 or `sizeOfNullableInteger` instead of
     `DataConstants.SIZE_INT` for the number of static connectors
     resulting in a variable calculated size discrepancy of either -4 or
     +1 respectively.
 - Encoding was using `writeString` instead of `writeNullableString` for
   the name of the transformer class resulting in an actual buffer size
   discrepancy of -1.

Aside from these fixes this commit also adds new tests specifically for
encoding & decoding include a test to verify known bytes during
encoding.

Lastly, it's worth noting that this *won't fix* bad data that was
already stored to disk by an older broker or bad data that comes over
the wire from an older broker (e.g. if a older primary broker paired
with a newer backup).
2024-07-24 14:51:55 +01:00
Justin Bertram 5c160ae1a8 ARTEMIS-4930 refactor storage manager tests
During the investigation for ARTEMIS-4910 it was noted that some of the
storage manager tests didn't actually force a full reload (i.e.
decoding) of the various configurations from disk. This commit does the
following:

 - refactors these tests so that they all force a reload from disk
 - organizes imports
 - eliminates various bits of repeated code in all the tests
 - improves code formatting

This commit exposes a bug in the encoding/decoding of
BridgeConfiguration via a failing test in
BridgeConfigurationStorageTest. This test is disabled. This failure will
be resolved in a subsequent commit at which point the test will be
enabled again.
2024-07-24 14:51:55 +01:00
Andy Taylor 9853211913 ARTEMIS-4950 - MBeanGuard throws an NPE
Although this doesnt affect the current console it does the new so needs addressing
2024-07-24 09:50:03 -04:00
Clebert Suconic ae26a8640f NO-JIRA Removing System.out from a test 2024-07-23 16:28:15 -04:00
Clebert Suconic 7c573db6a1 ARTEMIS-4949 TimedBuffer.checkSync could fail on ClosedChannelException 2024-07-23 12:56:33 -04:00
Justin Bertram 10adca5479 ARTEMIS-4923 reduce synchronization in ManagementServiceImpl
The `ManagementService` is used by the broker to register and
unregister components for management as well as send notifications.
When the broker is busy dealing with new sessions and auto-creating
queues, addresses, etc. there is a lot of contention.

To reduce synchronization and improve the service overall this commit
does the following:

 - Remove `synchronized` from most methods. In most cases it's
   completely unnecessary because the methods are already using a
   thread-safe data-structure (e.g. `ConcurrentHashMap`) or more
   specific synchronization is already in place (e.g. on
   `mbeanServer`).
 - Adds new & clarifies existing logging.
 - Synchronizes `start` & `stop` methods and adds gates via `started`.
 - Simplifies the `sendNotification` method by synchronizing once rather
   than twice and performing legitimacy checks sooner.
 - Removing an unnecessary overload of the `registereQueue` method.

To be clear, there are no tests included with this commit as there
should be no semantic changes. Existing tests should be sufficient to
identify any regressions.
2024-07-23 09:19:18 -07:00
Justin Bertram 26cc17c337
ARTEMIS-4948 clarify failover-on-shutdown doc 2024-07-23 10:55:21 -05:00
Clebert Suconic 41ec279e22 NO-JIRA Making test more resilient 2024-07-22 18:57:27 -04:00
Justin Bertram 71187c475d
This closes #5105 2024-07-22 15:39:58 -05:00
dependabot[bot] 77a9d84a76
ARTEMIS-4946 Bump selenium.version from 4.22.0 to 4.23.0
Bumps `selenium.version` from 4.22.0 to 4.23.0.

Updates `org.seleniumhq.selenium:selenium-api` from 4.22.0 to 4.23.0
- [Release notes](https://github.com/SeleniumHQ/selenium/releases)
- [Commits](https://github.com/SeleniumHQ/selenium/compare/selenium-4.22.0...selenium-4.23.0)

Updates `org.seleniumhq.selenium:selenium-firefox-driver` from 4.22.0 to 4.23.0
- [Release notes](https://github.com/SeleniumHQ/selenium/releases)
- [Commits](https://github.com/SeleniumHQ/selenium/compare/selenium-4.22.0...selenium-4.23.0)

Updates `org.seleniumhq.selenium:selenium-chrome-driver` from 4.22.0 to 4.23.0
- [Release notes](https://github.com/SeleniumHQ/selenium/releases)
- [Commits](https://github.com/SeleniumHQ/selenium/compare/selenium-4.22.0...selenium-4.23.0)

Updates `org.seleniumhq.selenium:selenium-chromium-driver` from 4.22.0 to 4.23.0
- [Release notes](https://github.com/SeleniumHQ/selenium/releases)
- [Commits](https://github.com/SeleniumHQ/selenium/compare/selenium-4.22.0...selenium-4.23.0)

Updates `org.seleniumhq.selenium:selenium-remote-driver` from 4.22.0 to 4.23.0
- [Release notes](https://github.com/SeleniumHQ/selenium/releases)
- [Commits](https://github.com/SeleniumHQ/selenium/compare/selenium-4.22.0...selenium-4.23.0)

Updates `org.seleniumhq.selenium:selenium-support` from 4.22.0 to 4.23.0
- [Release notes](https://github.com/SeleniumHQ/selenium/releases)
- [Commits](https://github.com/SeleniumHQ/selenium/compare/selenium-4.22.0...selenium-4.23.0)

---
updated-dependencies:
- dependency-name: org.seleniumhq.selenium:selenium-api
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.seleniumhq.selenium:selenium-firefox-driver
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.seleniumhq.selenium:selenium-chrome-driver
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.seleniumhq.selenium:selenium-chromium-driver
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.seleniumhq.selenium:selenium-remote-driver
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.seleniumhq.selenium:selenium-support
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-07-22 15:39:23 -05:00
Justin Bertram c246df86b8
This closes #5106 2024-07-22 15:37:57 -05:00
dependabot[bot] 09adbdb61a
ARTEMIS-4945 Bump netty.version from 4.1.111.Final to 4.1.112.Final
Bumps `netty.version` from 4.1.111.Final to 4.1.112.Final.

Updates `io.netty:netty-buffer` from 4.1.111.Final to 4.1.112.Final
- [Commits](https://github.com/netty/netty/compare/netty-4.1.111.Final...netty-4.1.112.Final)

Updates `io.netty:netty-transport` from 4.1.111.Final to 4.1.112.Final
- [Commits](https://github.com/netty/netty/compare/netty-4.1.111.Final...netty-4.1.112.Final)

Updates `io.netty:netty-handler` from 4.1.111.Final to 4.1.112.Final
- [Commits](https://github.com/netty/netty/compare/netty-4.1.111.Final...netty-4.1.112.Final)

Updates `io.netty:netty-handler-proxy` from 4.1.111.Final to 4.1.112.Final
- [Commits](https://github.com/netty/netty/compare/netty-4.1.111.Final...netty-4.1.112.Final)

Updates `io.netty:netty-codec` from 4.1.111.Final to 4.1.112.Final
- [Commits](https://github.com/netty/netty/compare/netty-4.1.111.Final...netty-4.1.112.Final)

Updates `io.netty:netty-codec-http` from 4.1.111.Final to 4.1.112.Final
- [Commits](https://github.com/netty/netty/compare/netty-4.1.111.Final...netty-4.1.112.Final)

Updates `io.netty:netty-codec-mqtt` from 4.1.111.Final to 4.1.112.Final
- [Commits](https://github.com/netty/netty/compare/netty-4.1.111.Final...netty-4.1.112.Final)

Updates `io.netty:netty-codec-socks` from 4.1.111.Final to 4.1.112.Final
- [Commits](https://github.com/netty/netty/compare/netty-4.1.111.Final...netty-4.1.112.Final)

Updates `io.netty:netty-common` from 4.1.111.Final to 4.1.112.Final
- [Commits](https://github.com/netty/netty/compare/netty-4.1.111.Final...netty-4.1.112.Final)

Updates `io.netty:netty-resolver` from 4.1.111.Final to 4.1.112.Final
- [Commits](https://github.com/netty/netty/compare/netty-4.1.111.Final...netty-4.1.112.Final)

Updates `io.netty:netty-transport-native-unix-common` from 4.1.111.Final to 4.1.112.Final
- [Commits](https://github.com/netty/netty/compare/netty-4.1.111.Final...netty-4.1.112.Final)

Updates `io.netty:netty-transport-classes-epoll` from 4.1.111.Final to 4.1.112.Final
- [Commits](https://github.com/netty/netty/compare/netty-4.1.111.Final...netty-4.1.112.Final)

Updates `io.netty:netty-transport-native-epoll` from 4.1.111.Final to 4.1.112.Final
- [Commits](https://github.com/netty/netty/compare/netty-4.1.111.Final...netty-4.1.112.Final)

Updates `io.netty:netty-transport-classes-kqueue` from 4.1.111.Final to 4.1.112.Final
- [Commits](https://github.com/netty/netty/compare/netty-4.1.111.Final...netty-4.1.112.Final)

Updates `io.netty:netty-transport-native-kqueue` from 4.1.111.Final to 4.1.112.Final
- [Commits](https://github.com/netty/netty/compare/netty-4.1.111.Final...netty-4.1.112.Final)

---
updated-dependencies:
- dependency-name: io.netty:netty-buffer
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: io.netty:netty-transport
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: io.netty:netty-handler
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: io.netty:netty-handler-proxy
  dependency-type: direct:development
  update-type: version-update:semver-patch
- dependency-name: io.netty:netty-codec
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: io.netty:netty-codec-http
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: io.netty:netty-codec-mqtt
  dependency-type: direct:development
  update-type: version-update:semver-patch
- dependency-name: io.netty:netty-codec-socks
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: io.netty:netty-common
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: io.netty:netty-resolver
  dependency-type: direct:development
  update-type: version-update:semver-patch
- dependency-name: io.netty:netty-transport-native-unix-common
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: io.netty:netty-transport-classes-epoll
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: io.netty:netty-transport-native-epoll
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: io.netty:netty-transport-classes-kqueue
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: io.netty:netty-transport-native-kqueue
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-07-22 15:37:36 -05:00
Justin Bertram 513b0445bc
This closes #5095 2024-07-22 15:36:26 -05:00
dependabot[bot] 38a2e665b2
ARTEMIS-4944 Bump testcontainers.version from 1.19.8 to 1.20.0
Bumps `testcontainers.version` from 1.19.8 to 1.20.0.

Updates `org.testcontainers:testcontainers` from 1.19.8 to 1.20.0
- [Release notes](https://github.com/testcontainers/testcontainers-java/releases)
- [Changelog](https://github.com/testcontainers/testcontainers-java/blob/main/CHANGELOG.md)
- [Commits](https://github.com/testcontainers/testcontainers-java/compare/1.19.8...1.20.0)

Updates `org.testcontainers:selenium` from 1.19.8 to 1.20.0
- [Release notes](https://github.com/testcontainers/testcontainers-java/releases)
- [Changelog](https://github.com/testcontainers/testcontainers-java/blob/main/CHANGELOG.md)
- [Commits](https://github.com/testcontainers/testcontainers-java/compare/1.19.8...1.20.0)

---
updated-dependencies:
- dependency-name: org.testcontainers:testcontainers
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.testcontainers:selenium
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-07-22 15:35:43 -05:00
Justin Bertram b59bf88c74
This closes #5093 2024-07-22 15:34:29 -05:00
dependabot[bot] fe00c62a7c
ARTEMIS-4943 Bump owasp.version from 10.0.0 to 10.0.3
Bumps `owasp.version` from 10.0.0 to 10.0.3.

Updates `org.owasp:dependency-check-maven` from 10.0.0 to 10.0.3
- [Release notes](https://github.com/jeremylong/DependencyCheck/releases)
- [Changelog](https://github.com/jeremylong/DependencyCheck/blob/main/CHANGELOG.md)
- [Commits](https://github.com/jeremylong/DependencyCheck/compare/v10.0.0...v10.0.3)

Updates `org.owasp:dependency-check-core` from 10.0.0 to 10.0.3
- [Release notes](https://github.com/jeremylong/DependencyCheck/releases)
- [Changelog](https://github.com/jeremylong/DependencyCheck/blob/main/CHANGELOG.md)
- [Commits](https://github.com/jeremylong/DependencyCheck/compare/v10.0.0...v10.0.3)

Updates `org.owasp:dependency-check-utils` from 10.0.0 to 10.0.3
- [Release notes](https://github.com/jeremylong/DependencyCheck/releases)
- [Changelog](https://github.com/jeremylong/DependencyCheck/blob/main/CHANGELOG.md)
- [Commits](https://github.com/jeremylong/DependencyCheck/compare/v10.0.0...v10.0.3)

---
updated-dependencies:
- dependency-name: org.owasp:dependency-check-maven
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.owasp:dependency-check-core
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.owasp:dependency-check-utils
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-07-22 15:33:45 -05:00
Justin Bertram 016e897917
This closes #5089 2024-07-22 15:32:11 -05:00
dependabot[bot] fcdbff3a7b
ARTEMIS-4942 Bump org.apache.maven.plugins:maven-pmd-plugin
Bumps [org.apache.maven.plugins:maven-pmd-plugin](https://github.com/apache/maven-pmd-plugin) from 3.23.0 to 3.24.0.
- [Release notes](https://github.com/apache/maven-pmd-plugin/releases)
- [Commits](https://github.com/apache/maven-pmd-plugin/compare/maven-pmd-plugin-3.23.0...maven-pmd-plugin-3.24.0)

---
updated-dependencies:
- dependency-name: org.apache.maven.plugins:maven-pmd-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-07-22 15:31:37 -05:00
Clebert Suconic fb2a57f3ed ARTEMIS-4941 Remove lazy update after application properties as it's no longer needed 2024-07-22 15:31:36 -04:00
Justin Bertram 642a2c79fd ARTEMIS-4913 provide more details on error callbacks 2024-07-22 15:38:25 +01:00
Robbie Gemmell bc1bb99d37 ARTEMIS-4940: update to protonj2 test driver 1.0.0-M21 2024-07-22 11:27:07 +01:00
Robbie Gemmell 7d9a64b4d1 ARTEMIS-4869: update to errorprone 2.29.2 2024-07-22 09:51:33 +01:00
Clebert Suconic 9e8df4cf7a ARTEMIS-4821 OperationContext leaking on SendAckThread
co-authored: nmeylan (test attached to the JIRA)
2024-07-21 22:23:38 -04:00
Justin Bertram 4e1daccfe3 ARTEMIS-4912 filter not enforced when sending msg to q via web console 2024-07-19 15:00:45 -05:00
Justin Bertram 4053698014
ARTEMIS-4936 make test more resilient 2024-07-19 10:58:31 -05:00
Timothy Bish 75034e32b6 ARTEMIS-4938 Update commons-lang to 3.15.0 2024-07-19 10:43:26 -04:00
Justin Bertram 9a0797509d ARTEMIS-4936 verify response correlationId when using Core client
If, for whatever reason, the response for a packet sent with blocking
semantics is never returned it's possible that an async response
received in the interventing time will be interpreted as the current
response. This is because ChannelImpl does not verify the correlation
ID set on the response packet when it is received.
2024-07-19 07:05:46 -07:00
Timothy Bish 2eebebf601 ARTEMIS-4839 Update jline to v3.26.3 2024-07-18 18:17:29 -04:00
Clebert Suconic bcdf626efa NO-JIRA Speeding up test
Removing redundant verification that was just spending time and not being verified.
2024-07-18 16:00:37 -04:00
Clebert Suconic da7dccae87 ARTEMIS-4925 Making assertion to also consider journal and other files from the broker
Small change but say there's ever a leak on the journal. Removing the clause from paging would allow to also capture other leaks.

This is currently not an issue and the test should still pass.
2024-07-18 14:16:02 -04:00
Clebert Suconic 79708749e8 NO-JIRA Speending up a failover test
No need for the iterations, and a few minor improvements to the test.

This method was taking up to 15 seconds on the CI and the same method is reused a couple times, resulting in many minutes wasted
2024-07-18 14:16:02 -04:00
Clebert Suconic 58f9e00874 ARTEMIS-4925 adding missing assertion on the test 2024-07-17 12:02:41 -04:00
Clebert Suconic 569a07c287 ARTEMIS-4925 Allowing server reuse on a test 2024-07-17 10:19:27 -04:00