Commit Graph

6420 Commits

Author SHA1 Message Date
Justin Bertram eb50546a4f NO-JIRA fix race condition in QueueQueryTest 2019-01-24 14:32:56 -05:00
Michael Andre Pearce 7ea7b85f1a This closes #2427 2019-01-24 08:31:11 +00:00
Michael André Pearce cf65912bcc ARTEMIS-2170 Optimized CoreMessage clearInternalProperties
Ensure only iterate properties, if internal property is set.
2019-01-24 08:31:10 +00:00
Francesco Nigro 6446d01a15 ARTEMIS-2170 Optimized CoreMessage check and cleanup methods
Any checkProperties();<usage of this.properties> pattern has been
replaced by an atomic checkProperties().<usage of returned properties>
to help both performance and consistency.
The cleanup is now performed into CoreTypedProperties both
for performance reasons (avoid lock/unlock many times)
and consistency, given that the operation is now atomic.
2019-01-24 08:31:10 +00:00
Clebert Suconic b73ff1b48e This closes #2305 2019-01-23 21:30:36 -05:00
Howard Gao 90ca87c5e1 ARTEMIS-2088 - Page.write() should throw exception if file is closed
In Page.write(final PagedMessage message) if the page file is closed
it returns silently. The caller has no way to know that if the message
is paged to file or not. It should throw an exception so that the
caller can handle it correctly.

This causes random failure PagingTest#testExpireLargeMessageOnPaging().
The test shows that when the server stops it closes the page file.
In the mean time a message is expired to the expiry queue and if
the expiry queue is in paging mode, it goes to Page.write() and
returns without any error. The result is that the message is removed
from the original queue and not added to the expiry queue.

If we throw exception here it makes the expiration failed, the message
will not be removed from the orginal queue. Next time broker is started,
the message will be reloaded and expired again. no message lost.
2019-01-23 21:25:58 -05:00
Clebert Suconic 3ac96491ec NO-JIRA Update year to 2019 2019-01-23 21:06:09 -05:00
Clebert Suconic 9a15dcecc3 This closes #2515 2019-01-23 13:32:10 -05:00
Justin Bertram a4a929a154 ARTEMIS-1867 fix FQQNOpenWireTest 2019-01-23 13:32:09 -05:00
Clebert Suconic 5a19c54f9f ARTEMIS-196 Removing dead variables
Fixing build after removing variable used by FieldUpdater
2019-01-23 13:31:31 -05:00
Clebert Suconic 99b24adfba This closes #2451 2019-01-23 11:52:33 -05:00
Justin Bertram 8d7d78074c ARTEMIS-2192 LegacyLDAPSecuritySettingPlugin uses hard-coded RDN types
Change the LegacyLDAPSecuritySettingPlugin to interpret the search
results based on the order of the returned RDNs rather than hard-coded
types.
2019-01-23 11:52:32 -05:00
Clebert Suconic d7c940d01a This closes #2490 2019-01-23 11:30:58 -05:00
Clebert Suconic f225a4e166 ARTEMIS-196 Removing dead variables
This is really a NO-JIRA
however it was done in the context of merging ARTEMIS-196
2019-01-23 11:25:15 -05:00
Michael André Pearce 7dfa0fe7f4 ARTEMIS-196 Implement Consumer Priority
Add consumer priority support
Includes refactor of consumer iterating in QueueImpl to its own logical class, to be able to implement.
Add OpenWire JMS Test - taken from ActiveMQ5
Add Core JMS Test
Add AMQP Test
Add Docs
2019-01-23 11:19:24 -05:00
Clebert Suconic 71d5494345 This closes #2510 2019-01-23 10:17:03 -05:00
Luis De Bello d78eeb05cd ARTEMIS-2156 Message Duplication when using exclusive divert and clustering 2019-01-23 10:17:03 -05:00
Clebert Suconic fd1447a168 This closes #2514 2019-01-23 10:10:53 -05:00
Michael André Pearce d4c41e45bc ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451
Readdress ARTEMIS-1451 concern of sync blocks, remove synchronization by simplifying original code and using atomics.
2019-01-23 10:01:40 +00:00
Michael André Pearce b9a063f2e7 ARTEMIS-2236 - Revert Original ARTEMIS-1451
This reverts commit f8b758d1
2019-01-23 09:54:19 +00:00
Clebert Suconic 9599fab372 This closes #2506 2019-01-22 17:42:57 -05:00
Howard Gao b5e7b703b5 ARTEMIS-2230 Exception closing advisory consumers when supportAdvisory=false
When broker's advisory is disabled (supportAdvisory=false) any
advisory consumer won't get created at broker and the advisory
consumer ID won't be stored.

Legacy openwire clients can have a reference of advisory consumer
regardless broker's settings and therefore when it closes the
advisory consumer the broker has no reference to it.
Therefore broker throws an exception like:

javax.jms.IllegalStateException: Cannot
remove a consumer that had not been registered

If the broker stores the consumer info (even it doesn't create
it) the exception can be avoided.
2019-01-22 17:42:57 -05:00
Clebert Suconic 261b05e5c4 This closes #2473 2019-01-22 17:37:13 -05:00
Howard Gao ae00423034 ARTEMIS-1058 Jars in web tmp dir locked on Windows
Because Sun's URLClassLoader never closes it's jar file handles
Jetty doesn't cleanup is temp web dir after Artemis broker shut
down normally on Windows.

To work around this a new process is forked before broker VM
exits to clean up the tmp dir if they are not deleted. The
new process out lives the main VM so that those jar's handles
are released and the temp dir can be cleaned up.
2019-01-22 17:37:12 -05:00
Clebert Suconic 02dcc9e37b NO-JIRA update shade plugin
We were hitting a bug on shade, where shade was trying to download our own sources
instead of using from the local built repository.
2019-01-22 09:40:44 -05:00
Francesco Nigro 6c8bd53561 This closes #2513 2019-01-22 12:08:28 +01:00
andytaylor 2d768760af ARTEMIS-2235 - remove credentials from browser log
https://issues.apache.org/jira/browse/ARTEMIS-2235
2019-01-22 12:08:28 +01:00
Francesco Nigro dc5404a6c3 This closes #2512 2019-01-22 11:54:28 +01:00
Martyn Taylor bab7bd05c8 Remove test scope for jaxrs module 2019-01-22 10:48:10 +00:00
Martyn Taylor 569ce9d8a3 Add Interceptor Example 2019-01-22 10:48:10 +00:00
Martyn Taylor 132763f067 Added ability to skip doc and website creation 2019-01-22 10:48:10 +00:00
Justin Bertram c0252c7cae This closes #2511 2019-01-21 14:20:57 -06:00
Emmanuel Hugonnet 8b272bd1c8 ARTEMIS-2234 fix warning from LoggingConfigurationFileReloader
return the LogContextConfiguration if we have one
2019-01-21 14:19:09 -06:00
Howard Gao 65d01a4f91 This closes #2509 2019-01-21 13:27:53 +08:00
Michael André Pearce 55732d401f NO-JIRA Fix Possible NPE in connectToNodeInReplicatedCluster
Variable possibleLive may be null, as signified by trace log above, also dedupe code.
2019-01-21 13:26:24 +08:00
Michael Andre Pearce 3aebe74d07 This closes #2444 2019-01-19 08:16:09 +00:00
yang wei 3954f0183f ARTEMIS-2186 Large message incomplete when server is crashed 2019-01-19 08:16:09 +00:00
Michael Andre Pearce de90d8cfe1 This closes #2508 2019-01-18 22:42:40 +00:00
Michael André Pearce 39ff9f43b2 NO-JIRA fix writableBuffer so that its only visible after sub statements
Potential race condition. This assignment to writableBuffer is visible to other threads before the subsequent statements are executed.
2019-01-18 22:41:17 +00:00
Michael Andre Pearce 5cf54f6c69 This closes #2434 2019-01-18 09:03:30 +00:00
Justin Bertram 61e0354b1a ARTEMIS-1867 FQQN for producers
There's a *slight* semantic change with the behavior of the queue query
and binding query to make them consistent with the address query, namely
that they will return the name of the queue and the name of the address
in every case and the returned names will be not use the FQQN syntax but
will be parsed to reflect their actual names in the broker.
2019-01-18 09:03:30 +00:00
Justin Bertram 03c45d6479 NO-JIRA de-duplicate createQueue()
There were two different but nearly identical implementations of
createQueue(). I consolidated these into a single method. There should
be no semantic differences.
2019-01-18 09:03:29 +00:00
Michael Andre Pearce 5c47e71d4f This closes #2507 2019-01-18 08:53:15 +00:00
Michael André Pearce 7fe45dea0b NO-JIRA Fix possible IOE
This array access might be out of bounds, as the index might be equal to the array length.
2019-01-18 08:33:49 +00:00
Michael André Pearce f49d3e89dc NO-JIRA Fix possible IOE
id must be less than values.length,  values[id] array access might be out of bounds, as the index might be equal to the array length.
2019-01-18 08:20:14 +00:00
Michael André Pearce b2d40b716d NO-JIRA Fix double check locking in ActiveMQJMSContext
Double checked locking was operating on a non-volatile field this is not threadsafe, make field volatile.
2019-01-18 08:16:29 +00:00
Clebert Suconic 05d893036e ARTEMIS-2200 NPE fix
This was a typo on my last commit around ARTEMIS-2200
2019-01-17 21:51:30 -05:00
Michael Andre Pearce 516ca81093 This closes #2505 2019-01-18 01:04:06 +00:00
Michael André Pearce dbc4547dad NO-JIRA Null Check in logging 2019-01-18 01:04:06 +00:00
Michael Andre Pearce 7efa6187d8 This closes #2504 2019-01-18 01:03:47 +00:00