Commit Graph

6402 Commits

Author SHA1 Message Date
Michael André Pearce d4c41e45bc ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451
Readdress ARTEMIS-1451 concern of sync blocks, remove synchronization by simplifying original code and using atomics.
2019-01-23 10:01:40 +00:00
Michael André Pearce b9a063f2e7 ARTEMIS-2236 - Revert Original ARTEMIS-1451
This reverts commit f8b758d1
2019-01-23 09:54:19 +00:00
Clebert Suconic 9599fab372 This closes #2506 2019-01-22 17:42:57 -05:00
Howard Gao b5e7b703b5 ARTEMIS-2230 Exception closing advisory consumers when supportAdvisory=false
When broker's advisory is disabled (supportAdvisory=false) any
advisory consumer won't get created at broker and the advisory
consumer ID won't be stored.

Legacy openwire clients can have a reference of advisory consumer
regardless broker's settings and therefore when it closes the
advisory consumer the broker has no reference to it.
Therefore broker throws an exception like:

javax.jms.IllegalStateException: Cannot
remove a consumer that had not been registered

If the broker stores the consumer info (even it doesn't create
it) the exception can be avoided.
2019-01-22 17:42:57 -05:00
Clebert Suconic 261b05e5c4 This closes #2473 2019-01-22 17:37:13 -05:00
Howard Gao ae00423034 ARTEMIS-1058 Jars in web tmp dir locked on Windows
Because Sun's URLClassLoader never closes it's jar file handles
Jetty doesn't cleanup is temp web dir after Artemis broker shut
down normally on Windows.

To work around this a new process is forked before broker VM
exits to clean up the tmp dir if they are not deleted. The
new process out lives the main VM so that those jar's handles
are released and the temp dir can be cleaned up.
2019-01-22 17:37:12 -05:00
Clebert Suconic 02dcc9e37b NO-JIRA update shade plugin
We were hitting a bug on shade, where shade was trying to download our own sources
instead of using from the local built repository.
2019-01-22 09:40:44 -05:00
Francesco Nigro 6c8bd53561 This closes #2513 2019-01-22 12:08:28 +01:00
andytaylor 2d768760af ARTEMIS-2235 - remove credentials from browser log
https://issues.apache.org/jira/browse/ARTEMIS-2235
2019-01-22 12:08:28 +01:00
Francesco Nigro dc5404a6c3 This closes #2512 2019-01-22 11:54:28 +01:00
Martyn Taylor bab7bd05c8 Remove test scope for jaxrs module 2019-01-22 10:48:10 +00:00
Martyn Taylor 569ce9d8a3 Add Interceptor Example 2019-01-22 10:48:10 +00:00
Martyn Taylor 132763f067 Added ability to skip doc and website creation 2019-01-22 10:48:10 +00:00
Justin Bertram c0252c7cae This closes #2511 2019-01-21 14:20:57 -06:00
Emmanuel Hugonnet 8b272bd1c8 ARTEMIS-2234 fix warning from LoggingConfigurationFileReloader
return the LogContextConfiguration if we have one
2019-01-21 14:19:09 -06:00
Howard Gao 65d01a4f91 This closes #2509 2019-01-21 13:27:53 +08:00
Michael André Pearce 55732d401f NO-JIRA Fix Possible NPE in connectToNodeInReplicatedCluster
Variable possibleLive may be null, as signified by trace log above, also dedupe code.
2019-01-21 13:26:24 +08:00
Michael Andre Pearce 3aebe74d07 This closes #2444 2019-01-19 08:16:09 +00:00
yang wei 3954f0183f ARTEMIS-2186 Large message incomplete when server is crashed 2019-01-19 08:16:09 +00:00
Michael Andre Pearce de90d8cfe1 This closes #2508 2019-01-18 22:42:40 +00:00
Michael André Pearce 39ff9f43b2 NO-JIRA fix writableBuffer so that its only visible after sub statements
Potential race condition. This assignment to writableBuffer is visible to other threads before the subsequent statements are executed.
2019-01-18 22:41:17 +00:00
Michael Andre Pearce 5cf54f6c69 This closes #2434 2019-01-18 09:03:30 +00:00
Justin Bertram 61e0354b1a ARTEMIS-1867 FQQN for producers
There's a *slight* semantic change with the behavior of the queue query
and binding query to make them consistent with the address query, namely
that they will return the name of the queue and the name of the address
in every case and the returned names will be not use the FQQN syntax but
will be parsed to reflect their actual names in the broker.
2019-01-18 09:03:30 +00:00
Justin Bertram 03c45d6479 NO-JIRA de-duplicate createQueue()
There were two different but nearly identical implementations of
createQueue(). I consolidated these into a single method. There should
be no semantic differences.
2019-01-18 09:03:29 +00:00
Michael Andre Pearce 5c47e71d4f This closes #2507 2019-01-18 08:53:15 +00:00
Michael André Pearce 7fe45dea0b NO-JIRA Fix possible IOE
This array access might be out of bounds, as the index might be equal to the array length.
2019-01-18 08:33:49 +00:00
Michael André Pearce f49d3e89dc NO-JIRA Fix possible IOE
id must be less than values.length,  values[id] array access might be out of bounds, as the index might be equal to the array length.
2019-01-18 08:20:14 +00:00
Michael André Pearce b2d40b716d NO-JIRA Fix double check locking in ActiveMQJMSContext
Double checked locking was operating on a non-volatile field this is not threadsafe, make field volatile.
2019-01-18 08:16:29 +00:00
Clebert Suconic 05d893036e ARTEMIS-2200 NPE fix
This was a typo on my last commit around ARTEMIS-2200
2019-01-17 21:51:30 -05:00
Michael Andre Pearce 516ca81093 This closes #2505 2019-01-18 01:04:06 +00:00
Michael André Pearce dbc4547dad NO-JIRA Null Check in logging 2019-01-18 01:04:06 +00:00
Michael Andre Pearce 7efa6187d8 This closes #2504 2019-01-18 01:03:47 +00:00
Michael André Pearce 07fa93dfae NO-JIRA Check data != null during encode
Picked up by code analysis checks
2019-01-18 00:47:44 +00:00
Michael Andre Pearce 82ab6ff159 This closes #2503 2019-01-18 00:38:32 +00:00
Michael André Pearce 1f1aacc7ca NO-JIRA Fix field access 2019-01-18 00:33:59 +00:00
Michael Andre Pearce a26608d34a This closes #2502 2019-01-18 00:25:39 +00:00
Michael André Pearce 300ba4ecda NO-JIRA Fix String and SimpleString equals check 2019-01-18 00:24:20 +00:00
Michael Andre Pearce 7337274338 This closes #2501 2019-01-17 23:56:01 +00:00
Michael André Pearce dac2ae6636 ARTEMIS-2221 Fix Merge 2019-01-17 23:50:09 +00:00
Clebert Suconic 3a0491b920 This closes #2445 2019-01-17 18:12:58 -05:00
yang wei 5ea72022a1 ARTEMIS-2187 remove page from softcache before consumedpage 2019-01-17 18:12:57 -05:00
Clebert Suconic a04f8053b4 This closes #2446 2019-01-17 17:51:52 -05:00
yang wei 52d236d850 ARTEMIS-2188 fix address size leak caused by large page message 2019-01-17 17:51:51 -05:00
Michael Andre Pearce 10f5b184ee This closes #2469 2019-01-17 22:50:41 +00:00
Justin Bertram 6c0f9f8d3d ARTEMIS-2221 avoid unnecessary Bindings instance creation
When trying to get the bindings for an address the getBindingsForAddress
method will create a Bindings instance if there are no bindings for the
address. This is unnecessary in most circumstances so use the
lookupBindingsForAddress method instead and check for null.
2019-01-17 22:49:35 +00:00
Michael Andre Pearce ba53bed20d This closes #2470 2019-01-17 22:41:56 +00:00
Justin Bertram bfefd1f1ed NO-JIRA fix lgtm.com errors
Errors enumerated at
https://lgtm.com/projects/g/apache/activemq-artemis/alerts/?mode=tree&severity=error
2019-01-17 22:37:01 +00:00
Justin Bertram 57aacf784c NO-JIRA fix lgtm.com warnings
Warnings enumerated at
https://lgtm.com/projects/g/apache/activemq-artemis/alerts/?mode=tree&severity=warning
2019-01-17 22:30:28 +00:00
Michael Andre Pearce 6e0dc8163d This closes #2438 2019-01-17 22:22:01 +00:00
Justin Bertram 47aa25933f ARTEMIS-2178 routing-type config for core bridge
MULTICAST messages forwarded by a core bridge will not be routed to any
ANYCAST queues and vice-versa. Diverts have the ability to configure how
routing-type is treated. Core bridges now support this same kind of
functionality. By default the bridge does not alter the routing-type of
forwarded messages to maintain compatibility with existing behavior.
2019-01-17 22:22:01 +00:00