Commit Graph

364 Commits

Author SHA1 Message Date
Howard Gao 216f31765f ARTEMIS-1000 Openwire exception response no correlation-id
When openwire sends back an exception response, it doesn't set
the correct correlation id. This causes the client to miss the
response and the exception won't get caught.

To fix it we need to add the correlation id before sending.
2017-02-26 22:25:10 -05:00
Justin Bertram 01465035c0 ARTEMIS-970 handle indeterminate JMS destination 2017-02-23 12:55:27 -05:00
Howard Gao 2fabd059d8 ARTEMIS-981 OpenWire can't receive empty ObjectMessage
When sending an empty ObjectMessage, broker doesn't
write a 'length' field to the message buffer. In delivery
the broker tries to read the length from the buffer, which
causes "IndexOutOfBoundsException".

To fix it, we need to check if the buffer is empty or not,
and only read it if the buffer is not empty.
2017-02-22 12:59:52 +08:00
Justin Bertram b7d7d134eb NO-JIRA fix possible STOMP NPE 2017-02-21 22:22:12 -05:00
Howard Gao b84a7f3e25 ARTEMIS-980 Openwire can't send message to temp destination
When a producer sends a messages to a temp destination created from
another connection, it fails. The reason behind it is that the
producer's connection didn't receive the advisory message (notification)
from broker about this temp destination, and it will throw an exception
if it doesn't know this temp destination.

The fix is send the advisory to the client so that it knows this destination.
2017-02-21 14:46:47 +08:00
Jiri Danek a7a0535afa NO-JIRA Fixing typos in log messages, test names and comments
Related to ARTEMIS-387 (fowardingAddress)
2017-02-20 20:54:45 -05:00
Clebert Suconic 29af4a982a NO-JIRA: removing dead code on AMQPSessionContext 2017-02-20 19:34:38 -05:00
Clebert Suconic b788acd834 ARTEMIS-982 Fixing possible deadlock on AMQP.close & delivery
https://issues.apache.org/jira/browse/ARTEMIS-982

This is fixing a possible deadlock on delivering messages while AMQP close is called for any reason.
2017-02-20 12:35:49 -06:00
Howard Gao e7a4d42a64 ARTEMIS-979 OpenWire "no-Local" consumer not working
When creating a 'no-local' openwire consumer, it doesn't work,
meaning it can still receive messages from the same connection.
The fix is similar to what Artemis client does, which is adding
a 'filter' to the consumer/subscription.
The difference is that with OpenWire we have to do it on the
broker side.
2017-02-20 08:17:43 -05:00
Martyn Taylor 8b51ec27db NO-JIRA Send MQTT WILL outside of Server Session 2017-02-18 13:31:57 +00:00
Martyn Taylor 5a235d98b6 ARTEMIS-974 ensure will messages are retained 2017-02-16 18:22:10 +00:00
Dejan Bosanac 21b64b3e4f https://issues.apache.org/jira/browse/ARTEMIS-815 - support wildcard address configuration in mqtt layer
https://issues.apache.org/jira/browse/ARTEMIS-815 - support wildcard address configuration in mqtt layer - remove old swap method

https://issues.apache.org/jira/browse/ARTEMIS-815 - added tests for mqtt-openwire integration and fixed openwire layer

https://issues.apache.org/jira/browse/ARTEMIS-815 - remove unused imports
2017-02-16 17:37:50 +00:00
Ulf Lilleengen 5f6a390b60 ARTEMIS-908: Ensure that connection lock is held when flushing 2017-02-15 14:09:27 +01:00
Martyn Taylor bd1f244dfc NO-JIRA Clean up around MQTTConnectionManager 2017-02-14 11:26:54 -06:00
Martyn Taylor 3bd5c9df6a ARTMEIS-958 Route Will message outside server session 2017-02-14 11:26:54 -06:00
Martyn Taylor 59773c2849 ARTEMIS-960 Do not encode Will messages 2017-02-14 11:26:54 -06:00
Justin Bertram ff3e75d148 NO-JIRA move RoutingType to different package 2017-02-13 09:50:41 -06:00
Andy Taylor 318778954d ENTMQBR-522 - dont ack on separately settled deliveries
https://issues.jboss.org/browse/ENTMQBR-522
2017-02-10 09:50:51 -05:00
Martyn Taylor cd28d76554 ARTEMIS-951 Auto Commit MQTT Acks 2017-02-09 10:43:03 +00:00
Martyn Taylor b2e250d425 ARTEMIS-952 Remove MQTT Queues on Clean Session 2017-02-09 10:43:03 +00:00
Howard Gao 1a3fdd0916 ARTEMIS-949 Prevent Openwire from closing consumer twice 2017-02-08 15:57:43 +08:00
Andy Taylor f268c101af ARTEMIS-944 - Broker can't convert AMQP python message to Openwire format
https://issues.apache.org/jira/browse/ARTEMIS-944
2017-02-07 14:02:20 +00:00
Timothy Bish b9bf5d54f2 ARTEMIS-794 Add tests for handling of various outcomes for deliveries
Adds tests for handling of Rejected, Released and Modified outcomes for
a delivery sent to a receiver.  Tests show that for the Modified outcome
the broker is redelivering the message to the same receiver when the
undeliverable here value is set which violates the AMQP 1.0 specified
handling of that field.  Also for Rejected outcome the broker should
be sending the rejected message to the DLQ as Rejected is supposed to
be a terminal outcome.

Small fix included to not adjust the delivery count if the Modified
outcome does not indicate that the delivery failed.
2017-02-07 13:45:11 +00:00
Martyn Taylor 3900cb0ec7 ARTEMIS-917 Only return body of retained message after reboot 2017-02-06 13:33:26 -06:00
Clebert Suconic f79b21e866 ARTEMIS-934 Stomp Heart beat not being stopped in some cases 2017-01-25 12:17:47 -05:00
Will Reichert 3347a4fd27 ARTEMIS-928 Changing Netty and InVM to copy buffers, and retain them on the Netty Polls. 2017-01-18 16:59:32 -05:00
Justin Bertram 8cf94623a4 ARTEMIS-922 Rename deleteOnNoConsumers throughout
The name "deleteOnNoConsumers" isn't a good match for the semantics underneath.
The name "purgeOnNoConsumers" (and variants) is a better fit.
2017-01-17 11:40:56 -06:00
Andy Taylor f52cb5c610 ARTEMIS-918 - use requested routing type when client defined with amqp and address doesnt exist
https://issues.apache.org/jira/browse/ARTEMIS-918
2017-01-12 12:07:16 +00:00
Howard Gao 4e309d842e ARTEMIS-562 Use 'to' field if sender target is null 2017-01-11 14:20:39 -05:00
Andy Taylor 355d33ea4f fix log trace message throwing exception 2017-01-09 14:58:25 -05:00
Ulf Lilleengen f2f3552067 ARTEMIS-908: Hold connection lock when issuing credits 2017-01-04 10:59:33 -06:00
Howard Gao eecbbb18db ARTEMIS-902 OpenWire Compression Issue 2016-12-23 21:29:28 +08:00
Timothy Bish 51c95babfe ARTEMIS-901 Account for the presence of authzid in sasl plan auth
If the SASL plain mechanism arrives with the authzid value set the
mechanism needs to account for its presence and use the correct fields
of the exchange to get the username and password values.  Adds some
tests to validate this fix.
2016-12-21 18:18:54 -05:00
Clebert Suconic 81df93ebcf ARTEMIS-883 improving exceptions sending 2016-12-21 12:04:06 -05:00
Howard Gao ae90edfdb6 ARTEMIS-883 Fix OpenWire ProducerFlowControlTest 2016-12-21 12:04:06 -05:00
Andy Taylor 63f723fe8d ARTEMIS-888 - default to false if header durable not set
https://issues.apache.org/jira/browse/ARTEMIS-888
2016-12-20 09:32:33 +00:00
Andy Taylor 198143edd0 ARTEMIS-892 - add lock to tick method
https://issues.apache.org/jira/browse/ARTEMIS-892
2016-12-16 12:11:54 +00:00
Clebert Suconic 0c18c343e9 NO-JIRA: fixing checkstyle 2016-12-15 17:00:10 -05:00
Martyn Taylor 55fbcfebf8 Do not autoDelete address if it was not autoCreated 2016-12-15 17:13:09 +00:00
Andy Taylor a9b32bdf0b adding missing check for closed on proton receiver 2016-12-15 13:40:47 +00:00
Andy Taylor 3b75c95413 ARTEMIS-888 - AMQP headers arent always set
https://issues.apache.org/jira/browse/ARTEMIS-888
2016-12-15 07:07:04 +00:00
jbertram 10a32481fd ARTEMIS-789 fix ArtemisTest 2016-12-14 19:46:53 -06:00
Andy Taylor 881615e646 ARTEMIS-891 - upgrade proton to 0.16
https://issues.apache.org/jira/browse/ARTEMIS-891
2016-12-14 18:25:26 +00:00
Clebert Suconic 08e0c5e4f1 Revert "ARTEMIS-888 - AMQP headers arent always set"
This reverts commit d471f6b15f.
2016-12-14 10:20:18 -05:00
Andy Taylor d471f6b15f ARTEMIS-888 - AMQP headers arent always set
https://issues.apache.org/jira/browse/ARTEMIS-888
2016-12-14 09:25:10 -05:00
jbertram 30b1335614 ARTEMIS-877 STOMP tests + routing header 2016-12-13 17:59:09 -06:00
jbertram 3150759806 ARTEMIS-880 use built-in prefixing for STOMP 2016-12-13 15:05:43 -06:00
Howard Gao d67ea071a3 ARTEMIS-885 Fix OpenWire wildcard conversion issue 2016-12-13 15:58:35 -05:00
Martyn Taylor 7f658cad21 ARTEMIS-788 Enable auto create and Prefix in MQTT 2016-12-13 15:54:50 -05:00
Martyn Taylor 6682072da6 Major Version Bump 2.0.0 After Major Arch Change 2016-12-09 18:43:15 +00:00