Commit Graph

44 Commits

Author SHA1 Message Date
Justin Bertram 97c78525da ARTEMIS-4181 make try-with-resources style consistent 2023-03-03 08:40:51 -06:00
Justin Bertram a4c1155a01 ARTEMIS-3341 update checkstyle to latest + update code
As a follow-up to #3618/dc7de893747b90b627d729f9f18a758bb4dad9d5 update
checkstyle to the latest version, restoring the originally intended
"RightCurly" style, and updating all the code to properly adhere to the
style as enforced by the new checkstyle version.

The version of checkstyle we used before the aforementioned commit had
a bug which didn't properly enforced our intended "RightCurly" style
(see https://github.com/checkstyle/checkstyle/issues/6345). That commit
changed the style to accommodate the handful of unintended style
violations. This commit reverts that change for 2 main reasons:
 - The style was always intended to use `alone` for both `METHOD_DEF`
and `CTOR_DEF`.
 - There are over 1,000 existing uses of the intended style and around
30 violations of this style which were unintentionally allowed.

Reverting the style back to the original and cleaning up the unintented
violations makes the code more consistent and prevents further style
inconsistencies in the future.

There were a handful of other changes related to checkstyle bugs which
allowed unintended style violations. These were related to indentation
levels.

This closes #3619
(with some minor changes from Robbie to fix remaining violations)
2021-06-11 12:16:04 +01:00
Robbie Gemmell dc7de89374 ARTEMIS-3341: update checkstyle, use consistent plugin version, fix some issues or tweak config to allow existing style 2021-06-10 20:53:16 +01:00
Emmanuel Hugonnet efe0f468de ARTEMIS-2109: Updating the build to be able to execute it on Java 11 and Java 8. 2020-06-11 18:50:01 +01:00
Justin Bertram 4a4442ed56 NO-JIRA checkstyle upgrade 2019-11-05 16:06:48 -05:00
Michael Andre Pearce c65ea783ea ARTEMIS-1189 - Fix checkstyle violations post checkstyle upgrade
After upgrade of checkstyle, resolve violations

remove checkstyle override added as temp measure at point of upgrade forced by sevntu
2017-05-30 13:40:00 -04:00
Michael Andre Pearce b8ebe05775 ARTEMIS-1188: Update sevntu to 1.24.0 available in maven central
remove custom repo
update groupid to match artifact in maven central.
bump version also to that now deployed to maven central.
bump checkstyle version to 7.7 to make compatible.

updated checkstyle.xml to ignore existing issues which are prolific 
which are now flagged in latest version as some bugs in previous meant they we'ren't detected e.g. https://github.com/checkstyle/checkstyle/issues/3320

fixing some violations which are not too prolific.
2017-05-30 09:54:17 -04:00
Clebert Suconic dc26ac96b4 ARTEMIS-1156: moving our collections on its own package 2017-05-12 10:06:05 -04:00
Ville Skyttä b2fe246e62 Add EditorConfig
http://editorconfig.org/
2016-10-10 10:01:01 +02:00
Ville Skyttä 323d1b6e1b Insert space after closing cast paren in Eclipse 2016-10-01 11:04:02 +03:00
Ville Skyttä dc84a3000f Sync Eclipse preferences with new Checkstyle settings 2016-10-01 10:35:14 +03:00
Ville Skyttä 26a9815cd6 Grammar fixes 2016-10-01 10:35:13 +03:00
Ville Skyttä d551d2088d Move Eclipse settings to subdir 2016-10-01 10:34:40 +03:00
Clebert Suconic ec48f9ed00 ARTEMIS-765 Improve Checkstyle 2016-09-30 11:12:09 -04:00
Ville Skyttä 0e8f582f1b Flag missing @Override as error in Eclipse 2016-09-21 16:31:14 -04:00
Ville Skyttä 5329311570 Add IDEA inspection settings, flag missing @Override as error 2016-09-21 16:31:14 -04:00
Christopher L. Shannon (cshannon) a331a2f955 ARTEMIS-730: Updating Hacking guide documentation
Fixed a few issues with Eclipse related documentation
2016-09-12 10:02:47 -04:00
Clebert Suconic 87c3f23e88 ignoring IDE settings from the source distribution 2016-09-06 11:42:09 -04:00
Ville Skyttä b3ed6fbd43 Use sevntu-checkstyle check for required annotation parameters
RequiredParameterForAnnotation available on Sevntu since https://github.com/sevntu-checkstyle/sevntu.checkstyle/issues/321
2016-06-14 20:50:21 -04:00
Ville Skyttä 560ba1b39b Add Sevntu-checkstyle diamond operator check 2016-06-14 20:50:21 -04:00
Ville Skyttä c857019f1f Update Java version in example Eclipse config 2015-12-21 21:47:15 -05:00
Ville Skyttä 4eb4bb7228 Update checkstyle config DTD to 1.3
Checkstyle versions at least down to 5.2 use this.
2015-08-16 15:44:47 +03:00
Ville Skyttä e46dd5f6f9 Suppress unfixable checkstyle violations in JavaCC generated sources 2015-08-16 15:36:05 +03:00
Ville Skyttä eb407389a6 Update maven-checkstyle-plugin to version 2.16 2015-08-16 15:26:15 +03:00
Ville Skyttä ff79af3117 Update URL to checkstyle checks documentation 2015-08-16 15:22:49 +03:00
Clebert Suconic 455962a2aa idea style update 2015-08-10 09:20:56 -04:00
Clebert Suconic 7fb5d921e3 Changing checkstyle configuration to the new style 2015-08-10 09:16:53 -04:00
Clebert Suconic 39b9fd1ce7 fixing idea-style damaged from renaming 2015-08-03 11:54:38 -04:00
Martyn Taylor a17c828b85 Ensure all references to the project use ActiveMQ Artemis 2015-05-13 11:51:26 +01:00
jbertram 791cc5c50c More rename updates 2015-04-30 09:07:20 -05:00
Justin Bertram 8f52a622d0 ACTIVEMQ6-1 Artemis rename
Based on the Apache ActiveMQ community vote this project is being
renamed "Artemis."
2015-04-27 17:48:02 -04:00
Martyn Taylor 11e1b850c9 Renamed ActiveMQ6 to ActiveMQ Artemis 2015-04-24 14:07:31 +01:00
Clebert Suconic 6239ff6291 settings updates 2015-04-01 16:13:56 -04:00
Clebert Suconic b469ae9fc4 Idea style update - no @author
Since the update on removing @author tags I did a quick update
to the style so new files won't include them.

It's a small issue anyways since we have the checkstyle would avoid it
2015-03-10 17:17:09 -04:00
jbertram 88ed03e2bd ACTIVEMQ6-87 Strip @author tags 2015-03-10 15:23:07 -05:00
Howard Gao 1d022fe474 ACTIVEMQ6-43(reopened) : Replace License Headers on codebase
- added missing license headers found by maven rat plugin.
  most of them added automatically via apache-rat
  a few manually added

- added apache-rat maven plugin to the build cycle
2015-01-05 13:14:25 -05:00
Clebert Suconic 66aee24e6c Fixing IDEA Style template
This is just fixing the IDEA Style template that got corrupted
during the renaming to activemq.

I also fixed the copyright header on the template
and renamed the code style names

I'm not creating a JIRA for this, since this is a small change not affecting the codebase
2014-12-01 16:04:42 -05:00
Howard Gao 293b242ffc ACTIVEMQ6-43 Replace License Headers on codebase
upgrade mycila plugin to 2.6
2014-12-01 10:20:24 +08:00
Clebert Suconic 89a84c6ae2 More name changes to activemq
more hornetq changes
2014-11-19 16:01:54 -05:00
Martyn Taylor 4a6b980fed Remove references to HornetQ in doc and Comments 2014-11-19 15:15:35 +00:00
Clebert Suconic 9a587c5633 ACTIVEMQ6-3 renaming package names from activemq6 to activemq
https://issues.apache.org/jira/browse/ACTIVEMQ6-3

We are renaming packages from activemq6 to activemq as that's more generic and version independent
The previous commit renamed the directories. On this commit now I'm changing the code.
If we changed the code and the directories on the same commit git would remove and add a lot of files
without recognizing the renames.
2014-11-17 09:33:53 -05:00
Martyn Taylor 1f869f9f4c Use new package names in config and classes 2014-11-11 18:28:18 +00:00
Martyn Taylor 177e6820b5 ACTIVEMQ6-2 Update to HQ master 2014-11-11 10:48:14 +00:00
Andy Taylor 8ecd255f98 ACTIVEMQ6-1 - Initial HornetQ Donation Commit
https://issues.apache.org/jira/browse/ACTIVEMQ6-1

This is the initial donation of the HornetQ codebase as per document http://incubator.apache.org/ip-clearance/hornetq.html
2014-11-10 10:31:25 -06:00