a4c1155a01
As a follow-up to #3618/dc7de893747b90b627d729f9f18a758bb4dad9d5 update checkstyle to the latest version, restoring the originally intended "RightCurly" style, and updating all the code to properly adhere to the style as enforced by the new checkstyle version. The version of checkstyle we used before the aforementioned commit had a bug which didn't properly enforced our intended "RightCurly" style (see https://github.com/checkstyle/checkstyle/issues/6345). That commit changed the style to accommodate the handful of unintended style violations. This commit reverts that change for 2 main reasons: - The style was always intended to use `alone` for both `METHOD_DEF` and `CTOR_DEF`. - There are over 1,000 existing uses of the intended style and around 30 violations of this style which were unintentionally allowed. Reverting the style back to the original and cleaning up the unintented violations makes the code more consistent and prevents further style inconsistencies in the future. There were a handful of other changes related to checkstyle bugs which allowed unintended style violations. These were related to indentation levels. This closes #3619 (with some minor changes from Robbie to fix remaining violations) |
||
|---|---|---|
| .. | ||
| ide-settings | ||
| checkstyle-suppressions.xml | ||
| checkstyle.xml | ||
| findbugs-exclude.xml | ||
| license-header.txt | ||