Fix the TopicMasterSlaveTest that was failing

- Stack was overflowing due to the advisory broker advising on topic advisories
 - MasterConnector now makes sync request to the slave if it's given a sync request
 - Test was failing due to kaha not being able to create a file that was too long.. fixed by making the 
   sub name and client id and dest name shorter.  Need to revisit.



git-svn-id: https://svn.apache.org/repos/asf/activemq/trunk@563854 13f79535-47bb-0310-9956-ffa450edef68

activemq-core/src/main/java/org/apache/activemq/advisory/AdvisoryBroker.java

@@ -145,11 +145,12 @@ public class AdvisoryBroker extends BrokerFilter {
     
     public Destination addDestination(ConnectionContext context, ActiveMQDestination destination) throws Exception {
         Destination answer = next.addDestination(context, destination);  
-      
-        ActiveMQTopic topic = AdvisorySupport.getDestinationAdvisoryTopic(destination);
-        DestinationInfo info = new DestinationInfo(context.getConnectionId(), DestinationInfo.ADD_OPERATION_TYPE, destination);
-        fireAdvisory(context, topic, info);        
-        destinations.put(destination, info);
+        if( !AdvisorySupport.isAdvisoryTopic(destination) ) { 
+            ActiveMQTopic topic = AdvisorySupport.getDestinationAdvisoryTopic(destination);
+            DestinationInfo info = new DestinationInfo(context.getConnectionId(), DestinationInfo.ADD_OPERATION_TYPE, destination);
+            fireAdvisory(context, topic, info);        
+            destinations.put(destination, info);
+        }
         return answer;
     }
     
@@ -157,9 +158,11 @@ public class AdvisoryBroker extends BrokerFilter {
         ActiveMQDestination destination =  info.getDestination();
         next.addDestinationInfo(context, info);  
         
-        ActiveMQTopic topic = AdvisorySupport.getDestinationAdvisoryTopic(destination);
-        fireAdvisory(context, topic, info);        
-        destinations.put(destination, info);    
+        if( !AdvisorySupport.isAdvisoryTopic(destination) ) { 
+            ActiveMQTopic topic = AdvisorySupport.getDestinationAdvisoryTopic(destination);
+            fireAdvisory(context, topic, info);        
+            destinations.put(destination, info); 
+        }
     }
 
     public void removeDestination(ConnectionContext context, ActiveMQDestination destination, long timeout) throws Exception {

activemq-core/src/main/java/org/apache/activemq/broker/BrokerService.java

@@ -1367,12 +1367,12 @@ public class BrokerService implements Service {
         // Add a filter that will stop access to the broker once stopped
         broker = new MutableBrokerFilter(broker) {
             public void stop() throws Exception {
-                super.stop();
                 setNext(new ErrorBroker("Broker has been stopped: "+this) {
                     // Just ignore additional stop actions.
                     public void stop() throws Exception {
                     }
                 });
+                super.stop();
             }
         };
         

activemq-core/src/main/java/org/apache/activemq/broker/ft/MasterConnector.java

@@ -222,11 +222,12 @@ public class MasterConnector implements Service,BrokerServiceAware{
             }else{
                 boolean responseRequired=command.isResponseRequired();
                 int commandId=command.getCommandId();
-                localBroker.oneway(command);
                 if(responseRequired){
-                    Response response=new Response();
+                    Response response = (Response)localBroker.request(command);
                     response.setCorrelationId(commandId);
                     remoteBroker.oneway(response);
+                } else {
+                    localBroker.oneway(command);                    
                 }
             }
         }catch(IOException e){

activemq-core/src/test/java/org/apache/activemq/JmsSendReceiveTestSupport.java

@@ -126,8 +126,8 @@ public class JmsSendReceiveTestSupport extends TestSupport implements MessageLis
         if (data.length != copyOfMessages.size()) {
             for (Iterator iter = copyOfMessages.iterator(); iter.hasNext();) {
                 TextMessage message = (TextMessage) iter.next();
-                if (log.isDebugEnabled()) {
-                    log.info("<== " + counter++ + " = " + message);
+                if (log.isInfoEnabled()) {
+                    log.info("<== " + counter++ + " = " + message.getText());
                 }
             }
         }

activemq-core/src/test/java/org/apache/activemq/TestSupport.java

@@ -122,7 +122,7 @@ public class TestSupport extends TestCase {
     }
 
     protected String getSubject() {
-        return getClass().getName() + "." + getName();
+        return getName();
     }
     
     

activemq-core/src/test/java/org/apache/activemq/broker/ft/TopicMasterSlaveTest.java

@@ -34,12 +34,12 @@ public class TopicMasterSlaveTest extends QueueMasterSlaveTest{
     }
 
     protected MessageConsumer createConsumer(Session session,Destination dest) throws JMSException{
-        return session.createDurableSubscriber((Topic) dest,dest.toString());
+        return session.createDurableSubscriber((Topic) dest,"subName");
     }
 
     protected Connection createReceiveConnection() throws Exception{
         Connection result=super.createReceiveConnection();
-        result.setClientID(getClass().getName());
+        result.setClientID("clientId");
         return result;
     }
 }