Apache
/
activemq
mirror of https://github.com/apache/activemq.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix test failure under Java 8. Root cause is in CombinationTestSupport 

and only shows up in Java 8 because iteration order of the options map
changes such that the expandCombination method gets an empty value for
an option and returns immediately without evalutating all the added
options.
This commit is contained in:
Timothy Bish 2014-08-07 16:58:49 -04:00
parent 533cedc4fc
commit 1f9a2d6f68
1 changed files with 8 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
activemq-unit-tests/src/test/java/org/apache/activemq/security/SimpleAnonymousPluginTest.java
View File

@ -63,7 +63,6 @@ public class SimpleAnonymousPluginTest extends SimpleAuthenticationPluginTest {
}
}
public void testAnonymousReceiveSucceeds() throws JMSException {
doReceive(false);
}
@ -84,8 +83,8 @@ public class SimpleAnonymousPluginTest extends SimpleAuthenticationPluginTest {
* @see {@link CombinationTestSupport}
*/
public void initCombosForTestAnonymousReceiveSucceeds() {
addCombinationValues("userName", new Object[] {});
addCombinationValues("password", new Object[] {});
addCombinationValues("userName", new Object[] { null });
addCombinationValues("password", new Object[] { null });
addCombinationValues("destination", new Object[] {new ActiveMQQueue("GUEST.BAR"), new ActiveMQTopic("GUEST.BAR")});
}
@ -93,8 +92,8 @@ public class SimpleAnonymousPluginTest extends SimpleAuthenticationPluginTest {
* @see {@link CombinationTestSupport}
*/
public void initCombosForTestAnonymousReceiveFails() {
addCombinationValues("userName", new Object[] {});
addCombinationValues("password", new Object[] {});
addCombinationValues("userName", new Object[] { null });
addCombinationValues("password", new Object[] { null });
addCombinationValues("destination", new Object[] {new ActiveMQQueue("TEST"), new ActiveMQTopic("TEST"), new ActiveMQQueue("USERS.FOO"), new ActiveMQTopic("USERS.FOO") });
}
@ -102,8 +101,8 @@ public class SimpleAnonymousPluginTest extends SimpleAuthenticationPluginTest {
* @see {@link CombinationTestSupport}
*/
public void initCombosForTestAnonymousSendFails() {
addCombinationValues("userName", new Object[] {});
addCombinationValues("password", new Object[] {});
addCombinationValues("userName", new Object[] { null });
addCombinationValues("password", new Object[] { null });
addCombinationValues("destination", new Object[] {new ActiveMQQueue("TEST"), new ActiveMQTopic("TEST"), new ActiveMQQueue("USERS.FOO"), new ActiveMQTopic("USERS.FOO")});
}
@ -111,9 +110,8 @@ public class SimpleAnonymousPluginTest extends SimpleAuthenticationPluginTest {
* @see {@link CombinationTestSupport}
*/
public void initCombosForTestAnonymousSendSucceeds() {
addCombinationValues("userName", new Object[] {});
addCombinationValues("password", new Object[] {});
addCombinationValues("userName", new Object[] { null });
addCombinationValues("password", new Object[] { null });
addCombinationValues("destination", new Object[] {new ActiveMQQueue("GUEST.BAR"), new ActiveMQTopic("GUEST.BAR")});
}
}