mirror of https://github.com/apache/activemq.git
Fixing X-Frame-Options header so that is applied for all content served by Jetty. The previous patch wasn't correct because it only applied it to Servlets and JSPs and not static content. This also reverts AMQ-6113
This commit is contained in:
Christopher L. Shannon (cshannon)
parent
b595b8bc12
commit
24ad367785
|
|
@ -25,16 +25,6 @@
|
|||
Apache ActiveMQ Web Console
|
||||
</description>
|
||||
<display-name>ActiveMQ Console</display-name>
|
||||
|
||||
<filter>
|
||||
<filter-name>XFrameOptions</filter-name>
|
||||
<filter-class>org.apache.activemq.web.XFrameOptionsFilter</filter-class>
|
||||
</filter>
|
||||
|
||||
<filter-mapping>
|
||||
<filter-name>XFrameOptions</filter-name>
|
||||
<url-pattern>/*</url-pattern>
|
||||
</filter-mapping>
|
||||
|
||||
<!-- ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -->
|
||||
<!-- Expose Spring POJOs to JSP . -->
|
||||
|
|
|
|||
|
|
@ -30,15 +30,6 @@
|
|||
</context-param>
|
||||
|
||||
<!-- filters -->
|
||||
<filter>
|
||||
<filter-name>XFrameOptions</filter-name>
|
||||
<filter-class>org.apache.activemq.web.XFrameOptionsFilter</filter-class>
|
||||
</filter>
|
||||
|
||||
<filter-mapping>
|
||||
<filter-name>XFrameOptions</filter-name>
|
||||
<url-pattern>/*</url-pattern>
|
||||
</filter-mapping>
|
||||
<filter>
|
||||
<filter-name>session</filter-name>
|
||||
<filter-class>org.apache.activemq.web.SessionFilter</filter-class>
|
||||
|
|
|
|||
|
|
@ -1,53 +0,0 @@
|
|||
/**
|
||||
* Licensed to the Apache Software Foundation (ASF) under one or more
|
||||
* contributor license agreements. See the NOTICE file distributed with
|
||||
* this work for additional information regarding copyright ownership.
|
||||
* The ASF licenses this file to You under the Apache License, Version 2.0
|
||||
* (the "License"); you may not use this file except in compliance with
|
||||
* the License. You may obtain a copy of the License at
|
||||
*
|
||||
* http://www.apache.org/licenses/LICENSE-2.0
|
||||
*
|
||||
* Unless required by applicable law or agreed to in writing, software
|
||||
* distributed under the License is distributed on an "AS IS" BASIS,
|
||||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||
* See the License for the specific language governing permissions and
|
||||
* limitations under the License.
|
||||
*/
|
||||
package org.apache.activemq.web;
|
||||
|
||||
import java.io.IOException;
|
||||
|
||||
import javax.servlet.Filter;
|
||||
import javax.servlet.FilterChain;
|
||||
import javax.servlet.FilterConfig;
|
||||
import javax.servlet.ServletException;
|
||||
import javax.servlet.ServletRequest;
|
||||
import javax.servlet.ServletResponse;
|
||||
import javax.servlet.http.HttpServletResponse;
|
||||
|
||||
/**
|
||||
* Filter to set the header X-FRAME-OPTIONS on web responses
|
||||
*
|
||||
*/
|
||||
public class XFrameOptionsFilter implements Filter {
|
||||
|
||||
private static String SAMEORIGIN = "SAMEORIGIN";
|
||||
|
||||
@Override
|
||||
public void init(FilterConfig config) throws ServletException {
|
||||
}
|
||||
|
||||
@Override
|
||||
public void doFilter(ServletRequest request, ServletResponse response, FilterChain chain) throws IOException, ServletException {
|
||||
HttpServletResponse servletResponse = (HttpServletResponse)response;
|
||||
//Set all responses to SAMEORIGIN, can be switched to be configurable later if
|
||||
//we need to conditionally set this
|
||||
servletResponse.addHeader("X-FRAME-OPTIONS", SAMEORIGIN);
|
||||
chain.doFilter(request, response);
|
||||
}
|
||||
|
||||
@Override
|
||||
public void destroy() {
|
||||
}
|
||||
}
|
||||
|
|
@ -46,9 +46,22 @@
|
|||
<property name="pathSpec" value="*.action" />
|
||||
</bean>
|
||||
|
||||
<bean id="rewriteHandler" class="org.eclipse.jetty.rewrite.handler.RewriteHandler">
|
||||
<property name="rules">
|
||||
<list>
|
||||
<bean id="header" class="org.eclipse.jetty.rewrite.handler.HeaderPatternRule">
|
||||
<property name="pattern" value="*"/>
|
||||
<property name="name" value="X-FRAME-OPTIONS"/>
|
||||
<property name="value" value="SAMEORIGIN"/>
|
||||
</bean>
|
||||
</list>
|
||||
</property>
|
||||
</bean>
|
||||
|
||||
<bean id="secHandlerCollection" class="org.eclipse.jetty.server.handler.HandlerCollection">
|
||||
<property name="handlers">
|
||||
<list>
|
||||
<ref bean="rewriteHandler"/>
|
||||
<bean class="org.eclipse.jetty.webapp.WebAppContext">
|
||||
<property name="contextPath" value="/admin" />
|
||||
<property name="resourceBase" value="${activemq.home}/webapps/admin" />
|
||||
|
|
|
|||
|
|
@ -46,9 +46,22 @@
|
|||
<property name="pathSpec" value="*.action" />
|
||||
</bean>
|
||||
|
||||
<bean id="rewriteHandler" class="org.eclipse.jetty.rewrite.handler.RewriteHandler">
|
||||
<property name="rules">
|
||||
<list>
|
||||
<bean id="header" class="org.eclipse.jetty.rewrite.handler.HeaderPatternRule">
|
||||
<property name="pattern" value="*"/>
|
||||
<property name="name" value="X-FRAME-OPTIONS"/>
|
||||
<property name="value" value="SAMEORIGIN"/>
|
||||
</bean>
|
||||
</list>
|
||||
</property>
|
||||
</bean>
|
||||
|
||||
<bean id="secHandlerCollection" class="org.eclipse.jetty.server.handler.HandlerCollection">
|
||||
<property name="handlers">
|
||||
<list>
|
||||
<ref bean="rewriteHandler"/>
|
||||
<bean class="org.eclipse.jetty.webapp.WebAppContext">
|
||||
<property name="contextPath" value="/admin" />
|
||||
<property name="resourceBase" value="${activemq.home}/webapps/admin" />
|
||||
|
|
|
|||
Loading…
Reference in New Issue