Apache/activemq
1
0
Fork 0
mirror of https://github.com/apache/activemq.git synced 2025-02-17 15:35:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

apply patch for: https://issues.apache.org/jira/browse/AMQ-3209

Browse Source 
git-svn-id: https://svn.apache.org/repos/asf/activemq/trunk@1079831 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Timothy A. Bish 2011-03-09 15:17:59 +00:00
parent 8700ab7cde
commit 4f9784dafc
2 changed files with 27 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
activemq-core/src/main/java/org/apache/activemq/util/URISupport.java
View File

@ -174,12 +174,16 @@ public class URISupport {
String schemeSpecificPart = uri.getRawSchemeSpecificPart(); String schemeSpecificPart = uri.getRawSchemeSpecificPart();
// strip existing query if any // strip existing query if any
int questionMark = schemeSpecificPart.lastIndexOf("?"); int questionMark = schemeSpecificPart.lastIndexOf("?");
// make sure question mark is not within parentheses
if (questionMark < schemeSpecificPart.lastIndexOf(")")) {
questionMark = -1;
}
if (questionMark > 0) { if (questionMark > 0) {
schemeSpecificPart = schemeSpecificPart.substring(0, questionMark); schemeSpecificPart = schemeSpecificPart.substring(0, questionMark);
} }
if (query != null && query.length() > 0) { if (query != null && query.length() > 0) {
schemeSpecificPart += "?" + query; schemeSpecificPart += "?" + query;
} }
return new URI(uri.getScheme(), schemeSpecificPart, uri.getFragment()); return new URI(uri.getScheme(), schemeSpecificPart, uri.getFragment());
} }

22
activemq-core/src/test/java/org/apache/activemq/util/URISupportTest.java
View File

@ -113,6 +113,28 @@ public class URISupportTest extends TestCase {
parameters = URISupport.parseParameters(uri); parameters = URISupport.parseParameters(uri);
} }
public void testCompositeCreateURIWithQuery() throws Exception {
String queryString = "query=value";
URI originalURI = new URI("outerscheme:(innerscheme:innerssp)");
URI querylessURI = originalURI;
assertEquals(querylessURI, URISupport.createURIWithQuery(originalURI, null));
assertEquals(querylessURI, URISupport.createURIWithQuery(originalURI, ""));
assertEquals(new URI(querylessURI + "?" + queryString), URISupport.createURIWithQuery(originalURI, queryString));
originalURI = new URI("outerscheme:(innerscheme:innerssp)?outerquery=0");
assertEquals(querylessURI, URISupport.createURIWithQuery(originalURI, null));
assertEquals(querylessURI, URISupport.createURIWithQuery(originalURI, ""));
assertEquals(new URI(querylessURI + "?" + queryString), URISupport.createURIWithQuery(originalURI, queryString));
originalURI = new URI("outerscheme:(innerscheme:innerssp?innerquery=0)");
querylessURI = originalURI;
assertEquals(querylessURI, URISupport.createURIWithQuery(originalURI, null));
assertEquals(querylessURI, URISupport.createURIWithQuery(originalURI, ""));
assertEquals(new URI(querylessURI + "?" + queryString), URISupport.createURIWithQuery(originalURI, queryString));
originalURI = new URI("outerscheme:(innerscheme:innerssp?innerquery=0)?outerquery=0");
assertEquals(querylessURI, URISupport.createURIWithQuery(originalURI, null));
assertEquals(querylessURI, URISupport.createURIWithQuery(originalURI, ""));
assertEquals(new URI(querylessURI + "?" + queryString), URISupport.createURIWithQuery(originalURI, queryString));
}
private void verifyParams(Map<String,String> parameters) { private void verifyParams(Map<String,String> parameters) {
assertEquals(parameters.get("proxyHost"), "localhost"); assertEquals(parameters.get("proxyHost"), "localhost");
assertEquals(parameters.get("proxyPort"), "80"); assertEquals(parameters.get("proxyPort"), "80");