diff --git a/activemq-web-console/pom.xml b/activemq-web-console/pom.xml index b6aa647d2e..ad986bf9f6 100755 --- a/activemq-web-console/pom.xml +++ b/activemq-web-console/pom.xml @@ -18,7 +18,7 @@ --> + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://maven.apache.org/POM/4.0.0"> 4.0.0 @@ -39,16 +39,16 @@ org.apache.maven.plugins maven-war-plugin - - WEB-INF/lib/activation*.jar, - WEB-INF/lib/activeio*.jar, - WEB-INF/lib/activemq-console*.jar, - WEB-INF/lib/activemq-core*.jar, - WEB-INF/lib/activemq-xmpp*.jar, - WEB-INF/lib/geronimo*.jar, - WEB-INF/lib/xml-apis*.jar, - WEB-INF/lib/xerces*.jar - + + WEB-INF/lib/activation*.jar, + WEB-INF/lib/activeio*.jar, + WEB-INF/lib/activemq-console*.jar, + WEB-INF/lib/activemq-core*.jar, + WEB-INF/lib/activemq-xmpp*.jar, + WEB-INF/lib/geronimo*.jar, + WEB-INF/lib/xml-apis*.jar, + WEB-INF/lib/xerces*.jar + @@ -62,39 +62,39 @@ 60000 - + / - + com.sun.management.jmxremote - - + + webconsole.type embedded - + 10 @@ -191,10 +191,28 @@ + + org.slf4j - slf4j-jcl + slf4j-api + + org.slf4j + slf4j-log4j12 + + log4j log4j diff --git a/activemq-web-console/src/main/java/org/apache/activemq/web/handler/BindingBeanNameUrlHandlerMapping.java b/activemq-web-console/src/main/java/org/apache/activemq/web/handler/BindingBeanNameUrlHandlerMapping.java index 0e9d21715b..399ca509bb 100644 --- a/activemq-web-console/src/main/java/org/apache/activemq/web/handler/BindingBeanNameUrlHandlerMapping.java +++ b/activemq-web-console/src/main/java/org/apache/activemq/web/handler/BindingBeanNameUrlHandlerMapping.java @@ -22,6 +22,7 @@ import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; import org.springframework.web.bind.ServletRequestDataBinder; import org.springframework.web.servlet.handler.BeanNameUrlHandlerMapping; +import org.springframework.web.servlet.HandlerExecutionChain; /** * @version $Revision$ @@ -33,17 +34,28 @@ public class BindingBeanNameUrlHandlerMapping extends BeanNameUrlHandlerMapping Object object = super.getHandlerInternal(request); if (object instanceof String) { - String handlerName = (String)object; + String handlerName = (String) object; object = getApplicationContext().getBean(handlerName); } + if (object instanceof HandlerExecutionChain) { + HandlerExecutionChain handlerExecutionChain = (HandlerExecutionChain) object; + object = handlerExecutionChain.getHandler(); + } - ServletRequestDataBinder binder = new ServletRequestDataBinder(object, "request"); - binder.bind(request); - binder.setIgnoreUnknownFields(true); - if (LOG.isDebugEnabled()) { - LOG.debug("Bound POJO is now: " + object); + if (object != null) { + ServletRequestDataBinder binder = new ServletRequestDataBinder(object, "request"); + try { + binder.bind(request); + binder.setIgnoreUnknownFields(true); + if (LOG.isDebugEnabled()) { + LOG.debug("Bound POJO is now: " + object); + } + } + catch (Exception e) { + LOG.warn("Caught: " + e, e); + throw e; + } } return object; } - } diff --git a/activemq-web/src/main/java/org/apache/activemq/web/DestinationFacade.java b/activemq-web/src/main/java/org/apache/activemq/web/DestinationFacade.java index c56432a4c9..72b9c4f821 100644 --- a/activemq-web/src/main/java/org/apache/activemq/web/DestinationFacade.java +++ b/activemq-web/src/main/java/org/apache/activemq/web/DestinationFacade.java @@ -61,7 +61,14 @@ public class DestinationFacade { // Properties // ------------------------------------------------------------------------- public BrokerViewMBean getBrokerAdmin() throws Exception { - return brokerFacade.getBrokerAdmin(); + if (brokerFacade == null) { + throw new IllegalArgumentException("No brokerFacade injected!"); + } + BrokerViewMBean answer = brokerFacade.getBrokerAdmin(); + if (answer == null) { + throw new IllegalArgumentException("No brokerAdmin on the injected brokerFacade: " + brokerFacade); + } + return answer; } public BrokerFacade getBrokerFacade() { diff --git a/pom.xml b/pom.xml index 9d519f36e1..4d26869f0e 100755 --- a/pom.xml +++ b/pom.xml @@ -65,7 +65,7 @@ 0.1.8 1.7.2.2 1.0 - 6.1.4 + 6.1.9 1.0.1 3.8.1 2.0 @@ -75,8 +75,7 @@ 1.1.2 1.3 0.8 - 1.4.0 - + 1.5.0 1.2.0 2.6.0 2.0.0-beta1 @@ -847,6 +846,11 @@ slf4j-jcl ${slf4j-version} + + org.slf4j + slf4j-log4j12 + ${slf4j-version} + opensymphony sitemesh