From 52d5189698af1c0ffd7a80dc2849c341eee67e52 Mon Sep 17 00:00:00 2001
From: Gary Tully <gtully@apache.org>
Date: Thu, 12 May 2011 10:22:20 +0000
Subject: [PATCH] https://issues.apache.org/jira/browse/AMQ-3315 - Allow socket
 option soLinger to be enabled on TcpTransport. allow disable, soLinger == -1,
 disable, > -1 enable otherwise not set so system default

git-svn-id: https://svn.apache.org/repos/asf/activemq/trunk@1102232 13f79535-47bb-0310-9956-ffa450edef68
---
 .../apache/activemq/transport/tcp/TcpTransport.java    | 10 ++++++----
 .../activemq/transport/tcp/TransportUriTest.java       |  2 ++
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/activemq-core/src/main/java/org/apache/activemq/transport/tcp/TcpTransport.java b/activemq-core/src/main/java/org/apache/activemq/transport/tcp/TcpTransport.java
index 0c6befd68f..0ac4bc721d 100755
--- a/activemq-core/src/main/java/org/apache/activemq/transport/tcp/TcpTransport.java
+++ b/activemq-core/src/main/java/org/apache/activemq/transport/tcp/TcpTransport.java
@@ -129,7 +129,7 @@ public class TcpTransport extends TransportThreadSupport implements Transport, S
     protected final AtomicReference<CountDownLatch> stoppedLatch = new AtomicReference<CountDownLatch>();
 
     private Map<String, Object> socketOptions;
-    private int soLinger = -1;
+    private int soLinger = Integer.MIN_VALUE;
     private Boolean keepAlive;
     private Boolean tcpNoDelay;
     private Thread runnerThread;
@@ -360,8 +360,8 @@ public class TcpTransport extends TransportThreadSupport implements Transport, S
     }
 
     /**
-     * Enable soLinger with the specified soLinger
-     * @param soLinger enabled if > -1
+     * Enable/disable soLinger
+     * @param soLinger enabled if > -1, disabled if == -1, system default otherwise
      */
     public void setSoLinger(int soLinger) {
         this.soLinger = soLinger;
@@ -448,8 +448,10 @@ public class TcpTransport extends TransportThreadSupport implements Transport, S
             sock.setKeepAlive(keepAlive.booleanValue());
         }
 
-        if (soLinger != -1) {
+        if (soLinger > -1) {
             sock.setSoLinger(true, soLinger);
+        } else if (soLinger == -1) {
+            sock.setSoLinger(false, 0);
         }
         if (tcpNoDelay != null) {
             sock.setTcpNoDelay(tcpNoDelay.booleanValue());
diff --git a/activemq-core/src/test/java/org/apache/activemq/transport/tcp/TransportUriTest.java b/activemq-core/src/test/java/org/apache/activemq/transport/tcp/TransportUriTest.java
index 4ab1c3f21e..d1cbfaa5b6 100644
--- a/activemq-core/src/test/java/org/apache/activemq/transport/tcp/TransportUriTest.java
+++ b/activemq-core/src/test/java/org/apache/activemq/transport/tcp/TransportUriTest.java
@@ -139,6 +139,8 @@ public class TransportUriTest extends EmbeddedBrokerTestSupport {
         // TODO: Add more combinations.
         addCombinationValues("postfix", new Object[]
             {"?tcpNoDelay=true&keepAlive=true&soLinger=0"});
+        addCombinationValues("postfix", new Object[]
+            {"?tcpNoDelay=true&keepAlive=true&soLinger=-1"});
     }
 
     private void testValidOptionsWork(String options, String msg) {